From patchwork Sat Sep 7 14:54:22 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 143776 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2ED6A4592F; Sat, 7 Sep 2024 16:55:01 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1181F4060B; Sat, 7 Sep 2024 16:54:53 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 374CE40609 for ; Sat, 7 Sep 2024 16:54:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725720891; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Io3Mgf8YrKGmCb9YeJ6mwnDOx8H8ETmC2/Emk8B9L3k=; b=AnjBau1jEaHaiuIeFNxOhhShxizbXmpUnuWXNd/p/WBeiff9Mw0dK1/QkpNeYGxr60MPMT xMNqdXToQi9SxZPt9V6LAL8C2jD4H7q3Mu09MV8HvpPfSQPFqFDDD7wUZVithdsva8zxWJ EFUN4a3cuwbOHRvXOvuiWX2fBjMPqhk= Received: from mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-611-arqVvAV_PtqFq0JqYlTj0A-1; Sat, 07 Sep 2024 10:54:49 -0400 X-MC-Unique: arqVvAV_PtqFq0JqYlTj0A-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-02.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id A5B7A19560B0; Sat, 7 Sep 2024 14:54:48 +0000 (UTC) Received: from dmarchan.redhat.com (unknown [10.45.226.65]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 686141956048; Sat, 7 Sep 2024 14:54:47 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: Thomas Monjalon Subject: [PATCH 02/11] devtools: report all warnings in forbidden token check Date: Sat, 7 Sep 2024 16:54:22 +0200 Message-ID: <20240907145433.1479091-3-david.marchand@redhat.com> In-Reply-To: <20240907145433.1479091-1-david.marchand@redhat.com> References: <20240907145433.1479091-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Do not stop at the first file that got warnings. Signed-off-by: David Marchand --- devtools/check-forbidden-tokens.awk | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/devtools/check-forbidden-tokens.awk b/devtools/check-forbidden-tokens.awk index 807dad7f48..d72d244d3a 100755 --- a/devtools/check-forbidden-tokens.awk +++ b/devtools/check-forbidden-tokens.awk @@ -13,6 +13,7 @@ BEGIN { in_file=0; in_comment=0; count=0; + warned=0; comment_start="/*" comment_end="*/" } @@ -50,7 +51,8 @@ BEGIN { ($0 ~ "^\\+\\+\\+ b/") { in_file = 0; if (count > 0) { - exit; + warned = warned + 1 + print "Warning in " substr(last_file,7) ":" } count = 0 for (i in deny_folders) { @@ -66,7 +68,10 @@ BEGIN { } END { if (count > 0) { + warned = warned + 1 print "Warning in " substr(last_file,7) ":" + } + if (warned > 0) { print MESSAGE exit RET_ON_FAIL }