diff mbox series

[v1,03/43] net/dpaa2: add proper MTU debugging print

Message ID	20240913055959.3246917-4-vanshika.shukla@nxp.com (mailing list archive)
State	Superseded
Delegated to:	Thomas Monjalon
Headers	From: vanshika.shukla@nxp.com To: dev@dpdk.org, Hemant Agrawal <hemant.agrawal@nxp.com>, Sachin Saxena <sachin.saxena@nxp.com> Cc: Apeksha Gupta <apeksha.gupta@nxp.com>, Jun Yang <jun.yang@nxp.com> Subject: [v1 03/43] net/dpaa2: add proper MTU debugging print Date: Fri, 13 Sep 2024 11:29:19 +0530 Message-Id: <20240913055959.3246917-4-vanshika.shukla@nxp.com> In-Reply-To: <20240913055959.3246917-1-vanshika.shukla@nxp.com> References: <20240913055959.3246917-1-vanshika.shukla@nxp.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: dev-bounces@dpdk.org
Series	DPAA2 specific patches \| [v1,00/43] DPAA2 specific patches [v1,01/43] net/dpaa2: enhance Tx scatter-gather mempool [v1,02/43] net/dpaa2: support PTP packet one-step timestamp [v1,03/43] net/dpaa2: add proper MTU debugging print [v1,04/43] net/dpaa2: add support to dump dpdmux counters [v1,05/43] bus/fslmc: change dpcon close as internal symbol [v1,06/43] bus/fslmc: add close API to close DPAA2 device [v1,07/43] net/dpaa2: dpdmux: add support for CVLAN [v1,08/43] bus/fslmc: upgrade with MC version 10.37 [v1,09/43] net/dpaa2: support link state for eth interfaces [v1,10/43] net/dpaa2: update DPNI link status method [v1,11/43] net/dpaa2: add new PMD API to check dpaa platform version [v1,12/43] bus/fslmc: improve BMAN buffer acquire [v1,13/43] bus/fslmc: get MC VFIO group FD directly [v1,14/43] bus/fslmc: enhance MC VFIO multiprocess support [v1,15/43] bus/fslmc: free VFIO group FD in case of add group failure [v1,16/43] bus/fslmc: dynamic IOVA mode configuration [v1,17/43] bus/fslmc: remove VFIO IRQ mapping [v1,18/43] bus/fslmc: create dpaa2 device with it's object [v1,19/43] bus/fslmc: fix coverity issue [v1,20/43] bus/fslmc: fix invalid error FD code [v1,21/43] bus/fslmc: change qbman eq desc from d to desc [v1,22/43] bus/fslmc: introduce VFIO DMA mapping API for fslmc [v1,23/43] net/dpaa2: change miss flow ID macro name [v1,24/43] net/dpaa2: flow API refactor [v1,25/43] net/dpaa2: dump Rx parser result [v1,26/43] net/dpaa2: enhancement of raw flow extract [v1,27/43] net/dpaa2: frame attribute flags parser [v1,28/43] net/dpaa2: add VXLAN distribution support [v1,29/43] net/dpaa2: protocol inside tunnel distribution [v1,30/43] net/dpaa2: eCPRI support by parser result [v1,31/43] net/dpaa2: add GTP flow support [v1,32/43] net/dpaa2: check if Soft parser is loaded [v1,33/43] net/dpaa2: soft parser flow verification [v1,34/43] net/dpaa2: add flow support for IPsec AH and ESP [v1,35/43] net/dpaa2: fix memory corruption in TM [v1,36/43] net/dpaa2: support software taildrop [v1,37/43] net/dpaa2: check IOVA before sending MC command [v1,38/43] net/dpaa2: improve DPDMUX error behavior settings [v1,39/43] net/dpaa2: store drop priority in mbuf [v1,40/43] net/dpaa2: add API to get endpoint name [v1,41/43] net/dpaa2: support VLAN traffic splitting [v1,42/43] net/dpaa2: add support for C-VLAN and MAC [v1,43/43] net/dpaa2: dpdmux single flow/multiple rules support

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

vanshika.shukla@nxp.com Sept. 13, 2024, 5:59 a.m. UTC

From: Apeksha Gupta <apeksha.gupta@nxp.com>

This patch add proper debug info for check information of
max-pkt-len and configured params.

also store MTU

Signed-off-by: Apeksha Gupta <apeksha.gupta@nxp.com>
Signed-off-by: Jun Yang <jun.yang@nxp.com>
---
 drivers/net/dpaa2/dpaa2_ethdev.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff mbox series

Patch

diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c
index 596f1b4f61..efba9ef286 100644
--- a/drivers/net/dpaa2/dpaa2_ethdev.c
+++ b/drivers/net/dpaa2/dpaa2_ethdev.c
@@ -579,9 +579,11 @@  dpaa2_eth_dev_configure(struct rte_eth_dev *dev)
 			DPAA2_PMD_ERR("Unable to set mtu. check config");
 			return ret;
 		}
-		DPAA2_PMD_INFO("MTU configured for the device: %d",
+		DPAA2_PMD_DEBUG("MTU configured for the device: %d",
 				dev->data->mtu);
 	} else {
+		DPAA2_PMD_ERR("Configured mtu %d and calculated max-pkt-len is %d which should be <= %d",
+			eth_conf->rxmode.mtu, max_rx_pktlen, DPAA2_MAX_RX_PKT_LEN);
 		return -1;
 	}
 
@@ -1534,6 +1536,7 @@  dpaa2_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
 		DPAA2_PMD_ERR("Setting the max frame length failed");
 		return -1;
 	}
+	dev->data->mtu = mtu;
 	DPAA2_PMD_INFO("MTU configured for the device: %d", mtu);
 	return 0;
 }
@@ -2836,6 +2839,7 @@  dpaa2_dev_init(struct rte_eth_dev *eth_dev)
 		DPAA2_PMD_ERR("Unable to set mtu. check config");
 		goto init_err;
 	}
+	eth_dev->data->mtu = RTE_ETHER_MTU;
 
 	/*TODO To enable soft parser support DPAA2 driver needs to integrate
 	 * with external entity to receive byte code for software sequence