diff mbox series

[v2,6/9] app/testpmd: remove flex item init command leftover

Message ID 20240918134623.8441-7-viacheslavo@nvidia.com (mailing list archive)
State Awaiting Upstream
Delegated to: Raslan Darawsheh
Headers
Series net/mlx5: cumulative fix series for flex item |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Viacheslav Ovsiienko Sept. 18, 2024, 1:46 p.m. UTC 
There was a leftover of "flow flex init" command used
for debug purposes and had no useful functionality in
the production code.

Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
---
 app/test-pmd/cmdline_flow.c | 12 ------------
 1 file changed, 12 deletions(-)

Comments

Dariusz Sosnowski Sept. 18, 2024, 1:58 p.m. UTC | #1 
> -----Original Message-----
> From: Slava Ovsiienko <viacheslavo@nvidia.com>
> Sent: Wednesday, September 18, 2024 15:46
> To: dev@dpdk.org
> Cc: Matan Azrad <matan@nvidia.com>; Raslan Darawsheh
> <rasland@nvidia.com>; Ori Kam <orika@nvidia.com>; Dariusz Sosnowski
> <dsosnowski@nvidia.com>
> Subject: [PATCH v2 6/9] app/testpmd: remove flex item init command leftover
> 
> There was a leftover of "flow flex init" command used for debug purposes and
> had no useful functionality in the production code.
> 
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
> ---
>  app/test-pmd/cmdline_flow.c | 12 ------------
>  1 file changed, 12 deletions(-)
> 
> diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index
> d04280eb3e..858f4077bd 100644
> --- a/app/test-pmd/cmdline_flow.c
> +++ b/app/test-pmd/cmdline_flow.c
> @@ -106,7 +106,6 @@ enum index {
>  	HASH,
> 
>  	/* Flex arguments */
> -	FLEX_ITEM_INIT,
>  	FLEX_ITEM_CREATE,
>  	FLEX_ITEM_DESTROY,
> 
> @@ -1317,7 +1316,6 @@ struct parse_action_priv {
>  	})
> 
>  static const enum index next_flex_item[] = {
> -	FLEX_ITEM_INIT,
>  	FLEX_ITEM_CREATE,
>  	FLEX_ITEM_DESTROY,
>  	ZERO,
> @@ -4171,15 +4169,6 @@ static const struct token token_list[] = {
>  		.next = NEXT(next_flex_item),
>  		.call = parse_flex,
>  	},
> -	[FLEX_ITEM_INIT] = {
> -		.name = "init",
> -		.help = "flex item init",
> -		.args = ARGS(ARGS_ENTRY(struct buffer, args.flex.token),
> -			     ARGS_ENTRY(struct buffer, port)),
> -		.next = NEXT(NEXT_ENTRY(COMMON_FLEX_TOKEN),
> -			     NEXT_ENTRY(COMMON_PORT_ID)),
> -		.call = parse_flex
> -	},
>  	[FLEX_ITEM_CREATE] = {
>  		.name = "create",
>  		.help = "flex item create",
> @@ -11431,7 +11420,6 @@ parse_flex(struct context *ctx, const struct token
> *token,
>  		switch (ctx->curr) {
>  		default:
>  			break;
> -		case FLEX_ITEM_INIT:
>  		case FLEX_ITEM_CREATE:
>  		case FLEX_ITEM_DESTROY:
>  			out->command = ctx->curr;
> --
> 2.34.1

Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>

Resending the Ack for each patch separately, because patchwork assigned my Ack for the series to v1, not v2.

Best regards,
Dariusz Sosnowski
diff mbox series

Patch

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index d04280eb3e..858f4077bd 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -106,7 +106,6 @@  enum index {
 	HASH,
 
 	/* Flex arguments */
-	FLEX_ITEM_INIT,
 	FLEX_ITEM_CREATE,
 	FLEX_ITEM_DESTROY,
 
@@ -1317,7 +1316,6 @@  struct parse_action_priv {
 	})
 
 static const enum index next_flex_item[] = {
-	FLEX_ITEM_INIT,
 	FLEX_ITEM_CREATE,
 	FLEX_ITEM_DESTROY,
 	ZERO,
@@ -4171,15 +4169,6 @@  static const struct token token_list[] = {
 		.next = NEXT(next_flex_item),
 		.call = parse_flex,
 	},
-	[FLEX_ITEM_INIT] = {
-		.name = "init",
-		.help = "flex item init",
-		.args = ARGS(ARGS_ENTRY(struct buffer, args.flex.token),
-			     ARGS_ENTRY(struct buffer, port)),
-		.next = NEXT(NEXT_ENTRY(COMMON_FLEX_TOKEN),
-			     NEXT_ENTRY(COMMON_PORT_ID)),
-		.call = parse_flex
-	},
 	[FLEX_ITEM_CREATE] = {
 		.name = "create",
 		.help = "flex item create",
@@ -11431,7 +11420,6 @@  parse_flex(struct context *ctx, const struct token *token,
 		switch (ctx->curr) {
 		default:
 			break;
-		case FLEX_ITEM_INIT:
 		case FLEX_ITEM_CREATE:
 		case FLEX_ITEM_DESTROY:
 			out->command = ctx->curr;