diff mbox series

[v4,02/18] net/r8169: add logging structure

Message ID	20241025033529.15581-3-howard_wang@realsil.com.cn (mailing list archive)
State	Superseded, archived
Delegated to:	Ferruh Yigit
Headers	code: ctloc85258 From: Howard Wang <howard_wang@realsil.com.cn> To: <dev@dpdk.org> CC: <pro_nic_dpdk@realtek.com>, Howard Wang <howard_wang@realsil.com.cn> Subject: [PATCH v4 02/18] net/r8169: add logging structure Date: Fri, 25 Oct 2024 11:35:13 +0800 Message-ID: <20241025033529.15581-3-howard_wang@realsil.com.cn> In-Reply-To: <20241025033529.15581-1-howard_wang@realsil.com.cn> References: <20241025033529.15581-1-howard_wang@realsil.com.cn> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Precedence: list Errors-To: dev-bounces@dpdk.org
Series	Modify code as suggested by the maintainer. \| [v4,00/18] Modify code as suggested by the maintainer. [v4,01/18] net/r8169: add PMD driver skeleton [v4,02/18] net/r8169: add logging structure [v4,03/18] net/r8169: add hardware registers access routines [v4,04/18] net/r8169: implement core logic for Tx/Rx [v4,05/18] net/r8169: add support for hw config [v4,06/18] net/r8169: add phy registers access routines [v4,07/18] net/r8169: add support for hardware operations [v4,08/18] net/r8169: add support for phy configuration [v4,09/18] net/r8169: add support for hw initialization [v4,10/18] net/r8169: add link status and interrupt management [v4,11/18] net/r8169: implement Rx path [v4,12/18] net/r8169: implement Tx path [v4,13/18] net/r8169: implement device statistics [v4,14/18] net/r8169: implement promisc and allmulti modes [v4,15/18] net/r8169: implement MTU configuration [v4,16/18] net/r8169: add support for getting fw version [v4,17/18] net/r8169: add driver_start and driver_stop [v4,18/18] doc/guides/nics: add documents for r8169 pmd

Checks

Context	Check	Description
ci/checkpatch	warning	coding style issues

Commit Message

Howard Wang Oct. 25, 2024, 3:35 a.m. UTC

Implement logging macros for debug purposes.

Signed-off-by: Howard Wang <howard_wang@realsil.com.cn>
---
 drivers/net/r8169/r8169_ethdev.c |  9 +++++++
 drivers/net/r8169/r8169_logs.h   | 46 ++++++++++++++++++++++++++++++++
 2 files changed, 55 insertions(+)
 create mode 100644 drivers/net/r8169/r8169_logs.h

Comments

Stephen Hemminger Oct. 28, 2024, 2:28 a.m. UTC | #1

On Fri, 25 Oct 2024 11:35:13 +0800
Howard Wang <howard_wang@realsil.com.cn> wrote:

> Implement logging macros for debug purposes.
> 
> Signed-off-by: Howard Wang <howard_wang@realsil.com.cn>

Did you see this from checkpatch? Probably not because it was buried
in all the CamelCase warnings.

Warning in drivers/net/r8169/r8169_logs.h:
Prefer RTE_LOG_LINE/RTE_LOG_DP_LINE
Warning in drivers/net/r8169/r8169_logs.h:
Do not use variadic argument pack in macros

diff mbox series

Patch

diff --git a/drivers/net/r8169/r8169_ethdev.c b/drivers/net/r8169/r8169_ethdev.c
index 1f90a142c5..a5de322c9a 100644
--- a/drivers/net/r8169/r8169_ethdev.c
+++ b/drivers/net/r8169/r8169_ethdev.c
@@ -176,3 +176,12 @@  static struct rte_pci_driver rte_r8169_pmd = {
 RTE_PMD_REGISTER_PCI(net_r8169, rte_r8169_pmd);
 RTE_PMD_REGISTER_PCI_TABLE(net_r8169, pci_id_r8169_map);
 RTE_PMD_REGISTER_KMOD_DEP(net_r8169, "* igb_uio | uio_pci_generic | vfio-pci");
+
+RTE_LOG_REGISTER_SUFFIX(r8169_logtype_init, init, NOTICE)
+RTE_LOG_REGISTER_SUFFIX(r8169_logtype_driver, driver, NOTICE)
+#ifdef RTE_ETHDEV_DEBUG_RX
+RTE_LOG_REGISTER_SUFFIX(r8169_logtype_rx, rx, DEBUG)
+#endif
+#ifdef RTE_ETHDEV_DEBUG_TX
+RTE_LOG_REGISTER_SUFFIX(r8169_logtype_tx, tx, DEBUG)
+#endif
diff --git a/drivers/net/r8169/r8169_logs.h b/drivers/net/r8169/r8169_logs.h
new file mode 100644
index 0000000000..9bef517176
--- /dev/null
+++ b/drivers/net/r8169/r8169_logs.h
@@ -0,0 +1,46 @@ 
+/* SPDX-License-Identifier: BSD-3-Clause
+ * Copyright(c) 2024 Realtek Corporation. All rights reserved
+ */
+
+#ifndef _R8169_LOGS_H_
+#define _R8169_LOGS_H_
+
+#include <rte_log.h>
+
+extern int r8169_logtype_init;
+extern int r8169_logtype_driver;
+#ifdef RTE_ETHDEV_DEBUG_RX
+extern int r8169_logtype_rx;
+#endif
+#ifdef RTE_ETHDEV_DEBUG_TX
+extern int r8169_logtype_tx;
+#endif
+
+#define RTE_LOGTYPE_R8169_INIT   r8169_logtype_init
+#define RTE_LOGTYPE_R8169_RX     r8169_logtype_rx
+#define RTE_LOGTYPE_R8169_TX     r8169_logtype_tx
+#define RTE_LOGTYPE_R8169_DRIVER r8169_logtype_driver
+
+#define PMD_INIT_LOG(level, fmt, args...) \
+	RTE_LOG_DP(level, R8169_INIT, "%s(): " fmt "\n", __func__, ## args)
+
+#define PMD_INIT_FUNC_TRACE() PMD_INIT_LOG(DEBUG, " >>")
+
+#ifdef RTE_ETHDEV_DEBUG_RX
+#define PMD_RX_LOG(level, fmt, args...) \
+	RTE_LOG_DP_LINE(level, R8169_RX, "%s(): " fmt, __func__, ## args)
+#else
+#define PMD_RX_LOG(level, fmt, args...) do { } while (0)
+#endif
+
+#ifdef RTE_ETHDEV_DEBUG_TX
+#define PMD_TX_LOG(level, fmt, args...) \
+	RTE_LOG_DP_LINE(level, R8169_TX, "%s(): " fmt, __func__, ## args)
+#else
+#define PMD_TX_LOG(level, fmt, args...) do { } while (0)
+#endif
+
+#define PMD_DRV_LOG(level, fmt, args...) \
+	RTE_LOG_DP_LINE(level, R8169_DRIVER, "%s(): " fmt, __func__, ## args)
+
+#endif /* _R8169_LOGS_H_ */