diff mbox series

[v2,1/2] test-gpudev: avoid use-after-free and free-non-heap warnings

Message ID 20241028190301.264378-2-stephen@networkplumber.org (mailing list archive)
State Changes Requested, archived
Delegated to: Thomas Monjalon
Headers
Series gpudev: annotate memory allocation functions |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Stephen Hemminger Oct. 28, 2024, 7:01 p.m. UTC 
Remove the test intentionally frees a bad pointer in GPU memory,
and GCC sees that at compile time now.

Fix use after free in printf.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 app/test-gpudev/main.c | 16 +++-------------
 1 file changed, 3 insertions(+), 13 deletions(-)
diff mbox series

Patch

diff --git a/app/test-gpudev/main.c b/app/test-gpudev/main.c
index f065e6cd81..30fe573bf9 100644
--- a/app/test-gpudev/main.c
+++ b/app/test-gpudev/main.c
@@ -96,29 +96,19 @@  alloc_gpu_memory(uint16_t gpu_id)
 		goto error;
 	}
 
-	ret = rte_gpu_mem_free(gpu_id, (uint8_t *)(ptr_1)+0x700);
-	if (ret < 0) {
-		printf("GPU memory 0x%p NOT freed: GPU driver didn't find this memory address internally.\n",
-				(uint8_t *)(ptr_1)+0x700);
-	} else {
-		fprintf(stderr, "ERROR: rte_gpu_mem_free freed GPU memory 0x%p\n",
-				(uint8_t *)(ptr_1)+0x700);
-		goto error;
-	}
-
+	printf("GPU memory 0x%p free\n", ptr_2);
 	ret = rte_gpu_mem_free(gpu_id, ptr_2);
 	if (ret < 0) {
 		fprintf(stderr, "rte_gpu_mem_free returned error %d\n", ret);
 		goto error;
 	}
-	printf("GPU memory 0x%p freed\n", ptr_2);
 
+	printf("GPU memory 0x%p free\n", ptr_1);
 	ret = rte_gpu_mem_free(gpu_id, ptr_1);
 	if (ret < 0) {
 		fprintf(stderr, "rte_gpu_mem_free returned error %d\n", ret);
 		goto error;
 	}
-	printf("GPU memory 0x%p freed\n", ptr_1);
 
 	printf("\n=======> TEST: PASSED\n");
 	return 0;
@@ -228,12 +218,12 @@  gpu_mem_cpu_map(uint16_t gpu_id)
 	}
 	printf("GPU memory CPU unmapped, 0x%p not valid anymore\n", ptr_cpu);
 
+	printf("GPU memory 0x%p freeing\n", ptr_gpu);
 	ret = rte_gpu_mem_free(gpu_id, ptr_gpu);
 	if (ret < 0) {
 		fprintf(stderr, "rte_gpu_mem_free returned error %d\n", ret);
 		goto error;
 	}
-	printf("GPU memory 0x%p freed\n", ptr_gpu);
 
 	printf("\n=======> TEST: PASSED\n");
 	return 0;