[v2,2/2] dts: add blocklist test suite

Message ID 20241107135654.4121761-3-luca.vizzarro@arm.com (mailing list archive)
State Accepted, archived
Delegated to: Patrick Robb
Headers
Series dts: add blocklist test suite |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation warning apply issues

Commit Message

Luca Vizzarro Nov. 7, 2024, 1:56 p.m. UTC
This test suite tests the port blocklisting functionality built in
testpmd.

Signed-off-by: Luca Vizzarro <luca.vizzarro@arm.com>
Reviewed-by: Paul Szczepanek <paul.szczepanek@arm.com>
---
 dts/framework/config/conf_yaml_schema.json |  3 +-
 dts/tests/TestSuite_blocklist.py           | 63 ++++++++++++++++++++++
 2 files changed, 65 insertions(+), 1 deletion(-)
 create mode 100644 dts/tests/TestSuite_blocklist.py
  

Comments

Nicholas Pratte Nov. 7, 2024, 8:33 p.m. UTC | #1
Hi Luca, nice work!

See my small comment below/ I ran some local tests and everything
seems to be working fine, so other than that minor fix I pointed out,
the rest should be all set!

<snip>
> +"""The DPDK device blocklisting test suite.
> +
> +This testing suite ensures tests the port blocklisting functionality of testpmd.

I would remove the 'tests' and just write 'testing suite ensures the port...'

> +"""
> +
<snip>
  
Luca Vizzarro Nov. 8, 2024, 2:38 p.m. UTC | #2
On 07/11/2024 20:33, Nicholas Pratte wrote:
> Hi Luca, nice work!
> 
> See my small comment below/ I ran some local tests and everything
> seems to be working fine, so other than that minor fix I pointed out,
> the rest should be all set!


Good suggestion, I've changed it a little bit now. Thanks!
  
Patrick Robb Nov. 14, 2024, 9:18 p.m. UTC | #3
Applied to next-dts, thanks.
  

Patch

diff --git a/dts/framework/config/conf_yaml_schema.json b/dts/framework/config/conf_yaml_schema.json
index cc3e78cef5..65d0991686 100644
--- a/dts/framework/config/conf_yaml_schema.json
+++ b/dts/framework/config/conf_yaml_schema.json
@@ -244,7 +244,8 @@ 
         "hello_world",
         "os_udp",
         "pmd_buffer_scatter",
-        "vlan"
+        "vlan",
+        "blocklist"
       ]
     },
     "test_target": {
diff --git a/dts/tests/TestSuite_blocklist.py b/dts/tests/TestSuite_blocklist.py
new file mode 100644
index 0000000000..b9e9cd1d1a
--- /dev/null
+++ b/dts/tests/TestSuite_blocklist.py
@@ -0,0 +1,63 @@ 
+# SPDX-License-Identifier: BSD-3-Clause
+# Copyright(c) 2024 Arm Limited
+
+"""The DPDK device blocklisting test suite.
+
+This testing suite ensures tests the port blocklisting functionality of testpmd.
+"""
+
+from framework.remote_session.testpmd_shell import TestPmdShell
+from framework.test_suite import TestSuite, func_test
+from framework.testbed_model.capability import TopologyType, requires
+from framework.testbed_model.port import Port
+
+
+@requires(topology_type=TopologyType.two_links)
+class TestBlocklist(TestSuite):
+    """DPDK device blocklisting test suite."""
+
+    def verify_blocklisted_ports(self, ports_to_block: list[Port]):
+        """Runs testpmd with the given ports blocklisted and verifies the ports."""
+        with TestPmdShell(self.sut_node, allowed_ports=[], blocked_ports=ports_to_block) as testpmd:
+            allowlisted_ports = {port.device_name for port in testpmd.show_port_info_all()}
+            blocklisted_ports = {port.pci for port in ports_to_block}
+
+            # sanity check
+            allowed_len = len(allowlisted_ports - blocklisted_ports)
+            self.verify(allowed_len > 0, "At least one port should have been allowed")
+
+            blocked = not allowlisted_ports & blocklisted_ports
+            self.verify(blocked, "At least one port was not blocklisted")
+
+    @func_test
+    def no_blocklisted(self):
+        """Run testpmd with no blocklisted device.
+
+        Steps:
+            Run testpmd without specifying allowed or blocked ports.
+        Verify:
+            That no ports were blocked.
+        """
+        self.verify_blocklisted_ports([])
+
+    @func_test
+    def one_port_blocklisted(self):
+        """Run testpmd with one blocklisted port.
+
+        Steps:
+            Run testpmd with one only one blocklisted port and allowing all the other ones.
+        Verify:
+            That the port was successfully blocklisted.
+        """
+        self.verify_blocklisted_ports(self.sut_node.ports[:1])
+
+    @func_test
+    def all_but_one_port_blocklisted(self):
+        """Run testpmd with all but one blocklisted port.
+
+        Steps:
+            Run testpmd with only one allowed port, blocking all the other ones.
+        Verify:
+            That all specified ports were successfully blocklisted.
+        """
+        self.verify_blocklisted_ports(self.sut_node.ports[:-1])