diff mbox series

[v5,25/25] devtools: check for some reentrant function

Message ID	20241108110404.18317-26-haijie1@huawei.com (mailing list archive)
State	Changes Requested, archived
Delegated to:	David Marchand
Headers	From: Jie Hai <haijie1@huawei.com> To: <dev@dpdk.org>, <thomas@monjalon.net>, <ferruh.yigit@amd.com> CC: <lihuisong@huawei.com>, <fengchengwen@huawei.com>, <haijie1@huawei.com>, <huangdengdui@huawei.com> Subject: [PATCH v5 25/25] devtools: check for some reentrant function Date: Fri, 8 Nov 2024 19:04:04 +0800 Message-ID: <20241108110404.18317-26-haijie1@huawei.com> In-Reply-To: <20241108110404.18317-1-haijie1@huawei.com> References: <20231113104550.2138654-1-haijie1@huawei.com> <20241108110404.18317-1-haijie1@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Precedence: list Errors-To: dev-bounces@dpdk.org
Series	[v5,01/25] app/graph: replace strtok with reentrant version \| [v5,00/25] [v5,01/25] app/graph: replace strtok with reentrant version [v5,02/25] app/bbdev: replace strtok with reentrant version [v5,03/25] app/compress-perf: replace strtok with reentrant version [v5,04/25] app/crypto-perf: replace strtok with reentrant version [v5,05/25] app/dma-perf: replace strtok with reentrant version [v5,06/25] app/flow-perf: replace strtok with reentrant version [v5,07/25] app/test-mldev: replace strtok with reentrant version [v5,08/25] app/test-fib: replace strtok with reentrant version [v5,09/25] dmadev: replace strtok with reentrant version [v5,10/25] eal: replace strtok with reentrant version [v5,11/25] ethdev: replace strtok with reentrant version [v5,12/25] eventdev: replace strtok with reentrant version [v5,13/25] security: replace strtok with reentrant version [v5,14/25] telemetry: replace strtok with reentrant version [v5,15/25] bus/fslmc: replace strtok with reentrant version [v5,16/25] common/cnxk: replace strtok with reentrant version [v5,17/25] event/cnxk: replace strtok with reentrant version [v5,18/25] net/ark: replace strtok with reentrant version [v5,19/25] raw/cnxk_gpio: replace strtok with reentrant version [v5,20/25] net/cnxk: replace strtok with reentrant version [v5,21/25] common/qat: replace strtok with reentrant version [v5,22/25] net/mlx5: replace strtok with reentrant version [v5,23/25] examples/l2fwd-crypto: replace strtok with reentrant version [v5,24/25] examples/vhost: replace strtok with reentrant version [v5,25/25] devtools: check for some reentrant function

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK
ci/loongarch-compilation	success	Compilation OK
ci/loongarch-unit-testing	success	Unit Testing PASS
ci/Intel-compilation	success	Compilation OK
ci/intel-Testing	success	Testing PASS
ci/intel-Functional	success	Functional PASS
ci/github-robot: build	fail	github build: failed
ci/iol-intel-Performance	success	Performance Testing PASS
ci/iol-mellanox-Performance	success	Performance Testing PASS
ci/iol-marvell-Functional	success	Functional Testing PASS
ci/iol-intel-Functional	success	Functional Testing PASS
ci/iol-unit-arm64-testing	success	Testing PASS
ci/iol-unit-amd64-testing	fail	Testing issues
ci/iol-broadcom-Performance	success	Performance Testing PASS
ci/iol-compile-amd64-testing	success	Testing PASS
ci/iol-sample-apps-testing	success	Testing PASS
ci/iol-compile-arm64-testing	success	Testing PASS

Commit Message

Jie Hai Nov. 8, 2024, 11:04 a.m. UTC

Multiple threads calling the same function may cause condition
race issues, which often leads to abnormal behavior and can cause
more serious vulnerabilities such as abnormal termination, denial
of service, and compromised data integrity.

This patch adds check in checkpatches.sh for strtok, which is
non-reentrant.

Cc: stable@dpdk.org

Signed-off-by: Jie Hai <haijie1@huawei.com>
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
---
 devtools/checkpatches.sh | 8 ++++++++
 1 file changed, 8 insertions(+)

diff mbox series

Patch

diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh
index 4a8591be225e..80fe41604427 100755
--- a/devtools/checkpatches.sh
+++ b/devtools/checkpatches.sh
@@ -145,6 +145,14 @@  check_forbidden_additions() { # <patch>
 		-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
 		"$1" || res=1
 
+	# refrain from using some non-reentrant functions
+	awk -v FOLDERS="lib drivers app examples" \
+		-v EXPRESSIONS="strtok\\\(" \
+		-v RET_ON_FAIL=1 \
+		-v MESSAGE='Using non-reentrant function strtok, prefer strtok_r' \
+		-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \
+		"$1" || res=1
+
 	# refrain from using some pthread functions
 	awk -v FOLDERS="lib drivers app examples" \
 		-v EXPRESSIONS="pthread_(create|join|detach|set(_?name_np|affinity_np)|attr_set(inheritsched|schedpolicy))\\\(" \