diff mbox series

[v1] net/cpfl: fix IO port forwarding issue

Message ID 20241108110923.80404-1-praveen.shetty@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Bruce Richardson
Headers
Series [v1] net/cpfl: fix IO port forwarding issue |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-marvell-Functional success Functional Testing PASS
ci/github-robot: build success github build: passed
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-unit-amd64-testing fail Testing issues
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS

Commit Message

Praveen Shetty Nov. 8, 2024, 11:09 a.m. UTC 
Issue was reported in dpdk internal regression testing that
forwarding the packets from IDPF VF to IO ports using the cpfl
represented_port action was not working.
This patch will fix this issue.

Fixes: 861261957684 ("net/cpfl: add checks for flow action types")
Cc: stable@dpdk.org

Signed-off-by: Praveen Shetty <praveen.shetty@intel.com>
---
 drivers/net/cpfl/cpfl_flow_engine_fxp.c | 5 -----
 1 file changed, 5 deletions(-)

Comments

Bruce Richardson Nov. 11, 2024, 3:27 p.m. UTC | #1 
On Fri, Nov 08, 2024 at 11:09:23AM +0000, Praveen Shetty wrote:
> Issue was reported in dpdk internal regression testing that
> forwarding the packets from IDPF VF to IO ports using the cpfl
> represented_port action was not working.
> This patch will fix this issue.
> 
> Fixes: 861261957684 ("net/cpfl: add checks for flow action types")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Praveen Shetty <praveen.shetty@intel.com>
> ---
>  drivers/net/cpfl/cpfl_flow_engine_fxp.c | 5 -----
>  1 file changed, 5 deletions(-)
> 

Following discussion with Praveen to clarify the issue and the fix, applied
with expanded commit-log message (below) to next-net-intel.

"""
    net/cpfl: fix forwarding to physical port
    
    CPFL PMD should be able to support below traffic forwarding capabilities
    based on the rte flow action types.
    
     1. Forwarding the traffic to the local CPFL vports using
        port_representor action.
    
     2. Forwarding the traffic to the physical IO ports using
        represented_port action.
    
     3. Forwarding the traffic to an IDPF VF using represented_port action.
    
    The 2nd use case, forwarding the traffic to IO ports using
    represented_port action, is not working due to the additional check
    added in the previous patch (861261957684 ("net/cpfl: add checks for
    flow action types"))
    
    This patch removes the incorrect check to fix the issue.
"""

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied,
Thanks.
diff mbox series

Patch

diff --git a/drivers/net/cpfl/cpfl_flow_engine_fxp.c b/drivers/net/cpfl/cpfl_flow_engine_fxp.c
index 2c75ea6577..0eb7cdf1a3 100644
--- a/drivers/net/cpfl/cpfl_flow_engine_fxp.c
+++ b/drivers/net/cpfl/cpfl_flow_engine_fxp.c
@@ -298,11 +298,6 @@  cpfl_fxp_parse_action(struct cpfl_itf *itf,
 				PMD_DRV_LOG(ERR, "Cannot use port_representor action for the represented_port");
 				goto err;
 			}
-			if (action_type == RTE_FLOW_ACTION_TYPE_REPRESENTED_PORT &&
-			    dst_itf->type == CPFL_ITF_TYPE_VPORT) {
-				PMD_DRV_LOG(ERR, "Cannot use represented_port action for the local vport");
-				goto err;
-			}
 			if (is_vsi)
 				dev_id = cpfl_get_vsi_id(dst_itf);
 			else