[v4,1/6] raw/ifpga: remove check around pthread_mutex_init()
Checks
Commit Message
> pthread_mutex_init always returns 0. The other mutex functions
> return 0 on success and a non-zero error code on error.
Link: https://man7.org/linux/man-pages/man3/pthread_mutex_lock.3.html
Bugzilla ID: 1586
Cc: Rosen Xu <rosen.xu@intel.com>
Signed-off-by: Ariel Otilibili <otilibil@eurecom.fr>
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/raw/ifpga/base/opae_intel_max10.c | 5 +----
drivers/raw/ifpga/base/opae_spi_transaction.c | 7 +------
2 files changed, 2 insertions(+), 10 deletions(-)
@@ -1486,10 +1486,7 @@ intel_max10_device_init(struct intel_max10_device *dev)
if (ret)
return ret;
- ret = pthread_mutex_init(&dev->bmc_ops.lock, NULL);
- if (ret)
- return ret;
-
+ pthread_mutex_init(&dev->bmc_ops.lock, NULL);
if (!dev->bmc_ops.mutex)
dev->bmc_ops.mutex = &dev->bmc_ops.lock;
}
@@ -494,7 +494,6 @@ struct spi_transaction_dev *spi_transaction_init(struct altera_spi_device *dev,
int chipselect)
{
struct spi_transaction_dev *spi_tran_dev;
- int ret;
spi_tran_dev = opae_malloc(sizeof(struct spi_transaction_dev));
if (!spi_tran_dev)
@@ -507,11 +506,7 @@ struct spi_transaction_dev *spi_transaction_init(struct altera_spi_device *dev,
if (!spi_tran_dev->buffer)
goto err;
- ret = pthread_mutex_init(&spi_tran_dev->lock, NULL);
- if (ret) {
- dev_err(spi_tran_dev, "fail to init mutex lock\n");
- goto err;
- }
+ pthread_mutex_init(&spi_tran_dev->lock, NULL);
if (dev->mutex) {
dev_info(NULL, "use multi-process mutex in spi\n");
spi_tran_dev->mutex = dev->mutex;