net/i40e/base: fix the debug print format
Checks
Commit Message
This patch modifies format specifier in debug prints to match to the
change of time variables from 64 bit to 32 bit.
Fixes: d980a401b137 ("net/i40e/base: add NVM acquire with custom timeout")
Fixes: ba90329a5eb3 ("net/i40e/base: fix invalid log format characters")
Cc: stable@dpdk.org
Signed-off-by: Jaroslaw Ilgiewicz <jaroslaw.ilgiewicz@intel.com>
Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>
---
drivers/net/i40e/base/i40e_nvm.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
Comments
On Tue, Jan 14, 2025 at 10:44 AM Zhichao Zeng <zhichaox.zeng@intel.com> wrote:
>
> This patch modifies format specifier in debug prints to match to the
> change of time variables from 64 bit to 32 bit.
I am missing something... this is reverting a valid change.
If anything needs to be changed.. PRIu32 should be used in the four
hunks this patch touches.
>
> Fixes: d980a401b137 ("net/i40e/base: add NVM acquire with custom timeout")
> Fixes: ba90329a5eb3 ("net/i40e/base: fix invalid log format characters")
And in this case, I think you want to point at:
Fixes: cb593a832630 ("net/i40e/base: reduce size of time variables")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jaroslaw Ilgiewicz <jaroslaw.ilgiewicz@intel.com>
> Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>
Hi David
Thanks for your comments, will submit v2 patch.
Regards
Zhichao
> -----Original Message-----
> From: David Marchand <david.marchand@redhat.com>
> Sent: Tuesday, January 14, 2025 9:15 PM
> To: Zeng, ZhichaoX <zhichaox.zeng@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; Ilgiewicz, Jaroslaw
> <jaroslaw.ilgiewicz@intel.com>; Stokes, Ian <ian.stokes@intel.com>;
> Richardson, Bruce <bruce.richardson@intel.com>; Midde Ajijur Rehaman
> <ajijurx.rehaman.midde@intel.com>; Burakov, Anatoly
> <anatoly.burakov@intel.com>
> Subject: Re: [PATCH] net/i40e/base: fix the debug print format
>
> On Tue, Jan 14, 2025 at 10:44 AM Zhichao Zeng <zhichaox.zeng@intel.com>
> wrote:
> >
> > This patch modifies format specifier in debug prints to match to the
> > change of time variables from 64 bit to 32 bit.
>
> I am missing something... this is reverting a valid change.
>
> If anything needs to be changed.. PRIu32 should be used in the four hunks
> this patch touches.
>
> >
> > Fixes: d980a401b137 ("net/i40e/base: add NVM acquire with custom
> > timeout")
> > Fixes: ba90329a5eb3 ("net/i40e/base: fix invalid log format
> > characters")
>
> And in this case, I think you want to point at:
> Fixes: cb593a832630 ("net/i40e/base: reduce size of time variables")
>
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Jaroslaw Ilgiewicz <jaroslaw.ilgiewicz@intel.com>
> > Signed-off-by: Zhichao Zeng <zhichaox.zeng@intel.com>
>
>
> --
> David Marchand
@@ -79,7 +79,7 @@ enum i40e_status_code i40e_acquire_nvm(struct i40e_hw *hw,
if (ret_code)
i40e_debug(hw, I40E_DEBUG_NVM,
- "NVM acquire type %d failed time_left=%" PRIu32 " ret=%d aq_err=%d\n",
+ "NVM acquire type %d failed time_left=%u ret=%d aq_err=%d\n",
access, time_left, ret_code, hw->aq.asq_last_status);
if (ret_code && time_left) {
@@ -101,7 +101,7 @@ enum i40e_status_code i40e_acquire_nvm(struct i40e_hw *hw,
if (ret_code != I40E_SUCCESS) {
hw->nvm.hw_semaphore_timeout = 0;
i40e_debug(hw, I40E_DEBUG_NVM,
- "NVM acquire timed out, wait %" PRIu32 " ms before trying again. status=%d aq_err=%d\n",
+ "NVM acquire timed out, wait %u ms before trying again. status=%d aq_err=%d\n",
time_left, ret_code, hw->aq.asq_last_status);
}
}
@@ -145,9 +145,8 @@ enum i40e_status_code i40e_acquire_nvm_ex(struct i40e_hw *hw,
if (ret_code)
i40e_debug(hw, I40E_DEBUG_NVM,
- "NVM acquire type %d failed time_left=%llu ret=%d aq_err=%d\n",
- access, (unsigned long long)time_left, ret_code,
- hw->aq.asq_last_status);
+ "NVM acquire type %d failed time_left=%u ret=%d aq_err=%d\n",
+ access, time_left, ret_code, hw->aq.asq_last_status);
if (ret_code && time_left) {
/* Poll until the current NVM owner timeouts */
@@ -168,9 +167,8 @@ enum i40e_status_code i40e_acquire_nvm_ex(struct i40e_hw *hw,
if (ret_code != I40E_SUCCESS) {
hw->nvm.hw_semaphore_timeout = 0;
i40e_debug(hw, I40E_DEBUG_NVM,
- "NVM acquire timed out, wait %llu ms before trying again. status=%d aq_err=%d\n",
- (unsigned long long)time_left, ret_code,
- hw->aq.asq_last_status);
+ "NVM acquire timed out, wait %u ms before trying again. status=%d aq_err=%d\n",
+ time_left, ret_code, hw->aq.asq_last_status);
}
}