[v2,2/2] ethdev: fix some functions are available in the new event

Message ID 20250116114034.9858-3-lihuisong@huawei.com (mailing list archive)
State Superseded
Delegated to: Stephen Hemminger
Headers
Series ethdev: clarify something about new event |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/intel-Functional success Functional PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-marvell-Functional success Functional Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS

Commit Message

Huisong Li Jan. 16, 2025, 11:40 a.m. UTC
During probing, before the port becomes generally available, the
rte_eth_dev_socket_id() and rte_eth_dev_owner_*() are available to
application.

Fixes: 7dcd73e37965 ("drivers/bus: set device NUMA node to unknown by default")
Fixes: 53ef1b34776b ("ethdev: add sanity checks in control APIs")
Cc: stable@dpdk.org

Signed-off-by: Huisong Li <lihuisong@huawei.com>
---
 lib/ethdev/rte_ethdev.c | 14 +++++++++++---
 lib/ethdev/rte_ethdev.h |  3 ++-
 2 files changed, 13 insertions(+), 4 deletions(-)
  

Comments

Thomas Monjalon Jan. 16, 2025, 3:18 p.m. UTC | #1
16/01/2025 12:40, Huisong Li:
> During probing, before the port becomes generally available, the
> rte_eth_dev_socket_id() and rte_eth_dev_owner_*() are available to
> application.
> 
> Fixes: 7dcd73e37965 ("drivers/bus: set device NUMA node to unknown by default")
> Fixes: 53ef1b34776b ("ethdev: add sanity checks in control APIs")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
[...]
>  	/** The port is being probed, i.e. allocated and not yet available.
>  	 * It is too early to check validity, query infos, and configure
> -	 * the port.
> +	 * the port. But some functions, like rte_eth_dev_socket_id() and
> +	 * rte_eth_dev_owner_*() are available to application.

I would add "the" before "application".

With this minor change,
Acked-by: Thomas Monjalon <thomas@monjalon.net>
  
Huisong Li Jan. 17, 2025, 8:43 a.m. UTC | #2
在 2025/1/16 23:18, Thomas Monjalon 写道:
> 16/01/2025 12:40, Huisong Li:
>> During probing, before the port becomes generally available, the
>> rte_eth_dev_socket_id() and rte_eth_dev_owner_*() are available to
>> application.
>>
>> Fixes: 7dcd73e37965 ("drivers/bus: set device NUMA node to unknown by default")
>> Fixes: 53ef1b34776b ("ethdev: add sanity checks in control APIs")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> [...]
>>   	/** The port is being probed, i.e. allocated and not yet available.
>>   	 * It is too early to check validity, query infos, and configure
>> -	 * the port.
>> +	 * the port. But some functions, like rte_eth_dev_socket_id() and
>> +	 * rte_eth_dev_owner_*() are available to application.
> I would add "the" before "application".
>
> With this minor change,
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
Ack
>
>
> .
  

Patch

diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
index 6413c54e3b..9cfb397cee 100644
--- a/lib/ethdev/rte_ethdev.c
+++ b/lib/ethdev/rte_ethdev.c
@@ -600,9 +600,10 @@  rte_eth_dev_owner_get(const uint16_t port_id, struct rte_eth_dev_owner *owner)
 	struct rte_eth_dev *ethdev;
 	int ret;
 
-	RTE_ETH_VALID_PORTID_OR_ERR_RET(port_id, -ENODEV);
-	ethdev = &rte_eth_devices[port_id];
+	if (port_id >= RTE_MAX_ETHPORTS)
+		return -ENODEV;
 
+	ethdev = &rte_eth_devices[port_id];
 	if (!eth_dev_is_allocated(ethdev)) {
 		RTE_ETHDEV_LOG_LINE(ERR, "Port ID %"PRIu16" is not allocated",
 			port_id);
@@ -635,8 +636,15 @@  int
 rte_eth_dev_socket_id(uint16_t port_id)
 {
 	int socket_id = SOCKET_ID_ANY;
+	struct rte_eth_dev *ethdev;
 
-	if (!rte_eth_dev_is_valid_port(port_id)) {
+	if (port_id >= RTE_MAX_ETHPORTS) {
+		rte_errno = EINVAL;
+		return socket_id;
+	}
+
+	ethdev = &rte_eth_devices[port_id];
+	if (!eth_dev_is_allocated(ethdev)) {
 		rte_errno = EINVAL;
 	} else {
 		socket_id = rte_eth_devices[port_id].data->numa_node;
diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
index ee7197aa97..0b6d65880a 100644
--- a/lib/ethdev/rte_ethdev.h
+++ b/lib/ethdev/rte_ethdev.h
@@ -4130,7 +4130,8 @@  enum rte_eth_event_type {
 	RTE_ETH_EVENT_INTR_RMV, /**< device removal event */
 	/** The port is being probed, i.e. allocated and not yet available.
 	 * It is too early to check validity, query infos, and configure
-	 * the port.
+	 * the port. But some functions, like rte_eth_dev_socket_id() and
+	 * rte_eth_dev_owner_*() are available to application.
 	 */
 	RTE_ETH_EVENT_NEW,
 	RTE_ETH_EVENT_DESTROY,  /**< port is released */