diff mbox series

[10/32] examples: replace memcpy with assignment

Message ID	20250208203142.242284-11-stephen@networkplumber.org (mailing list archive)
State	New
Delegated to:	Thomas Monjalon
Headers	From: Stephen Hemminger <stephen@networkplumber.org> To: dev@dpdk.org Cc: Stephen Hemminger <stephen@networkplumber.org>, Nicolas Chautru <nicolas.chautru@intel.com>, Tomasz Kantecki <tomasz.kantecki@intel.com>, Kirill Rybalchenko <kirill.rybalchenko@intel.com> Subject: [PATCH 10/32] examples: replace memcpy with assignment Date: Sat, 8 Feb 2025 12:22:02 -0800 Message-ID: <20250208203142.242284-11-stephen@networkplumber.org> In-Reply-To: <20250208203142.242284-1-stephen@networkplumber.org> References: <20250208203142.242284-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: dev-bounces@dpdk.org
Series	Use structure assignment instead of memcpy \| [00/32] Use structure assignment instead of memcpy [01/32] devtools/cocci: prefer structure assignment over memcpy [02/32] app/testpmd: replace memcpy with assignment [03/32] app/graph: replace memcpy with structure assignment [04/32] crypto/dpaa_sec: replace memcpy with assignment [05/32] dma/dpaa2: replace memcpy with assignment [06/32] eventdev: replace memcpy with assignment [07/32] event/dpaa2: replace memcpy with structure assignment [08/32] event/dsw: replace memcpy with assignment [09/32] ml/cnxk: replace memcpy with assignment [10/32] examples: replace memcpy with assignment [11/32] node: replace memcpy with assignment [12/32] pipeline: replace memcpy with assignment [13/32] sched: replace memcpy with structure assignment [14/32] table: replace memcpy with structure assignment [15/32] net/ntnic: replace memcpy with structure assignment [16/32] net/bnxt: replace memcpy with structure assignment [17/32] crypto/qat: replace memcpy with structure assignment [18/32] mempool/cnxk: replace memcpy with structure assignment [19/32] net/dpaa2: replace memcpy with assignment [20/32] net/enic: replace memcpy with assignment [21/32] net/intel/i40e: replace memcpy with structure assignment [22/32] net/nfp: replace memcpy with assignment [23/32] net/txgbe: replace memcpy with assignment [24/32] net/bnx2x: replace memcpy with structure assignment [25/32] net/dpaa2: replace memcpy with structure assignment [26/32] net/bonding: replace memcpy with structure assignment [27/32] net/cnxk: replace memcpy with structure assignment [28/32] net/enic: replace memcpy with structure assignment [29/32] net/iavf: replace memcpy with structure assignment [30/32] net/ice: replace memcpy with structure assignment [31/32] test: replace memcpy with structure assignment [32/32] test/cryptodev: replace memcpy with structure assignment

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Stephen Hemminger Feb. 8, 2025, 8:22 p.m. UTC

Prefer structure assignment over memcpy.
Found by cocci/struct_assign.cocci

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 examples/bbdev_app/main.c      | 2 +-
 examples/l2fwd-cat/cat.c       | 3 +--
 examples/ptpclient/ptpclient.c | 4 +---
 3 files changed, 3 insertions(+), 6 deletions(-)

diff mbox series

Patch

diff --git a/examples/bbdev_app/main.c b/examples/bbdev_app/main.c
index 46f20238db..03f15f91cc 100644
--- a/examples/bbdev_app/main.c
+++ b/examples/bbdev_app/main.c
@@ -360,7 +360,7 @@  add_ether_hdr(struct rte_mbuf *pkt_src, struct rte_mbuf *pkt_dst)
 	eth_to = rte_pktmbuf_mtod(pkt_dst, struct rte_ether_hdr *);
 
 	/* copy header */
-	rte_memcpy(eth_to, eth_from, sizeof(struct rte_ether_hdr));
+	*eth_to = *eth_from;
 }
 
 static inline void
diff --git a/examples/l2fwd-cat/cat.c b/examples/l2fwd-cat/cat.c
index 00e4cde48b..ac8feaec8e 100644
--- a/examples/l2fwd-cat/cat.c
+++ b/examples/l2fwd-cat/cat.c
@@ -314,8 +314,7 @@  parse_l3ca(const char *l3ca)
 		if (cmask != 0 && is_contiguous(cmask) == 0)
 			goto err;
 
-		rte_memcpy(&m_config[idx].cpumask,
-			&cpuset, sizeof(rte_cpuset_t));
+		m_config[idx].cpumask = cpuset;
 
 		if (cmask != 0) {
 			m_config[idx].cdp = 1;
diff --git a/examples/ptpclient/ptpclient.c b/examples/ptpclient/ptpclient.c
index def8de29ff..2f9764bf07 100644
--- a/examples/ptpclient/ptpclient.c
+++ b/examples/ptpclient/ptpclient.c
@@ -470,9 +470,7 @@  parse_fup(struct ptpv2_time_receiver_ordinary *ptp_data)
 		client_clkid->id[6] = eth_hdr->src_addr.addr_bytes[4];
 		client_clkid->id[7] = eth_hdr->src_addr.addr_bytes[5];
 
-		rte_memcpy(&ptp_data->client_clock_id,
-			   client_clkid,
-			   sizeof(struct clock_id));
+		ptp_data->client_clock_id = *client_clkid;
 
 		/* Enable flag for hardware timestamping. */
 		created_pkt->ol_flags |= RTE_MBUF_F_TX_IEEE1588_TMST;