diff mbox series

[04/32] crypto/dpaa_sec: replace memcpy with assignment

Message ID	20250208203142.242284-5-stephen@networkplumber.org (mailing list archive)
State	New
Delegated to:	Thomas Monjalon
Headers	From: Stephen Hemminger <stephen@networkplumber.org> To: dev@dpdk.org Cc: Stephen Hemminger <stephen@networkplumber.org>, Gagandeep Singh <g.singh@nxp.com>, Hemant Agrawal <hemant.agrawal@nxp.com> Subject: [PATCH 04/32] crypto/dpaa_sec: replace memcpy with assignment Date: Sat, 8 Feb 2025 12:21:56 -0800 Message-ID: <20250208203142.242284-5-stephen@networkplumber.org> In-Reply-To: <20250208203142.242284-1-stephen@networkplumber.org> References: <20250208203142.242284-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: dev-bounces@dpdk.org
Series	Use structure assignment instead of memcpy \| [00/32] Use structure assignment instead of memcpy [01/32] devtools/cocci: prefer structure assignment over memcpy [02/32] app/testpmd: replace memcpy with assignment [03/32] app/graph: replace memcpy with structure assignment [04/32] crypto/dpaa_sec: replace memcpy with assignment [05/32] dma/dpaa2: replace memcpy with assignment [06/32] eventdev: replace memcpy with assignment [07/32] event/dpaa2: replace memcpy with structure assignment [08/32] event/dsw: replace memcpy with assignment [09/32] ml/cnxk: replace memcpy with assignment [10/32] examples: replace memcpy with assignment [11/32] node: replace memcpy with assignment [12/32] pipeline: replace memcpy with assignment [13/32] sched: replace memcpy with structure assignment [14/32] table: replace memcpy with structure assignment [15/32] net/ntnic: replace memcpy with structure assignment [16/32] net/bnxt: replace memcpy with structure assignment [17/32] crypto/qat: replace memcpy with structure assignment [18/32] mempool/cnxk: replace memcpy with structure assignment [19/32] net/dpaa2: replace memcpy with assignment [20/32] net/enic: replace memcpy with assignment [21/32] net/intel/i40e: replace memcpy with structure assignment [22/32] net/nfp: replace memcpy with assignment [23/32] net/txgbe: replace memcpy with assignment [24/32] net/bnx2x: replace memcpy with structure assignment [25/32] net/dpaa2: replace memcpy with structure assignment [26/32] net/bonding: replace memcpy with structure assignment [27/32] net/cnxk: replace memcpy with structure assignment [28/32] net/enic: replace memcpy with structure assignment [29/32] net/iavf: replace memcpy with structure assignment [30/32] net/ice: replace memcpy with structure assignment [31/32] test: replace memcpy with structure assignment [32/32] test/cryptodev: replace memcpy with structure assignment

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Stephen Hemminger Feb. 8, 2025, 8:21 p.m. UTC

Prefer structure assignment over memcpy.
Found by cocci/struct_assign.cocci

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/crypto/dpaa_sec/dpaa_sec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Hemant Agrawal Feb. 10, 2025, 10:38 a.m. UTC | #1

On 09-02-2025 01:51, Stephen Hemminger wrote:
> Prefer structure assignment over memcpy.
> Found by cocci/struct_assign.cocci
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>   drivers/crypto/dpaa_sec/dpaa_sec.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c
> index 3fa88ca968..af605d2025 100644
> --- a/drivers/crypto/dpaa_sec/dpaa_sec.c
> +++ b/drivers/crypto/dpaa_sec/dpaa_sec.c
> @@ -680,7 +680,7 @@ dpaa_sec_dump(struct dpaa_sec_op_ctx *ctx, struct dpaa_sec_qp *qp, FILE *f)
>   	}
>   
>   	cdb = &sess->cdb;
> -	rte_memcpy(&c_cdb, cdb, sizeof(struct sec_cdb));
> +	c_cdb = *cdb;
>   #ifdef RTE_LIB_SECURITY
>   	fprintf(f, "\nsession protocol type = %d\n", sess->proto_alg);
>   #endif
Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>

diff mbox series

Patch

diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c
index 3fa88ca968..af605d2025 100644
--- a/drivers/crypto/dpaa_sec/dpaa_sec.c
+++ b/drivers/crypto/dpaa_sec/dpaa_sec.c
@@ -680,7 +680,7 @@  dpaa_sec_dump(struct dpaa_sec_op_ctx *ctx, struct dpaa_sec_qp *qp, FILE *f)
 	}
 
 	cdb = &sess->cdb;
-	rte_memcpy(&c_cdb, cdb, sizeof(struct sec_cdb));
+	c_cdb = *cdb;
 #ifdef RTE_LIB_SECURITY
 	fprintf(f, "\nsession protocol type = %d\n", sess->proto_alg);
 #endif