diff mbox series

[v2,12/26] net/ntnic: remove usless part of conditional expression

Message ID 20250505071309.586015-13-okl-plv@napatech.com (mailing list archive)
State New
Delegated to: Stephen Hemminger
Headers
Series net/ntnic: fixes and improvements |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Oleksandr Kolomeiets May 5, 2025, 7:12 a.m. UTC 
From: Danylo Vodopianov <dvo-plv@napatech.com>

The conditional expressions that always has unchanging state was removed

Signed-off-by: Danylo Vodopianov <dvo-plv@napatech.com>
---
 drivers/net/ntnic/link_mgmt/link_100g/nt4ga_link_100g.c | 2 +-
 drivers/net/ntnic/nthw/core/nthw_fpga.c                 | 4 +---
 2 files changed, 2 insertions(+), 4 deletions(-)
diff mbox series

Patch

diff --git a/drivers/net/ntnic/link_mgmt/link_100g/nt4ga_link_100g.c b/drivers/net/ntnic/link_mgmt/link_100g/nt4ga_link_100g.c
index dde185c62f..43b3c5a41f 100644
--- a/drivers/net/ntnic/link_mgmt/link_100g/nt4ga_link_100g.c
+++ b/drivers/net/ntnic/link_mgmt/link_100g/nt4ga_link_100g.c
@@ -672,7 +672,7 @@  static int nt4ga_link_100g_ports_init(struct adapter_info_s *p_adapter_info, nth
 	 */
 	RTE_ASSERT(adapter_no >= 0 && adapter_no < NUM_ADAPTER_MAX);
 
-	if (res == 0 && !p_adapter_info->nt4ga_link.variables_initialized) {
+	if (!p_adapter_info->nt4ga_link.variables_initialized) {
 		nthw_mac_pcs_t *mac_pcs = p_adapter_info->nt4ga_link.u.var100g.mac_pcs100g;
 		nim_i2c_ctx_t *nim_ctx = p_adapter_info->nt4ga_link.u.var100g.nim_ctx;
 		nthw_gpio_phy_t *gpio_phy = p_adapter_info->nt4ga_link.u.var100g.gpio_phy;
diff --git a/drivers/net/ntnic/nthw/core/nthw_fpga.c b/drivers/net/ntnic/nthw/core/nthw_fpga.c
index 485e912912..47f4b4e7b1 100644
--- a/drivers/net/ntnic/nthw/core/nthw_fpga.c
+++ b/drivers/net/ntnic/nthw/core/nthw_fpga.c
@@ -550,10 +550,8 @@  int nthw_fpga_shutdown(struct fpga_info_s *p_fpga_info)
 {
 	int res = -1;
 
-	if (p_fpga_info) {
-		if (p_fpga_info && p_fpga_info->mp_nthw_rac)
+		if (p_fpga_info->mp_nthw_rac)
 			res = nthw_rac_rab_reset(p_fpga_info->mp_nthw_rac);
-	}
 
 	return res;
 }