diff mbox series

build: fix disabling developer mode

Message ID 20250508044230.133966-1-david.marchand@redhat.com (mailing list archive)
State Accepted
Delegated to: David Marchand
Headers
Series build: fix disabling developer mode |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/github-robot: build success github build: passed
ci/iol-marvell-Functional success Functional Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/intel-Functional success Functional PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-sample-apps-testing warning Testing issues
ci/aws-unit-testing success Unit Testing PASS

Commit Message

David Marchand May 8, 2025, 4:42 a.m. UTC 
A recent change broke disabling developer mode:
$ meson setup plop -Ddeveloper_mode=disabled
...
drivers/meson.build:150:14: ERROR: Unknown variable "fs".

Fixes: 8fa3af6c05f8 ("build: add generic support for base code in drivers")

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 meson.build | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Bruce Richardson May 12, 2025, 3:28 p.m. UTC | #1 
On Thu, May 08, 2025 at 06:42:29AM +0200, David Marchand wrote:
> A recent change broke disabling developer mode:
> $ meson setup plop -Ddeveloper_mode=disabled
> ...
> drivers/meson.build:150:14: ERROR: Unknown variable "fs".
> 
> Fixes: 8fa3af6c05f8 ("build: add generic support for base code in drivers")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  meson.build | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/meson.build b/meson.build
> index 8436d1dff8..dfb4cb3aee 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -13,10 +13,11 @@ project('DPDK', 'c',
>          meson_version: '>= 0.57'
>  )
>  
> +fs = import('fs')
> +
>  # check for developer mode
>  developer_mode = false
>  if get_option('developer_mode').auto()
> -    fs = import('fs')
>      developer_mode = fs.exists('.git')
>  else
>      developer_mode = get_option('developer_mode').enabled()
> -- 

Simple fix, LGTM.

Acked-by: Bruce Richardson <bruce.richardson@intel.com>
David Marchand May 12, 2025, 3:45 p.m. UTC | #2 
On Mon, May 12, 2025 at 5:28 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
> On Thu, May 08, 2025 at 06:42:29AM +0200, David Marchand wrote:
> > A recent change broke disabling developer mode:
> > $ meson setup plop -Ddeveloper_mode=disabled
> > ...
> > drivers/meson.build:150:14: ERROR: Unknown variable "fs".
> >
> > Fixes: 8fa3af6c05f8 ("build: add generic support for base code in drivers")
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/meson.build b/meson.build
index 8436d1dff8..dfb4cb3aee 100644
--- a/meson.build
+++ b/meson.build
@@ -13,10 +13,11 @@  project('DPDK', 'c',
         meson_version: '>= 0.57'
 )
 
+fs = import('fs')
+
 # check for developer mode
 developer_mode = false
 if get_option('developer_mode').auto()
-    fs = import('fs')
     developer_mode = fs.exists('.git')
 else
     developer_mode = get_option('developer_mode').enabled()