diff mbox series

[1/2] ci: treat warning as error for MSVC builds in GHA

Message ID 20250610083643.8466-1-david.marchand@redhat.com (mailing list archive)
State Accepted
Delegated to: David Marchand
Headers
Series [1/2] ci: treat warning as error for MSVC builds in GHA |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

David Marchand June 10, 2025, 8:36 a.m. UTC 
Some trivial builds warnings with MSVC were missed as those were not
treated as errors.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 .github/workflows/build.yml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Aaron Conole June 12, 2025, 12:54 p.m. UTC | #1 
David Marchand <david.marchand@redhat.com> writes:

> Some trivial builds warnings with MSVC were missed as those were not
> treated as errors.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---

Acked-by: Aaron Conole <aconole@redhat.com>

>  .github/workflows/build.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
> index 1e289979e3..e5f17ef6ac 100644
> --- a/.github/workflows/build.yml
> +++ b/.github/workflows/build.yml
> @@ -198,7 +198,7 @@ jobs:
>        shell: cmd
>        run: |
>          call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\VsDevCmd.bat" -host_arch=amd64 -arch=amd64
> -        meson setup -Denable_stdatomic=true build
> +        meson setup -Denable_stdatomic=true -Dwerror=true build
>      - name: Build
>        shell: cmd
>        run: |
diff mbox series

Patch

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 1e289979e3..e5f17ef6ac 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -198,7 +198,7 @@  jobs:
       shell: cmd
       run: |
         call "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\VsDevCmd.bat" -host_arch=amd64 -arch=amd64
-        meson setup -Denable_stdatomic=true build
+        meson setup -Denable_stdatomic=true -Dwerror=true build
     - name: Build
       shell: cmd
       run: |