diff mbox series

net/fm10k: fix build with GCC 16

Message ID 20251104111515.1728873-1-bruce.richardson@intel.com (mailing list archive)
State Accepted
Delegated to: Bruce Richardson
Headers
Series net/fm10k: fix build with GCC 16 |

Checks

Context Check Description
ci/checkpatch warning coding style issues
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing fail Unit Testing FAIL
ci/Intel-compilation success Compilation OK
ci/iol-mellanox-Functional success Functional Testing PASS
ci/intel-Testing success Testing PASS
ci/iol-marvell-Functional success Functional Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/intel-Functional success Functional PASS
ci/github-robot: build success github build: passed
ci/github-robot-post success github post: success
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/aws-unit-testing success Unit Testing PASS
ci/iol-unit-arm64-testing success Testing PASS

Commit Message

Bruce Richardson Nov. 4, 2025, 11:15 a.m. UTC 
Build error reported with GCC 16, due to a set but unused variable. Fix
the issue by removing the setting of the var and marking it as unused.

../drivers/net/intel/fm10k/base/fm10k_common.c: In function 'fm10k_unbind_hw_stats_q':
../drivers/net/intel/fm10k/base/fm10k_common.c:480:62: warning:
parameter 'idx' set but not used [-Wunused-but-set-parameter=]
  480 | void fm10k_unbind_hw_stats_q(struct fm10k_hw_stats_q *q, u32 idx, u32 count)

Bugzilla ID: 1822
Fixes: 7223d200c227 ("fm10k: add base driver")
Cc: stable@dpdk.org
Cc: stephen@networkplumber.org

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 drivers/net/intel/fm10k/base/fm10k_common.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Vladimir Medvedkin Nov. 4, 2025, 2:52 p.m. UTC | #1 
Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>

On 11/4/2025 11:15 AM, Bruce Richardson wrote:
> Build error reported with GCC 16, due to a set but unused variable. Fix
> the issue by removing the setting of the var and marking it as unused.
>
> ../drivers/net/intel/fm10k/base/fm10k_common.c: In function 'fm10k_unbind_hw_stats_q':
> ../drivers/net/intel/fm10k/base/fm10k_common.c:480:62: warning:
> parameter 'idx' set but not used [-Wunused-but-set-parameter=]
>    480 | void fm10k_unbind_hw_stats_q(struct fm10k_hw_stats_q *q, u32 idx, u32 count)
>
> Bugzilla ID: 1822
> Fixes: 7223d200c227 ("fm10k: add base driver")
> Cc: stable@dpdk.org
> Cc: stephen@networkplumber.org
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>   drivers/net/intel/fm10k/base/fm10k_common.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/intel/fm10k/base/fm10k_common.c b/drivers/net/intel/fm10k/base/fm10k_common.c
> index b78d4b575b..677ef87608 100644
> --- a/drivers/net/intel/fm10k/base/fm10k_common.c
> +++ b/drivers/net/intel/fm10k/base/fm10k_common.c
> @@ -477,11 +477,11 @@ void fm10k_update_hw_stats_q(struct fm10k_hw *hw, struct fm10k_hw_stats_q *q,
>    *  Function invalidates the index values for the queues so any updates that
>    *  may have happened are ignored and the base for the queue stats is reset.
>    **/
> -void fm10k_unbind_hw_stats_q(struct fm10k_hw_stats_q *q, u32 idx, u32 count)
> +void fm10k_unbind_hw_stats_q(struct fm10k_hw_stats_q *q, u32 idx __rte_unused, u32 count)
>   {
>   	u32 i;
>   
> -	for (i = 0; i < count; i++, idx++, q++) {
> +	for (i = 0; i < count; i++, q++) {
>   		q->rx_stats_idx = 0;
>   		q->tx_stats_idx = 0;
>   	}
Bruce Richardson Nov. 5, 2025, 10:43 a.m. UTC | #2 
On Tue, Nov 04, 2025 at 02:52:37PM +0000, Medvedkin, Vladimir wrote:
> 
> On 11/4/2025 11:15 AM, Bruce Richardson wrote:
> > Build error reported with GCC 16, due to a set but unused variable. Fix
> > the issue by removing the setting of the var and marking it as unused.
> > 
> > ../drivers/net/intel/fm10k/base/fm10k_common.c: In function 'fm10k_unbind_hw_stats_q':
> > ../drivers/net/intel/fm10k/base/fm10k_common.c:480:62: warning:
> > parameter 'idx' set but not used [-Wunused-but-set-parameter=]
> >    480 | void fm10k_unbind_hw_stats_q(struct fm10k_hw_stats_q *q, u32 idx, u32 count)
> > 
> > Bugzilla ID: 1822
> > Fixes: 7223d200c227 ("fm10k: add base driver")
> > Cc: stable@dpdk.org
> > Cc: stephen@networkplumber.org
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> > ---
Applied to dpdk-next-net-intel.

/Bruce
diff mbox series

Patch

diff --git a/drivers/net/intel/fm10k/base/fm10k_common.c b/drivers/net/intel/fm10k/base/fm10k_common.c
index b78d4b575b..677ef87608 100644
--- a/drivers/net/intel/fm10k/base/fm10k_common.c
+++ b/drivers/net/intel/fm10k/base/fm10k_common.c
@@ -477,11 +477,11 @@  void fm10k_update_hw_stats_q(struct fm10k_hw *hw, struct fm10k_hw_stats_q *q,
  *  Function invalidates the index values for the queues so any updates that
  *  may have happened are ignored and the base for the queue stats is reset.
  **/
-void fm10k_unbind_hw_stats_q(struct fm10k_hw_stats_q *q, u32 idx, u32 count)
+void fm10k_unbind_hw_stats_q(struct fm10k_hw_stats_q *q, u32 idx __rte_unused, u32 count)
 {
 	u32 i;
 
-	for (i = 0; i < count; i++, idx++, q++) {
+	for (i = 0; i < count; i++, q++) {
 		q->rx_stats_idx = 0;
 		q->tx_stats_idx = 0;
 	}