From patchwork Wed Mar 14 15:49:13 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Santosh Shukla X-Patchwork-Id: 36104 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 88B177CFD; Wed, 14 Mar 2018 16:49:36 +0100 (CET) Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0045.outbound.protection.outlook.com [104.47.40.45]) by dpdk.org (Postfix) with ESMTP id BFEFD7CFC for ; Wed, 14 Mar 2018 16:49:33 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=CAVIUMNETWORKS.onmicrosoft.com; s=selector1-cavium-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=yuBvyE1yN1ZBn64LHJcDL8uxNajEz/JgQg1BzllDgZg=; b=jKLSk2RrUxbxx8vA2OA1mFv4km1+Et1D6TrlXZnJO9kQevcRayWHOZHzAkksSqS8thSjJ6jNBLZ0A9uINQsmGFwLHwO9j9K4iM+kwyBpfGCfYHNsLbCZzj5P619ddNyfauvaw3LHdBgDC1f2fSoPDiUsb94ZaMJxK13aNxcsU5g= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Santosh.Shukla@cavium.com; Received: from [192.168.0.106] (103.76.56.167) by SN1PR0701MB1904.namprd07.prod.outlook.com (2a01:111:e400:517b::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.548.13; Wed, 14 Mar 2018 15:49:29 +0000 To: Andrew Rybchenko , dev@dpdk.org Cc: Olivier MATZ , Jerin Jacob , Hemant Agrawal , Shreyansh Jain References: <1516713372-10572-1-git-send-email-arybchenko@solarflare.com> <1520696382-16400-1-git-send-email-arybchenko@solarflare.com> From: santosh Message-ID: <317a928a-f8de-13da-74bd-28fa0b5234b9@caviumnetworks.com> Date: Wed, 14 Mar 2018 21:19:13 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <1520696382-16400-1-git-send-email-arybchenko@solarflare.com> Content-Language: en-US X-Originating-IP: [103.76.56.167] X-ClientProxiedBy: BM1PR0101CA0046.INDPRD01.PROD.OUTLOOK.COM (2603:1096:b00:1a::32) To SN1PR0701MB1904.namprd07.prod.outlook.com (2a01:111:e400:517b::30) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9ea202b8-36eb-4d24-1287-08d589c32d4a X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(5600026)(4604075)(4534165)(4627221)(201703031133081)(201702281549075)(2017052603328)(7153060)(7193020); SRVR:SN1PR0701MB1904; X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB1904; 3:/FzUIcYoTFjCuh5h1slUPhtD3up6snIuEYWHas5x1pkWu53+HwUgXDqYD6Pss/MjAvP81xt9BObeTbMkpoK6nvz+w2t31IFptTpUxIKe1oJsOSloyxN+oyGSfa5T6kXNlXDVXjFhxd3O75LprBNE/HFXck7e9UjOaLkVSGaJ+yQsCvyobGgu3tfT5ETexdLUo3xuEdJaBNZRghH+LeLbnNLkGTQPOKgHk1IVnt8ZsLytKTKWlioH3vPmJ4W6yJ5f; 25:hK51SVhA9d2ioIVRWHKMFaetV+MY/njFcB2GddbfoTeYouH0JaXItmR4JTEYft4YNVDyQy7t0UKi6PNnQMwL0DPx+E783vIjMbpaSWIa2gkDFveP4t3zjYZiEEEgNVv0LvbPXIz0tX0STR2rL/vU/gCNP/71LFTfO3Dxrl7N5S8CUIjn5osCWMeiA7V1TffQDKMrfyhbnNw6hC8IrT7iXSefvfzlWr4C2JWBJ8NQ/CEnDoUOlgoqz5UX/K9G+saUCwzJJVnDTCnTazi7YICEHQgs1q0/HdgKKSMMMoioJbVlA2rOGHaokoZmtQqFw6KdtEGaTMc/4kOBLWu4f6Ng9w==; 31:DboEiEY1qtqlVInk9rJrrYQ0/Xrc2fzdffZGKDJFZOeh+BFybazDs3MjjiX5SkLD/lWMk38NgET2ugsVUR7u47YB8R7nWo53DT8cVR4w51MwF8FseoIsRLjnxI7zBNPf9KRMM2oRsBigOvxsB+NDZXswELeRVnahfg6QJmLYfz7+wTVnaGWPwb6KNfMNGKCiQZMz76XIaqPLjB1xhsdECuFtKZ8RIoCN6xTlUuB0FtE= X-MS-TrafficTypeDiagnostic: SN1PR0701MB1904: X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB1904; 20:p5WyTag3TIyuNhZ+ZN+8ltag7WcztNX2q4TQ/G+Lrw3KMUKSx9cEYaZSB/od2fhlkUUNHYD5h4+TvEN/YyFMMw9gyth/VdEJK6yJLh3XIlGK7jx3GUweT2HXZXawrkNCGr53h2Jo4Trr/ZQpQi5qhLINGgx+dF/0hFxQfCglaJEzIBcIZuudMzPkkLbldgcxKv50SGK1leba4YCoo62kj03CIp1uXYYV3Vg9Mvj99hwBRmAB05opfMSpmYIWT/+F8Ay7oahRQoFqM9uGP51OerUFRIa86UlHiDpXgA7OK+yG0WcgKA3Ot567xx+BUVlLAPxAZqU6wkTCj+ikGMS/FZ8kQffsQU9KqZ0CGCSiZQnlQQPWwLFRJ5wxBRMseJWjNrcho6Mucfnkm5dGjXcnfibUgnfVy+evqiPs3VP89ozJEDlZ2B+UViHq1lcCKlVYvbxYWo6pDKsUuUjY1DSEjfX22DVJrJe/QRU2/5TnFfbnoxuHZFtylDoOUbpeVFCCabIcdUv4UtfjbTAARl+KZqngqI705Khf5ZEbtgdIGYb2XvxMsMpZn9ifbyfp8WYQhJBrnQKV3W2haFb1PKJBgx+9/t3wjx/bHq5CMgupqFg=; 4:ZYGqECWbEqio63mrjb4GXi5F4JcpEOwcJs0Lvu+SzvXHG+HkIxrEnePFunLsBLvaawccowRFQCqTvQqBoyzflRiGxD2CuZ1lXhCyObrWhBeRErq4zTx77NNNJCiFM+JztFMrnl1F0YCAH2s4n9Pau2k7X4sNNm6gZjqNFst/0O1lv6JEe8lOZThsAZ4wytBeq3GYLuiO54XoXbl0yPYzeNpGgHcf4s0iYc8FRaLfev7EG4wrCS7J2p1xPV/eRNND28u/c3SPhNuUvn0yXVLgaw== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(3231221)(944501244)(52105095)(10201501046)(3002001)(93006095)(6041310)(20161123558120)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123562045)(20161123564045)(20161123560045)(6072148)(201708071742011); SRVR:SN1PR0701MB1904; BCL:0; PCL:0; RULEID:; SRVR:SN1PR0701MB1904; X-Forefront-PRVS: 0611A21987 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(6049001)(396003)(376002)(39850400004)(39380400002)(366004)(346002)(189003)(199004)(26005)(50466002)(77096007)(105586002)(31696002)(8676002)(81166006)(52146003)(23676004)(8936002)(52116002)(8656006)(66066001)(2486003)(81156014)(36756003)(386003)(106356001)(47776003)(97736004)(65806001)(65956001)(5660300001)(186003)(16526019)(31686004)(42882007)(316002)(54906003)(25786009)(229853002)(53936002)(16576012)(305945005)(3846002)(117156002)(68736007)(6486002)(64126003)(4326008)(58126008)(72206003)(6116002)(6666003)(6246003)(2870700001)(76176011)(7736002)(86152003)(2906002)(65826007)(2950100002)(478600001); DIR:OUT; SFP:1101; SCL:1; SRVR:SN1PR0701MB1904; H:[192.168.0.106]; FPR:; SPF:None; PTR:InfoNoRecords; MX:1; A:1; LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?q?1=3BSN1PR0701MB1904=3B23=3AjU?= =?utf-8?q?xstRBCYIae/dirL7CqSlWAkCMI1flTTD1GXXAUAV/km7aFpT+o2PlEEX?= =?utf-8?q?NNIU1CemVmwk6S0cukVuxWhNinc0e04RXczSzzpHcYxmJ9PgvuJ8WNDz?= =?utf-8?q?cXX7J9qWzfZ+rSDr+dbcFldJ5XhYCEm4GQPwlPc8dGlVWHdGA617Ub65?= =?utf-8?q?QV+6K2vYE+9ebll408G/x9yuUPXBEUvl9I/7ibdZiWvGgE4Hw8PJJV2C?= =?utf-8?q?yzscaAP0qFcsaXtJnjz/fh9M9aa86QPiOhMx+eRcGJZnT1jd7mL9loNv?= =?utf-8?q?uCJlMSVz1iPKMiDFC+SlsFrdUbXEBAX4eldlSydYZ6X8DcT6hzrLdo0A?= =?utf-8?q?Hn9Rs3S19+eaMXGwIxrG2fetZlyR7pqbBe82tLNQ2NaFLA28IX0fuF/S?= =?utf-8?q?JizEUhWToV0MQhFLPtl/82LSkYPt22Mj0FLABBXlN3FKYuXCedB0GmtM?= =?utf-8?q?Ly3+yMbymdcVmKjlO8fGph+UwL1xPszAVxXrPQoqlYwfjWf2BwsJ2nSO?= =?utf-8?q?lUJiKQZb/tJHenAw1yFxceMe8sZGM+q3BWQOIeKhErRiXUrZ4EavipRx?= =?utf-8?q?CwF8cApD+Re02+5azGJWMDMZuQmv7dE2FmAz3LBYM1Yx6lVuSYFXVxJz?= =?utf-8?q?mqCAXjd+7o7DrAruzkjxf6whAfvZCPfguIbRU2PjW3kaDJiSBvuS9IUA?= =?utf-8?q?DPouhkUy/0u7eKUMWOgJinRarhgaZXMHjTVrWamPWZT5dAkB8c6kTAlL?= =?utf-8?q?zW07kljZr9hqiYMZjpE9ZORdkEd/skyRD/WEnjydh55rSSUYXNHBz7TO?= =?utf-8?q?K0W4Dr0sjQtQ9OlPoEl/DpkFuZk+3oWZu6QiWqV/dhBgrJkLLv+9T2Lj?= =?utf-8?q?UKhhWdcVpXR8WS5f/633TyxeUgQ8pVo8oLOg4l1/5XjFHKY1zg+V5lYr?= =?utf-8?q?jeoVaCWDvySupCwcspM7YBBnv0kP+AH3J0nbot8hH8y78dzIu3rVnVgH?= =?utf-8?q?bikoDGTTicEejxNPqfed2cP9SSvQnCvOpJqkFmUn70fMZooKTonSWreb?= =?utf-8?q?Uzh9ZU5BY/XnZBBcSuyWYZMWAOdcLX7lPpbsFVlR5P3NG6iMg7KtcVAd?= =?utf-8?q?zxD7iwMvgaQqzOHaGimcDQy/mfJa70zRJDcLUdzF8sOZ5aKXVywOfJku?= =?utf-8?q?3IU5Wm7JvT18fpUdMULfauYTbzgXedphF3oDf1ltMf+9P8PnGMGe0JQo?= =?utf-8?q?Xugg+SX7314zA/yYUWXlOWtEv24q7NoibutVM7hhSRUiof3wc6Txy0C+?= =?utf-8?q?VLj2DXucxqXSRa/atasKcNAqpzxZ0PFwJe2Fhy8SHiCvonBJvgJi/nU/?= =?utf-8?q?Wqg6hvztYUNFVeS9mavfkJ1MRXv8btOfy1ifzWPH6tIW4fROnK8+2Olr?= =?utf-8?q?fhYedP1Hj1s5sByrglnC1SvQSf2ysc9X9mX+EEI4n/+wKFQDmR9eZ4J1?= =?utf-8?q?Ru8IH4?= X-Microsoft-Antispam-Message-Info: wCYE2+BES2T8FWQ1Zk5M18sCbalpgrNwLgodwmx2oMj9s2QOj7z56RiaePEPZMoqxM4B2p9GFfUv9TalrnbKWfF5b8SpnQojdmfsPxkXq6YjgpzOvnyp2MVOvV1WDELAZWPaG0A3LIxAe1/h4ywwjBeY/j8DpG9xVKbAFO4dXPxkfcb11vRKdpDaZapy5ar0 X-Microsoft-Exchange-Diagnostics: 1; SN1PR0701MB1904; 6:Nun2te+EDPIGNW/SpRIreqA4hgCgevyYSPYcOa17omw3Zw5UJF6WAHbfO983nlqTGU4Wzg0YpO3Q78wYJ3J4EWvmvGIYJxo40f1AAeSYkoPnGPKjGVdZ+MM54yDcyT2J1QBjCcuPJfMqMc01fSBN+7A94oD38MJVijGVZB2pmyiArGk4t0DTpkep2QdJZtJCfK7EzLIdGndyNwggw0R1fZAKzgrFRsuG94C94cVpWNSFVakhE+VlYoMaQsu0afoc8Fwq2M3mgJUOgXmKrjyuOxM22ICEq0qouUkghpvy7yK2j928FcqRFlFF7QFT+nNLN/4pEOqkeLqljCvluplgEWj6fXOaS1ORkVc4HcElxVM=; 5:QfwCbWcP35IJBznqffHA36Kbl0A+UEceoGuozUazfbVDxzD91UyT39TXEOL733rM+qEc1HZxT9MF8D9r4nUKQabtL8oOLjBVzjn7eDxJqY2lmdgCZMRk50pmlI1s37KykFpd5DagEPs2Bp3t7DtbqO2wf1U5j0h+koest3rdFCo=; 24:8OMlQ5YVg8bRbTNjAyZwa1j7FsgiXok9k9cX/U3z8/RCtlQDclcgHxEPK6BlJLVeRTz+3qfh1aB8OtzFjKD9Jm6g+RduLPhtnm3uyv4+dWI=; 7:23SixiVSKYelkE68S5ibqZ/YgEGyvkXuhpxW/MXrRwpGP6xD1rP/Rpa0tXTQ4qnOTXwz21oZSYFQ12xR5eH+Qy5wfAiX45ccffynpvNETTBbhgvnUNJiNexi6JQSIpIVs1uNhNPNr5f6ARBolBNBTseG7Q5X+eJ+ig75NoKy1hrbEQ6RbhRsf91BQvdy+qTNV01avPe2+ZMv8ZD2/gnKSfCzZNoU3C0tAyZcHNYD+FFR9wxNseKHreR718QBJ3Lk SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2018 15:49:29.0182 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9ea202b8-36eb-4d24-1287-08d589c32d4a X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR0701MB1904 Subject: Re: [dpdk-dev] [PATCH v1 0/9] mempool: prepare to add bucket driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Andrew, On Saturday 10 March 2018 09:09 PM, Andrew Rybchenko wrote: [...] > RFCv1 -> RFCv2: > - add driver ops to calculate required memory size and populate > mempool objects, remove extra flags which were required before > to control it > - transition of octeontx and dpaa drivers to the new callbacks > - change info API to get information from driver required to > API user to know contiguous block size > - remove get_capabilities (not required any more and may be > substituted with more in info get API) > - remove register_memory_area since it is substituted with > populate callback which can do more > - use SPDX tags > - avoid all objects affinity to single lcore > - fix bucket get_count > - deprecate XMEM API > - avoid introduction of a new function to flush cache > - fix NO_CACHE_ALIGN case in bucket mempool I'm evaluating your series in octeontx platform. Noticed a build break for dpaa platform: CC dpaa_mempool.o /home/ubuntu/83xx/dpdk/drivers/mempool/dpaa/dpaa_mempool.c: In function ‘dpaa_populate’: /home/ubuntu/83xx/dpdk/drivers/mempool/dpaa/dpaa_mempool.c:291:41: error: passing argument 1 of ‘rte_mempool_op_populate_default’ discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers] return rte_mempool_op_populate_default(mp, max_objs, vaddr, paddr, len, ^ In file included from /home/ubuntu/83xx/dpdk/drivers/mempool/dpaa/dpaa_mempool.h:15:0, from /home/ubuntu/83xx/dpdk/drivers/mempool/dpaa/dpaa_mempool.c:28: /home/ubuntu/83xx/dpdk/build/include/rte_mempool.h:490:5: note: expected ‘struct rte_mempool *’ but argument is of type ‘const struct rte_mempool *’ int rte_mempool_op_populate_default(struct rte_mempool *mp, ^ /home/ubuntu/83xx/dpdk/drivers/mempool/dpaa/dpaa_mempool.c: At top level: /home/ubuntu/83xx/dpdk/drivers/mempool/dpaa/dpaa_mempool.c:303:14: error: initialization from incompatible pointer type [-Werror=incompatible-pointer-types] .populate = dpaa_populate, ^ /home/ubuntu/83xx/dpdk/drivers/mempool/dpaa/dpaa_mempool.c:303:14: note: (near initialization for ‘dpaa_mpool_ops.populate’) cc1: all warnings being treated as errors may be consider adding for dpaa platform.. Will share test and review feedback for octeontx platform soon. [...] diff --git a/drivers/mempool/dpaa/dpaa_mempool.c b/drivers/mempool/dpaa/dpaa_mempool.c index a2bbb392a..ce5050627 100644 --- a/drivers/mempool/dpaa/dpaa_mempool.c +++ b/drivers/mempool/dpaa/dpaa_mempool.c @@ -263,8 +263,8 @@ dpaa_mbuf_get_count(const struct rte_mempool *mp) return bman_query_free_buffers(bp_info->bp); } -static int -dpaa_populate(const struct rte_mempool *mp, unsigned int max_objs, +static int __rte_unused +dpaa_populate(struct rte_mempool *mp, unsigned int max_objs, char *vaddr, rte_iova_t paddr, size_t len, rte_mempool_populate_obj_cb_t *obj_cb, void *obj_cb_arg) {