From patchwork Tue Mar 13 12:50:39 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?N=C3=A9lio_Laranjeiro?= X-Patchwork-Id: 36058 X-Patchwork-Delegate: shahafs@mellanox.com Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EDD55AAB7; Tue, 13 Mar 2018 13:52:06 +0100 (CET) Received: from mail-wr0-f196.google.com (mail-wr0-f196.google.com [209.85.128.196]) by dpdk.org (Postfix) with ESMTP id B34FFA486 for ; Tue, 13 Mar 2018 13:52:02 +0100 (CET) Received: by mail-wr0-f196.google.com with SMTP id d10so9888534wrf.3 for ; Tue, 13 Mar 2018 05:52:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=5Ky+tycm17wgXJrA/PWUAVIBJN5P1UZv7F3DE9d3kkg=; b=17rp/MG+vJ9NJBglt7gnYuKR58eeaVsskrzKWCb0UN3WgtyH3Uv6GIIrTJRF9AjSQU RoPK8a4hEwfvdjTP8eMQ2gz56luO8L6m6E2c+gr1eLQh/Xg4yhYxJki0AqA3jIBKFS60 FmZKUZ/OP7hN+U/zsetiGw779NSDQSgy1Z2MaRbkvCVw9nkJp9tCbvL3hXq2e//ctP9r bxKCOkq6MN2cACyKurwSJBARezJfSHpVyyZ7j6ngwBbcA0/yVxfHEwy7SIysxTvUxiJM H7T6L7Wjm6HlssxN4xhl0YiRpDPasdZs9osnVHTkbLc+o3wOP0NyFym2GdihWV+AHoPf +qHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=5Ky+tycm17wgXJrA/PWUAVIBJN5P1UZv7F3DE9d3kkg=; b=GuiKxpcIsrGRfYa4CdlQnQuV3UaQnAFFUZkgutgpzGJMofi8YxtdyI2nkTitHdEaDz CpU23q+6UJId4EolT9PY67g3OgM9quh3xQf8iu8dTJo8y8bsUNSApGpx4xOAcrl835zj yggUQY77oH3m7Zilxvb3U3DmkMsbwQLHDwR4nleQ2vlaa/5EsBDIIfpy3vu8cWfef2JT WqZDK1LWtAmY6yRSRdtxEjBijLzj+lIddzG84ZqkAdIw9QVaS06qkYXoDr7r10NCl5ac nD5coRIF4Ch/0ci5vTeNLzMkOhJaOd7yqvmAxugHUY76Y0zWAqU2SzZMyB3peerP0Vk2 THSw== X-Gm-Message-State: AElRT7HnjOMdLCEDPidpmupEhZQ9b1OWa/4jE/ijVC4WD6SJxYV9Kq31 0Z5ktc7/Ogl3dvVIi2ZPrlVh X-Google-Smtp-Source: AG47ELtFspd1ZkGCOjcokjs7NnAfO1h+CemdmxlRru1PtAPdw2M+IkheITXW8ZoO+aZcxVhsxxEPLg== X-Received: by 10.223.167.153 with SMTP id j25mr531967wrc.118.1520945522347; Tue, 13 Mar 2018 05:52:02 -0700 (PDT) Received: from laranjeiro-vm.dev.6wind.com (host.78.145.23.62.rev.coltfrance.com. [62.23.145.78]) by smtp.gmail.com with ESMTPSA id f8sm202350wmc.1.2018.03.13.05.52.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 13 Mar 2018 05:52:01 -0700 (PDT) From: Nelio Laranjeiro To: Adrien Mazarguil , Yongseok Koh Cc: dev@dpdk.org Date: Tue, 13 Mar 2018 13:50:39 +0100 Message-Id: <4f7edc1bf7163c274f6ea60d2f813b4963f1a968.1520944256.git.nelio.laranjeiro@6wind.com> X-Mailer: git-send-email 2.11.0 In-Reply-To: References: In-Reply-To: References: Subject: [dpdk-dev] [PATCH 5/5] net/mlx5: add a parameter for Netlink support in VF X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" All Netlink request the PMD will do can also be done by a iproute2 command line interface, letting the operator configure the VF behavior without having to modify the application nor reaching PMD limits (e.g. MAC address number limit). Signed-off-by: Nelio Laranjeiro --- doc/guides/nics/mlx5.rst | 13 ++++++++++++ drivers/net/mlx5/mlx5.c | 7 ++++++ drivers/net/mlx5/mlx5.h | 1 + drivers/net/mlx5/mlx5_vf.c | 53 ++++++++++++++++++++++++++++++++++++++++++++-- 4 files changed, 72 insertions(+), 2 deletions(-) diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index 46d26e4c8..54e6f327b 100644 --- a/doc/guides/nics/mlx5.rst +++ b/doc/guides/nics/mlx5.rst @@ -135,6 +135,11 @@ Limitations - Flows with a VXLAN Network Identifier equal (or ends to be equal) to 0 are not supported. - VXLAN TSO and checksum offloads are not supported on VM. +- VF: Flow rules matching a specific MAC address are only triggers if the MAC + has been previously added by the application. + Adding more than MLX5_MAX_MAC_ADDRESSES MAC addresses is not supported in VF + mode. **Note** needs a Linux kernel v4.16 or higher or Mellanox OFED + installed. Statistics ---------- @@ -335,6 +340,14 @@ Run-time configuration Enabled by default. +- ``vf_nl_en`` parameter [int] + + A nonzero value enables Netlink requests from the VF to add/remove MAC + addresses or/and enable/disable promiscuous/allmulticast on the Netdevice. + Otherwise the according configuration must be run with Linux iproute2 tools. + + Enabled by default on VF. + Prerequisites ------------- diff --git a/drivers/net/mlx5/mlx5.c b/drivers/net/mlx5/mlx5.c index e966884bd..d1ca0837c 100644 --- a/drivers/net/mlx5/mlx5.c +++ b/drivers/net/mlx5/mlx5.c @@ -68,6 +68,9 @@ /* Device parameter to enable hardware Rx vector. */ #define MLX5_RX_VEC_EN "rx_vec_en" +/* Activate Netlink support in VF mode. */ +#define MLX5_VF_NL_EN "vf_nl_en" + #ifndef HAVE_IBV_MLX5_MOD_MPW #define MLX5DV_CONTEXT_FLAGS_MPW_ALLOWED (1 << 2) #define MLX5DV_CONTEXT_FLAGS_ENHANCED_MPW (1 << 3) @@ -414,6 +417,8 @@ mlx5_args_check(const char *key, const char *val, void *opaque) config->tx_vec_en = !!tmp; } else if (strcmp(MLX5_RX_VEC_EN, key) == 0) { config->rx_vec_en = !!tmp; + } else if (strcmp(MLX5_VF_NL_EN, key) == 0) { + config->vf_nl_en = !!tmp; } else { DRV_LOG(WARNING, "%s: unknown parameter", key); rte_errno = EINVAL; @@ -445,6 +450,7 @@ mlx5_args(struct mlx5_dev_config *config, struct rte_devargs *devargs) MLX5_TXQ_MAX_INLINE_LEN, MLX5_TX_VEC_EN, MLX5_RX_VEC_EN, + MLX5_VF_NL_EN, NULL, }; struct rte_kvargs *kvlist; @@ -750,6 +756,7 @@ mlx5_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, .txq_inline = MLX5_ARG_UNSET, .txqs_inline = MLX5_ARG_UNSET, .inline_max_packet_sz = MLX5_ARG_UNSET, + .vf_nl_en = 1, }; len = snprintf(name, sizeof(name), PCI_PRI_FMT, diff --git a/drivers/net/mlx5/mlx5.h b/drivers/net/mlx5/mlx5.h index 245235641..8c3e925af 100644 --- a/drivers/net/mlx5/mlx5.h +++ b/drivers/net/mlx5/mlx5.h @@ -88,6 +88,7 @@ struct mlx5_dev_config { unsigned int tx_vec_en:1; /* Tx vector is enabled. */ unsigned int rx_vec_en:1; /* Rx vector is enabled. */ unsigned int mpw_hdr_dseg:1; /* Enable DSEGs in the title WQEBB. */ + unsigned int vf_nl_en:1; /* Enable Netlink request in VF mode. */ unsigned int tso_max_payload_sz; /* Maximum TCP payload for TSO. */ unsigned int ind_table_max_size; /* Maximum indirection table size. */ int txq_inline; /* Maximum packet size for inlining. */ diff --git a/drivers/net/mlx5/mlx5_vf.c b/drivers/net/mlx5/mlx5_vf.c index cf71e79d9..18b02365d 100644 --- a/drivers/net/mlx5/mlx5_vf.c +++ b/drivers/net/mlx5/mlx5_vf.c @@ -361,7 +361,16 @@ mlx5_vf_mac_addr_add(struct rte_eth_dev *dev, struct ether_addr *mac) int i; int mac_index = MLX5_MAX_MAC_ADDRESSES; int ret; + struct priv *priv = dev->data->dev_private; + if (!priv->config.vf_nl_en) { + DRV_LOG(WARNING, + "port %u Netlink requests are disabled, add the MAC" + " though bridge command: bridge fdb add dev" + " ", + dev->data->port_id); + return 0; + } ret = mlx5_vf_mac_addr_list(dev, &macs, &macs_n); if (ret) return ret; @@ -399,7 +408,16 @@ mlx5_vf_mac_addr_remove(struct rte_eth_dev *dev, struct ether_addr *mac) int i; int mac_index = MLX5_MAX_MAC_ADDRESSES; int ret; + struct priv *priv = dev->data->dev_private; + if (!priv->config.vf_nl_en) { + DRV_LOG(WARNING, + "port %u Netlink requests are disabled, delete the MAC" + " though bridge command: bridge fdb del dev" + " ", + dev->data->port_id); + return 0; + } ret = mlx5_vf_mac_addr_list(dev, &macs, &macs_n); if (ret) return ret; @@ -432,7 +450,16 @@ mlx5_vf_mac_addr_flush(struct rte_eth_dev *dev) { int i; const struct ether_addr mac_null = { .addr_bytes = { 0 }, }; + struct priv *priv = dev->data->dev_private; + if (!priv->config.vf_nl_en) { + DRV_LOG(WARNING, + "port %u Netlink requests are disabled, flush added" + " MAC though bridge command: bridge fdb del dev" + " ", + dev->data->port_id); + return 0; + } /* Skip the default mac at index 0. */ for (i = 1; i != MLX5_MAX_MAC_ADDRESSES; ++i) { struct ether_addr *m = &dev->data->mac_addrs[i]; @@ -516,8 +543,19 @@ mlx5_vf_device_flags(struct rte_eth_dev *dev, uint32_t flags, int enable) int mlx5_vf_promisc(struct rte_eth_dev *dev, int enable) { - int ret = mlx5_vf_device_flags(dev, IFF_PROMISC, enable); + int ret; + struct priv *priv = dev->data->dev_private; + if (!priv->config.vf_nl_en) { + DRV_LOG(WARNING, + "port %u Netlink requests are disabled, %s promisc" + " though ip link command: ip link set promisc" + " %s", + dev->data->port_id, enable ? "enable" : "disable", + enable ? "on" : "off"); + return 0; + } + ret = mlx5_vf_device_flags(dev, IFF_PROMISC, enable); if (ret) DRV_LOG(DEBUG, "port %u cannot %s promisc mode: Netlink error %s", @@ -540,8 +578,19 @@ mlx5_vf_promisc(struct rte_eth_dev *dev, int enable) int mlx5_vf_allmulti(struct rte_eth_dev *dev, int enable) { - int ret = mlx5_vf_device_flags(dev, IFF_ALLMULTI, enable); + int ret; + struct priv *priv = dev->data->dev_private; + if (!priv->config.vf_nl_en) { + DRV_LOG(WARNING, + "port %u Netlink requests are disabled, %s allmulti" + " though ip link command: ip link set " + " allmulticast %s", + dev->data->port_id, enable ? "enable" : "disable", + enable ? "on" : "off"); + return 0; + } + ret = mlx5_vf_device_flags(dev, IFF_ALLMULTI, enable); if (ret) DRV_LOG(DEBUG, "port %u cannot %s allmulti mode: Netlink error %s",