From patchwork Sat Sep 27 18:35:01 2014 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Wiles, Roger Keith" X-Patchwork-Id: 611 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id 071D7683E; Sat, 27 Sep 2014 20:28:40 +0200 (CEST) Received: from mail1.windriver.com (mail1.windriver.com [147.11.146.13]) by dpdk.org (Postfix) with ESMTP id 165AC678C for ; Sat, 27 Sep 2014 20:28:38 +0200 (CEST) Received: from ALA-HCB.corp.ad.wrs.com (ala-hcb.corp.ad.wrs.com [147.11.189.41]) by mail1.windriver.com (8.14.9/8.14.5) with ESMTP id s8RIZ5XO017987 (version=TLSv1/SSLv3 cipher=AES128-SHA bits=128 verify=FAIL) for ; Sat, 27 Sep 2014 11:35:05 -0700 (PDT) Received: from ALA-MBB.corp.ad.wrs.com ([169.254.1.18]) by ALA-HCB.corp.ad.wrs.com ([147.11.189.41]) with mapi id 14.03.0174.001; Sat, 27 Sep 2014 11:35:02 -0700 From: "Wiles, Roger Keith" To: "" Thread-Topic: [PATCH] rte_mempool_dump() crashes with NULL rte_mempool pointer. Thread-Index: AQHP2oG/7+zUgDJSJ0eBA/ewM6tenA== Date: Sat, 27 Sep 2014 18:35:01 +0000 Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.25.40.166] Content-ID: <9F346B39A9E4C44F8625649EA55EE177@local> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH] rte_mempool_dump() crashes with NULL rte_mempool pointer. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Check the FILE *f and rte_mempool *mp pointers for NULL and return plus print out a message if RTE_LIBRTE_MEMPOOL_DEBUG is enabled. Signed-off-by: Keith Wiles --- lib/librte_mempool/rte_mempool.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/lib/librte_mempool/rte_mempool.c b/lib/librte_mempool/rte_mempool.c index 332f469..efa6a6c 100644 --- a/lib/librte_mempool/rte_mempool.c +++ b/lib/librte_mempool/rte_mempool.c @@ -765,6 +765,12 @@ rte_mempool_dump(FILE *f, const struct rte_mempool *mp) unsigned common_count; unsigned cache_count; + if ( (f == NULL) || (mp == NULL) ) { +#ifdef RTE_LIBRTE_MEMPOOL_DEBUG + fprintf(stderr, "*** Called rte_mempool_dump(%p, %p) with NULL argument\n", f, mp); +#endif /* RTE_LIBRTE_MEMPOOL_DEBUG */ + return; + } fprintf(f, "mempool <%s>@%p\n", mp->name, mp); fprintf(f, " flags=%x\n", mp->flags); fprintf(f, " ring=<%s>@%p\n", mp->ring->name, mp->ring);