Coverity issue: Failure to enqueue packets for cryptodev-scheduler_multicore can lead to program crashes Bugzilla ID: 1537 Fixes: replace `pending_deq_ops` with `pending_enq_ops` Cc: stable@dpdk.org
| Message ID | tencent_78F34ED4B605837C021A9D92D6DC6A16CC05@qq.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Delegated to: | akhil goyal |
| Headers | |
| Series | Coverity issue: Failure to enqueue packets for cryptodev-scheduler_multicore can lead to program crashes Bugzilla ID: 1537 Fixes: replace `pending_deq_ops` with `pending_enq_ops` Cc: stable@dpdk.org | |
Checks
| Context | Check | Description |
|---|---|---|
| ci/checkpatch | warning | coding style issues |
| ci/loongarch-compilation | success | Compilation OK |
| ci/loongarch-unit-testing | success | Unit Testing PASS |
| ci/Intel-compilation | success | Compilation OK |
| ci/intel-Testing | success | Testing PASS |
| ci/github-robot: build | success | github build: passed |
| ci/intel-Functional | success | Functional PASS |
| ci/iol-unit-amd64-testing | success | Testing PASS |
| ci/iol-compile-amd64-testing | success | Testing PASS |
| ci/iol-compile-arm64-testing | success | Testing PASS |
| ci/iol-unit-arm64-testing | success | Testing PASS |
| ci/iol-broadcom-Performance | success | Performance Testing PASS |
| ci/iol-broadcom-Functional | success | Functional Testing PASS |
| ci/iol-sample-apps-testing | success | Testing PASS |
| ci/iol-marvell-Functional | success | Functional Testing PASS |
| ci/iol-intel-Functional | success | Functional Testing PASS |
Commit Message
diff --git a/drivers/crypto/scheduler/scheduler_multicore.c b/drivers/crypto/scheduler/scheduler_multicore.c index a21b522f9f..70f8a25b70 100644 --- a/drivers/crypto/scheduler/scheduler_multicore.c +++ b/drivers/crypto/scheduler/scheduler_multicore.c @@ -191,11 +191,11 @@ mc_scheduler_worker(struct rte_cryptodev *dev) worker->qp_id, &enq_ops[pending_enq_ops_idx], pending_enq_ops); - if (processed_ops < pending_deq_ops) + if (processed_ops < pending_enq_ops) scheduler_retrieve_sessions( &enq_ops[pending_enq_ops_idx + processed_ops], - pending_deq_ops - processed_ops); + pending_enq_ops - processed_ops); pending_enq_ops -= processed_ops; pending_enq_ops_idx += processed_ops; inflight_ops += processed_ops;