From patchwork Fri Jan 22 17:05:28 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Owen Hilyard X-Patchwork-Id: 87100 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 33E4FA0A0A; Fri, 22 Jan 2021 18:05:34 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 29B43141035; Fri, 22 Jan 2021 18:05:34 +0100 (CET) Received: from mail-ua1-f100.google.com (mail-ua1-f100.google.com [209.85.222.100]) by mails.dpdk.org (Postfix) with ESMTP id B9D7614102D for ; Fri, 22 Jan 2021 18:05:32 +0100 (CET) Received: by mail-ua1-f100.google.com with SMTP id u27so2025094uaa.13 for ; Fri, 22 Jan 2021 09:05:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iol.unh.edu; s=unh-iol; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Yj5I2VyHrjbohHt1fb9O+RrgjOD3Z390ARCt7kz1+lU=; b=XB1AINLoSXZqM0oU2mWTGLcTWoNYFI50/WEWldZKa4ujTNf3oj/uOo70+c5JCuG5DF JaT8kpkxaIq3xlvFFX25khXcpAQ/Uy7+hS2XSXSkHDfWBAKuwDqyaOjPwuSuUjarnkLc BXdxeDhuzgs8ALc5QPJyUu1NTTqEvXlKruIig= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Yj5I2VyHrjbohHt1fb9O+RrgjOD3Z390ARCt7kz1+lU=; b=lbp8zMA8xR5xnEBMHetKZ8iBKZQFJE9InDTIt39IIi6zLT4uk8CbOk5CoHSPJl/9Pu id+3w1Su7OyBhRHbC0RyjRvU3XxdCTF3bOJtVXuzIqgG6owP+VvHwpRe4WD/dNSlA015 sDsojVPiw5tqcfLdz59tzxFKgTA83cYkUKPwFuRK4/L0HuAkfmJEa0f1RJDwENjonyjn d2nRLKafGlUZZFArV4CTLbj0Uh0niavhzX92A3dL4xi+3juI8l99YpP0gI+3RmJP+nUU fVp1ECcs9/n2d0VBKgwGrwIzQMyqiaEq80FNSkEOLikvCP16LdjrEQeBGXDVJoxXiR2s HSuw== X-Gm-Message-State: AOAM53369DSvcGlKPc+jxGhl3VFmuhgkq9fM2JBtlcKzSR5N/JAaoZyj MfxHl2q85KjK3hiiPzt3xmIfc1AnG3l9+yLpy8641p7jR2pAgyWgv9KcCJ95roXVMbLi5sbLKzE IVTsKtEe/28S9u67YuzbLZOOYQkyPo5IHs2rjF6WQpuZyTgknVJnnkTDSwle5EGwsCMveqAXl63 iU8747CPU5Hekw+w== X-Google-Smtp-Source: ABdhPJwN71MZO5fSLbXwK9aDh8Ryl10LWl4HWElbrDBebzF+eKa8Phy/wB1PSMSr/f2HT6sDo27mkB2BB5dH X-Received: by 2002:a9f:2286:: with SMTP id 6mr160220uan.66.1611335132021; Fri, 22 Jan 2021 09:05:32 -0800 (PST) Received: from postal.iol.unh.edu (postal.iol.unh.edu. [2606:4100:3880:1234::84]) by smtp-relay.gmail.com with ESMTPS id w129sm1785370vkh.5.2021.01.22.09.05.31 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Jan 2021 09:05:32 -0800 (PST) X-Relaying-Domain: iol.unh.edu Received: from iol.unh.edu (unknown [IPv6:2606:4100:3880:1254::1033]) by postal.iol.unh.edu (Postfix) with ESMTP id 61BB46052472; Fri, 22 Jan 2021 12:05:31 -0500 (EST) From: ohilyard@iol.unh.edu To: dts@dpdk.org Cc: lijuan.tu@intel.com, Owen Hilyard Date: Fri, 22 Jan 2021 12:05:28 -0500 Message-Id: <20210122170529.672048-1-ohilyard@iol.unh.edu> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Subject: [dts] [PATCH] meson compile: Improve compile times X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Sender: "dts" From: Owen Hilyard Increased compile timeout Removed workers parameter from ninja compilation command After a review of CI metrics, we noticed that dts runtimes had increased greatly over the last few months. A review of recent logs showed timeouts for compiling dpdk. Upon review, we discovered that, if the "dut_cores" parameter is not set in conf/crbs.cfg, then dts uses the default value, which is a single core, as the core list. The number of cores in this list was then used the number of workers for ninja. This causes DTS to attempt to compile DPDK serially, resulting in greatly increased compile times. The IOL's development machine saw a 30x compile speed increase from the included changes. Signed-off-by: Owen Hilyard --- framework/project_dpdk.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/framework/project_dpdk.py b/framework/project_dpdk.py index 915c648f..af542a91 100644 --- a/framework/project_dpdk.py +++ b/framework/project_dpdk.py @@ -281,7 +281,7 @@ class DPDKdut(Dut): """ Build DPDK source code on linux use meson """ - build_time = 900 + build_time = 1200 target_info = target.split('-') arch = target_info[0] machine = target_info[1] @@ -315,7 +315,7 @@ class DPDKdut(Dut): toolchain, extra_options, options_config, default_library, target), "# ", build_time) assert ("FAILED" not in out), "meson setup failed ..." - out = self.send_expect("ninja -C %s -j %d" % (target, self.number_of_cores), "# ", build_time) + out = self.send_expect("ninja -C %s" % target, "# ", build_time) assert ("FAILED" not in out), "ninja complie failed ...\r\n %s" % out # copy kmod file to the folder same as make