diff mbox series

framework: Advise against using root passwords

Message ID 20211117162330.25896-1-ohilyard@iol.unh.edu (mailing list archive)
State Superseded
Headers show
Series framework: Advise against using root passwords | expand

Checks

Context Check Description
ci/Intel-dts-suite-test fail Testing issues

Commit Message

Owen Hilyard Nov. 17, 2021, 4:23 p.m. UTC
From: Owen Hilyard <ohilyard@iol.unh.edu>

Added messages to notify the user that a blank password field will use
ssh keys, and that using root passwords is insecure.
---
 conf/crbs.cfg  | 4 ++--
 tools/setup.py | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
diff mbox series

Patch

diff --git a/conf/crbs.cfg b/conf/crbs.cfg
index b6c0a9af..a12e60a4 100644
--- a/conf/crbs.cfg
+++ b/conf/crbs.cfg
@@ -2,10 +2,10 @@ 
 #[DUT IP]
 #  dut_ip: DUT ip address
 #  dut_user: Login DUT username
-#  dut_passwd: Login DUT password
+#  dut_passwd: [INSECURE] Login DUT password, leaving this blank will force using SSH keys
 #  os: operation system type linux or freebsd
 #  tester_ip: Tester ip address
-#  tester_passwd: Tester password
+#  tester_passwd: [INSECURE] Tester password, leaving this blank will force using SSH keys
 #  pktgen_group: packet generator group name: ixia/trex/ixia_network
 #  channels: Board channel number
 #  bypass_core0: Whether by pass core0
diff --git a/tools/setup.py b/tools/setup.py
index 3873a884..c70730c7 100755
--- a/tools/setup.py
+++ b/tools/setup.py
@@ -105,7 +105,7 @@  def config_crbs():
 
     passwd_option = {'prompt': 'DUT root password',
                      'type': 'string',
-                     'help': 'Please input password of DUT crb',
+                     'help': '[INSECURE] Please input password of DUT crb (leave blank to use preconfigured SSH keys)',
                      'default': ''}
     opt = Option(**passwd_option)
     dut_pass = opt.parse_input()
@@ -120,7 +120,7 @@  def config_crbs():
 
     passwd_option = {'prompt': 'Tester root password',
                      'type': 'string',
-                     'help': 'Please input password of Tester crb',
+                     'help': '[INSECURE] Please input password of Tester crb (leave blank to use preconfigured SSH keys)',
                      'default': ''}
     opt = Option(**passwd_option)
     tester_pass = opt.parse_input()