diff mbox series

[v2] framework: Advise against using root passwords

Message ID 20211117170107.30162-1-ohilyard@iol.unh.edu (mailing list archive)
State Accepted
Headers show
Series [v2] framework: Advise against using root passwords | expand

Checks

Context Check Description
ci/Intel-dts-suite-test fail Testing issues

Commit Message

Owen Hilyard Nov. 17, 2021, 5:01 p.m. UTC 
From: Owen Hilyard <ohilyard@iol.unh.edu>

Added messages to notify the user that a blank password field will use
ssh keys, and that using root passwords is insecure.

Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
---
 conf/crbs.cfg  | 4 ++--
 tools/setup.py | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)

Comments

Juraj Linkeš Nov. 18, 2021, 10:16 a.m. UTC | #1 
> Subject: [PATCH v2] framework: Advise against using root passwords
> 
> From: Owen Hilyard <ohilyard@iol.unh.edu>
> 
> Added messages to notify the user that a blank password field will use ssh keys,
> and that using root passwords is insecure.
> 
> Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>

Acked-by: Juraj Linkeš <juraj.linkes@pantheon.tech>
Tu, Lijuan Nov. 23, 2021, 2:28 p.m. UTC | #2 
> -----Original Message-----
> From: Juraj Linkeš <juraj.linkes@pantheon.tech>
> Sent: 2021年11月18日 18:17
> To: ohilyard@iol.unh.edu; dts@dpdk.org
> Cc: Tu, Lijuan <lijuan.tu@intel.com>
> Subject: RE: [PATCH v2] framework: Advise against using root passwords
> 
> > Subject: [PATCH v2] framework: Advise against using root passwords
> >
> > From: Owen Hilyard <ohilyard@iol.unh.edu>
> >
> > Added messages to notify the user that a blank password field will use
> > ssh keys, and that using root passwords is insecure.
> >
> > Signed-off-by: Owen Hilyard <ohilyard@iol.unh.edu>
> 
> Acked-by: Juraj Linkeš <juraj.linkes@pantheon.tech>

Applied, thanks
diff mbox series

Patch

diff --git a/conf/crbs.cfg b/conf/crbs.cfg
index b6c0a9af..a12e60a4 100644
--- a/conf/crbs.cfg
+++ b/conf/crbs.cfg
@@ -2,10 +2,10 @@ 
 #[DUT IP]
 #  dut_ip: DUT ip address
 #  dut_user: Login DUT username
-#  dut_passwd: Login DUT password
+#  dut_passwd: [INSECURE] Login DUT password, leaving this blank will force using SSH keys
 #  os: operation system type linux or freebsd
 #  tester_ip: Tester ip address
-#  tester_passwd: Tester password
+#  tester_passwd: [INSECURE] Tester password, leaving this blank will force using SSH keys
 #  pktgen_group: packet generator group name: ixia/trex/ixia_network
 #  channels: Board channel number
 #  bypass_core0: Whether by pass core0
diff --git a/tools/setup.py b/tools/setup.py
index 3873a884..c70730c7 100755
--- a/tools/setup.py
+++ b/tools/setup.py
@@ -105,7 +105,7 @@  def config_crbs():
 
     passwd_option = {'prompt': 'DUT root password',
                      'type': 'string',
-                     'help': 'Please input password of DUT crb',
+                     'help': '[INSECURE] Please input password of DUT crb (leave blank to use preconfigured SSH keys)',
                      'default': ''}
     opt = Option(**passwd_option)
     dut_pass = opt.parse_input()
@@ -120,7 +120,7 @@  def config_crbs():
 
     passwd_option = {'prompt': 'Tester root password',
                      'type': 'string',
-                     'help': 'Please input password of Tester crb',
+                     'help': '[INSECURE] Please input password of Tester crb (leave blank to use preconfigured SSH keys)',
                      'default': ''}
     opt = Option(**passwd_option)
     tester_pass = opt.parse_input()