tests/TestSuite_crypto_perf_cryptodev_perf: fix output parsing

Message ID 20240916092515.1851927-1-david.marchand@redhat.com (mailing list archive)
State Accepted
Delegated to: David Marchand
Headers
Series tests/TestSuite_crypto_perf_cryptodev_perf: fix output parsing |

Commit Message

David Marchand Sept. 16, 2024, 9:25 a.m. UTC
The parsing of the test results was considering too many lines.

It was not an issue as the extra inspected line was an empty line.
Following fixes on the qat driver logs, this triggers a parsing error.

Fixes: a3c915c1a3b9 ("tests/crypto_perf_cryptodev_perf: optimize parse output")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 tests/TestSuite_crypto_perf_cryptodev_perf.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Patrick Robb Sept. 17, 2024, 9:19 p.m. UTC | #1
Reviewed-by: Patrick Robb <probb@iol.unh.edu>
Tested-by: Patrick Robb <probb@iol.unh.edu>

Did a non-regression test against origin/main, and tested with
https://patchwork.dpdk.org/project/dpdk/list/?series=33005, which is
the series which prompted this DTS patch.
  
David Marchand Sept. 18, 2024, 7:17 a.m. UTC | #2
On Mon, Sep 16, 2024 at 11:25 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> The parsing of the test results was considering too many lines.
>
> It was not an issue as the extra inspected line was an empty line.
> Following fixes on the qat driver logs, this triggers a parsing error.
>
> Fixes: a3c915c1a3b9 ("tests/crypto_perf_cryptodev_perf: optimize parse output")
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Reviewed-by: Patrick Robb <probb@iol.unh.edu>
Tested-by: Patrick Robb <probb@iol.unh.edu>

Applied, thanks.
  

Patch

diff --git a/tests/TestSuite_crypto_perf_cryptodev_perf.py b/tests/TestSuite_crypto_perf_cryptodev_perf.py
index 0531b9c6..633dd637 100644
--- a/tests/TestSuite_crypto_perf_cryptodev_perf.py
+++ b/tests/TestSuite_crypto_perf_cryptodev_perf.py
@@ -252,7 +252,7 @@  class TestCryptoPerfCryptodevPerf(TestCase):
                 if lines[line_index].startswith("    lcore id"):
                     self.logger.debug("data output line from: " + str(line_index))
                     break
-            data_line = line_index - 2
+            data_line = line_index - 1
 
             results = []
             pattern = re.compile(r"\s+")