From patchwork Wed Apr 28 09:18:19 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Slava Ovsiienko X-Patchwork-Id: 92319 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 37181A0A0E; Wed, 28 Apr 2021 11:18:44 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EB3954014E; Wed, 28 Apr 2021 11:18:43 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2056.outbound.protection.outlook.com [40.107.223.56]) by mails.dpdk.org (Postfix) with ESMTP id 1443E40147; Wed, 28 Apr 2021 11:18:42 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kE2g6zUDHVyfVT0zKWuBBmWHREciGdflFnrMKkGCunI93GiIBtb6M56an/HiRol4P9dl9AsltfGeOEOB4LDppFEIr53XmRCz93QciSSt/Rpem1lrPehdv0HpW4w//3ygkJsz9lQH6aYyhTskft64FNk1vEbDk/VLvhxo1H8Ou5zKO/hpDEfonMvyBhtXpwlz0KGHTQZctq5x0of4hPEPUpYVNLLOyhE4Sk2bY+WomNwyh61PL9kKB1eY2lCIkWWks3EW1Dpu/yuuQHUi0Da5/DvaeLmFO80svxM4bkWVdqawwe7KC3A37RU5a6B8ZhjphQqPJgXkOvyZ+lB8XwwFMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RQHA0N7NUPFESNmjD4jH7fCC9rxIdeLRgSccso3cazw=; b=YvckWaq8cotfjQuNzFervkELfm5TuaeXt0ph6jg4x4LtCOtrC44+dG3MLjFCUImqv/AHDiPF/Fac8XvZCalX8SdUIU56FN0i4+5caktVDFnuOhrWiEu4kyOoLwXjSaPeQyOR7GMkS8js/t2If6dOFdXlDE4EKQ3fr/HyHm/RzvjtnJZJmCO5z5ZlYl2/9LwMb/C+9DTVqgkdhd/2IDUp9U5NreVXBOn6VvS4Lu6y/rH/GsjnyiDY6ALPVpFxgRELlug++OYP3lziOuoLNKQNybQyfDv6akIqOXRD/mq9iD+uW/eFS+eVjJk8QuPYTWOs8w6/fstC67lWxoS0JeyKNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.112.34) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RQHA0N7NUPFESNmjD4jH7fCC9rxIdeLRgSccso3cazw=; b=VA0ucNNyHoJWY03GmRQGYy7ZxGJwspolWXLXCpxybnn0XaewLtlbXe1dgdlcHCd7cW9SL9SQvLgHekEh33tC7hVndfuNe3Y3tc2FS3zxVuM+gUfR1XX3vQHVtVTlwWGEujgz/WPOeilqPqRVinMIDZgMH/5HbzFnIkeQheLhnqErElGsFbASo/x/ZDc1pys7KEkHHqFGikhakkUCPFH1U03XpIvznR9IggAR8XbrzxoBdol9W8WPng95X5t7axZ3inoGFPMEtaRnjTYntxrKi0kY26xm1HVNqOlbCtDkcT4cOw9TBq+q8yf5FJDVbdLQZ32vwMst9/ex6LF/F7xn0g== Received: from BN6PR20CA0061.namprd20.prod.outlook.com (2603:10b6:404:151::23) by DM6PR12MB2778.namprd12.prod.outlook.com (2603:10b6:5:50::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.24; Wed, 28 Apr 2021 09:18:40 +0000 Received: from BN8NAM11FT024.eop-nam11.prod.protection.outlook.com (2603:10b6:404:151:cafe::44) by BN6PR20CA0061.outlook.office365.com (2603:10b6:404:151::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4087.25 via Frontend Transport; Wed, 28 Apr 2021 09:18:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.112.34) smtp.mailfrom=nvidia.com; dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.112.34 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.112.34; helo=mail.nvidia.com; Received: from mail.nvidia.com (216.228.112.34) by BN8NAM11FT024.mail.protection.outlook.com (10.13.177.38) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.4065.21 via Frontend Transport; Wed, 28 Apr 2021 09:18:40 +0000 Received: from nvidia.com (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 28 Apr 2021 09:18:38 +0000 From: Viacheslav Ovsiienko To: CC: , , Date: Wed, 28 Apr 2021 12:18:19 +0300 Message-ID: <20210428091819.13306-1-viacheslavo@nvidia.com> X-Mailer: git-send-email 2.18.1 MIME-Version: 1.0 X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 31c94a5c-d4be-455d-9b67-08d90a269ce8 X-MS-TrafficTypeDiagnostic: DM6PR12MB2778: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:5236; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: kTXP3ou4kBsJS1cxiHT0bABwbj7SJNymoUxP/nD3Iu49g+/enJUEjnEnjuSAkyKtYNJvAhJ740eM1NcDm0EXTtlM0PAUfJpisoPJfQBcvaivBSKLzh4XbZkSgduP7w4rLUoLnORbFKYfSroogijN5fRHPz7duVPULa62oHUGM5EvJa+VMM2lC/jLJ5V3Vb7TALADgtFmt+VE6XM6ov+LxwIAtl2z5HieU1W6Rp/q4iIIKYf7UFpLGFwrbrmlom65uhc4L+T1V7sXVSzmyGqXdJE3Iq/gMsCPZ0J5m7izTnxephdXft4R9rQpwPlH+FiMRWZdjqoUuVIue4jd+T1YcZtWiwLFOuqv8fxeJQQK4k2FHJh1GOEaMXzVQsAQ0Mp/2GeX2Rpl23RNyEXkWyGzGtNk7YSuBfx+x0h22uQjYX4qGyX9vn7i0chfgcsWOyNX0zVDAGdCZeLsBWNLOtTWIDr1kU59+jQ4rn53qCysnIXNRanR3gT8Y2AbP65W2te1YEq6qhONWDxgJSwBSwmDhQIIR/Y3hXoH7495cs1EXAW+48pOCGZxZ4RME6H29h2JLJJMarEPP0KVxDtn0swSWVB404Q8G+pcGkimrBLfQwSRM3/lE4jsYyRGte+Sk1tuZJDaA1Q8dzvd9gotbCfc0mUjwdAKa7itgnsHsb1wVZs= X-Forefront-Antispam-Report: CIP:216.228.112.34; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:schybrid03.nvidia.com; CAT:NONE; SFS:(4636009)(376002)(346002)(39860400002)(396003)(136003)(36840700001)(46966006)(1076003)(4326008)(36906005)(6286002)(6666004)(82310400003)(54906003)(86362001)(426003)(47076005)(7636003)(36756003)(5660300002)(6916009)(8936002)(83380400001)(336012)(450100002)(478600001)(36860700001)(2616005)(186003)(356005)(8676002)(2906002)(70206006)(70586007)(26005)(55016002)(82740400003)(16526019)(316002)(7696005); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2021 09:18:40.5291 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 31c94a5c-d4be-455d-9b67-08d90a269ce8 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.112.34]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN8NAM11FT024.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB2778 Subject: [dpdk-dev] [PATCH] net/mlx5: fix Tx queue doorbell record field offset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" If the Send Queue (backing one for PMD Tx queue) the was created with DevX API the doorbell record offset for the producer index field was incorrect. If hardware missed the doorbell register write event the wrong content of doorbell record might cause queue malfunction. For the Send Queues created with Verbs API the doorbell record offset was configured correctly. Fixes: 86d259cec852 ("net/mlx5: separate Tx queue object creations") Cc: stable@dpdk.org Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_devx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_devx.c b/drivers/net/mlx5/mlx5_devx.c index 76d31f5539..531a81d7fa 100644 --- a/drivers/net/mlx5/mlx5_devx.c +++ b/drivers/net/mlx5/mlx5_devx.c @@ -1113,7 +1113,7 @@ mlx5_txq_devx_obj_new(struct rte_eth_dev *dev, uint16_t idx) txq_data->wqe_pi = 0; txq_data->wqe_comp = 0; txq_data->wqe_thres = txq_data->wqe_s / MLX5_TX_COMP_THRESH_INLINE_DIV; - txq_data->qp_db = txq_obj->sq_obj.db_rec; + txq_data->qp_db = &txq_obj->sq_obj.db_rec[MLX5_SND_DBR]; *txq_data->qp_db = 0; txq_data->qp_num_8s = txq_obj->sq_obj.sq->id << 8; /* Change Send Queue state to Ready-to-Send. */