From patchwork Tue Mar 29 10:24:07 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tadhg Kearney X-Patchwork-Id: 109006 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7F590A050A; Tue, 29 Mar 2022 12:24:15 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 76E514281C; Tue, 29 Mar 2022 12:24:15 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id B1B3240691 for ; Tue, 29 Mar 2022 12:24:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648549453; x=1680085453; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=L/RtPt4YUf6MJuKKmOvmjzwJu98G5p2M9PuVFMc8c60=; b=fbDgXnx4AAYAb7PLsZmlpj9494ij1jDzBU3kyQ18WLskTLJ4WSA9O9Hq RcoIi68Rq4OFH0ENPx9iIwULGAVl4KWIXZSjNOjDJgokKYiZ+eKXNCcv/ m+W8hFHxRytzjdCMQQI5jsBy8ae1Nf1uMfOik71evIJWvtdkT7fQ1hPbX KaMN2N+OFKX+/iaN5peizpaKrKmg+X//uNmo3XiMpC00iHiO76MVyb0XP TooPwyagvjiwV2jo82XpXxALreTupPbAtxiCBy1YxyXDWuxxERdSt6rq6 fOOgnRp0c4j5iI0AZ+K0qjP/fX/eIeQ8rTmwdfdNmgLD4mn8rYHawOc6v w==; X-IronPort-AV: E=McAfee;i="6200,9189,10300"; a="239811224" X-IronPort-AV: E=Sophos;i="5.90,220,1643702400"; d="scan'208";a="239811224" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2022 03:24:13 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,220,1643702400"; d="scan'208";a="546332873" Received: from silpixa00401183.ir.intel.com ([10.55.129.105]) by orsmga007.jf.intel.com with ESMTP; 29 Mar 2022 03:24:12 -0700 From: Tadhg Kearney To: dts@dpdk.org Cc: reshma.pattan@intel.com, Tadhg Kearney Subject: [dts][V3 1/2] test_plans/*: Remove old DPDK RTE flags from power tests Date: Tue, 29 Mar 2022 10:24:07 +0000 Message-Id: <20220329102408.1137392-2-tadhg.kearney@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220329102408.1137392-1-tadhg.kearney@intel.com> References: <20220329102408.1137392-1-tadhg.kearney@intel.com> MIME-Version: 1.0 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org Remove refernce to flags that don't exist anymore Signed-off-by: Tadhg Kearney --- test_plans/power_branch_ratio_test_plan.rst | 5 ++--- test_plans/power_telemetry_test_plan.rst | 5 ----- 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/test_plans/power_branch_ratio_test_plan.rst b/test_plans/power_branch_ratio_test_plan.rst index 4bbf95af..ba943693 100644 --- a/test_plans/power_branch_ratio_test_plan.rst +++ b/test_plans/power_branch_ratio_test_plan.rst @@ -47,9 +47,8 @@ Prepare work intel_pstate=enable -5. Set CONFIG_RTE_LIBRTE_POWER_DEBUG=y CONFIG_RTE_LIBRTE_POWER=y in /config/common_base file. -6. modprobe msr module to let the application can get the CPU HW info. -7. Let user space can control the CPU frequency:: +5. modprobe msr module to let the application can get the CPU HW info. +6. Let user space can control the CPU frequency:: cpupower frequency-set -g userspace diff --git a/test_plans/power_telemetry_test_plan.rst b/test_plans/power_telemetry_test_plan.rst index 0afb0f77..8804129c 100644 --- a/test_plans/power_telemetry_test_plan.rst +++ b/test_plans/power_telemetry_test_plan.rst @@ -53,11 +53,6 @@ Preparation Work for Settings cpupower frequency-set -g userspace -Compile DPDK with telemetry enabled, enable telemetry lib in configuration file:: - - -CONFIG_RTE_LIBRTE_TELEMETRY=n - +CONFIG_RTE_LIBRTE_TELEMETRY=y - Test Case 1 : Check all 3 type of power related info reported by Telemetry System ================================================================================= From patchwork Tue Mar 29 10:24:08 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tadhg Kearney X-Patchwork-Id: 109007 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C66DA0509; Tue, 29 Mar 2022 12:24:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9708C42818; Tue, 29 Mar 2022 12:24:16 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by mails.dpdk.org (Postfix) with ESMTP id 72DD24281B for ; Tue, 29 Mar 2022 12:24:15 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1648549455; x=1680085455; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=zj34JRaIylt3X49r6XsIrHhG8xEoyDfAmG2cky8cAbQ=; b=ODHHI2TavFq33bwUwyU0ipnAoAnOBt9Rft3AS/AqJMGdeqK0vtHfhgcO 6cVBiRHd5I2TQP/2pXyp7WVmWvW/C9zew/CMQwRbME3UkaXqVVf45GBU1 atvIU0ddkxAmYmflKT5kjqK+bo+KAASCYQlKpSJxEN+UneIj/5UoKv/Di G2Gy39JDg7MoRxz7d9M4WnxU+pWicAdwNaaSi5izecXn/RPTQwKpH6M01 LWeMYGUAKqd/isyManuBN20I6p9InTv/ISS34Oi+AeGT/RWmXBbTA3/f0 c0TGMut4gHZVD5CgB5Cu2/Vy4QP165FR84EijivS+ZZMuN6kh8/ppVmdh g==; X-IronPort-AV: E=McAfee;i="6200,9189,10300"; a="239811230" X-IronPort-AV: E=Sophos;i="5.90,220,1643702400"; d="scan'208";a="239811230" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2022 03:24:14 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,220,1643702400"; d="scan'208";a="546332889" Received: from silpixa00401183.ir.intel.com ([10.55.129.105]) by orsmga007.jf.intel.com with ESMTP; 29 Mar 2022 03:24:13 -0700 From: Tadhg Kearney To: dts@dpdk.org Cc: reshma.pattan@intel.com, Tadhg Kearney Subject: [dts][V3 2/2] tests/*: Remove old DPDK flags from power tests Date: Tue, 29 Mar 2022 10:24:08 +0000 Message-Id: <20220329102408.1137392-3-tadhg.kearney@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220329102408.1137392-1-tadhg.kearney@intel.com> References: <20220329102408.1137392-1-tadhg.kearney@intel.com> MIME-Version: 1.0 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org * CONFIG_RTE_LIBRTE_I40E_PMD, CONFIG_RTE_LIBRTE_POWER + _CONFIG option do not exist anymore * Telemetry is built by default + _LIBRTE_ option also does not exist anymore Signed-off-by: Tadhg Kearney Acked-by: Jun Dong --- tests/TestSuite_power_branch_ratio.py | 39 +-------------------------- tests/TestSuite_power_telemetry.py | 18 +------------ 2 files changed, 2 insertions(+), 55 deletions(-) diff --git a/tests/TestSuite_power_branch_ratio.py b/tests/TestSuite_power_branch_ratio.py index deb271e0..a2c28478 100644 --- a/tests/TestSuite_power_branch_ratio.py +++ b/tests/TestSuite_power_branch_ratio.py @@ -44,8 +44,7 @@ from pprint import pformat from framework.exception import VerifyFailure from framework.packet import Packet from framework.pktgen import TRANSMIT_CONT -from framework.qemu_libvirt import LibvirtKvm -from framework.settings import HEADER_SIZE, HOST_BUILD_TYPE_SETTING, load_global_setting +from framework.settings import HEADER_SIZE from framework.test_case import TestCase from framework.utils import create_mask as dts_create_mask @@ -227,27 +226,6 @@ class TestPowerBranchRatio(TestCase): return result - @property - def compile_switch(self): - sw_table = [ - "CONFIG_RTE_LIBRTE_POWER", - "CONFIG_RTE_LIBRTE_POWER_DEBUG", - ] - return sw_table - - def preset_compilation(self): - if "meson" == load_global_setting(HOST_BUILD_TYPE_SETTING): - compile_SWs = self.compile_switch + ["CONFIG_RTE_LIBRTE_I40E_PMD"] - self.dut.set_build_options(dict([(sw[7:], "y") for sw in compile_SWs])) - else: - for sw in self.compile_switch: - cmd = ( - "sed -i -e " "'s/{0}=n$/{0}=y/' " "{1}/config/common_base" - ).format(sw, self.target_dir) - self.d_a_con(cmd) - # re-compile dpdk source code - self.dut.build_install_dpdk(self.target) - @contextmanager def restore_environment(self): try: @@ -258,19 +236,6 @@ class TestPowerBranchRatio(TestCase): self.restore_port_drv() except Exception as e: self.logger.error(traceback.format_exc()) - # restore compilation - if "meson" == load_global_setting(HOST_BUILD_TYPE_SETTING): - self.dut.set_build_options( - dict([(sw[7:], "n") for sw in self.compile_switch]) - ) - else: - for sw in self.compile_switch: - cmd = ( - "sed -i -e " "'s/{0}=y$/{0}=n/' " "{1}/config/common_base" - ).format(sw, self.target_dir) - self.d_a_con(cmd) - # re-compile dpdk source code - self.dut.build_install_dpdk(self.target) def restore_port_drv(self): driver = self.drivername @@ -532,8 +497,6 @@ class TestPowerBranchRatio(TestCase): # modprobe msr module to let the application can get the CPU HW info self.d_a_con("modprobe msr") self.d_a_con("cpupower frequency-set -g userspace > /dev/null 2>&1") - # compile - self.preset_compilation() # init binary self.init_vm_power_mgr() self.init_testpmd() diff --git a/tests/TestSuite_power_telemetry.py b/tests/TestSuite_power_telemetry.py index afb55262..39acdef2 100644 --- a/tests/TestSuite_power_telemetry.py +++ b/tests/TestSuite_power_telemetry.py @@ -45,7 +45,7 @@ from pprint import pformat from framework.exception import VerifyFailure from framework.packet import Packet from framework.pktgen import TRANSMIT_CONT -from framework.settings import HEADER_SIZE, HOST_BUILD_TYPE_SETTING, load_global_setting +from framework.settings import HEADER_SIZE from framework.test_case import TestCase from framework.utils import create_mask as dts_create_mask @@ -125,20 +125,6 @@ class TestPowerTelemetry(TestCase): return result - def preset_compilation(self): - if self.dut.skip_setup: - return - SW = "CONFIG_RTE_LIBRTE_TELEMETRY" - if "meson" == load_global_setting(HOST_BUILD_TYPE_SETTING): - self.dut.set_build_options({SW[7:]: "y"}) - else: - cmd = "sed -i -e 's/{0}=n$/{0}=y/' {1}/config/common_base".format( - SW, self.target_dir - ) - self.d_a_con(cmd) - # re-compile dpdk source code - self.dut.build_install_dpdk(self.target) - def prepare_binary(self, name): example_dir = "examples/" + name out = self.dut.build_dpdk_apps("./" + example_dir) @@ -445,8 +431,6 @@ class TestPowerTelemetry(TestCase): def preset_test_environment(self): self.is_l3fwd_on = None - # open compile switch and re-compile target source code - self.preset_compilation() # init binary self.init_l3fwd_power() self.init_telemetry()