From patchwork Thu Apr 7 13:42:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arkadiusz Kusztal X-Patchwork-Id: 109423 X-Patchwork-Delegate: gakhil@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87598A0032; Thu, 7 Apr 2022 15:43:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 76B424068B; Thu, 7 Apr 2022 15:43:04 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 58A9740689 for ; Thu, 7 Apr 2022 15:43:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1649338982; x=1680874982; h=from:to:cc:subject:date:message-id; bh=3WwvGlMd8JbYwFbrBqVh5yfXjUl3Dht6cvB/quIqGmo=; b=FiE9XlKA5WH8tVofH4+DIgjMXCUv/DozhRSg/MMvoOmLClunh+cK0+FH BKiN0WgvcemFUq22HQU1a9qeqZQxWUillyTo5hSvMTjYW2i9UazEbkb0J ZCqChB5xk2hWi5DZ45l1CDNCZArGS5mHBnrutSr68lmYUfwQowZ4f6OXZ hTCVuTL+6IC/T+ntPOTI73ekhJB2QWHGGS0VtzePCeUAKuzqydfWmVhE+ x9+8joprtMdcXwyg6UFkGF74tFzwhbd4NCpKc93rP9q2gIP/pBjQZanF2 NoAcd+0HFXPgrZKzZWymQ93dyTU2TV4BoFxEZ2PTTQwLutkO8rzu60zPN A==; X-IronPort-AV: E=McAfee;i="6400,9594,10309"; a="260159438" X-IronPort-AV: E=Sophos;i="5.90,242,1643702400"; d="scan'208";a="260159438" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2022 06:43:01 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,242,1643702400"; d="scan'208";a="571056027" Received: from silpixa00400308.ir.intel.com ([10.237.214.95]) by orsmga008.jf.intel.com with ESMTP; 07 Apr 2022 06:42:59 -0700 From: Arek Kusztal To: dev@dpdk.org Cc: gakhil@marvell.com, roy.fan.zhang@intel.com, Arek Kusztal Subject: [RFC PATCH] cryptodev: add diffie hellman verify, change ec enum Date: Thu, 7 Apr 2022 14:42:48 +0100 Message-Id: <20220407134248.20178-1-arkadiuszx.kusztal@intel.com> X-Mailer: git-send-email 2.17.1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This commit: 1) adds Diffie-Hellman verify operation. 2) splits asym_op_type with dh op_type 3) removes next pointer from asym_xform 4) changes enumeration of elliptic curves Signed-off-by: Arek Kusztal --- lib/cryptodev/rte_crypto_asym.h | 36 +++++++++++++++++------------------- 1 file changed, 17 insertions(+), 19 deletions(-) diff --git a/lib/cryptodev/rte_crypto_asym.h b/lib/cryptodev/rte_crypto_asym.h index cd24d4b07b..6fbc7b7708 100644 --- a/lib/cryptodev/rte_crypto_asym.h +++ b/lib/cryptodev/rte_crypto_asym.h @@ -43,11 +43,11 @@ rte_crypto_asym_op_strings[]; */ enum rte_crypto_ec_group { RTE_CRYPTO_EC_GROUP_UNKNOWN = 0, - RTE_CRYPTO_EC_GROUP_SECP192R1 = 19, - RTE_CRYPTO_EC_GROUP_SECP224R1 = 21, - RTE_CRYPTO_EC_GROUP_SECP256R1 = 23, - RTE_CRYPTO_EC_GROUP_SECP384R1 = 24, - RTE_CRYPTO_EC_GROUP_SECP521R1 = 25, + RTE_CRYPTO_EC_GROUP_SECP192R1 = 1, + RTE_CRYPTO_EC_GROUP_SECP224R1 = 2, + RTE_CRYPTO_EC_GROUP_SECP256R1 = 3, + RTE_CRYPTO_EC_GROUP_SECP384R1 = 4, + RTE_CRYPTO_EC_GROUP_SECP521R1 = 5, }; /** @@ -109,13 +109,19 @@ enum rte_crypto_asym_op_type { /**< Signature Generation operation */ RTE_CRYPTO_ASYM_OP_VERIFY, /**< Signature Verification operation */ - RTE_CRYPTO_ASYM_OP_PRIVATE_KEY_GENERATE, + RTE_CRYPTO_ASYM_OP_LIST_END +}; + +enum rte_crypto_dh_op_type { + RTE_CRYPTO_DH_OP_INVALID, + RTE_CRYPTO_DH_OP_PRIVATE_KEY_GENERATE, /**< DH Private Key generation operation */ - RTE_CRYPTO_ASYM_OP_PUBLIC_KEY_GENERATE, + RTE_CRYPTO_DH_OP_PUBLIC_KEY_GENERATE, /**< DH Public Key generation operation */ - RTE_CRYPTO_ASYM_OP_SHARED_SECRET_COMPUTE, + RTE_CRYPTO_DH_OP_SHARED_SECRET_COMPUTE, /**< DH Shared Secret compute operation */ - RTE_CRYPTO_ASYM_OP_LIST_END + RTE_CRYPTO_DH_OP_PUBLIC_KEY_VERIFY, + /**< DH verify correctness of public key */ }; /** @@ -256,7 +262,7 @@ struct rte_crypto_modinv_xform { * */ struct rte_crypto_dh_xform { - enum rte_crypto_asym_op_type type; + enum rte_crypto_dh_op_type type; /**< Setup xform for key generate or shared secret compute */ rte_crypto_uint p; /**< Prime modulus data */ @@ -278,13 +284,7 @@ struct rte_crypto_dsa_xform { rte_crypto_uint g; /**< Generator of the subgroup */ rte_crypto_uint x; - /**< x: Private key of the signer in octet-string network - * byte order format. - * Used when app has pre-defined private key. - * Valid only when xform chain is DSA ONLY. - * if xform chain is DH private key generate + DSA, then DSA sign - * compute will use internally generated key. - */ + /**< x: Private key */ }; /** @@ -504,8 +504,6 @@ struct rte_crypto_ecpm_op_param { * Structure describing asym xforms. */ struct rte_crypto_asym_xform { - struct rte_crypto_asym_xform *next; - /**< Pointer to next xform to set up xform chain.*/ enum rte_crypto_asym_xform_type xform_type; /**< Asymmetric crypto transform */