From patchwork Thu Oct 20 16:28:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Naga Harish K, S V" X-Patchwork-Id: 118831 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C4650A0553; Thu, 20 Oct 2022 18:29:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 660C7410FC; Thu, 20 Oct 2022 18:29:00 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 1484A40FAE; Thu, 20 Oct 2022 18:28:57 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1666283338; x=1697819338; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=QOxi53I/WSK67r5MtdVLEx4GeitkgB+xp2gME10rCSQ=; b=BkhF/ek4gfg1xEMM4O/6SWhgMZvvJYaJtwrRQjMPLrB8GyA612buzTK+ Q1yomIHwmTNHrXiCjSn0/4EX+QNgvUSggodClu6qdxiKfTXm7H1IdnLOH 9xJWJ1O+6NXx0iXObP51bnw8de6CX/Qme8ISVu7a1P8daaHe2pNF2YAbs FEEk72A+5hldEqBqFfPcZ478H5Pi126bzjXjxTXnjcbcJrKWsXucF9WcL is/gv9IcLkfhM6DT/aVbQIHQK91ZuWZsLN+wz9u7D9JpbHXtH+QExTypV vdehyPnBW4O7n5/3nELO3FfIVREo36nzLp5pbL6czNIxbG7Hp+/Rhiui0 w==; X-IronPort-AV: E=McAfee;i="6500,9779,10506"; a="294158750" X-IronPort-AV: E=Sophos;i="5.95,199,1661842800"; d="scan'208";a="294158750" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Oct 2022 09:28:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10506"; a="734950047" X-IronPort-AV: E=Sophos;i="5.95,199,1661842800"; d="scan'208";a="734950047" Received: from txandevlnx322.an.intel.com ([10.123.117.44]) by fmsmga002.fm.intel.com with ESMTP; 20 Oct 2022 09:28:53 -0700 From: Naga Harish K S V To: jay.jayatheerthan@intel.com, jerinj@marvell.com Cc: dev@dpdk.org, stable@dpdk.org Subject: [PATCH] eventdev/eth_tx: fix queue delete logic Date: Thu, 20 Oct 2022 11:28:49 -0500 Message-Id: <20221020162849.1645281-1-s.v.naga.harish.k@intel.com> X-Mailer: git-send-email 2.23.0 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org To delete all the queues of a ethernet device associated with adapter instance the queue_id can be passed as -1 to the queue delete API. When a subset of queues of a ethernet device are associated, the queue delete logic is exiting without deleting the queues in some cases (higher numbered associated queues) for above scenario as the queue delete logic is not checking all the queue association status. This patch fixes this issue by checking the queue association status of all the queues of the ethernet device. Fixes: 741b499e642 ("eventdev/eth_tx: fix queue delete logic") Cc: stable@dpdk.org Signed-off-by: Naga Harish K S V --- lib/eventdev/rte_event_eth_tx_adapter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/eventdev/rte_event_eth_tx_adapter.c b/lib/eventdev/rte_event_eth_tx_adapter.c index c2a848103b..f60b7a82ef 100644 --- a/lib/eventdev/rte_event_eth_tx_adapter.c +++ b/lib/eventdev/rte_event_eth_tx_adapter.c @@ -934,7 +934,7 @@ txa_service_queue_del(uint8_t id, uint16_t i, q, nb_queues; int ret = 0; - nb_queues = txa->txa_ethdev[port_id].nb_queues; + nb_queues = txa->txa_ethdev[port_id].dev->data->nb_tx_queues; if (nb_queues == 0) return 0;