From patchwork Wed Nov 9 06:09:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lingli Chen X-Patchwork-Id: 119599 Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B3C6EA0093; Wed, 9 Nov 2022 08:02:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 53BBB400D7; Wed, 9 Nov 2022 08:02:38 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 52DAF400D4 for ; Wed, 9 Nov 2022 08:02:36 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1667977357; x=1699513357; h=from:to:cc:subject:date:message-id; bh=a+EfnQhhmqNxmmrZgkGxKX+A4q3J8Ii5M2h1pj8K3kI=; b=RfG850cUyFNPNZrUJyE9K8bwuCsYFsym38V6LzSlqPnMkc/R+wNqCLgz Y2iYwhekipFcU1bUAaEW02s9EPhCZmflkI5U6xB1CapdqgrmgnCTzllCy 39MWO3hgEBZa631OmHKLBhe+5b5r7mrc0VUlP1AT/vI2qpFpErMpSuD2B v7RDDDKnBPZqC8fZKUKOSx9wl+O03AHNWbcdE5X4StZITm8QFE7z3/tBZ lQVwge5tgpEU0Qs36lCOvzzzjkBuTuVRUMhv7Q9hq7q6Q3jjmy0xCoEbZ 8qYMsDWRsPJYHQio2QAb080iqWCKejzyw/XqguzA51FZMkIBlGbRt+2ve w==; X-IronPort-AV: E=McAfee;i="6500,9779,10525"; a="375183301" X-IronPort-AV: E=Sophos;i="5.96,149,1665471600"; d="scan'208";a="375183301" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2022 23:02:36 -0800 X-IronPort-AV: E=McAfee;i="6500,9779,10525"; a="667888744" X-IronPort-AV: E=Sophos;i="5.96,149,1665471600"; d="scan'208";a="667888744" Received: from unknown (HELO localhost.localdomain) ([10.239.252.99]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Nov 2022 23:02:34 -0800 From: Lingli Chen To: dts@dpdk.org Cc: zhiminx.huang@intel.com, Lingli Chen Subject: [dts][PATCH V1] tests/pmdrss_hash: remove port stop all command Date: Wed, 9 Nov 2022 01:09:23 -0500 Message-Id: <20221109060923.21957-1-linglix.chen@intel.com> X-Mailer: git-send-email 2.17.1 X-BeenThere: dts@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: test suite reviews and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dts-bounces@dpdk.org 1. Executing the `port stop all` command destroys all flow rules associated with the port. Therefore, remove this command. 2. modify toeplitz_symmetric case sync with testplan: the hash value and queue should be the same for symmetric packets. Signed-off-by: Lingli Chen --- tests/TestSuite_pmdrss_hash.py | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/tests/TestSuite_pmdrss_hash.py b/tests/TestSuite_pmdrss_hash.py index da9d143a..afa30bf3 100644 --- a/tests/TestSuite_pmdrss_hash.py +++ b/tests/TestSuite_pmdrss_hash.py @@ -456,7 +456,7 @@ class TestPmdrssHash(TestCase): status = "true" result.insert(i, 0) if i % 2 == 1: - if pre_RSS_hash != tmp_reta_line["RSS hash"]: + if pre_RSS_hash == tmp_reta_line["RSS hash"]: status = "true" result.insert(len(reta_lines) + (i - 1) // 2, 0) else: @@ -549,7 +549,6 @@ class TestPmdrssHash(TestCase): self.dut.send_expect("set promisc all off", "testpmd> ") self.dut.send_expect("set nbcore %d" % (queue + 1), "testpmd> ") - self.dut.send_expect("port stop all", "testpmd> ") self.dut.send_expect("flow flush 0", "testpmd> ") rule_cmd = f"flow create 0 ingress pattern eth / ipv4 / end actions rss types {iptype} end queues end {rule_action}" if "sctp" in iptype or "udp" in iptype or "tcp" in iptype: @@ -558,7 +557,6 @@ class TestPmdrssHash(TestCase): rule_cmd = rule_cmd.replace("ipv4", "ipv6") outx = self.dut.send_expect(rule_cmd, "testpmd> ") self.verify("created" in outx, "Create flow failed") - self.dut.send_expect("port start all", "testpmd> ") out = self.dut.send_expect("port config all rss %s" % rsstype, "testpmd> ") self.verify( "error" not in out, "Configuration of RSS hash failed: Invalid argument" @@ -600,7 +598,6 @@ class TestPmdrssHash(TestCase): self.dut.send_expect("set promisc all off", "testpmd> ") self.dut.send_expect("set nbcore %d" % (queue + 1), "testpmd> ") - self.dut.send_expect("port stop all", "testpmd> ") self.dut.send_expect("flow flush 0", "testpmd> ") rule_cmd = f"flow create 0 ingress pattern eth / ipv4 / end actions rss types {iptype} end queues end {rule_action}" if "sctp" in iptype or "udp" in iptype or "tcp" in iptype: @@ -609,7 +606,6 @@ class TestPmdrssHash(TestCase): rule_cmd = rule_cmd.replace("ipv4", "ipv6") outx = self.dut.send_expect(rule_cmd, "testpmd> ") self.verify("created" in outx, "Create flow failed") - self.dut.send_expect("port start all", "testpmd> ") out = self.dut.send_expect("port config all rss %s" % rsstype, "testpmd> ") self.verify( "error" not in out, "Configuration of RSS hash failed: Invalid argument" @@ -657,7 +653,6 @@ class TestPmdrssHash(TestCase): self.dut.send_expect("set promisc all off", "testpmd> ") self.dut.send_expect("set nbcore %d" % (queue + 1), "testpmd> ") - self.dut.send_expect("port stop all", "testpmd> ") # some nic not support change hash algorithm self.dut.send_expect("flow flush 0", "testpmd> ") rule_cmd = f"flow create 0 ingress pattern eth / ipv4 / end actions rss types {iptype} end queues end {rule_action}" @@ -667,7 +662,6 @@ class TestPmdrssHash(TestCase): rule_cmd = rule_cmd.replace("ipv4", "ipv6") outx = self.dut.send_expect(rule_cmd, "testpmd> ") self.verify("created" in outx, "Create flow failed") - self.dut.send_expect("port start all", "testpmd> ") out = self.dut.send_expect("port config all rss %s" % rsstype, "testpmd> ") self.verify( "error" not in out, "Configuration of RSS hash failed: Invalid argument"