From patchwork Wed Nov 9 07:57:53 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Slava Ovsiienko X-Patchwork-Id: 119605 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E9554A0093; Wed, 9 Nov 2022 08:58:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D4D60400D7; Wed, 9 Nov 2022 08:58:34 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2053.outbound.protection.outlook.com [40.107.220.53]) by mails.dpdk.org (Postfix) with ESMTP id 9CE21400D4 for ; Wed, 9 Nov 2022 08:58:32 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=P/pqIYx26LEWzsAMD++EVyqQ682ACStrQLl2qFtVCT2ZZt4QarKM67KncwXviYc+8N1wo7UikpauVdkkh3qYZ8Stdk//zYXh99/QvLByOFBAJpyOHxmq/fbJ+trDtIly1iESZbvG2WCWCTwDSLH5P+VUa6Zc8XbiburqtBBPyPcZQll6f/doko0akpaKL0GvGOAnVMYkJ7rMk3+Lu4nwXcSbUGB4eNet4Ou+4X5YOi5j8YrJ3W8qofsGuWOTko3Ux7Qx+UpG6uZSgVToisznPN1Q9sQu+aQ07vUVuXNMviL3xWJKe1FjLlq5VqjUzBS7gALFcRJY3OyiMKY7khOgJQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vp2mFCRjPS8dkmlN5lanwxIJI+hRi8RRnuYNL+CGFZU=; b=HgIAn4QptIHmXVd6YC4w6pUtrqemscgg/IFTeP6PWOlCYUGmlZ4LZgeAMGcH1fhPFhmqJtcYJvMQQS4OvpQnYfLog7SR54vRo882coNDntViuaFQaSxRXC6aqyYNwc+kxtW+JwNcR4TeFKZi6Jjd60u4p4YafMZD+7L5o9tjZfWGfQ8TaSAcOaES5zROFBxncUJgM2wuVRbH5SCKcFrxeo6+ui2CPYG05nKSTyysY9N/TYHmMyzkbMrOYCFW6knsGTHtn7RFiWp0lF9s+NG/nHAyl9wVgNMCvqLs6+jouOXsKslFKVwIMByxAihDjajObV9DAzQGFjHQIFXYYPnCFA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vp2mFCRjPS8dkmlN5lanwxIJI+hRi8RRnuYNL+CGFZU=; b=blLZ/xVHUo2hakVPnaPWBgUqBpTagch/VSOuB+uMxGu0Pza1wXeoqbMtBXLR6xokNLF7FQ6N1Xj+XA5zu5eTXX6BaQOjSWkxNCu2Map4znbYK33lMsLxUh3n31CMCl+ESkCgqti9bya0mzfKs1o0+Lb0tsx+iBI1RXea4cOGWTu/nsU/XGFJEKWnpRJxuNYdcfkiVnat6xsUBjkNjW7fPl0eYIiasoveiAw+Lur7YLKpbXxHvYwbZW63hGaJVP6zNtaj3YR50ZO7ovqGgJtcrh8QEfatIoNSJAKcZvw4AnhO72xZ2zGvfnBjVOSiGpxF6NuKR/WufHyobuA/qFzehg== Received: from MW4PR03CA0204.namprd03.prod.outlook.com (2603:10b6:303:b8::29) by BL3PR12MB6428.namprd12.prod.outlook.com (2603:10b6:208:3b7::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.20; Wed, 9 Nov 2022 07:58:30 +0000 Received: from CO1NAM11FT041.eop-nam11.prod.protection.outlook.com (2603:10b6:303:b8:cafe::c) by MW4PR03CA0204.outlook.office365.com (2603:10b6:303:b8::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5791.26 via Frontend Transport; Wed, 9 Nov 2022 07:58:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CO1NAM11FT041.mail.protection.outlook.com (10.13.174.217) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5813.12 via Frontend Transport; Wed, 9 Nov 2022 07:58:29 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.26; Tue, 8 Nov 2022 23:58:14 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.29; Tue, 8 Nov 2022 23:58:13 -0800 From: Viacheslav Ovsiienko To: CC: , , Subject: [PATCH v2] net/mlx5/hws: fix timestamp format on Tx queue creation Date: Wed, 9 Nov 2022 09:57:53 +0200 Message-ID: <20221109075753.2449-1-viacheslavo@nvidia.com> X-Mailer: git-send-email 2.18.1 In-Reply-To: <20221108185650.15489-1-viacheslavo@nvidia.com> References: <20221108185650.15489-1-viacheslavo@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail203.nvidia.com (10.129.68.9) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT041:EE_|BL3PR12MB6428:EE_ X-MS-Office365-Filtering-Correlation-Id: 59b9e099-116b-4e53-65cc-08dac22830cc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DALVA0ioNCc4vySm034CCUec24RIogkFJJntuD8f0kQS7YZHSl4PDYA5u+4RNeze+eKjWJrvmuO4JyDx35Ax350lzlIyvKgPF8aECnjkP6Q516qn6pUNXEp6jdYGDBNyy6j/V4oI7fM2sESgDUjj422nu4iel7/GrBbHXe98PgGU+gDk5Kzir9vMTBBF5Zqd1YUDIOGILLe6UH667mahSnESmwVijbRuCPSb+QMYNKLqXEhok7Oop9oTvKx4NR87WYWP0eZgtvOtG/sa0DlvObODE0oMJ3z+KuB+euIPaeEXXkR1Pod1eoiy+NVDPEChhoGJONUXqtmAxcMNScVRGe2hNWYlzpqzCdI6dB+Hfgbp6VJipdEsN1BFiuTCut/1RSIxsJ8bWEcSF+gOiwC78mjdhbC0Q57QKVdmnZMKt3AK3i4O+og5/o2j0txunpnzV4guKWWOoV15jccD2lXJbCbOGhyrnLBxKJAKb3qeCH8EUBWKR0GnsXrTIDU06DkfmoDVFk7fKwcDRp9aJHyqA5NG/jZb1WGCp8bg83ktZDRv+nV45BKNJhwdPkBaKhBonIg/o7GdLCgqOpO8SIh7UAAeyew1s3Cmw9Qxw2Hq3CM+qwnl2NWpWuANzzrLD2JWtaQsTrjXPkRY9waSLY533TBUa5ekZNE95NSPYJXS8NtOQIGiLUncpSa+F7HowS8IqhjGFm0z8JRjkk6bRDqHqTQc8gX38kFdelahkVh4xM7ar/vuFSor8GjAaMISFfFifo/xpDrQBKM9MOS2j0ntQ+4QLq3CoZaE6Q+yLFc5SkSYa800+G2PWOfJxyOfp8ckMqpeIFGnto219ZElGOs31sIE+NBH1Vp9aPNzyC+6/8gMOl+CWgpNe2sAEU6HFQmK X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230022)(4636009)(39860400002)(346002)(396003)(376002)(136003)(451199015)(46966006)(36840700001)(40470700004)(86362001)(70206006)(2906002)(5660300002)(40460700003)(41300700001)(4326008)(36756003)(8676002)(40480700001)(7696005)(7636003)(966005)(82740400003)(70586007)(478600001)(356005)(186003)(336012)(2616005)(26005)(107886003)(6286002)(6666004)(54906003)(316002)(1076003)(6916009)(16526019)(426003)(8936002)(82310400005)(55016003)(36860700001)(47076005)(175924003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Nov 2022 07:58:29.7810 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 59b9e099-116b-4e53-65cc-08dac22830cc X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT041.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL3PR12MB6428 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The NIC since 6DX supports multiple timestamp formats in CQEs configured via firmware. If real time timestamp format has been configured the correct attributes should be specified on queue creation via DevX. These attributes setting was missed on steering queue creation and hardware steering initialization failed. Fixes: 3eb748869d2d ("net/mlx5/hws: add send layer") Signed-off-by: Viacheslav Ovsiienko --- drivers/net/mlx5/hws/mlx5dr_cmd.c | 4 ++++ drivers/net/mlx5/hws/mlx5dr_cmd.h | 2 ++ drivers/net/mlx5/hws/mlx5dr_send.c | 4 ++++ 3 files changed, 10 insertions(+) v1: - http://patches.dpdk.org/project/dpdk/patch/20221108185650.15489-1-viacheslavo@nvidia.com/ v2: - minor style changes - removed unnessesary variables diff --git a/drivers/net/mlx5/hws/mlx5dr_cmd.c b/drivers/net/mlx5/hws/mlx5dr_cmd.c index da8cc3d265..721376b8da 100644 --- a/drivers/net/mlx5/hws/mlx5dr_cmd.c +++ b/drivers/net/mlx5/hws/mlx5dr_cmd.c @@ -674,6 +674,7 @@ mlx5dr_cmd_sq_create(struct ibv_context *ctx, MLX5_SET(sqc, sqc, cqn, attr->cqn); MLX5_SET(sqc, sqc, flush_in_error_en, 1); MLX5_SET(sqc, sqc, non_wire, 1); + MLX5_SET(sqc, sqc, ts_format, attr->ts_format); MLX5_SET(wq, wqc, wq_type, MLX5_WQ_TYPE_CYCLIC); MLX5_SET(wq, wqc, pd, attr->pdn); MLX5_SET(wq, wqc, uar_page, attr->page_id); @@ -763,6 +764,9 @@ int mlx5dr_cmd_query_caps(struct ibv_context *ctx, MLX5_GET64(query_hca_cap_out, out, capability.cmd_hca_cap.match_definer_format_supported); + caps->sq_ts_format = MLX5_GET(query_hca_cap_out, out, + capability.cmd_hca_cap.sq_ts_format); + MLX5_SET(query_hca_cap_in, in, op_mod, MLX5_GET_HCA_CAP_OP_MOD_GENERAL_DEVICE_2 | MLX5_HCA_CAP_OPMOD_GET_CUR); diff --git a/drivers/net/mlx5/hws/mlx5dr_cmd.h b/drivers/net/mlx5/hws/mlx5dr_cmd.h index 2548b2b238..2b3b47f473 100644 --- a/drivers/net/mlx5/hws/mlx5dr_cmd.h +++ b/drivers/net/mlx5/hws/mlx5dr_cmd.h @@ -121,6 +121,7 @@ struct mlx5dr_cmd_sq_create_attr { uint32_t dbr_id; uint32_t wq_id; uint32_t log_wq_sz; + uint32_t ts_format; }; struct mlx5dr_cmd_query_ft_caps { @@ -159,6 +160,7 @@ struct mlx5dr_cmd_query_caps { uint32_t eswitch_manager_vport_number; uint8_t log_header_modify_argument_granularity; uint8_t log_header_modify_argument_max_alloc; + uint8_t sq_ts_format; uint64_t definer_format_sup; uint32_t trivial_match_definer; char fw_ver[64]; diff --git a/drivers/net/mlx5/hws/mlx5dr_send.c b/drivers/net/mlx5/hws/mlx5dr_send.c index 1e9953a38f..5c8bbe6fc6 100644 --- a/drivers/net/mlx5/hws/mlx5dr_send.c +++ b/drivers/net/mlx5/hws/mlx5dr_send.c @@ -492,6 +492,10 @@ static int mlx5dr_send_ring_create_sq_obj(struct mlx5dr_context *ctx, attr.dbr_id = sq->db_umem->umem_id; attr.wq_id = sq->buf_umem->umem_id; attr.log_wq_sz = log_wq_sz; + if (ctx->caps->sq_ts_format == MLX5_HCA_CAP_TIMESTAMP_FORMAT_FR) + attr.ts_format = MLX5_QPC_TIMESTAMP_FORMAT_FREE_RUNNING; + else + attr.ts_format = MLX5_QPC_TIMESTAMP_FORMAT_DEFAULT; sq->obj = mlx5dr_cmd_sq_create(ctx->ibv_ctx, &attr); if (!sq->obj)