From patchwork Wed Nov 9 23:24:38 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 119670 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E7D5A0093; Thu, 10 Nov 2022 00:25:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B555540A7D; Thu, 10 Nov 2022 00:24:57 +0100 (CET) Received: from mail-pg1-f171.google.com (mail-pg1-f171.google.com [209.85.215.171]) by mails.dpdk.org (Postfix) with ESMTP id B672B400D4 for ; Thu, 10 Nov 2022 00:24:56 +0100 (CET) Received: by mail-pg1-f171.google.com with SMTP id 78so45776pgb.13 for ; Wed, 09 Nov 2022 15:24:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Va/5ciuzhoW7glab6jfjtSvcRjkE/+oyvtZCp4BGtCA=; b=ezN5MWTyTyxSaJSExQvVW/ZsUGAXkELiJtFHpbLS7LEHiyoeHIi5SFq2Pmq0RHtxty aus9Sg+Rjg+ZQPXzCoK2KVlDlJAJgUU/eVVaoGVN0sRi1zhWcetVFx4fPd5AMkwMfpYY fNiDyhGZFiegu7xsYIeHvK+cxtaLQXBY8rXq9S0la3/bcR/VgSiUJOxThqPy5Xypjhqe AmX9jpt3jxRF8fztDSHaFGGNzonjRHGFmmRz3puc28oZvULCfEwLSMzXgLVx9B98SmR6 rIBdXQXFcMj9ucMyj6f57O/zbxjZpbWldNwrcECjBPJMPcF+t5zcbE9xst7mNLin58Nd /kjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Va/5ciuzhoW7glab6jfjtSvcRjkE/+oyvtZCp4BGtCA=; b=pCUKD4vBamKN1JqIwGPMevf2ueaRhD+lGjT48UJ3Tf3APZGr3IXwxpMyT9f1SQFMsq yI37itc0/4JJ1RfrRuupJKapnQGtAjywvj8TSOd6w2SMPkq2VLzjY1Wur7mgzlAu4DKn uKiHP+yedZ59QHd3Djiu38t7l2ZML945S7u3D+YSx4G4TxRngMTFY63znA3ciPfzUsXm kUaesSHjxTdNyqX6oLMaiMjxmkiaqaFRU0z1uaZwPMqCavxdmEQsqD/ktPQ6YXxX5fUa tqu8oGTk5QkUDseNDxuDCJ5G3t64E1ReZhnHb2hq7MnKOrHIwlNoD8sJ7G+q8jEGzX6E Cuwg== X-Gm-Message-State: ACrzQf2ZXXol9biRHj3XElMuY29Ufkt64j2HLwFzM6cgANaeNkMBVuAr f1l1IHece935xRi6rDTONjMWWHzMoebZvA== X-Google-Smtp-Source: AMsMyM4Y1verJQGqf9oUq1GlVLqVGpLBurXTY1rMZ8WvSJCc9qkdZBc86vseEXq7N4KWA1BI/NMadA== X-Received: by 2002:a63:dc45:0:b0:43c:b43f:5228 with SMTP id f5-20020a63dc45000000b0043cb43f5228mr1367299pgj.58.1668036295643; Wed, 09 Nov 2022 15:24:55 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id y28-20020aa79e1c000000b0056e15b7138esm8798645pfq.157.2022.11.09.15.24.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 15:24:54 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Harman Kalra Subject: [PATCH v3 01/14] eal: fix whitespace Date: Wed, 9 Nov 2022 15:24:38 -0800 Message-Id: <20221109232451.265059-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221109232451.265059-1-stephen@networkplumber.org> References: <20221109191445.140320-1-stephen@networkplumber.org> <20221109232451.265059-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add space after keywords. Signed-off-by: Stephen Hemminger --- lib/eal/include/generic/rte_cycles.h | 4 ++-- lib/eal/linux/eal_hugepage_info.c | 6 +++--- lib/eal/linux/eal_interrupts.c | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/lib/eal/include/generic/rte_cycles.h b/lib/eal/include/generic/rte_cycles.h index f4fdca416570..e05b56e2cac6 100644 --- a/lib/eal/include/generic/rte_cycles.h +++ b/lib/eal/include/generic/rte_cycles.h @@ -94,7 +94,7 @@ static inline uint64_t rte_get_timer_cycles(void) { #ifdef RTE_LIBEAL_USE_HPET - switch(eal_timer_source) { + switch (eal_timer_source) { case EAL_TIMER_TSC: #endif return rte_get_tsc_cycles(); @@ -116,7 +116,7 @@ static inline uint64_t rte_get_timer_hz(void) { #ifdef RTE_LIBEAL_USE_HPET - switch(eal_timer_source) { + switch (eal_timer_source) { case EAL_TIMER_TSC: #endif return rte_get_tsc_hz(); diff --git a/lib/eal/linux/eal_hugepage_info.c b/lib/eal/linux/eal_hugepage_info.c index a1b6cb31ff1a..b6d751a2ee97 100644 --- a/lib/eal/linux/eal_hugepage_info.c +++ b/lib/eal/linux/eal_hugepage_info.c @@ -180,8 +180,8 @@ get_default_hp_size(void) FILE *fd = fopen(proc_meminfo, "r"); if (fd == NULL) rte_panic("Cannot open %s\n", proc_meminfo); - while(fgets(buffer, sizeof(buffer), fd)){ - if (strncmp(buffer, str_hugepagesz, hugepagesz_len) == 0){ + while (fgets(buffer, sizeof(buffer), fd)) { + if (strncmp(buffer, str_hugepagesz, hugepagesz_len) == 0) { size = rte_str_to_size(&buffer[hugepagesz_len]); break; } @@ -231,7 +231,7 @@ get_hugepage_dir(uint64_t hugepage_sz, char *hugedir, int len) if (default_size == 0) default_size = get_default_hp_size(); - while (fgets(buf, sizeof(buf), fd)){ + while (fgets(buf, sizeof(buf), fd)) { const char *pagesz_str; if (rte_strsplit(buf, sizeof(buf), splitstr, _FIELDNAME_MAX, diff --git a/lib/eal/linux/eal_interrupts.c b/lib/eal/linux/eal_interrupts.c index d52ec8eb4cd7..3be1b090be9e 100644 --- a/lib/eal/linux/eal_interrupts.c +++ b/lib/eal/linux/eal_interrupts.c @@ -1073,7 +1073,7 @@ eal_intr_handle_interrupts(int pfd, unsigned totalfds) struct epoll_event events[totalfds]; int nfds = 0; - for(;;) { + for (;;) { nfds = epoll_wait(pfd, events, totalfds, EAL_INTR_EPOLL_WAIT_FOREVER); /* epoll_wait fail */ From patchwork Wed Nov 9 23:24:39 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 119671 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9BE6EA0093; Thu, 10 Nov 2022 00:25:06 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 955F7410EF; Thu, 10 Nov 2022 00:24:59 +0100 (CET) Received: from mail-pg1-f169.google.com (mail-pg1-f169.google.com [209.85.215.169]) by mails.dpdk.org (Postfix) with ESMTP id 3C886410E6 for ; Thu, 10 Nov 2022 00:24:58 +0100 (CET) Received: by mail-pg1-f169.google.com with SMTP id f63so83106pgc.2 for ; Wed, 09 Nov 2022 15:24:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IiZjGh6EYGuTuV9xZk6AoXRTZxfa+uP6Q3936gc9mD8=; b=eWqyprCJ2hvdq1eqY4+3cGnQQbcovrgmL1+NmHWw8eO5Ht8vqPpOVHQ6cS4wuLwvE1 NqqkJZuarHaE9Vm2VmAEls1K3kP1FvDEC4YK06NTOLtCVGYUiIu0PHUzh5E/64ksAgoN 67xzkcEZIVyI4JP4Jkuab2+X9y5+oaMKQeKKRqLh9ObEP2jKhKliAC06Ut/TNEuRH56I eG/nLBjJjfsH1QUF5PjPLKNUkMaoa4lzPCdb7ggdFEM5z4FIdVqjaQ35xQLX5St1xWDd Mb2NP6ilkuTpWKSKgagi+HHKUk9+Zn28Rg9C3Fg30ZnHmOzBXG97yMv9i/ZTkfWIjQNV WCnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IiZjGh6EYGuTuV9xZk6AoXRTZxfa+uP6Q3936gc9mD8=; b=dvRZFxcRslytni+RI/8u7nLOvuJ/057aN3pFyE4tvAvvPGIu+eU8IpF9xQj1cXMWye JJcoAjLrU+jva4qL6eiFvzxYk1MHXWI8BgpPJs32nIFOFcn9xvoxCebrWs/MtFVa1vKi kyMGJeYukjdJMMkE0sYo6A+y6MqYqBDSUVxZH1AZuenwuTbBOQEx1oRtu2+vvzB+EvBL lVVkpO93e/bbt1DXcdiWKVf7Dg5wcq8pJ3phhaF6TK+LyOAuMViv7XMiPz7nonZ/HBzh viS19iFfOV1rpMWkT0/nDpe8+HEsTTSmDFEAJhI0mRCanuo2TNunqV619tgM/72UhpS2 pV1Q== X-Gm-Message-State: ACrzQf0ZT7sdcj7VW2Zmc01H8oFzBUMotxvPfeCsERbHbpCbhqiaZNxz m2e6r9W0y48dgyiVDyg8QFMij5LNeZ6dcg== X-Google-Smtp-Source: AMsMyM444SaT9/gSLlTVtj6KY+c+WPpkFtYgwiTWQE7v64aqyDYen9JKf5eRzw8ykx1g/gC6pd53wA== X-Received: by 2002:a65:42c8:0:b0:41a:8138:f47f with SMTP id l8-20020a6542c8000000b0041a8138f47fmr54127446pgp.476.1668036297118; Wed, 09 Nov 2022 15:24:57 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id y28-20020aa79e1c000000b0056e15b7138esm8798645pfq.157.2022.11.09.15.24.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 15:24:56 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Olivier Matz Subject: [PATCH v3 02/14] cmdline: fix whitespace Date: Wed, 9 Nov 2022 15:24:39 -0800 Message-Id: <20221109232451.265059-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221109232451.265059-1-stephen@networkplumber.org> References: <20221109191445.140320-1-stephen@networkplumber.org> <20221109232451.265059-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add space after keywords. Remove unnecessary spaces in if expressions. Signed-off-by: Stephen Hemminger --- lib/cmdline/cmdline_parse_string.c | 17 +++++++---------- lib/cmdline/cmdline_rdline.c | 12 ++++++------ 2 files changed, 13 insertions(+), 16 deletions(-) diff --git a/lib/cmdline/cmdline_parse_string.c b/lib/cmdline/cmdline_parse_string.c index d756638905a2..4224983d2e73 100644 --- a/lib/cmdline/cmdline_parse_string.c +++ b/lib/cmdline/cmdline_parse_string.c @@ -73,20 +73,17 @@ cmdline_parse_string(cmdline_parse_token_hdr_t *tk, const char *buf, void *res, token_len = get_token_len(str); /* if token is too big... */ - if (token_len >= STR_TOKEN_SIZE - 1) { + if (token_len >= STR_TOKEN_SIZE - 1) continue; - } - if ( strncmp(buf, str, token_len) ) { + if (strncmp(buf, str, token_len)) continue; - } - if ( !cmdline_isendoftoken(*(buf+token_len)) ) { + if (!cmdline_isendoftoken(*(buf+token_len))) continue; - } break; - } while ( (str = get_next_token(str)) != NULL ); + } while ((str = get_next_token(str)) != NULL); if (!str) return -1; @@ -108,7 +105,7 @@ cmdline_parse_string(cmdline_parse_token_hdr_t *tk, const char *buf, void *res, /* unspecified string (unknown single token) */ else { token_len = 0; - while(!cmdline_isendoftoken(buf[token_len]) && + while (!cmdline_isendoftoken(buf[token_len]) && token_len < (STR_TOKEN_SIZE-1)) token_len++; @@ -149,9 +146,9 @@ int cmdline_complete_get_nb_string(cmdline_parse_token_hdr_t *tk) return 0; str = sd->str; - while( (str = get_next_token(str)) != NULL ) { + while ((str = get_next_token(str)) != NULL) ret++; - } + return ret; } diff --git a/lib/cmdline/cmdline_rdline.c b/lib/cmdline/cmdline_rdline.c index 5cf723a0126a..b5927879d48f 100644 --- a/lib/cmdline/cmdline_rdline.c +++ b/lib/cmdline/cmdline_rdline.c @@ -301,7 +301,7 @@ rdline_char_in(struct rdline *rdl, char c) /* delete 1 char from the left */ case CMDLINE_KEY_BKSPACE: case CMDLINE_KEY_BKSPACE2: - if(!cirbuf_del_tail_safe(&rdl->left)) { + if (!cirbuf_del_tail_safe(&rdl->left)) { rdline_puts(rdl, vt100_bs); display_right_buffer(rdl, 1); } @@ -354,7 +354,7 @@ rdline_char_in(struct rdline *rdl, char c) /* paste contents of kill buffer to the left side of caret */ case CMDLINE_KEY_CTRL_Y: i=0; - while(CIRBUF_GET_LEN(&rdl->right) + CIRBUF_GET_LEN(&rdl->left) < + while (CIRBUF_GET_LEN(&rdl->right) + CIRBUF_GET_LEN(&rdl->left) < RDLINE_BUF_SIZE && i < rdl->kill_size) { cirbuf_add_tail(&rdl->left, rdl->kill_buf[i]); @@ -403,10 +403,10 @@ rdline_char_in(struct rdline *rdl, char c) tmp_size = strnlen(tmp_buf, sizeof(tmp_buf)); /* add chars */ if (ret == RDLINE_RES_COMPLETE) { - i=0; - while(CIRBUF_GET_LEN(&rdl->right) + CIRBUF_GET_LEN(&rdl->left) < - RDLINE_BUF_SIZE && - i < tmp_size) { + i = 0; + while (CIRBUF_GET_LEN(&rdl->right) + + CIRBUF_GET_LEN(&rdl->left) < + RDLINE_BUF_SIZE && i < tmp_size) { cirbuf_add_tail(&rdl->left, tmp_buf[i]); rdl->write_char(rdl, tmp_buf[i]); i++; From patchwork Wed Nov 9 23:24:40 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 119672 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 02066A00C2; Thu, 10 Nov 2022 00:25:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8160942D0C; Thu, 10 Nov 2022 00:25:00 +0100 (CET) Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) by mails.dpdk.org (Postfix) with ESMTP id 8398A400EF for ; Thu, 10 Nov 2022 00:24:59 +0100 (CET) Received: by mail-pf1-f169.google.com with SMTP id y13so165689pfp.7 for ; Wed, 09 Nov 2022 15:24:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=b1WcfSMTUpWNCO1EbJfT3lp8xDOEHidPF/QX2vmYEtI=; b=dCX7NsSUegOEuJ7GIXo6VvwAshz3qAPgzEybTXtx80M45lVqKRRR+/9ZgZUEPc93Fk znmCaYaULrZrmaI8sdaPxiyCxux/DWQv7bUZsqFy7HyOlcrgg3sDk2WSvoL76ZWZOL9g M0gPDfNonClMk6JOsFwL7F6s6Cm60/DXa8M261aWbW5wRRbQAmPUxuaMwpcawejcLg+v 9QTPsD9lsSAyO9CwqIG3ldFoDKJfICPCZRGYgBQCLA2XTHXtUWVKevGbhJf/vS78LAhN R2E6dGmt4YP9+E7OknPG4bWubHsd1Q8eksnS88RoQ0HiQUCd/lCai0+5d28Y8IW7PLCt rJJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=b1WcfSMTUpWNCO1EbJfT3lp8xDOEHidPF/QX2vmYEtI=; b=VpGdG/fgJ6+xhuTjYtw3jjbWqcI82zSc6sBu2brNzr0GpoAmgeX1zsq+NN+mYfJhtC BEIqFqTBcQsYjLoPGCwCAhI5OQ3HoDxDh2TRwMJ6JKgzwyIoyg4K2cSRzJwdjLKgTnKp jflrJ1RRrc++dWS7ua3VvZ+qxrFdbm/MKxcRbBWUAmOIcSmJ3LxR5AF4L1EWDCpaMrIr eQLCO9UQ+W5qX2tAYJUMQkEg3QTfUM+tMZKwB7VnoVc6s508WblMwnd3loujtW/8UOPc LYmXFMOtqETlTGbxw6Tp6dDB2KDQVox4Uq1tN9/sIEoIs8Sg0r3lgFAqOXQ+L8bJpWY7 g/JQ== X-Gm-Message-State: ACrzQf0OMpJODUSxirkpgSL7mjhA6FkmUoU20hS1aEdsP2OcLvYjBxre Ns2Xd6U1sQ/sSytlSHYdziYSsgwPmXSEiA== X-Google-Smtp-Source: AMsMyM4fjfyzGbEjFgH+jNXlhQa3AkSML9Enj6qJn9acbHt/LSlCD5emde1kTh7K8lhQKO1QWUAdGA== X-Received: by 2002:a63:3106:0:b0:46f:f2f6:b06 with SMTP id x6-20020a633106000000b0046ff2f60b06mr1277035pgx.376.1668036298395; Wed, 09 Nov 2022 15:24:58 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id y28-20020aa79e1c000000b0056e15b7138esm8798645pfq.157.2022.11.09.15.24.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 15:24:57 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Erik Gabriel Carrillo Subject: [PATCH v3 03/14] timer: fix whitespace Date: Wed, 9 Nov 2022 15:24:40 -0800 Message-Id: <20221109232451.265059-4-stephen@networkplumber.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221109232451.265059-1-stephen@networkplumber.org> References: <20221109191445.140320-1-stephen@networkplumber.org> <20221109232451.265059-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add space after keywords. Signed-off-by: Stephen Hemminger --- lib/timer/rte_timer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/timer/rte_timer.c b/lib/timer/rte_timer.c index 85d67573eb9e..9eb73f1fed13 100644 --- a/lib/timer/rte_timer.c +++ b/lib/timer/rte_timer.c @@ -350,7 +350,7 @@ timer_get_prev_entries(uint64_t time_val, unsigned tim_lcore, { unsigned lvl = priv_timer[tim_lcore].curr_skiplist_depth; prev[lvl] = &priv_timer[tim_lcore].pending_head; - while(lvl != 0) { + while (lvl != 0) { lvl--; prev[lvl] = prev[lvl+1]; while (prev[lvl]->sl_next[lvl] && From patchwork Wed Nov 9 23:24:41 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 119673 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED748A0093; Thu, 10 Nov 2022 00:25:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B13A942D24; Thu, 10 Nov 2022 00:25:02 +0100 (CET) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mails.dpdk.org (Postfix) with ESMTP id B9F5442D0E for ; Thu, 10 Nov 2022 00:25:00 +0100 (CET) Received: by mail-pl1-f171.google.com with SMTP id p12so122666plq.4 for ; Wed, 09 Nov 2022 15:25:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jJ0X6Dq1D/GY6I6E4pJhph+lV2hSiKEeD8AtC+fUPco=; b=w4FLZt9C3jBH0wxHiy4T7+TtiH40gP7zDC6bgs4y3Dup2a+5f6oGk9mwNEm5qVDDz+ XbejcKXeHMQ9c6osaqLtN0CqKFdX/dpQLuksDwOwGELb8ugllYmdKxD2bKQzYee4Q6x9 7MZ/G+hskHQsDUR7Y2cZ/MvtUCMLkDbQVjYp7yY0uD+KHGu247IjVJgy7TAvTS8a/qza aQ6pQH+Si+0FHsULymv4Nstxp34XTJUa3X6i+xObNoGZ9GFFBHm3lyYigfjLwDzAG8bK ZqTFUjIbT9CAe4R7P/n87tU7jB8nh2Cl73T2m6X/7VQQqe0E1ZgqVaFh9mvrCLr7iWne ZofA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jJ0X6Dq1D/GY6I6E4pJhph+lV2hSiKEeD8AtC+fUPco=; b=DClJNfn3LopkabT3QeIGr+jICE/FNoUJewS4JLUhcAyXVOJy/HB9fjmrYaNLX5sL7+ ntiooPC0iGRBgqOvx+TzrpxYE+/B9snPa940fK9OodKY3SchrAR/RLblbzaM6C4ohlSI WCht+LZvWjLpMUq82qHOufV67yy86dGsYgvtXvPTbjXad829tITUkBVigC6UrvYaZJe9 tPU9DxDM2L9IsM6JW2K5Tq9XwSVloLcLSMpY1EIJKeTo4R0RNTiucqlCldi0/AFSOOxc Hu3cjzRdWGIGoCbpcS64bnIja+zm8lz3XkPDCefdU66nZdKqmZPUZe8iqvowfssuoqu1 xnqA== X-Gm-Message-State: ACrzQf0gkg2IDx3bY+99LsNKeLmpcK4l8oBI7rCsjYPIheKfOsnTP/ha naHG4cCm8ZtYgCj1X7XVy4LtHH9ynY+anw== X-Google-Smtp-Source: AMsMyM4xg+RZ/pCxgUkBfwX20da5qjVo1l4Hvt3jGvUDgJ8l1A+PFmtVS6K0gUDe39AcxswCsVIung== X-Received: by 2002:a17:902:64c1:b0:186:827e:a0da with SMTP id y1-20020a17090264c100b00186827ea0damr63374581pli.94.1668036299650; Wed, 09 Nov 2022 15:24:59 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id y28-20020aa79e1c000000b0056e15b7138esm8798645pfq.157.2022.11.09.15.24.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 15:24:59 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Konstantin Ananyev Subject: [PATCH v3 04/14] ip_frag: fix whitespace Date: Wed, 9 Nov 2022 15:24:41 -0800 Message-Id: <20221109232451.265059-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221109232451.265059-1-stephen@networkplumber.org> References: <20221109191445.140320-1-stephen@networkplumber.org> <20221109232451.265059-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add space after keywords. Signed-off-by: Stephen Hemminger --- lib/ip_frag/rte_ipv4_reassembly.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/ip_frag/rte_ipv4_reassembly.c b/lib/ip_frag/rte_ipv4_reassembly.c index 4a89a5f5365a..88ee0aa63f62 100644 --- a/lib/ip_frag/rte_ipv4_reassembly.c +++ b/lib/ip_frag/rte_ipv4_reassembly.c @@ -34,7 +34,7 @@ ipv4_frag_reassemble(struct ip_frag_pkt *fp) for (i = n; i != IP_FIRST_FRAG_IDX && ofs != first_len; i--) { /* previous fragment found. */ - if(fp->frags[i].ofs + fp->frags[i].len == ofs) { + if (fp->frags[i].ofs + fp->frags[i].len == ofs) { RTE_ASSERT(curr_idx != i); From patchwork Wed Nov 9 23:24:42 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 119674 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 78F6FA0093; Thu, 10 Nov 2022 00:25:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A7B9E42D28; Thu, 10 Nov 2022 00:25:03 +0100 (CET) Received: from mail-pf1-f170.google.com (mail-pf1-f170.google.com [209.85.210.170]) by mails.dpdk.org (Postfix) with ESMTP id 10E3542D21 for ; Thu, 10 Nov 2022 00:25:02 +0100 (CET) Received: by mail-pf1-f170.google.com with SMTP id y203so178510pfb.4 for ; Wed, 09 Nov 2022 15:25:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oxp2qItKxyvIxvIPqZSW9JotSdGmvWXvGA1HWz5sGLE=; b=DPPBFItqspht99oQGvxWZ/c5NvtfHRJJhqAA6iFUH2PexY/XsCAtv8nPr0dRg5Jior iZTXO8RrEzPe/hMUOFQLZWSfcc2IpmzEi7ya9he6Tw4B9rqF+NhVKbC8U11g2woVCjvb hYS2a6qKdfBpqi6+gB4EWMalZt5gamBpQ03NaBigsv7bSpb3O28UQVGGYIJc079ZaXQh 204x5jCJtvaW1pc0H+STHkCdrYUUh3XOBW2bSayw3cVAe47YDdBEjd2Rm6K2pDtJzGwc We4xVv/XFtOay1pOVUo4+e+6mDWXtErK0aszTgOuNpGr8s2i8fhSGacvTGpyoazvsZca dGHg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oxp2qItKxyvIxvIPqZSW9JotSdGmvWXvGA1HWz5sGLE=; b=GxoQDgBPPWCskWx+/fssL0QcxrMe2KxEg8SLtiJi0PozGWYGg3rICD7TITkv7BHsxo CLS0Bkg5c1ZAW9qZnfz+xXS3Bl37cRL17rn++f9cJbQMxIr65ffB6vKqfxXydCNd451+ vt3Tfotb02UuW/oEbPyi44ulutUoPCSMWeoirHhlM8gPwaV4YF6jY7XL+FkMpVHWqE9v 0g6ARKtGRLRO7zoIJWPRf1KrdBXwKjgN2FlieNnbN+5b19JFrKyD5PhHmOIggGb+MbrA jRWU52PqlpYlDOmFV+e5ixT589151fG/T1nnYBbDtcJoUYjqKhCKNEcZkAajin2Ks28G BzPA== X-Gm-Message-State: ACrzQf0drhSixng16ZiZDoWxqwSg2beu1sWB+2iwwm3mk7aUWjRxxbCS xA366a0jWGUvSnZ3aWejDSSXF6sTMTMrmQ== X-Google-Smtp-Source: AMsMyM7D3g5fEzwv2tEmKPe3BeKOmursidhKjDy3vCmjhKbU93ot3fM4ZNg22SOTDvv4gvD7jsB+ow== X-Received: by 2002:a62:e20e:0:b0:56c:6ec1:1f1e with SMTP id a14-20020a62e20e000000b0056c6ec11f1emr1345316pfi.7.1668036300896; Wed, 09 Nov 2022 15:25:00 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id y28-20020aa79e1c000000b0056e15b7138esm8798645pfq.157.2022.11.09.15.24.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 15:25:00 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Aman Singh , Yuying Zhang Subject: [PATCH v3 05/14] testpmd: fix whitespace Date: Wed, 9 Nov 2022 15:24:42 -0800 Message-Id: <20221109232451.265059-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221109232451.265059-1-stephen@networkplumber.org> References: <20221109191445.140320-1-stephen@networkplumber.org> <20221109232451.265059-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add space after keywords. Signed-off-by: Stephen Hemminger Reviewed-by: Yuying Zhang --- app/test-pmd/cmdline.c | 31 ++++++++++++++++--------------- app/test-pmd/parameters.c | 10 ++++++---- app/test-pmd/testpmd.c | 2 +- 3 files changed, 23 insertions(+), 20 deletions(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index 8dc60e938830..7721006cc310 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -2730,11 +2730,12 @@ parse_reta_config(const char *str, while ((p = strchr(p0,'(')) != NULL) { ++p; - if((p0 = strchr(p,')')) == NULL) + p0 = strchr(p, ')'); + if (p0 == NULL) return -1; size = p0 - p; - if(size >= sizeof(s)) + if (size >= sizeof(s)) return -1; snprintf(s, sizeof(s), "%.*s", size, p); @@ -3242,15 +3243,15 @@ cmd_config_thresh_parsed(void *parsed_result, if (!strcmp(res->name, "txpt")) tx_pthresh = res->value; - else if(!strcmp(res->name, "txht")) + else if (!strcmp(res->name, "txht")) tx_hthresh = res->value; - else if(!strcmp(res->name, "txwt")) + else if (!strcmp(res->name, "txwt")) tx_wthresh = res->value; - else if(!strcmp(res->name, "rxpt")) + else if (!strcmp(res->name, "rxpt")) rx_pthresh = res->value; - else if(!strcmp(res->name, "rxht")) + else if (!strcmp(res->name, "rxht")) rx_hthresh = res->value; - else if(!strcmp(res->name, "rxwt")) + else if (!strcmp(res->name, "rxwt")) rx_wthresh = res->value; else { fprintf(stderr, "Unknown parameter\n"); @@ -4088,8 +4089,8 @@ cmd_vlan_offload_parsed(void *parsed_result, len = strnlen(str, STR_TOKEN_SIZE); i = 0; /* Get port_id first */ - while(i < len){ - if(str[i] == ',') + while (i < len) { + if (str[i] == ',') break; i++; @@ -4097,7 +4098,7 @@ cmd_vlan_offload_parsed(void *parsed_result, str[i]='\0'; tmp = strtoul(str, NULL, 0); /* If port_id greater that what portid_t can represent, return */ - if(tmp >= RTE_MAX_ETHPORTS) + if (tmp >= RTE_MAX_ETHPORTS) return; port_id = (portid_t)tmp; @@ -4108,17 +4109,17 @@ cmd_vlan_offload_parsed(void *parsed_result, if (!strcmp(res->what, "strip")) rx_vlan_strip_set(port_id, on); - else if(!strcmp(res->what, "stripq")){ + else if (!strcmp(res->what, "stripq")) { uint16_t queue_id = 0; /* No queue_id, return */ - if(i + 1 >= len) { + if (i + 1 >= len) { fprintf(stderr, "must specify (port,queue_id)\n"); return; } tmp = strtoul(str + i + 1, NULL, 0); /* If queue_id greater that what 16-bits can represent, return */ - if(tmp > 0xffff) + if (tmp > 0xffff) return; queue_id = (uint16_t)tmp; @@ -7207,7 +7208,7 @@ static void cmd_mac_addr_parsed(void *parsed_result, ret = rte_eth_dev_mac_addr_remove(res->port_num, &res->address); /* check the return value and print it if is < 0 */ - if(ret < 0) + if (ret < 0) fprintf(stderr, "mac_addr_cmd error: (%s)\n", strerror(-ret)); } @@ -7780,7 +7781,7 @@ static void cmd_vf_mac_addr_parsed(void *parsed_result, res->vf_num); #endif - if(ret < 0) + if (ret < 0) fprintf(stderr, "vf_mac_addr_cmd error: (%s)\n", strerror(-ret)); } diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c index aed4cdcb8485..7fc6d91f0210 100644 --- a/app/test-pmd/parameters.c +++ b/app/test-pmd/parameters.c @@ -306,11 +306,12 @@ parse_portnuma_config(const char *q_arg) /* reset from value set at definition */ while ((p = strchr(p0,'(')) != NULL) { ++p; - if((p0 = strchr(p,')')) == NULL) + p0 = strchr(p, ')'); + if (p0 == NULL) return -1; size = p0 - p; - if(size >= sizeof(s)) + if (size >= sizeof(s)) return -1; snprintf(s, sizeof(s), "%.*s", size, p); @@ -366,11 +367,12 @@ parse_ringnuma_config(const char *q_arg) /* reset from value set at definition */ while ((p = strchr(p0,'(')) != NULL) { ++p; - if((p0 = strchr(p,')')) == NULL) + p0 = strchr(p, ')'); + if (p0 == NULL) return -1; size = p0 - p; - if(size >= sizeof(s)) + if (size >= sizeof(s)) return -1; snprintf(s, sizeof(s), "%.*s", size, p); diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index aa7ea29f15ba..04b078a2938b 100644 --- a/app/test-pmd/testpmd.c +++ b/app/test-pmd/testpmd.c @@ -2406,7 +2406,7 @@ start_packet_forwarding(int with_tx_first) test_done = 0; - if(!no_flush_rx) + if (!no_flush_rx) flush_fwd_rx_queues(); rxtx_config_display(); From patchwork Wed Nov 9 23:24:43 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 119675 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 30C17A0093; Thu, 10 Nov 2022 00:25:31 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A3E0C42D1A; Thu, 10 Nov 2022 00:25:05 +0100 (CET) Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) by mails.dpdk.org (Postfix) with ESMTP id 6F3D642D28 for ; Thu, 10 Nov 2022 00:25:03 +0100 (CET) Received: by mail-pg1-f175.google.com with SMTP id s196so80338pgs.3 for ; Wed, 09 Nov 2022 15:25:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jaqiKZoizeaDGGr33j8SN5T+FVUNLf7AMm2N5TeF/8k=; b=AGXvNy/kqesdxZLwhadPGmPTfcBXY/W9/J1T/GbKcpXJFq8koQX9T0nl4uyE00PQJk vxh3IEQQI7mSsfWwDFAG+J3v3piqSEnXr015TOy9MLEzDnJMNHwW55vXZPsh/0YD8gN7 aWmjLIfRrfIyNrpFzgalYjKAYV19ZEtT/A/WYiY7MiK6tyqDvbD5DZynyIyY9UpEmlcq 1ytvQQL9l7UQ12oEdQS6D9WY4WmZqPWKk6L72r1pduBau4Tioy1ZmpP3n1oFl2YZ0wGG EEzwJ+pD/Ulmf1opknTXtH+5XX1WrmGmrebYHJ1oqCTBuh291vZCf+2kCNQUt9q/dRel T1JA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jaqiKZoizeaDGGr33j8SN5T+FVUNLf7AMm2N5TeF/8k=; b=UOuZWVcNa8j8AGiI0X7bYKEEKPHLVz4vawy/arNFtIUaOZRceuk2jhS1G4Ollg9q0l 9zLAi2bg/vyhMDZVjZPBzTl6Tz53KuBe9KBNDO5kT2IXNqL72JzDOZ4Sqx4bQAh915pC 4dVdeTdYXijLdrbRdig1CsmtcmCtGk2UY0CHw9bK0l3LKJvBdnGbe00QfDLOCdnMYTdx q+lxCTCmUEbNw1Yjs95tIea+/2Q9wQ+XLVAwK1rVScSwrPG+mMEoQpmg0cEQHrYo140v vMi6bcJmxX2m/vMp8gtbiXdIwBXI+ykSxk7HaOlYJnOFdY3nAwcO+YUdFznt/JJ8vUsd PdtQ== X-Gm-Message-State: ACrzQf0zpLRXAPbGD+n1Zf8/f+pJvYPd/80LAT6Be1gJXW3AZVxbkXcP OWlMzvdFsHF5d7KDjUJvwuEXk4/PFwkYyA== X-Google-Smtp-Source: AMsMyM7JpQCS0bDwTODgAV9X3WeSosTJ1SPjIQTadcl7zi9P8Y0Fj/Smn+Dlv74yjdpQnbgTPKQmAQ== X-Received: by 2002:a05:6a00:72d:b0:56b:d027:214 with SMTP id 13-20020a056a00072d00b0056bd0270214mr1325214pfm.79.1668036302212; Wed, 09 Nov 2022 15:25:02 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id y28-20020aa79e1c000000b0056e15b7138esm8798645pfq.157.2022.11.09.15.25.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 15:25:01 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Olivier Matz , Yipeng Wang , Sameh Gobriel , Bruce Richardson , Vladimir Medvedkin , Anatoly Burakov , Honnappa Nagarahalli , Konstantin Ananyev Subject: [PATCH v3 06/14] test: fix whitespace Date: Wed, 9 Nov 2022 15:24:43 -0800 Message-Id: <20221109232451.265059-7-stephen@networkplumber.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221109232451.265059-1-stephen@networkplumber.org> References: <20221109191445.140320-1-stephen@networkplumber.org> <20221109232451.265059-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add space after keywords. Signed-off-by: Stephen Hemminger --- app/test/test_cmdline_cirbuf.c | 4 ++-- app/test/test_debug.c | 4 ++-- app/test/test_hash.c | 6 +++--- app/test/test_lpm6_perf.c | 2 +- app/test/test_malloc.c | 14 +++++++------- app/test/test_mbuf.c | 14 ++++++-------- app/test/test_ring_perf.c | 2 +- app/test/test_spinlock.c | 2 +- 8 files changed, 23 insertions(+), 25 deletions(-) diff --git a/app/test/test_cmdline_cirbuf.c b/app/test/test_cmdline_cirbuf.c index 8ac326cb02e0..6f7aae6df59a 100644 --- a/app/test/test_cmdline_cirbuf.c +++ b/app/test/test_cmdline_cirbuf.c @@ -708,7 +708,7 @@ test_cirbuf_char_fill(void) return -1; } /* delete buffer from tail */ - for(i = 0; i < CMDLINE_TEST_BUFSIZE; i++) + for (i = 0; i < CMDLINE_TEST_BUFSIZE; i++) cirbuf_del_tail_safe(&cb); /* try to delete from an empty buffer */ if (cirbuf_del_tail_safe(&cb) >= 0) { @@ -737,7 +737,7 @@ test_cirbuf_char_fill(void) return -1; } /* delete buffer from head */ - for(i = 0; i < CMDLINE_TEST_BUFSIZE; i++) + for (i = 0; i < CMDLINE_TEST_BUFSIZE; i++) cirbuf_del_head_safe(&cb); /* try to delete from an empty buffer */ if (cirbuf_del_head_safe(&cb) >= 0) { diff --git a/app/test/test_debug.c b/app/test/test_debug.c index 2704f5b92726..28fc2180e2b0 100644 --- a/app/test/test_debug.c +++ b/app/test/test_debug.c @@ -53,7 +53,7 @@ test_panic(void) return -1; } wait(&status); - if(status == 0){ + if (status == 0) { printf("Child process terminated normally!\n"); return -1; } else @@ -84,7 +84,7 @@ test_exit_val(int exit_val) } wait(&status); printf("Child process status: %d\n", status); - if(!WIFEXITED(status) || WEXITSTATUS(status) != (uint8_t)exit_val){ + if (!WIFEXITED(status) || WEXITSTATUS(status) != (uint8_t)exit_val) { printf("Child process terminated with incorrect status (expected = %d)!\n", exit_val); return -1; diff --git a/app/test/test_hash.c b/app/test/test_hash.c index 3e45afaa67fc..35d9d8a62ef8 100644 --- a/app/test/test_hash.c +++ b/app/test/test_hash.c @@ -724,12 +724,12 @@ static int test_five_keys(void) } /* Lookup */ - for(i = 0; i < 5; i++) + for (i = 0; i < 5; i++) key_array[i] = &keys[i]; ret = rte_hash_lookup_bulk(handle, &key_array[0], 5, (int32_t *)pos); - if(ret == 0) - for(i = 0; i < 5; i++) { + if (ret == 0) + for (i = 0; i < 5; i++) { print_key_info("Lkp", key_array[i], pos[i]); RETURN_IF_ERROR(pos[i] != expected_pos[i], "failed to find key (pos[%u]=%d)", i, pos[i]); diff --git a/app/test/test_lpm6_perf.c b/app/test/test_lpm6_perf.c index aaf2773b6fac..2f9321345e4b 100644 --- a/app/test/test_lpm6_perf.c +++ b/app/test/test_lpm6_perf.c @@ -47,7 +47,7 @@ print_route_distribution(const struct rules_tbl_entry *table, uint32_t n) printf("--------------------------- \n"); /* Count depths. */ - for(i = 1; i <= 128; i++) { + for (i = 1; i <= 128; i++) { unsigned depth_counter = 0; double percent_hits; diff --git a/app/test/test_malloc.c b/app/test/test_malloc.c index de40e506113a..8d3750a3f1f0 100644 --- a/app/test/test_malloc.c +++ b/app/test/test_malloc.c @@ -86,8 +86,8 @@ test_align_overlap_per_lcore(__rte_unused void *arg) ret = -1; break; } - for(j = 0; j < 1000 ; j++) { - if( *(char *)p1 != 0) { + for (j = 0; j < 1000 ; j++) { + if (*(char *)p1 != 0) { printf("rte_zmalloc didn't zero the allocated memory\n"); ret = -1; } @@ -157,8 +157,8 @@ test_reordered_free_per_lcore(__rte_unused void *arg) ret = -1; break; } - for(j = 0; j < 1000 ; j++) { - if( *(char *)p1 != 0) { + for (j = 0; j < 1000 ; j++) { + if (*(char *)p1 != 0) { printf("rte_zmalloc didn't zero the allocated memory\n"); ret = -1; } @@ -331,12 +331,12 @@ test_multi_alloc_statistics(void) /* After freeing both allocations check stats return to original */ rte_malloc_get_socket_stats(socket, &post_stats); - if(second_stats.heap_totalsz_bytes != first_stats.heap_totalsz_bytes) { + if (second_stats.heap_totalsz_bytes != first_stats.heap_totalsz_bytes) { printf("Incorrect heap statistics: Total size \n"); return -1; } /* Check allocated size is equal to two additions plus overhead */ - if(second_stats.heap_allocsz_bytes != + if (second_stats.heap_allocsz_bytes != size + overhead + first_stats.heap_allocsz_bytes) { printf("Incorrect heap statistics: Allocated size \n"); return -1; @@ -495,7 +495,7 @@ test_realloc_socket(int socket) return -1; } /* calc an alignment we don't already have */ - while(RTE_PTR_ALIGN(ptr7, new_align) == ptr7) + while (RTE_PTR_ALIGN(ptr7, new_align) == ptr7) new_align *= 2; char *ptr8 = rte_realloc_socket(ptr7, size7, new_align, socket); if (!ptr8){ diff --git a/app/test/test_mbuf.c b/app/test/test_mbuf.c index 53fe898a384c..fceacb8fead8 100644 --- a/app/test/test_mbuf.c +++ b/app/test/test_mbuf.c @@ -120,7 +120,7 @@ static unsigned refcnt_lcore[RTE_MAX_LCORE]; printf("mbuf test FAILED (l.%d): <" str ">\n", \ __LINE__, ##__VA_ARGS__); \ goto fail; \ -} while(0) +} while (0) /* * test data manipulation in mbuf with non-ascii data @@ -154,9 +154,7 @@ test_pktmbuf_with_non_ascii_data(struct rte_mempool *pktmbuf_pool) return 0; fail: - if(m) { - rte_pktmbuf_free(m); - } + rte_pktmbuf_free(m); return -1; } @@ -701,12 +699,12 @@ test_pktmbuf_pool(struct rte_mempool *pktmbuf_pool) } struct rte_mbuf *extra = NULL; extra = rte_pktmbuf_alloc(pktmbuf_pool); - if(extra != NULL) { + if (extra != NULL) { printf("Error pool not empty"); ret = -1; } extra = rte_pktmbuf_clone(m[0], pktmbuf_pool); - if(extra != NULL) { + if (extra != NULL) { printf("Error pool not empty"); ret = -1; } @@ -966,7 +964,7 @@ test_pktmbuf_free_segment(struct rte_mempool *pktmbuf_pool) struct rte_mbuf *mb, *mt; mb = m[i]; - while(mb != NULL) { + while (mb != NULL) { mt = mb; mb = mb->next; rte_pktmbuf_free_seg(mt); @@ -1195,7 +1193,7 @@ verify_mbuf_check_panics(struct rte_mbuf *buf) return -1; } wait(&status); - if(status == 0) + if (status == 0) return -1; return 0; diff --git a/app/test/test_ring_perf.c b/app/test/test_ring_perf.c index 2d8bb675a331..4cac9a94a73c 100644 --- a/app/test/test_ring_perf.c +++ b/app/test/test_ring_perf.c @@ -190,7 +190,7 @@ enqueue_dequeue_bulk_helper(const unsigned int flag, const int esize, #else if (__sync_add_and_fetch(&lcore_count, 1) != 2) #endif - while(lcore_count != 2) + while (lcore_count != 2) rte_pause(); burst = test_ring_calloc(MAX_BURST, esize); diff --git a/app/test/test_spinlock.c b/app/test/test_spinlock.c index 3f59372300c3..3ee82fa963a5 100644 --- a/app/test/test_spinlock.c +++ b/app/test/test_spinlock.c @@ -237,7 +237,7 @@ test_spinlock(void) /* * Try to acquire a lock that we already own */ - if(!rte_spinlock_recursive_trylock(&slr)) { + if (!rte_spinlock_recursive_trylock(&slr)) { printf("rte_spinlock_recursive_trylock failed on a lock that " "we already own\n"); ret = -1; From patchwork Wed Nov 9 23:24:44 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 119676 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 633D1A0093; Thu, 10 Nov 2022 00:25:36 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9861142D35; Thu, 10 Nov 2022 00:25:06 +0100 (CET) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mails.dpdk.org (Postfix) with ESMTP id 4038F42D2F for ; Thu, 10 Nov 2022 00:25:04 +0100 (CET) Received: by mail-pl1-f171.google.com with SMTP id p12so122738plq.4 for ; Wed, 09 Nov 2022 15:25:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=wLjwMcQ+6jQ30MfWWaa/DgHNusXeisAmQFqUqHTuZzo=; b=uFwNfkowd9OUy8BHcoDxeyS3pRM0H8wNuNfaKbt9FlajlmXEhqBQmOxhYL0v8RI9NS GA931H6OpHwMGIUUQyD550UBYIH5Lhe0HeilZxp2YWnUa5s9nAOUPvcNMVgMcKiawgUG oLhrkz8dhEYAKelrr4qrWWGNjONCCmpIDhhEdlJ90Zl7hZhXYARQNolLif4vRnLXqwxk Ny5s3sRRI4N2yP5L9Wjfax+UhZ/e1twmVMdLjo8QXyLunnBjNOA/eD2wRl/selM2qOIz SW/vQtcdsryMAMGTSBE8bBfADRdw77qBOY5rDEgxREUb2U9DA2PBgn2kEo1dxmUYC/2b Pmpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wLjwMcQ+6jQ30MfWWaa/DgHNusXeisAmQFqUqHTuZzo=; b=TlDrU91DCTVVAyxBYFda7g6Tsqp24aNchFL0aAJ7cGEtQD8/v/AN5kb04I3cQ/rNls 39UzpumYBvLUEUstlkJLBuR358sKcVnowoOTKbPi/V0k2F9pu7OPdPr0hAJ55of6SVEh weA9TERLWuCYp/BlZ58XgbTTU+N2ydjyt2M8cWUdrVxxE0LaN6WZlVRja8+UBm8+H/zi anlQnsYtrhRIVdC1yEkDn5Vrp5ns87PnNGimOvv2zdxFzaN4ulZm6Skv8vWkc3/SDMRG x92MVNGYNr2GmP8xG+BVdPY8Z1pu6N/uK5CAcxtou+h9r78QiYz6+OfwnldAYIg5PZah lBxQ== X-Gm-Message-State: ACrzQf1o+LG0Y+kjw/EDtCKeXxkTTgGG1ve7bgVMzH8hrXJzQt92obz2 a263v0z+JjlEtxIUtT6FLml7tOpTLif3vw== X-Google-Smtp-Source: AMsMyM4Gk65IdVgsbkZdm6urSV6A/J4XjOSmGmNbZ83XuStFDt5oJqh9XqmNHa6ZoqlN5w/o5skZMw== X-Received: by 2002:a17:902:aa44:b0:186:7a6b:7bbd with SMTP id c4-20020a170902aa4400b001867a6b7bbdmr63765725plr.78.1668036303393; Wed, 09 Nov 2022 15:25:03 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id y28-20020aa79e1c000000b0056e15b7138esm8798645pfq.157.2022.11.09.15.25.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 15:25:02 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Cristian Dumitrescu Subject: [PATCH v3 07/14] examples/qos_sched: fix whitespace Date: Wed, 9 Nov 2022 15:24:44 -0800 Message-Id: <20221109232451.265059-8-stephen@networkplumber.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221109232451.265059-1-stephen@networkplumber.org> References: <20221109191445.140320-1-stephen@networkplumber.org> <20221109232451.265059-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add space after keywords. Acked-by: Cristian Dumitrescu Signed-off-by: Stephen Hemminger --- examples/qos_sched/app_thread.c | 6 +++--- examples/qos_sched/args.c | 2 +- examples/qos_sched/init.c | 2 +- examples/qos_sched/main.c | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/examples/qos_sched/app_thread.c b/examples/qos_sched/app_thread.c index dbc878b55394..a49356fecf5f 100644 --- a/examples/qos_sched/app_thread.c +++ b/examples/qos_sched/app_thread.c @@ -79,7 +79,7 @@ app_rx_thread(struct thread_conf **confs) if (likely(nb_rx != 0)) { APP_STATS_ADD(conf->stat.nb_rx, nb_rx); - for(i = 0; i < nb_rx; i++) { + for (i = 0; i < nb_rx; i++) { get_pkt_sched(rx_mbufs[i], &subport, &pipe, &traffic_class, &queue, &color); rte_sched_port_pkt_write(conf->sched_port, @@ -91,7 +91,7 @@ app_rx_thread(struct thread_conf **confs) if (unlikely(rte_ring_sp_enqueue_bulk(conf->rx_ring, (void **)rx_mbufs, nb_rx, NULL) == 0)) { - for(i = 0; i < nb_rx; i++) { + for (i = 0; i < nb_rx; i++) { rte_pktmbuf_free(rx_mbufs[i]); APP_STATS_ADD(conf->stat.nb_drop, 1); @@ -137,7 +137,7 @@ app_send_packets(struct thread_conf *qconf, struct rte_mbuf **mbufs, uint32_t nb uint32_t i, len; len = qconf->n_mbufs; - for(i = 0; i < nb_pkt; i++) { + for (i = 0; i < nb_pkt; i++) { qconf->m_table[len] = mbufs[i]; len++; /* enough pkts to be sent */ diff --git a/examples/qos_sched/args.c b/examples/qos_sched/args.c index b2959499ae9a..b752eb221f7c 100644 --- a/examples/qos_sched/args.c +++ b/examples/qos_sched/args.c @@ -451,7 +451,7 @@ app_parse_args(int argc, char **argv) /* sanity check for cores assignment */ nb_lcores = app_cpu_core_count(); - for(i = 0; i < nb_pfc; i++) { + for (i = 0; i < nb_pfc; i++) { if (qos_conf[i].rx_core >= nb_lcores) { RTE_LOG(ERR, APP, "pfc %u: invalid RX lcore index %u\n", i + 1, qos_conf[i].rx_core); diff --git a/examples/qos_sched/init.c b/examples/qos_sched/init.c index 0709aec10c31..41b46b296298 100644 --- a/examples/qos_sched/init.c +++ b/examples/qos_sched/init.c @@ -323,7 +323,7 @@ int app_init(void) rte_exit(EXIT_FAILURE, "Invalid configuration profile\n"); /* Initialize each active flow */ - for(i = 0; i < nb_pfc; i++) { + for (i = 0; i < nb_pfc; i++) { uint32_t socket = rte_lcore_to_socket_id(qos_conf[i].rx_core); struct rte_ring *ring; diff --git a/examples/qos_sched/main.c b/examples/qos_sched/main.c index dc6a17a6464a..7b757df0eb02 100644 --- a/examples/qos_sched/main.c +++ b/examples/qos_sched/main.c @@ -152,7 +152,7 @@ app_stat(void) static struct rte_eth_stats tx_stats[MAX_DATA_STREAMS]; /* print statistics */ - for(i = 0; i < nb_pfc; i++) { + for (i = 0; i < nb_pfc; i++) { struct flow_conf *flow = &qos_conf[i]; rte_eth_stats_get(flow->rx_port, &stats); @@ -212,7 +212,7 @@ main(int argc, char **argv) } else { /* print statistics every second */ - while(1) { + while (1) { sleep(1); app_stat(); } From patchwork Wed Nov 9 23:24:45 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 119677 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3AB18A0093; Thu, 10 Nov 2022 00:25:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 777FB42D39; Thu, 10 Nov 2022 00:25:07 +0100 (CET) Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) by mails.dpdk.org (Postfix) with ESMTP id C22D242D27 for ; Thu, 10 Nov 2022 00:25:05 +0100 (CET) Received: by mail-pf1-f175.google.com with SMTP id g62so152878pfb.10 for ; Wed, 09 Nov 2022 15:25:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Fat4VHQS9w/vcwAC17NvSroEuvXWz2GMEehRoOVj/wM=; b=n+eViEPl5jNtgaYm6WPYKEMC1UrvqM99EJQSO1o+y89ary3DUBKamMVAQtPO9Y7LXt lRclCn3Lpk40D36N4QB6TeneDaDdl7f8utohNUVCIBrYOnxnLuIqpWiZX+QyA5AOgNX5 ol9KlW/3XlCV37vTJAGCzcrtEglNMIkYCS4Z8DF7OGnwFYcB30GAWKZmABpe7S2yed9G BjmxVJd2I5RiqB1lcOF4nNeOVANvFGhp0uGLk3D/RoKh8ezjwTjoLXrs1sNRFTJA9oU2 ExQO9TVD0Y6L+qLi+urRPEPJQj5Yr/F+ye09DtQRAia5Zmkbmc2J88uQFytO0N6v7yk/ yosw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Fat4VHQS9w/vcwAC17NvSroEuvXWz2GMEehRoOVj/wM=; b=pO394AZian2yyo2mdMNtCPNQ7gCduPyv5SDlg57FmfQP4cS2VDJzQ5RYY9iN6tZTAo YG2ycaoufDuKEWPGyh+dl6bQ+hgw0sf7qmWE4b4IWC69VsQicyiqygpgla/av1I4E8GR rriqVES7ogFpoVDt057ZEp/YU+S1VuxySHWrNMHWKrFrMnPX2+ih/j/0te1XWHJP+gFU hj3CF3kn9vJWn5nWQWm5tfvMONRE9SOOUkHB7Uq8zbRTecrsQtsQKPVX1yqn5DK1RpGI 1en8s84ZaP1Ahn09TeNmt36lzZdZWIfW+w90sXQl9h5mgrfUd3Xg1ad9eRSrG/FWnErh mZ0Q== X-Gm-Message-State: ACrzQf2FjXjKUXiCyJEEyFlzQi9vXG5BIqwKWFb1Vw0F54SFXCb06u+E KKor1leHAxjaB/0daXE7dNaAtTarW6XLig== X-Google-Smtp-Source: AMsMyM6b7kuLE2TsaYj8pN9hQkiQKz66/PZZ/VHqQYkKCqyIEY0QRh5YGPKNtf4a7V7amjI7Rs7AlA== X-Received: by 2002:a63:305:0:b0:470:15cd:d428 with SMTP id 5-20020a630305000000b0047015cdd428mr1130549pgd.213.1668036304702; Wed, 09 Nov 2022 15:25:04 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id y28-20020aa79e1c000000b0056e15b7138esm8798645pfq.157.2022.11.09.15.25.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 15:25:04 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Maxime Coquelin , Chenbo Xia Subject: [PATCH v3 08/14] examples/vhost: fix whitespace Date: Wed, 9 Nov 2022 15:24:45 -0800 Message-Id: <20221109232451.265059-9-stephen@networkplumber.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221109232451.265059-1-stephen@networkplumber.org> References: <20221109191445.140320-1-stephen@networkplumber.org> <20221109232451.265059-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add space after keywords. Signed-off-by: Stephen Hemminger Reviewed-by: Chenbo Xia --- examples/vhost/main.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/examples/vhost/main.c b/examples/vhost/main.c index 42e53a0f9a4f..9fee966916e9 100644 --- a/examples/vhost/main.c +++ b/examples/vhost/main.c @@ -1491,7 +1491,7 @@ switch_worker(void *arg __rte_unused) } } - while(1) { + while (1) { drain_mbuf_table(tx_q); drain_vhost_table(); /* @@ -1583,9 +1583,8 @@ destroy_device(int vid) return; /*set the remove flag. */ vdev->remove = 1; - while(vdev->ready != DEVICE_SAFE_REMOVE) { + while (vdev->ready != DEVICE_SAFE_REMOVE) rte_pause(); - } for (i = 0; i < RTE_MAX_LCORE; i++) rte_free(vhost_txbuff[i * RTE_MAX_VHOST_DEVICE + vid]); @@ -1816,7 +1815,7 @@ print_stats(__rte_unused void *arg) const char clr[] = { 27, '[', '2', 'J', '\0' }; const char top_left[] = { 27, '[', '1', ';', '1', 'H','\0' }; - while(1) { + while (1) { sleep(enable_stats); /* Clear screen and move to top left */ From patchwork Wed Nov 9 23:24:46 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 119678 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 46BE0A0093; Thu, 10 Nov 2022 00:25:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 720E142D41; Thu, 10 Nov 2022 00:25:08 +0100 (CET) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mails.dpdk.org (Postfix) with ESMTP id 2BF2A42D39 for ; Thu, 10 Nov 2022 00:25:07 +0100 (CET) Received: by mail-pl1-f171.google.com with SMTP id p21so109516plr.7 for ; Wed, 09 Nov 2022 15:25:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nhhXnLkYkG4mHGRUf5HbpuwBHEi398crtA4UbeAB6VE=; b=S/o94p73cwAR5sIZd8IiIvjGDzem9jaSRHJKzoibCYsbedZ4rGRZpJssQT3YME8MTI u3iL9CMJRaChSzyj5OcIzcFYxdR7YwadQ93gOBafnflZ4cXkhcBixzNE7ERmQoajy94l rY99yktR5VgFT/v3fklVmnnCB4y3NsOmnmZn66hxFXj1ezDMTW1GI9T5OZzqy2mKwsG0 iiulRfIiJQWRHl6wwnR7DSnL5bkJWfMjCVGmkrimVy789L3F/CTphfq7C/unpbjEDdaE 8j5cbSmbHohRQekoNFVIn1d+m+rt3palTacCbOnx4lSGZl75M36mVKbScNulWwd5+GdX ut6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nhhXnLkYkG4mHGRUf5HbpuwBHEi398crtA4UbeAB6VE=; b=vXLKb1bqmHXM22V3kg8CuBx1c2Og0KhTv8W+IS7DubflypNpeZchCNnMySF58xTPtH YJUt8bcjK3CqJVWZlhqIZiJ0/X5VduOyklVmQJA1dGJdnLE5ZxgKhmQICd7GGb1St20w H6BPdy8kpYZQ/pmGpfXshLLSGFdcQwAomA9Vka/z6Et53cBCc2qfnTeSxyuPQ1LssH4L VvRZAIcvu0iQ/4Sf3mpRNQQZPq9cdNomB8Hr3ZwAhjiP6u6pvLmcY0X/wfLhEf24Qme2 Wc5Fo6njJaDKxxyHATnSaB304R2EAC1GyfPWOZQXcuUxvgmQ5R3woU7GcbzN8Yixpy8Q Ag1w== X-Gm-Message-State: ACrzQf3qDxVygWmyygkgIRlFMzOGuKJpnIuP2bbWlnxXjqthPbulY+L0 3XspMfP2Vr3IAmYxNWH+t9ouJvB4peNoPw== X-Google-Smtp-Source: AMsMyM6WxN5H4pAp21zg70g+LIjrkMTuxDeBh2ITkF/fAZCzhktCdRSHuEEhoBckJAzFSFLgD0YDYA== X-Received: by 2002:a17:902:ef4d:b0:181:98d1:69c0 with SMTP id e13-20020a170902ef4d00b0018198d169c0mr64465773plx.45.1668036306091; Wed, 09 Nov 2022 15:25:06 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id y28-20020aa79e1c000000b0056e15b7138esm8798645pfq.157.2022.11.09.15.25.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 15:25:05 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , David Hunt Subject: [PATCH v3 09/14] l3fwd: fix whitespace Date: Wed, 9 Nov 2022 15:24:46 -0800 Message-Id: <20221109232451.265059-10-stephen@networkplumber.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221109232451.265059-1-stephen@networkplumber.org> References: <20221109191445.140320-1-stephen@networkplumber.org> <20221109232451.265059-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add space after keywords. Signed-off-by: Stephen Hemminger --- examples/l3fwd-power/main.c | 7 ++++--- examples/l3fwd/main.c | 7 ++++--- 2 files changed, 8 insertions(+), 6 deletions(-) diff --git a/examples/l3fwd-power/main.c b/examples/l3fwd-power/main.c index fd3ade330f82..7bd5d8cb2281 100644 --- a/examples/l3fwd-power/main.c +++ b/examples/l3fwd-power/main.c @@ -1787,11 +1787,12 @@ parse_config(const char *q_arg) while ((p = strchr(p0,'(')) != NULL) { ++p; - if((p0 = strchr(p,')')) == NULL) + p0 = strchr(p, ')'); + if (p0 == NULL) return -1; size = p0 - p; - if(size >= sizeof(s)) + if (size >= sizeof(s)) return -1; snprintf(s, sizeof(s), "%.*s", size, p); @@ -2946,7 +2947,7 @@ main(int argc, char **argv) fflush(stdout); /* init RX queues */ - for(queue = 0; queue < qconf->n_rx_queue; ++queue) { + for (queue = 0; queue < qconf->n_rx_queue; ++queue) { struct rte_eth_rxconf rxq_conf; portid = qconf->rx_queue_list[queue].port_id; diff --git a/examples/l3fwd/main.c b/examples/l3fwd/main.c index 5198ff30dd00..2b8575137d50 100644 --- a/examples/l3fwd/main.c +++ b/examples/l3fwd/main.c @@ -516,11 +516,12 @@ parse_config(const char *q_arg) while ((p = strchr(p0,'(')) != NULL) { ++p; - if((p0 = strchr(p,')')) == NULL) + p0 = strchr(p, ')'); + if (p0 == NULL) return -1; size = p0 - p; - if(size >= sizeof(s)) + if (size >= sizeof(s)) return -1; snprintf(s, sizeof(s), "%.*s", size, p); @@ -1366,7 +1367,7 @@ l3fwd_poll_resource_setup(void) printf("\nInitializing rx queues on lcore %u ... ", lcore_id ); fflush(stdout); /* init RX queues */ - for(queue = 0; queue < qconf->n_rx_queue; ++queue) { + for (queue = 0; queue < qconf->n_rx_queue; ++queue) { struct rte_eth_rxconf rxq_conf; portid = qconf->rx_queue_list[queue].port_id; From patchwork Wed Nov 9 23:24:47 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 119679 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B31FEA0093; Thu, 10 Nov 2022 00:25:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 33EB942D4D; Thu, 10 Nov 2022 00:25:10 +0100 (CET) Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by mails.dpdk.org (Postfix) with ESMTP id 6AEF042D3E for ; Thu, 10 Nov 2022 00:25:08 +0100 (CET) Received: by mail-pj1-f43.google.com with SMTP id l6so305010pjj.0 for ; Wed, 09 Nov 2022 15:25:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/QhJhFhZiPiDsPwY2VTvBHBSaly3Zeo3SiVUnEcBcCg=; b=LbnEILbti2qbtKfgVnwwwKBd5qv6IWoKKDqncfDN5v4JuLlvdRGF8QeFELt7RP2fDv n+i4eKgOmAq/+oejhMSmhe5BhKcKfanM6BzP3zlMyA48gXLsla3f2gzQbvv0oVSTJP7E UT/UXLVXnNLKK3/k1sGk4GRUWJutilOa1jQkAiRi2qQ5PxVKydZ9dkRTSA/OymufBByR Sl4NdlDF4lO9kVih+mTq7fuD6FTc8eUMyo+mz705kupsfXmf9fL0laWLk20BAqunbLz3 ofDjmw5QNFVUxKMf8kQpUWqW8rOOAtu2k6XIUvqKEmjGjL5NwJI4jRt6wsnllmr0zQP3 Qt7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/QhJhFhZiPiDsPwY2VTvBHBSaly3Zeo3SiVUnEcBcCg=; b=768mlp6+MMFQKHZOZ7dypVCOX3aqJKFwTGlfndKs+4qfHEW7+hjc4hKcd3iCBEZCKK LUkEUa4j+dMHMjtSUgEPNN6wq7tzC0Ld5o5gdm2SwTVLhfnUDtwhZkkX7DlxUcrlUBw/ NWA1YMXSjGHweaCNU7euOEPo1Up5eSUcc3utHNOw9u7Cdv+o1+qWbNFrosp2csfe1tFk xJ/byqDpVY+4z2w/eAWDclJDTbpLHxGjY7hfq9FsfhHVZrz7mL9IvbgUBn6ooskTzu6P 8CoUfV24oCtuBA05h+5SLkAPp4FKkYxNhGNi70f0TdC/VBrSWmZeDI23w9OxkXkbFVww 0qrg== X-Gm-Message-State: ACrzQf03jVgyoz3uoRxI58UBsWfsO87I7GK2hdqzkD4NDrSxJdbvm0v2 jo4YQmHKYAy1qMR64vGg1/RW8uFQWUYsYQ== X-Google-Smtp-Source: AMsMyM5qE3BrXfNIFA7gA9MvJFMTdNmr3UcrNDV5ANZvqPvJaVECicWM+b22DnHBnN128U0R27FZOw== X-Received: by 2002:a17:902:d2c9:b0:186:f355:a42b with SMTP id n9-20020a170902d2c900b00186f355a42bmr62247149plc.58.1668036307337; Wed, 09 Nov 2022 15:25:07 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id y28-20020aa79e1c000000b0056e15b7138esm8798645pfq.157.2022.11.09.15.25.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 15:25:06 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Olivier Matz , Konstantin Ananyev , Anatoly Burakov Subject: [PATCH v3 10/14] examples: fix whitespace Date: Wed, 9 Nov 2022 15:24:47 -0800 Message-Id: <20221109232451.265059-11-stephen@networkplumber.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221109232451.265059-1-stephen@networkplumber.org> References: <20221109191445.140320-1-stephen@networkplumber.org> <20221109232451.265059-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add space after keywords. Signed-off-by: Stephen Hemminger --- examples/cmdline/parse_obj_list.c | 2 +- examples/ip_reassembly/main.c | 2 +- examples/multi_process/symmetric_mp/main.c | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/examples/cmdline/parse_obj_list.c b/examples/cmdline/parse_obj_list.c index 959bcd14527e..759072d39620 100644 --- a/examples/cmdline/parse_obj_list.c +++ b/examples/cmdline/parse_obj_list.c @@ -42,7 +42,7 @@ parse_obj_list(cmdline_parse_token_hdr_t *tk, const char *buf, void *res, if (res && ressize < sizeof(struct object *)) return -1; - while(!cmdline_isendoftoken(buf[token_len])) + while (!cmdline_isendoftoken(buf[token_len])) token_len++; SLIST_FOREACH(o, tkd->list, next) { diff --git a/examples/ip_reassembly/main.c b/examples/ip_reassembly/main.c index bd0b1d31decf..7e84b4944759 100644 --- a/examples/ip_reassembly/main.c +++ b/examples/ip_reassembly/main.c @@ -300,7 +300,7 @@ send_single_packet(struct rte_mbuf *m, uint16_t port) TX_LCORE_STAT_UPDATE(&qconf->tx_stat, queue, 1); txmb->m_table[txmb->head] = m; - if(++txmb->head == len) + if (++txmb->head == len) txmb->head = 0; return 0; diff --git a/examples/multi_process/symmetric_mp/main.c b/examples/multi_process/symmetric_mp/main.c index 1ff85875dfdf..2f4441049253 100644 --- a/examples/multi_process/symmetric_mp/main.c +++ b/examples/multi_process/symmetric_mp/main.c @@ -156,7 +156,7 @@ smp_parse_args(int argc, char **argv) /* get the port numbers from the port mask */ RTE_ETH_FOREACH_DEV(i) - if(port_mask & (1 << i)) + if (port_mask & (1 << i)) ports[num_ports++] = (uint8_t)i; ret = optind-1; @@ -470,8 +470,8 @@ main(int argc, char **argv) /* Primary instance initialized. 8< */ if (num_ports & 1) rte_exit(EXIT_FAILURE, "Application must use an even number of ports\n"); - for(i = 0; i < num_ports; i++){ - if(proc_type == RTE_PROC_PRIMARY) + for (i = 0; i < num_ports; i++) { + if (proc_type == RTE_PROC_PRIMARY) if (smp_port_init(ports[i], mp, (uint16_t)num_procs) < 0) rte_exit(EXIT_FAILURE, "Error initialising ports\n"); } From patchwork Wed Nov 9 23:24:48 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 119680 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4FDA3A0093; Thu, 10 Nov 2022 00:25:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0DC9D42D11; Thu, 10 Nov 2022 00:25:12 +0100 (CET) Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by mails.dpdk.org (Postfix) with ESMTP id C474D42D43 for ; Thu, 10 Nov 2022 00:25:09 +0100 (CET) Received: by mail-pj1-f48.google.com with SMTP id l22-20020a17090a3f1600b00212fbbcfb78so3295607pjc.3 for ; Wed, 09 Nov 2022 15:25:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7h9XAuTLAdiw0cbcON/lzoi4fMgOU+VzF4RKwroQFmI=; b=I+shH/JLv0sXXp8I6PLKT9zLmWxO4xGT+sBdTkUsi28o7AmeUV1NFm8vfOVnVuKAHo bgxmvsxsKVnd7/DIdK9WisXfG8G8OSaAv+/cQDHhmZNMLYEhTB2YXoAVxxVqpTY5bsgm KQZHsUNZOcMGd4RzPbiBnfanxteu2bfRY/zb52uM43bRPceCdEYPjBqBIjxaA1qP9WYk EAUaQ/yn6Bn2QrjeEuAYiA9/cFihK7E4kVh7cEdH1jNbnM/27r5FPr1eIQu4FogObPoT WcikDtt60tVE9tN0chNzG+6E3MmYujWsLULoRztnv/LeVhnt2TlW6CeYFsBHrrYIct8P bQmg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7h9XAuTLAdiw0cbcON/lzoi4fMgOU+VzF4RKwroQFmI=; b=v3YR4D4JGYG40seSMJTOGb0KRR1O3YRcgkPg2Lqxx6SsrneR5lAwIC1xKfn2U7NPiN NZrL1d7m3oZg7hDfDL6VGzu88bXFkTMZI5WGUEBsvBTkGhDwiefiPFEIkc+eNyuv0mr9 d4XWtb6Gxl7Io+o0NgpwFXe5s6gIqffpHbZ6V5YS1oA63Pwmno1Pc1ZRSgo5iTrjZVbZ EVhDerC/edyvmkh2J0kYX9BprvbZmm0iYBUV5xaOIiZL+Qh5jyE7pn7l34sXKmn3/WN7 j4CMg/OU0VvVB3sb2l/r+dGlTv754VHrhIZWeptG6J3HqSFw0qr5VCYQKurGotJDMR0c /VoA== X-Gm-Message-State: ACrzQf1mkZ6/op8A0+bMUOp6kDCjdAe0BqoZ+gB4oTVEHvYBdshPeTBh NHBesLHDX5NLRwEW9hVBj2ItqNcVYQX1sw== X-Google-Smtp-Source: AMsMyM5QxWenH0LSa8ZH97pu8ZmSfxtfOYw40iCCR9JsG+ZEH8fWdMFxWtoJ3ir4H8dC+PC2Nen08A== X-Received: by 2002:a17:902:9894:b0:186:a7d7:c56 with SMTP id s20-20020a170902989400b00186a7d70c56mr64311618plp.168.1668036308580; Wed, 09 Nov 2022 15:25:08 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id y28-20020aa79e1c000000b0056e15b7138esm8798645pfq.157.2022.11.09.15.25.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 15:25:08 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v3 11/14] bus/pci: fix whitespace Date: Wed, 9 Nov 2022 15:24:48 -0800 Message-Id: <20221109232451.265059-12-stephen@networkplumber.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221109232451.265059-1-stephen@networkplumber.org> References: <20221109191445.140320-1-stephen@networkplumber.org> <20221109232451.265059-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add space after keywords. Signed-off-by: Stephen Hemminger --- drivers/bus/pci/bsd/pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/pci/bsd/pci.c b/drivers/bus/pci/bsd/pci.c index 7459d15c7e31..056e2eda2d5f 100644 --- a/drivers/bus/pci/bsd/pci.c +++ b/drivers/bus/pci/bsd/pci.c @@ -368,7 +368,7 @@ rte_pci_scan(void) } dev_count += conf_io.num_matches; - } while(conf_io.status == PCI_GETCONF_MORE_DEVS); + } while (conf_io.status == PCI_GETCONF_MORE_DEVS); close(fd); From patchwork Wed Nov 9 23:24:49 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 119681 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3BBE3A0093; Thu, 10 Nov 2022 00:26:02 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DDC0842D54; Thu, 10 Nov 2022 00:25:12 +0100 (CET) Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) by mails.dpdk.org (Postfix) with ESMTP id 003B242D50 for ; Thu, 10 Nov 2022 00:25:10 +0100 (CET) Received: by mail-pg1-f175.google.com with SMTP id r18so50680pgr.12 for ; Wed, 09 Nov 2022 15:25:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WWiooLfbtswlNemQYSlxEd+r0cBU/l7e2a1Q8UDr748=; b=NG7WLTXFrLr/jFIY+dkZiSnFIF/Ss/f7t9NeozZ3hnz0ITgtGC/Y3EHsMZDe7/cm+a eawg8z1XB7JZwnJRiqALRKS/HSaBjLMdzZw4TJD8y7Tb42C8v6aCrtPlHCmD/BQbggga bqp66v7d0/KfflnDYHW5q+jIqNLERyHxW9SPaHkGrrWt663Aw2xRd3q7dxKXdDXonkHU imMXgFnOuRsj2Ahw1fhyJBiAJ0Q+URX6NveCku/j8ygPq+l4jWvficxhWUvUtL+eo9Eq k8YHCnY81CohAVbes6HTFXWaJlganAeyOZpSIrl6CmboIzBHVfw42BFdmM34x2VNhRT6 RXpA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WWiooLfbtswlNemQYSlxEd+r0cBU/l7e2a1Q8UDr748=; b=gr7v1jEbRwlnj/LsY5ru03f3+QIkyKLZb9w31+49SOBEDZQ4TUwmZIYEQfVo8gZhP4 fGGsnvzqddHH+b/Cppo1SPCI7wHmkOEIoLmWDek5OyvduiPPpQeFrezBDa75tcG4atse uvvEo/fi6tvJBWB0xzWVhwI4SYK3WRUZa+LKH0pb5yLyOeJkxmgzG6Vbc77iks6aIVqd 0t9Lzizp+/udSfoODNsyT8/sxZ/1o7vegocRjDNsI5CJaplJ6Bq4Yb36+NUxtDjpPqDu SUbwih1VMdRPN+MoboinTcoz5sJbsO6IYpiquiilh7k3Z7wO9I11NbmylsVGJBlVagFu +69g== X-Gm-Message-State: ANoB5plrip+sZSlWHX1tA03I9jD8v02pBY0rHBmXglN5yZ35X2O6Rq5I D1SwFq74YuNEVsIB7oUzRvjiBsKuMo37sg== X-Google-Smtp-Source: AA0mqf56zvCvW3yKpAJxuZOVx0VfYEOrPaSvrangRGvGcCil622vbJpeWoBvAgvXAFtznlNsNPzFHQ== X-Received: by 2002:a63:f353:0:b0:470:814c:f4ee with SMTP id t19-20020a63f353000000b00470814cf4eemr12531760pgj.8.1668036309945; Wed, 09 Nov 2022 15:25:09 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id y28-20020aa79e1c000000b0056e15b7138esm8798645pfq.157.2022.11.09.15.25.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 15:25:09 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Simei Su , Wenjun Wu Subject: [PATCH v3 12/14] net/e1000: fix whitespace Date: Wed, 9 Nov 2022 15:24:49 -0800 Message-Id: <20221109232451.265059-13-stephen@networkplumber.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221109232451.265059-1-stephen@networkplumber.org> References: <20221109191445.140320-1-stephen@networkplumber.org> <20221109232451.265059-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add space after keywords. Signed-off-by: Stephen Hemminger --- drivers/net/e1000/em_ethdev.c | 4 ++-- drivers/net/e1000/igb_ethdev.c | 8 ++++---- drivers/net/e1000/igb_pf.c | 2 +- drivers/net/e1000/igb_rxtx.c | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/e1000/em_ethdev.c b/drivers/net/e1000/em_ethdev.c index 8ee9be12ad19..146e74cfc76e 100644 --- a/drivers/net/e1000/em_ethdev.c +++ b/drivers/net/e1000/em_ethdev.c @@ -872,8 +872,8 @@ eth_em_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *rte_stats) E1000_DEV_PRIVATE_TO_STATS(dev->data->dev_private); int pause_frames; - if(hw->phy.media_type == e1000_media_type_copper || - (E1000_READ_REG(hw, E1000_STATUS) & E1000_STATUS_LU)) { + if (hw->phy.media_type == e1000_media_type_copper || + (E1000_READ_REG(hw, E1000_STATUS) & E1000_STATUS_LU)) { stats->symerrs += E1000_READ_REG(hw,E1000_SYMERRS); stats->sec += E1000_READ_REG(hw, E1000_SEC); } diff --git a/drivers/net/e1000/igb_ethdev.c b/drivers/net/e1000/igb_ethdev.c index 8858f975f8cc..67e82d708964 100644 --- a/drivers/net/e1000/igb_ethdev.c +++ b/drivers/net/e1000/igb_ethdev.c @@ -1683,7 +1683,7 @@ igb_read_stats_registers(struct e1000_hw *hw, struct e1000_hw_stats *stats) uint64_t old_rpthc = stats->rpthc; uint64_t old_hgptc = stats->hgptc; - if(hw->phy.media_type == e1000_media_type_copper || + if (hw->phy.media_type == e1000_media_type_copper || (E1000_READ_REG(hw, E1000_STATUS) & E1000_STATUS_LU)) { stats->symerrs += E1000_READ_REG(hw,E1000_SYMERRS); @@ -3500,10 +3500,10 @@ static void igbvf_set_vfta_all(struct rte_eth_dev *dev, bool on) for (i = 0; i < IGB_VFTA_SIZE; i++){ vfta = shadow_vfta->vfta[i]; - if(vfta){ + if (vfta) { mask = 1; for (j = 0; j < 32; j++){ - if(vfta & mask) + if (vfta & mask) igbvf_set_vfta(hw, (uint16_t)((i<<5)+j), on); mask<<=1; @@ -3528,7 +3528,7 @@ igbvf_vlan_filter_set(struct rte_eth_dev *dev, uint16_t vlan_id, int on) /*vind is not used in VF driver, set to 0, check ixgbe_set_vfta_vf*/ ret = igbvf_set_vfta(hw, vlan_id, !!on); - if(ret){ + if (ret) { PMD_INIT_LOG(ERR, "Unable to set VF vlan"); return ret; } diff --git a/drivers/net/e1000/igb_pf.c b/drivers/net/e1000/igb_pf.c index c7588ea57eaa..b1f74eb841d2 100644 --- a/drivers/net/e1000/igb_pf.c +++ b/drivers/net/e1000/igb_pf.c @@ -78,7 +78,7 @@ void igb_pf_host_init(struct rte_eth_dev *eth_dev) if (hw->mac.type == e1000_i350) nb_queue = 1; - else if(hw->mac.type == e1000_82576) + else if (hw->mac.type == e1000_82576) /* per datasheet, it should be 2, but 1 seems correct */ nb_queue = 1; else diff --git a/drivers/net/e1000/igb_rxtx.c b/drivers/net/e1000/igb_rxtx.c index f32dee46df82..f5677da6b931 100644 --- a/drivers/net/e1000/igb_rxtx.c +++ b/drivers/net/e1000/igb_rxtx.c @@ -2276,7 +2276,7 @@ igb_dev_mq_rx_configure(struct rte_eth_dev *dev) /* 011b Def_Q ignore, according to VT_CTL.DEF_PL */ mrqc |= 0x3 << E1000_MRQC_DEF_Q_SHIFT; E1000_WRITE_REG(hw, E1000_MRQC, mrqc); - } else if(RTE_ETH_DEV_SRIOV(dev).active == 0) { + } else if (RTE_ETH_DEV_SRIOV(dev).active == 0) { /* * SRIOV inactive scheme */ From patchwork Wed Nov 9 23:24:50 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 119682 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4AE1FA0093; Thu, 10 Nov 2022 00:26:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CDBB742D5A; Thu, 10 Nov 2022 00:25:13 +0100 (CET) Received: from mail-pj1-f45.google.com (mail-pj1-f45.google.com [209.85.216.45]) by mails.dpdk.org (Postfix) with ESMTP id 373E242D50 for ; Thu, 10 Nov 2022 00:25:12 +0100 (CET) Received: by mail-pj1-f45.google.com with SMTP id v4-20020a17090a088400b00212cb0ed97eso151629pjc.5 for ; Wed, 09 Nov 2022 15:25:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HHt9PbzPy7mkylQAPxjeYOiNiOuzNKGwN6+hVQRO3+Q=; b=twdy34ZzVvUzoOVi1T4Jtg/E8/fMFobjmkEBXLRGaCM+blkR89Sq88/NfKouoG0cHc U3lsc1d1CGYjUZpKLbJccLEANuXHeKyPW887WLbPc827/u7pKZVF5ANvBywBqZNw44dv K+jWAnvRF9lVBBKKuaBCXJrsRQ+TGkGDaxO3E2qeWKhhQvISzVDzuihZ3eyBrw3L0gOi w/n6SYng65odxZRRKYvy7lK+Dsjg5EePnL+ZeQXQ6lodp5ldTavXjse7FyyBjO/0SkD9 x4ZnZiX4ShrktvK4XQme9fFcwQfK/Yl6N1hcjk/BeiNVNo/ARmyOmj7b1G+MA0oJ0Gfv QDVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HHt9PbzPy7mkylQAPxjeYOiNiOuzNKGwN6+hVQRO3+Q=; b=Lz7N2ANpDn8bR90Ocg5lNJmaUemM1cnIXgrdwzhHb+dApiGgrEYPnBVzELvnssaV9g wxZAsqP5zhmgEPNH68zOXlyO72fwYJ5dN3AdiZvq0t0qycWAu04wMaMHYuXsenaQcy0h GYCZd1ulZpHIlgrAtfgfxx8OLLJqi+KfsEquYJazU2/29WfZ9VakfVZQ0jHR8AF+chPZ zZxCOixnGGf7rN9U/paJ4XbG1m3VHklqCQOVllAm+9tM/9bRz1pK6WYnEGY+VYCUQJqE R0yd9mUFnZINQNlGPPqSGimLDvZ/1/mTa5Qf7Rm1jJq29ZYrnp2OHpMPWtzo3Nh+xzlB sH8w== X-Gm-Message-State: ACrzQf0NaQSrQ70L4j10cQyIs/5nU9T4LWexDXfiq/BfnRYE8Ln5qxDi pp4eRzS1ycot3erkgVLC6GUgxLpSZpymsw== X-Google-Smtp-Source: AMsMyM4sZBoK3VCOU93cyOn6PyE73E6keW5KPmkzBmJOjcqJmV+3LmNZsJJKgOkR77DIAuRJX2GC6g== X-Received: by 2002:a17:902:f28b:b0:186:b069:63fc with SMTP id k11-20020a170902f28b00b00186b06963fcmr64279700plc.38.1668036311142; Wed, 09 Nov 2022 15:25:11 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id y28-20020aa79e1c000000b0056e15b7138esm8798645pfq.157.2022.11.09.15.25.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 15:25:10 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Yuying Zhang , Beilei Xing Subject: [PATCH v3 13/14] net/i40e: fix whitespace Date: Wed, 9 Nov 2022 15:24:50 -0800 Message-Id: <20221109232451.265059-14-stephen@networkplumber.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221109232451.265059-1-stephen@networkplumber.org> References: <20221109191445.140320-1-stephen@networkplumber.org> <20221109232451.265059-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add space after keywords. Signed-off-by: Stephen Hemminger Reviewed-by: Yuying Zhang --- drivers/net/i40e/i40e_pf.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/net/i40e/i40e_pf.c b/drivers/net/i40e/i40e_pf.c index 15d9ff868f3a..7050e0057d8e 100644 --- a/drivers/net/i40e/i40e_pf.c +++ b/drivers/net/i40e/i40e_pf.c @@ -956,7 +956,7 @@ i40e_pf_host_process_cmd_add_vlan(struct i40e_pf_vf *vf, for (i = 0; i < vlan_filter_list->num_elements; i++) { ret = i40e_vsi_add_vlan(vf->vsi, vid[i]); - if(ret != I40E_SUCCESS) + if (ret != I40E_SUCCESS) goto send_msg; } @@ -996,7 +996,7 @@ i40e_pf_host_process_cmd_del_vlan(struct i40e_pf_vf *vf, vid = vlan_filter_list->vlan_id; for (i = 0; i < vlan_filter_list->num_elements; i++) { ret = i40e_vsi_delete_vlan(vf->vsi, vid[i]); - if(ret != I40E_SUCCESS) + if (ret != I40E_SUCCESS) goto send_msg; } @@ -1577,12 +1577,12 @@ i40e_pf_host_init(struct rte_eth_dev *dev) * return if SRIOV not enabled, VF number not configured or * no queue assigned. */ - if(!hw->func_caps.sr_iov_1_1 || pf->vf_num == 0 || pf->vf_nb_qps == 0) + if (!hw->func_caps.sr_iov_1_1 || pf->vf_num == 0 || pf->vf_nb_qps == 0) return I40E_SUCCESS; /* Allocate memory to store VF structure */ pf->vfs = rte_zmalloc("i40e_pf_vf",sizeof(*pf->vfs) * pf->vf_num, 0); - if(pf->vfs == NULL) + if (pf->vfs == NULL) return -ENOMEM; /* Disable irq0 for VFR event */ From patchwork Wed Nov 9 23:24:51 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 119683 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 30F37A0093; Thu, 10 Nov 2022 00:26:12 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C9B4B42D44; Thu, 10 Nov 2022 00:25:14 +0100 (CET) Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by mails.dpdk.org (Postfix) with ESMTP id 7DD1642D45 for ; Thu, 10 Nov 2022 00:25:13 +0100 (CET) Received: by mail-pg1-f179.google.com with SMTP id q71so64457pgq.8 for ; Wed, 09 Nov 2022 15:25:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=orlqAdyG2cO9p0skE4kv7DuYe3j4iDQmQO7NM85bGpM=; b=h3hjKvAquFSD2HZefFO6HciZJ01NV27o8cw4rLfSy30NOidnGPL+JuQDb/aqU3k745 mhcwE5qckuTKxrXPqebCLUO+kZKxtBad2jxz/Z1DksuMZOP8zUnaJhFQISUnTGXfXlHH ObM7O4jmQy67q5w1S33NUGhAY3EPmZTh7muHAS94TDp2pkrQpmZLeuOcQz6JqUOIVmvw 4hs6RORgScC+FSmrL6nwud76YGS9tX0yWXHAH8wNj37rBeoSqCiT024b7Um40qowXKLc 0ZsBTJzc4gl8e5+aPUJjykArQWO25Jdzq6S355XQnDb5hduu1em9FTPiACUm1/6PEPws RrNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=orlqAdyG2cO9p0skE4kv7DuYe3j4iDQmQO7NM85bGpM=; b=1C7ayC+sfr0ICsDdY8NgGf2CW21ygS9vh9OFGGMkDpksEKYLO7VMEIWYRd1IuPxEq3 0OCx++FUB3u4dJewTP+6Q1MHfVtT4raA9J+x+fEwrOKkHctfIgDiL7IS/o4SDN1kfYOk YT3yNqolzEjPoHJj7o8n8B8xvunQmB9I1rhMM5Ag4bEYq7KpQpYPiBWepgbnNVWU1J5D slGnqVOK8lJiaQ2JRDzjTAg2X9gRaIPvncdQqPeKW3/aNg0KyCZf3/s0bEn+U8UIf1N/ F32zVuH66zrxouxpaX0Z+Gal1HJwJFAiCCMVOyaGwZnoeXDDPd7kt/iV/7d5+uuHvVFA x3wg== X-Gm-Message-State: ACrzQf21TzmWApMAVfnBbZPALbUZyTyq2lwG1n6A7LfiN2aWqrnQPizQ w+iL39j4swJ4K4qikQMFH+pxxkLOHG9/ow== X-Google-Smtp-Source: AMsMyM6MfTXXPoFmeRv0JNYHC7Cjxl0pMIc/ehiwtyHQEBjX1jaT6uwn2RnOx4tuBQE9CUxK8SZltw== X-Received: by 2002:a63:914b:0:b0:46e:dbd5:ae15 with SMTP id l72-20020a63914b000000b0046edbd5ae15mr53952810pge.94.1668036312384; Wed, 09 Nov 2022 15:25:12 -0800 (PST) Received: from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218]) by smtp.gmail.com with ESMTPSA id y28-20020aa79e1c000000b0056e15b7138esm8798645pfq.157.2022.11.09.15.25.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 09 Nov 2022 15:25:11 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Rasesh Mody , Shahed Shaikh Subject: [PATCH v3 14/14] net/bnx2x: fix whitespace Date: Wed, 9 Nov 2022 15:24:51 -0800 Message-Id: <20221109232451.265059-15-stephen@networkplumber.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221109232451.265059-1-stephen@networkplumber.org> References: <20221109191445.140320-1-stephen@networkplumber.org> <20221109232451.265059-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add space after keywords. Signed-off-by: Stephen Hemminger --- drivers/net/bnx2x/bnx2x.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnx2x/bnx2x.h b/drivers/net/bnx2x/bnx2x.h index 89414ac88a93..9cb927e25449 100644 --- a/drivers/net/bnx2x/bnx2x.h +++ b/drivers/net/bnx2x/bnx2x.h @@ -96,7 +96,7 @@ int bnx2x_ilog2(int x) int log = 0; x >>= 1; - while(x) { + while (x) { log++; x >>= 1; }