From patchwork Mon Mar 27 14:30:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 125531 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F12CC4284B; Mon, 27 Mar 2023 16:30:34 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 38BB842B7E; Mon, 27 Mar 2023 16:30:26 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id EF3AB40EE1 for ; Mon, 27 Mar 2023 16:30:22 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id 3F5D720FD8B5; Mon, 27 Mar 2023 07:30:22 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 3F5D720FD8B5 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1679927422; bh=I8n4OupilQ6hE6Buwwh+ssS19VVbbiHCzBCAu/NXQh8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L9Nrq3jytfLVcfCC5wPvPIF2Iy9OitOLHDFzLobWKpsD6OmMzRJMtNNXtRFd19VMI pN/tZU2NJa/8lmk68F4LhokMlVHLAqe4GBDoBKvv8saWjjHg8bNQ0iunY4PuhzhCNX Crmgnr3uuLdcNSoNFuVjz7Vih478wrb0qWm7YNE4= From: Tyler Retzlaff To: dev@dpdk.org Cc: Honnappa.Nagarahalli@arm.com, Ruifeng.Wang@arm.com, thomas@monjalon.net, Tyler Retzlaff Subject: [PATCH 1/3] bus/vmbus: use C11 memory model GCC builtin atomics Date: Mon, 27 Mar 2023 07:30:18 -0700 Message-Id: <1679927420-26737-2-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1679927420-26737-1-git-send-email-roretzla@linux.microsoft.com> References: <1679927420-26737-1-git-send-email-roretzla@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Replace use of __sync_or_and_fetch with __atomic_fetch_or. Signed-off-by: Tyler Retzlaff --- drivers/bus/vmbus/vmbus_channel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/vmbus/vmbus_channel.c b/drivers/bus/vmbus/vmbus_channel.c index 5549fd0..4d74df3 100644 --- a/drivers/bus/vmbus/vmbus_channel.c +++ b/drivers/bus/vmbus/vmbus_channel.c @@ -22,7 +22,7 @@ vmbus_sync_set_bit(volatile uint32_t *addr, uint32_t mask) { /* Use GCC builtin which atomic does atomic OR operation */ - __sync_or_and_fetch(addr, mask); + __atomic_fetch_or(addr, mask, __ATOMIC_SEQ_CST); } static inline void From patchwork Mon Mar 27 14:30:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 125530 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 889004284B; Mon, 27 Mar 2023 16:30:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 189AC4161A; Mon, 27 Mar 2023 16:30:25 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 0142640F18 for ; Mon, 27 Mar 2023 16:30:22 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id 4BBB920FD8BC; Mon, 27 Mar 2023 07:30:22 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 4BBB920FD8BC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1679927422; bh=hs0LCV9NmIVAwZjInoFm1WLDLLnt2EUS+6rY36LylG0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aCTX+S2Jcttr34STcoHzP37Ueq/ZEK/6tluDzKnZy7/XH67zYTnpE+Bj9aJCy+kTf R80gW/QFmxg+hK51ughPhv0ivARyjGIVhcdKD8ZueZ86kQzDCLmKcXCIcBAXaf1X/n 7vIac2+qRG5Y1eblDm7c+2f0bSnZ5hdeIyK9eAfw= From: Tyler Retzlaff To: dev@dpdk.org Cc: Honnappa.Nagarahalli@arm.com, Ruifeng.Wang@arm.com, thomas@monjalon.net, Tyler Retzlaff Subject: [PATCH 2/3] crypto/ccp: use C11 memory model GCC builtin atomics Date: Mon, 27 Mar 2023 07:30:19 -0700 Message-Id: <1679927420-26737-3-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1679927420-26737-1-git-send-email-roretzla@linux.microsoft.com> References: <1679927420-26737-1-git-send-email-roretzla@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Replace use of __sync_fetch_and_or and __sync_fetch_and_and with __atomic_fetch_or and __atomic_fetch_and. Signed-off-by: Tyler Retzlaff --- drivers/crypto/ccp/ccp_dev.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/crypto/ccp/ccp_dev.c b/drivers/crypto/ccp/ccp_dev.c index ee30f5a..b7ca3af 100644 --- a/drivers/crypto/ccp/ccp_dev.c +++ b/drivers/crypto/ccp/ccp_dev.c @@ -116,13 +116,15 @@ struct ccp_queue * static inline void ccp_set_bit(unsigned long *bitmap, int n) { - __sync_fetch_and_or(&bitmap[WORD_OFFSET(n)], (1UL << BIT_OFFSET(n))); + __atomic_fetch_or(&bitmap[WORD_OFFSET(n)], (1UL << BIT_OFFSET(n)), + __ATOMIC_SEQ_CST); } static inline void ccp_clear_bit(unsigned long *bitmap, int n) { - __sync_fetch_and_and(&bitmap[WORD_OFFSET(n)], ~(1UL << BIT_OFFSET(n))); + __atomic_fetch_and(&bitmap[WORD_OFFSET(n)], ~(1UL << BIT_OFFSET(n)), + __ATOMIC_SEQ_CST); } static inline uint32_t From patchwork Mon Mar 27 14:30:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tyler Retzlaff X-Patchwork-Id: 125532 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 03B094284B; Mon, 27 Mar 2023 16:30:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 55F7542BC9; Mon, 27 Mar 2023 16:30:27 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 0CF6A410D0 for ; Mon, 27 Mar 2023 16:30:23 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1086) id 5847620FD8C1; Mon, 27 Mar 2023 07:30:22 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 5847620FD8C1 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1679927422; bh=0nJcKkIRDMULe+xr8PDhyshCqH7Bu9Us1x08O+t/IaI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Kiej0t80OVqifkC1JcWPlayBBB4TgflU9w/8AKvzTbOlPqDbuPjLsGfZ5nZXaa2Vh tFtv9BRZY1lPTogjgwbyJbt1Qa3OSLvV7ADFlNLXo6JcCF8Ooj+oqwz83V4WJaqlDW sZ8EIdp1Gq0DUt+a7o9z/rZ7vBBfK1JZG13USHK8= From: Tyler Retzlaff To: dev@dpdk.org Cc: Honnappa.Nagarahalli@arm.com, Ruifeng.Wang@arm.com, thomas@monjalon.net, Tyler Retzlaff Subject: [PATCH 3/3] eal: use C11 memory model GCC builtin atomics Date: Mon, 27 Mar 2023 07:30:20 -0700 Message-Id: <1679927420-26737-4-git-send-email-roretzla@linux.microsoft.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1679927420-26737-1-git-send-email-roretzla@linux.microsoft.com> References: <1679927420-26737-1-git-send-email-roretzla@linux.microsoft.com> X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Replace use of __sync_fetch_and_add and __sync_fetch_and_sub with __atomic_fetch_add and __atomic_fetch_sub. Signed-off-by: Tyler Retzlaff --- lib/eal/include/generic/rte_atomic.h | 32 ++++++++++++++++---------------- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/lib/eal/include/generic/rte_atomic.h b/lib/eal/include/generic/rte_atomic.h index 234b268..58df843 100644 --- a/lib/eal/include/generic/rte_atomic.h +++ b/lib/eal/include/generic/rte_atomic.h @@ -243,7 +243,7 @@ static inline void rte_atomic16_add(rte_atomic16_t *v, int16_t inc) { - __sync_fetch_and_add(&v->cnt, inc); + __atomic_fetch_add(&v->cnt, inc, __ATOMIC_SEQ_CST); } /** @@ -257,7 +257,7 @@ static inline void rte_atomic16_sub(rte_atomic16_t *v, int16_t dec) { - __sync_fetch_and_sub(&v->cnt, dec); + __atomic_fetch_sub(&v->cnt, dec, __ATOMIC_SEQ_CST); } /** @@ -310,7 +310,7 @@ static inline int16_t rte_atomic16_add_return(rte_atomic16_t *v, int16_t inc) { - return __sync_add_and_fetch(&v->cnt, inc); + return __atomic_fetch_add(&v->cnt, inc, __ATOMIC_SEQ_CST) + inc; } /** @@ -330,7 +330,7 @@ static inline int16_t rte_atomic16_sub_return(rte_atomic16_t *v, int16_t dec) { - return __sync_sub_and_fetch(&v->cnt, dec); + return __atomic_fetch_sub(&v->cnt, dec, __ATOMIC_SEQ_CST) - dec; } /** @@ -349,7 +349,7 @@ #ifdef RTE_FORCE_INTRINSICS static inline int rte_atomic16_inc_and_test(rte_atomic16_t *v) { - return __sync_add_and_fetch(&v->cnt, 1) == 0; + return __atomic_fetch_add(&v->cnt, 1, __ATOMIC_SEQ_CST) + 1 == 0; } #endif @@ -369,7 +369,7 @@ static inline int rte_atomic16_inc_and_test(rte_atomic16_t *v) #ifdef RTE_FORCE_INTRINSICS static inline int rte_atomic16_dec_and_test(rte_atomic16_t *v) { - return __sync_sub_and_fetch(&v->cnt, 1) == 0; + return __atomic_fetch_sub(&v->cnt, 1, __ATOMIC_SEQ_CST) - 1 == 0; } #endif @@ -522,7 +522,7 @@ static inline void rte_atomic16_clear(rte_atomic16_t *v) static inline void rte_atomic32_add(rte_atomic32_t *v, int32_t inc) { - __sync_fetch_and_add(&v->cnt, inc); + __atomic_fetch_add(&v->cnt, inc, __ATOMIC_SEQ_CST); } /** @@ -536,7 +536,7 @@ static inline void rte_atomic16_clear(rte_atomic16_t *v) static inline void rte_atomic32_sub(rte_atomic32_t *v, int32_t dec) { - __sync_fetch_and_sub(&v->cnt, dec); + __atomic_fetch_sub(&v->cnt, dec, __ATOMIC_SEQ_CST); } /** @@ -589,7 +589,7 @@ static inline void rte_atomic16_clear(rte_atomic16_t *v) static inline int32_t rte_atomic32_add_return(rte_atomic32_t *v, int32_t inc) { - return __sync_add_and_fetch(&v->cnt, inc); + return __atomic_fetch_add(&v->cnt, inc, __ATOMIC_SEQ_CST) + inc; } /** @@ -609,7 +609,7 @@ static inline void rte_atomic16_clear(rte_atomic16_t *v) static inline int32_t rte_atomic32_sub_return(rte_atomic32_t *v, int32_t dec) { - return __sync_sub_and_fetch(&v->cnt, dec); + return __atomic_fetch_sub(&v->cnt, dec, __ATOMIC_SEQ_CST) - dec; } /** @@ -628,7 +628,7 @@ static inline void rte_atomic16_clear(rte_atomic16_t *v) #ifdef RTE_FORCE_INTRINSICS static inline int rte_atomic32_inc_and_test(rte_atomic32_t *v) { - return __sync_add_and_fetch(&v->cnt, 1) == 0; + return __atomic_fetch_add(&v->cnt, 1, __ATOMIC_SEQ_CST) + 1 == 0; } #endif @@ -648,7 +648,7 @@ static inline int rte_atomic32_inc_and_test(rte_atomic32_t *v) #ifdef RTE_FORCE_INTRINSICS static inline int rte_atomic32_dec_and_test(rte_atomic32_t *v) { - return __sync_sub_and_fetch(&v->cnt, 1) == 0; + return __atomic_fetch_sub(&v->cnt, 1, __ATOMIC_SEQ_CST) - 1 == 0; } #endif @@ -854,7 +854,7 @@ static inline void rte_atomic32_clear(rte_atomic32_t *v) static inline void rte_atomic64_add(rte_atomic64_t *v, int64_t inc) { - __sync_fetch_and_add(&v->cnt, inc); + __atomic_fetch_add(&v->cnt, inc, __ATOMIC_SEQ_CST); } #endif @@ -873,7 +873,7 @@ static inline void rte_atomic32_clear(rte_atomic32_t *v) static inline void rte_atomic64_sub(rte_atomic64_t *v, int64_t dec) { - __sync_fetch_and_sub(&v->cnt, dec); + __atomic_fetch_sub(&v->cnt, dec, __ATOMIC_SEQ_CST); } #endif @@ -931,7 +931,7 @@ static inline void rte_atomic32_clear(rte_atomic32_t *v) static inline int64_t rte_atomic64_add_return(rte_atomic64_t *v, int64_t inc) { - return __sync_add_and_fetch(&v->cnt, inc); + return __atomic_fetch_add(&v->cnt, inc, __ATOMIC_SEQ_CST) + inc; } #endif @@ -955,7 +955,7 @@ static inline void rte_atomic32_clear(rte_atomic32_t *v) static inline int64_t rte_atomic64_sub_return(rte_atomic64_t *v, int64_t dec) { - return __sync_sub_and_fetch(&v->cnt, dec); + return __atomic_fetch_sub(&v->cnt, dec, __ATOMIC_SEQ_CST) - dec; } #endif