From patchwork Wed Jun 28 12:54:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Kozyrev X-Patchwork-Id: 129052 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC7A642D80; Wed, 28 Jun 2023 14:55:11 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5601540151; Wed, 28 Jun 2023 14:55:11 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2045.outbound.protection.outlook.com [40.107.223.45]) by mails.dpdk.org (Postfix) with ESMTP id 0DF01400EF for ; Wed, 28 Jun 2023 14:55:09 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E5r482a7pyO56+NCBTEgCjbWEIrJFzilnRAaF6sz6h8CtunSLjkGRdqIPl4vUkHm92H0zrvhnTUxlF75XtzArNwnS6+4Ygz1xRtbfNbdjy216fxf0RvONacSuldxn5KiKiu7+i/jd7WVd/OxbwDT1ohw6mBTbP+taJeJNovDoGZ53SMKqoYKDKCU5H+EZZrLZDJGkdGHgwPBAOdJcVseTqCOI3zUdj+nmMrddPR1kwturkXocdsFJdfd+LrKuDwycCkw/Q5Q4SZOPZWwNE0NwhkCD8LaT4HyxqGLUKeYP34sRSxsPAYsEVebTEUXC6nvuIFRE+eRR0sD9yuL6zPUgw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=u+yNrQd7o1jHxoekPrwsFsXUPylXK5v1FhB3VB0305Q=; b=JV+oR/shTOw6CPKgzaUghvnsHS8a1rc+DKo0AYU81bsAH/j7fbUqca6yqF5NjfluaTLWXWgHgo0bRPq3Qt3F5P/t77d04xtWnlHUzZVcM3K3Jvf2+GvoRziO93LAOoEbI+QhfCERcMJII9oKZ4vzSS2VIF/rzn+6QqW1vdvNWYV+iDBLK4jo8YAbr074ctEWuzeKuxb4/6SGXkzpK9UaS3z8ZfgmfOqYHlAS7KhtEtox7GD8fbJ7IAixCjAMUR652kKlZJDEsfA+vtJ0Lu2mX/HbIFRPlvY0oM4NoxXfW/dnxd6GOkfxs4cprhOuXRZ75chBWS8LL/i32AXLrSEVHw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=u+yNrQd7o1jHxoekPrwsFsXUPylXK5v1FhB3VB0305Q=; b=aAf3qPxhirkqdK52Mix899gY0GliSaoxb+/zwUQbAycLUiStYeMarMxSulA846Sf+t2KP1uJfoWltOCvkjq4ahSq7IMyxcx+QracwdHMuvfYsJT3J2DPWx/y4ORk5FZoZPoZIzSzveIvBPSScf0xJaX9BVRc3iAALYzRl8Ba45Y6Zm28ZV6MW+mN2tDi3tjK54rpig5GpApC4dskJyGqLgjLpYACazHkLl/DgRbFiUH4poVR+20tnlPsYxtQ6M2+fFGHBb1DHFsGawKpMK0cySLy7uX8oD874RcbDuBAAbn39YVtrfOK1LOyfksqUyJvxKMiGpzuWd1PrSy6cm7H1Q== Received: from DS7PR03CA0100.namprd03.prod.outlook.com (2603:10b6:5:3b7::15) by PH7PR12MB7020.namprd12.prod.outlook.com (2603:10b6:510:1ba::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.29; Wed, 28 Jun 2023 12:55:08 +0000 Received: from DM6NAM11FT055.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b7:cafe::bd) by DS7PR03CA0100.outlook.office365.com (2603:10b6:5:3b7::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.20 via Frontend Transport; Wed, 28 Jun 2023 12:55:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DM6NAM11FT055.mail.protection.outlook.com (10.13.173.103) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.47 via Frontend Transport; Wed, 28 Jun 2023 12:55:07 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Wed, 28 Jun 2023 05:54:54 -0700 Received: from pegasus01.mtr.labs.mlnx (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Wed, 28 Jun 2023 05:54:52 -0700 From: Alexander Kozyrev To: CC: , , Subject: [PATCH] net/mlx5: fix matcher index in case of insertion by index Date: Wed, 28 Jun 2023 15:54:37 +0300 Message-ID: <20230628125437.1834231-1-akozyrev@nvidia.com> X-Mailer: git-send-email 2.18.2 MIME-Version: 1.0 X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT055:EE_|PH7PR12MB7020:EE_ X-MS-Office365-Filtering-Correlation-Id: 930c8d7b-8a8f-42bd-26ee-08db77d6e696 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: P4sfIYJFL1JyJYxS33nr8exIUStkGzFxH+v6Mv4mOl92Q88lHO5S8MNTp4OTMdtK3Ul0SrFZxcz7MFRPYWF3C4RhZ42fc7jems7f3hCD3jMmCufRAeBMOsbnAE3YO4hnAZF5EBAzo/vBp3RQs5ZDqtEvXCqfZB15CdWrtvMlDtV6fl/FWyrzWQKr1Yd0lb/oXTlF/hakl8oa2vF2n9N/wu/cxGh5XnLS5C0U5IhD1FpkR5kMV/01iWZDD8JVAeHZnVJ6JB9J8iF4a4Wdr5O9kzDtoF6UGJxQ6m4wJuweL15+YFm09OKtANa+7rZhcdrAMQuL/8+82BIHcBvNzgKbYdtgsHGUUXWpxgUr77lM8/ZdDHRvNygt3UCFslrL/qdjqzJ4MeB+tAXxrM1N92hk8iGmL/VZYZwdNLhigRZRQeak5ipQgtWvh/tDn/mhcWGSw5b4LmB0FiTAlcPT/qvrtq0/QVZ7QKpb5XtS/i+nsjkQL9CbYkT9IL9qtQHVZEZGrPYzEI6oY8ekRliSiLkdnXdA/rL+6qp6kB5Ds50jpbQsbWNyGlWKcqyYwVfEZZr82P+Osfq73jygpJ3345D6r5bzujidotFhCVlYfyjmP3YLOhMtMd1+sLaKiZ5gNuOqmLS5a1Zpg+AsrAZXTbn0P5uTltOpCj6FPj1hdMeeBAmNZ0iqbTuKsd/XqJ0mRNBv8OFKqcghH0jlltumbRgCS1LUaSV0V/3FVznfNBHvAKyfij5uhTa6B3V7E/ch2uD6 X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230028)(4636009)(346002)(136003)(39860400002)(396003)(376002)(451199021)(40470700004)(36840700001)(46966006)(82310400005)(36860700001)(86362001)(36756003)(5660300002)(356005)(2906002)(4744005)(41300700001)(8936002)(316002)(8676002)(40460700003)(7636003)(40480700001)(4326008)(70206006)(6916009)(82740400003)(70586007)(107886003)(47076005)(478600001)(1076003)(186003)(26005)(426003)(16526019)(54906003)(2616005)(83380400001)(336012)(6666004); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2023 12:55:07.6801 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 930c8d7b-8a8f-42bd-26ee-08db77d6e696 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT055.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7020 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org There is only one matcher in an index-based template tables. Pass the 0 as the matcher index, not actions template index. Fixes: adfa4b1445 ("net/mlx5: add flow rule insertion by index") Signed-off-by: Alexander Kozyrev Acked-by: Ori Kam --- drivers/net/mlx5/mlx5_flow_hw.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index b5137a822a..2cf9e6ef3a 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -2796,8 +2796,7 @@ flow_hw_async_flow_create_by_index(struct rte_eth_dev *dev, */ if (flow_hw_actions_construct(dev, job, &table->ats[action_template_index], - action_template_index, actions, - rule_acts, queue, error)) { + 0, actions, rule_acts, queue, error)) { rte_errno = EINVAL; goto free; }