From patchwork Wed Jul 26 22:29:10 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Long Li X-Patchwork-Id: 129708 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD86D42F55; Thu, 27 Jul 2023 00:29:29 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 072CD43246; Thu, 27 Jul 2023 00:29:29 +0200 (CEST) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 3145040041; Thu, 27 Jul 2023 00:29:27 +0200 (CEST) Received: by linux.microsoft.com (Postfix, from userid 1004) id 3E7452383126; Wed, 26 Jul 2023 15:29:26 -0700 (PDT) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com 3E7452383126 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxonhyperv.com; s=default; t=1690410566; bh=Txh78MLvmAmSBzpE0VpofQGpFGBR9NhGkic7WQFs6Ns=; h=From:To:Cc:Subject:Date:Reply-To:From; b=KVrjaA6cSAlA6OvqQIRsGVDsIjDntvEb45TLU9Xt5EwGfnv3XltjYC5lUVOuetewl 0/1VI2Nwr76u6yzK+THJljV51zngaZGHslpPD2sfLsQCSzRmiRVxCaIvnxCNQt+29U ZlHjsPAfCkqL/vEqCe0Li5AOzveBmh5tBk2ZEMqQ= From: longli@linuxonhyperv.com To: Ferruh Yigit , Andrew Rybchenko Cc: dev@dpdk.org, Long Li , stable@dpdk.org Subject: [PATCH] net/netvsc: increase VSP response timeout to 60 seconds Date: Wed, 26 Jul 2023 15:29:10 -0700 Message-Id: <1690410550-15636-1-git-send-email-longli@linuxonhyperv.com> X-Mailer: git-send-email 1.8.3.1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: longli@microsoft.com Errors-To: dev-bounces@dpdk.org From: Long Li The current timeout is set to 5 seconds. In Azure, tests show that it may take up to 15 seconds for VSP to respond on busy nodes. The VSP schedules unbounded work to process VSC resquest, there is no upper limit on how long it takes to send response back to VSC. In the NETVSC kernel mode driver, it waits forever for VSP response. While in DPDK we can't wait forever, setting the timeout to 60 seconds. Cc: stable@dpdk.org Signed-off-by: Long Li --- drivers/net/netvsc/hn_rndis.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/netvsc/hn_rndis.c b/drivers/net/netvsc/hn_rndis.c index e6f1f28768..7e9abce8d0 100644 --- a/drivers/net/netvsc/hn_rndis.c +++ b/drivers/net/netvsc/hn_rndis.c @@ -35,7 +35,7 @@ #include "hn_rndis.h" #include "ndis.h" -#define RNDIS_TIMEOUT_SEC 5 +#define RNDIS_TIMEOUT_SEC 60 #define RNDIS_DELAY_MS 10 #define HN_RNDIS_XFER_SIZE 0x4000