From patchwork Thu Sep 14 09:37:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 131410 X-Patchwork-Delegate: jerinj@marvell.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5239642595; Thu, 14 Sep 2023 11:38:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C409E40293; Thu, 14 Sep 2023 11:38:08 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 3861E40289; Thu, 14 Sep 2023 11:38:06 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1694684287; x=1726220287; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=rs5YHJfRSMy3IIlm7Hthc0rUZ9DLa4Zi4uwNc0uDZa4=; b=lDbzpIZPXbit1cTMVDBpsUeg1mcLDgTQzO/I/Vj2i6jPz8B1qH9rryFu /xT7LmbnMe/tE59xUv0bVyrUex8OeGZLYe1WpACpI6kPeMREmXWISf4LW QMZuWDyGdfWTkYKsmNFKrlCMCaEnSRtxrSZyGTzBDp0XMy78k+R5zefR8 837/xIVLfd6/Y/jh8bnhlezT4yTLPqwMj7AIyG4vmW/4z22+BV6vnmI1B 9AL8FFFPvEQOS00sWYp9d54uzCzV/C6lfavh7eSSFh0fC/hSKe5zJbDle Xcvuqsc6K7L5rHYnHQVhYeJQK4ISNow0UZ3WAEEGFTB0DeVqPTVQSZ0ju g==; X-IronPort-AV: E=McAfee;i="6600,9927,10832"; a="465275460" X-IronPort-AV: E=Sophos;i="6.02,145,1688454000"; d="scan'208";a="465275460" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Sep 2023 02:38:05 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10832"; a="868182160" X-IronPort-AV: E=Sophos;i="6.02,145,1688454000"; d="scan'208";a="868182160" Received: from silpixa00401385.ir.intel.com ([10.237.214.14]) by orsmga004.jf.intel.com with ESMTP; 14 Sep 2023 02:38:03 -0700 From: Bruce Richardson To: dev@dpdk.org Cc: Harry van Haaren , Bruce Richardson , stable@dpdk.org Subject: [PATCH] event/sw: remove obsolete comment Date: Thu, 14 Sep 2023 10:37:51 +0100 Message-Id: <20230914093751.8170-1-bruce.richardson@intel.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Code that the comment refers to was previously removed, but the comment remained. Fixes: dca926ca9faa ("event/sw: use dynamically-sized IQs") Cc: stable@dpdk.org Signed-off-by: Bruce Richardson Acked-by: Harry van Haaren Acked-by: Stephen Hemminger --- drivers/event/sw/sw_evdev_scheduler.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/event/sw/sw_evdev_scheduler.c b/drivers/event/sw/sw_evdev_scheduler.c index de6ed21643..17953fde0e 100644 --- a/drivers/event/sw/sw_evdev_scheduler.c +++ b/drivers/event/sw/sw_evdev_scheduler.c @@ -368,12 +368,6 @@ __pull_port_lb(struct sw_evdev *sw, uint32_t port_id, int allow_reorder) if (!allow_reorder && !eop) flags = QE_FLAG_VALID; - /* - * if we don't have space for this packet in an IQ, - * then move on to next queue. Technically, for a - * packet that needs reordering, we don't need to check - * here, but it simplifies things not to special-case - */ uint32_t iq_num = PRIO_TO_IQ(qe->priority); struct sw_qid *qid = &sw->qids[qe->queue_id];