From patchwork Sat Oct 28 06:31:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 133555 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF51443220; Sat, 28 Oct 2023 08:32:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B3CB94027C; Sat, 28 Oct 2023 08:32:02 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2106.outbound.protection.outlook.com [40.107.237.106]) by mails.dpdk.org (Postfix) with ESMTP id 315D840272; Sat, 28 Oct 2023 08:32:01 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RsWetaoMd8xZRl7eC1CjPp8BjDmKEcYtAjdaftJekmdAd748F+e7FX4LxMapOppqngJrM1MqPaUAVZxxgxRNicFLLPn+Hle5PSufVmIEqMcelMenC65DqJ3AlKKSQO501ieAJU4Dl90RM26brtMnwdiTPOLPiupmcMf4O/G92HOZptX0XRXW19EdAXLQWFVVXJB0YntvGHTobCszvqHvB0JWgFyPFsPXdBS4hXy5rVExe36+VZvbXABSF0HviUsL6piu9pBn4NIc7QkCtFIRTIy3+TvumSsIwbJajBTX5ZDze1IwTynrGDHPJOrbVsFRkhp48SbnhSn8CqyUjfbigA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8BqIh8Px9MoxPk4e+PVM7tckagUjrN7diP0u4QmRrqA=; b=LDbPCjwYeaCuqSow6wYO8p4VwHAmIwXleFfkbqtDInd/v97PGBZCDLZQupnaenUExFV/vGbat/YKVGHBgJdDNCYaVtMzAB0dqR5jRjRKP7SbPrk6YjIGDKxQ4ybEa6fMO8DbuJPl9CHYfoXAzWt5GW4RNy+A4xJL50M06Gb65h+1btlKIPrOPx8DYgFrmUUiRFa8BFSv5lwinGqxGmCzbSckYwjHEz31nDAsyI13cH7V3a8xgTud+/DkKsYMcDxDGGZIue5w5FAyY5xoj4dQZ2K5rDU1jEDEuZrIneUoXt1TX6LYVIHrgQnTO/5T5Y8vGfX+CLwdQNiQjzArOoZMHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8BqIh8Px9MoxPk4e+PVM7tckagUjrN7diP0u4QmRrqA=; b=vb4o0rwfwHEl2kLLJ9MqvGZZwvOIfqPZr+FunUagZAV2x50hoU9c8lcAqF3nLJirrpsUnwYDoz2sqk4pINZPjXex0FjPqnwO9mbu9h63YreXPY7GSLVr9e5W+evgLOvOIoe3dMHc6R+hUNXBZBBclfnUq1elaGdpj2cFZzWAsdQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by PH7PR13MB5429.namprd13.prod.outlook.com (2603:10b6:510:138::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.22; Sat, 28 Oct 2023 06:31:59 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::45b3:d83c:cff2:4a1b]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::45b3:d83c:cff2:4a1b%6]) with mapi id 15.20.6933.022; Sat, 28 Oct 2023 06:31:59 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Shihong Wang , stable@dpdk.org, Chaoyong He , Peng Zhang Subject: [PATCH] net/nfp: fix offload flags of the security capabilities Date: Sat, 28 Oct 2023 14:31:40 +0800 Message-Id: <20231028063140.1843291-1-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 X-ClientProxiedBy: SJ0PR13CA0037.namprd13.prod.outlook.com (2603:10b6:a03:2c2::12) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|PH7PR13MB5429:EE_ X-MS-Office365-Filtering-Correlation-Id: 8d1fa7e4-f8bf-49a4-d1b4-08dbd77f9680 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: n8zIY9ORXSUrCnbghmksRnrMie/umUPG6ijK/Mpl2dqWQ524txUE2dYz1kI7QwLvcmxEaPnS9SrcXOS8eDjbu7bdgXPNO2/2K/hXeMBZgSmRsS8ICLTzim6yCTJNI72HzMYf7WshEeDmJ7duArMkCRr+0jiFByiDMU7r0g19w1IThBZKOkAvkl6gg0agJLpXvEGVsYAQArE3G1YHnd9mo1lkSM+rKYmpMwxr8j89YRLirpeJR6QGJJ8cu9Oc+Q4QqbR77uUYvxwZipbbuMhZf5/vm4enG/x/E7xVH5jF7OhvLwSKTuHxILxl3gQXZP/bg/nF4lG+fOxvxISoSuSM3lT85sDAAQ/Pu3xm+1+VwGefx8MUaeVtIakYf4i3ZmbmbGsoffFpIpRQF2nNabuRgf2fwXOmupRnDNNFQC4mmWGlsXL1FkNdxfXl5ulMOa83W/Moob5KFO6DViMXmjuKEuW5nmzixIXL6t3qhzvlnyD2+cM0w7PwjWWWvUDMXMdIF5Djnb+f1cY3/SBRFusjtxQo4yZ+vk4o7bvKqHVN9Kms5CsPEKxkLKPrPUCaykh9jJOkqY1WfSn27yWiN53aSOsznGKFqGDp+ge8qijezKBqkSNOffqhlzR1ACI2uadwMvx1PbgK8IpLLG2yjC0T648RTIktnH0m9+gKt4YiIQU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(396003)(39830400003)(366004)(346002)(376002)(136003)(230922051799003)(186009)(1800799009)(451199024)(64100799003)(2906002)(38100700002)(15650500001)(83380400001)(1076003)(107886003)(5660300002)(2616005)(86362001)(6512007)(41300700001)(44832011)(36756003)(38350700005)(66476007)(316002)(6916009)(66946007)(54906003)(66556008)(52116002)(6666004)(6506007)(6486002)(8676002)(26005)(478600001)(450100002)(4326008)(8936002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: o+n8lMPREzeKePU8A19FcuPpGdP7ivHuXbwNYT7DTit25sO5h/gBktXb96P+hx0aJfMsRtYG8oUJ7RuVPD6qTPRtmWZztMRQ7cr58rcoQLpwXyMcArXE2Np4TvAoMVP6LN/8l5jfJPhvwADluqAxZlFhMpeSJAekZLlv516fiokHUhp6jir2w3oLUm8AAlUQbvfTZPgxf/2oOlMW8wda67azE6AcDwDSqdksRUuEu9yZS5/vhNqZMauFFWYE6RD27A4u5n9WWtJkWsegFg5n/CnZ2a3gAjjyBwHqUEkM5J3rdKBZ7PmzHmM86rPqXB+xpFRHikPwS9/KeShitHlsyZPNHiUMV9g1miFjs5PCOHm8hNw4Da+hc4vrtoEZPBIsOO0OjpXQdNmTWzANbqR6BoMovWn5s9uRKUjDPXV6qMt8dymzPJBU0k82M555c3d8JqaABG976CpH3CqXa1wK9TAIWoyh6eAtx75fxZd+HBHHecnK5pDATkBTHp9HsS8Ebe4czLTLyyx1SWz6PZslkzwcFQFHV9tivHud7PRA2rQVzeuqbCXIhGrUGl8hAbhahQoKrItXusXYrnT4m/Q/48MqogvcOBtkkRxGuR3hIr1FbBozmQgYDKvVtd6A5lueznhlxwsQq2j/3JJlQVwTo3UijDb23/Kzw+YXhWO7OWnU1KMQs4oGXLE1HqR/ThbU2OGb1BvyLN3MG19liQtoh985oqS4i13ah0x/s70FZZxqJ+6BBLzjKtMpKYsJoljOkRwyR4ykoVDbiMhpq/CSUh65ajqcgIcB5kjoj22NFVYQ4pEr9s1J7+ohRGP/A4u8JLY5IIK2nNA/CT3EHsjhPWkU/BJqrgVlmz6ho7Z1g/vYCW14qoiOH7O7HI4JwO6Ps/uWIG0U4S0JYhTr9hKgz30mBQS8Km9y0TXjueVJ+KBEbASML2KOTOs71QHdLJdN+7JbMSI2eNV2a7BJoqrPrs1kmxqXe8x/nDYOBI6MQGAZAGVyn4sy1rUCbMub5//LDsAeCt6ueBkNuvqVxJXXz0Fu/o/Zga71yGGiLlc0eDdK7J1Pyqb2z0rA/41xofg542VZssyn117eF3SVt0tOqT7X+nCcv/Y58RKBbx3ow0pslaMZsviIqrNJ48XYkTj+C5Lhmt6RvTLyY7EyopOzFripI5bbI63+/9k0BfiBWvH/eSTRn/gO4B3QcXMq0/jrWW4NmEYy/ifqVsjRK5c71l4OpnMakeKX2HNDoaJUgBWPbas3JsyDGE78mPrsLt2e4U4WgxjuIDWlYXQaeTIJjT7TRPZu0ChZOydDjvmov7wKRpCBHVBxp1+LnD3dcyZr7/J3vLeydmEB4wsLu99AGrZm/76thCw1+D/73z9JRLwm2B6135jCeeoXLORwGACLdug+SKd2puz86UhWRyB4LpdeBenjTnNy2VFUAtYFGrJRil+vJ8RfdGT+czLreOJrv2KXj0R7ei2kO5xJBWAuwaQX7PIxGblzl+sj6skZa6WZEXPd9Zzy9pWMW2pPtsRoNuGZjcyjzyppgsywFNVafNRynNRCyOaDDNBuE+KEKDkDm1U/ndK0TPJu8WBRcr5vJDDDVt4CHZR9YzLyGrw35Q== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 8d1fa7e4-f8bf-49a4-d1b4-08dbd77f9680 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Oct 2023 06:31:59.1888 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: D1YsYUGTSaVm7aXjAnsDz1MIHU6gFvHzfeJ2mq6r8OnZSrTzYkIapk3B6HiXkVld8MEqVWszK35tAGTE0dY5XTRTWo3/wUEKyfMSCOSIy1E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR13MB5429 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Shihong Wang This patch resolves configuration error of ol_flags in the rte_security_capability. Currently ol_flags in the ingress direction of the SA, 'RTE_SECURITY_TX_OLOAD_NEED_MDATA' is configured. In fact, ol_flags only in the egress direction of the SA needs to be configured. Fixes: e6d69ea011c9 ("net/nfp: get security capabilities and session size") Cc: stable@dpdk.org Signed-off-by: Shihong Wang Reviewed-by: Chaoyong He Reviewed-by: Peng Zhang Acked-by: Ferruh Yigit --- drivers/net/nfp/nfp_ipsec.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/net/nfp/nfp_ipsec.c b/drivers/net/nfp/nfp_ipsec.c index a76ba2a91d..302962c58b 100644 --- a/drivers/net/nfp/nfp_ipsec.c +++ b/drivers/net/nfp/nfp_ipsec.c @@ -242,7 +242,8 @@ static const struct rte_security_capability nfp_security_caps[] = { .esn = 1 } }, - .crypto_capabilities = nfp_crypto_caps + .crypto_capabilities = nfp_crypto_caps, + .ol_flags = RTE_SECURITY_TX_OLOAD_NEED_MDATA }, { /* IPsec Inline Crypto Tunnel Ingress */ .action = RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO, @@ -257,8 +258,7 @@ static const struct rte_security_capability nfp_security_caps[] = { .esn = 1 } }, - .crypto_capabilities = nfp_crypto_caps, - .ol_flags = RTE_SECURITY_TX_OLOAD_NEED_MDATA + .crypto_capabilities = nfp_crypto_caps }, { /* IPsec Inline Crypto Transport Egress */ .action = RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO, @@ -273,7 +273,8 @@ static const struct rte_security_capability nfp_security_caps[] = { .esn = 1 } }, - .crypto_capabilities = nfp_crypto_caps + .crypto_capabilities = nfp_crypto_caps, + .ol_flags = RTE_SECURITY_TX_OLOAD_NEED_MDATA }, { /* IPsec Inline Crypto Transport Ingress */ .action = RTE_SECURITY_ACTION_TYPE_INLINE_CRYPTO, @@ -288,8 +289,7 @@ static const struct rte_security_capability nfp_security_caps[] = { .esn = 1 } }, - .crypto_capabilities = nfp_crypto_caps, - .ol_flags = RTE_SECURITY_TX_OLOAD_NEED_MDATA + .crypto_capabilities = nfp_crypto_caps }, { /* IPsec Inline Protocol Tunnel Egress */ .action = RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL, @@ -304,7 +304,8 @@ static const struct rte_security_capability nfp_security_caps[] = { .esn = 1 } }, - .crypto_capabilities = nfp_crypto_caps + .crypto_capabilities = nfp_crypto_caps, + .ol_flags = RTE_SECURITY_TX_OLOAD_NEED_MDATA }, { /* IPsec Inline Protocol Tunnel Ingress */ .action = RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL, @@ -319,8 +320,7 @@ static const struct rte_security_capability nfp_security_caps[] = { .esn = 1 } }, - .crypto_capabilities = nfp_crypto_caps, - .ol_flags = RTE_SECURITY_TX_OLOAD_NEED_MDATA + .crypto_capabilities = nfp_crypto_caps }, { /* IPsec Inline Protocol Transport Egress */ .action = RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL, @@ -335,7 +335,8 @@ static const struct rte_security_capability nfp_security_caps[] = { .esn = 1 } }, - .crypto_capabilities = nfp_crypto_caps + .crypto_capabilities = nfp_crypto_caps, + .ol_flags = RTE_SECURITY_TX_OLOAD_NEED_MDATA }, { /* IPsec Inline Protocol Transport Ingress */ .action = RTE_SECURITY_ACTION_TYPE_INLINE_PROTOCOL, @@ -350,8 +351,7 @@ static const struct rte_security_capability nfp_security_caps[] = { .esn = 1 } }, - .crypto_capabilities = nfp_crypto_caps, - .ol_flags = RTE_SECURITY_TX_OLOAD_NEED_MDATA + .crypto_capabilities = nfp_crypto_caps }, { .action = RTE_SECURITY_ACTION_TYPE_NONE