From patchwork Wed Nov 1 07:28:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Weiguo Li X-Patchwork-Id: 133712 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B6CBD4325D; Wed, 1 Nov 2023 08:28:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A3E68402DC; Wed, 1 Nov 2023 08:28:29 +0100 (CET) Received: from out203-205-251-59.mail.qq.com (out203-205-251-59.mail.qq.com [203.205.251.59]) by mails.dpdk.org (Postfix) with ESMTP id 3F5E9402DC; Wed, 1 Nov 2023 08:28:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1698823694; bh=OU5l6Egh/GD7+x/HC15Hc3RxLBBxvBdCOfOXYsFPGrA=; h=From:To:Cc:Subject:Date; b=O70Ib/Iw7IZdCv3sP1H0z/xh/W12gTUcaNN75Pn5r5lQtD83Jqm181tt8cTXQ5lTp BmDe9F24Cnjd8Sysrl9FnGiVk01TmDHH67mdUg6oRzyFCTrN6Cr4Fsn2zWmqpCO1PA /gbVT+VNjzhxm2avbEkXB6a/n797EOyXP4PhLLuA= Received: from liwg-V5320.. ([36.112.73.58]) by newxmesmtplogicsvrszc5-0.qq.com (NewEsmtp) with SMTP id 70A16C1A; Wed, 01 Nov 2023 15:28:10 +0800 X-QQ-mid: xmsmtpt1698823690tm7577oh1 Message-ID: X-QQ-XMAILINFO: ME9VhegEez8164JWX+rYDJ1odPPjiRHhpeSfoq7rOiA96rhklE7GeA9LYDS4GH ryDaAzIWMMCnh0AuAULgeKjNii9ct2aFXYdUGXkFkVwhjHkUHqP2Z+l+B6bgRovoMzGH0jLpErDc laDBAsJ7RIJolguNwgb0/k0qOEIvlZvPOMDJDO3pZoQw0NfmJWxHV6MkvmDtot29OAP/Kk7v0+SS ubY7gbgwFmCvpaXbF2UBZHtAI3WU+uECviXa7Yz6k6qmhWYZyFb93iY//hhepFevZEGPzURkF9ug at5wUtTbNuUNBqiFW0HZXKXzI6nW5MnotsRs0+Ah9r710cTRvEJ+mYX4J3d1cidN1g1HLUKUVwP1 j5sNPXBwY8qpc1ycZe9sivR7qh8tBBIeFKE4EzwYVQxZxnMvJqi7Oa6Deovq3aU2GwhTnYXb7/Vo EwL3ER8+OG8EJX98vbOqMzLWMRr1ijZ8QRCblRmjG6KhxtwQllqNXq1XKOndsMMMa4FNjpq9Jhi9 qFHiGpyrQpDdn2NITaEZ++HcwP0HhsW2aKW0c1WeVk9NV2qoiOiO/qWTJ8wCe0xfXdMoihPzB4+I ust6j5WtXtAIBEMQw7gGg2PVQ8G7YDEVtHn7WbwfN3/oKOIkAdM2sefd3SKv0AMZ6z7es6Cxll8I L3+1FI9h8+IpZdmpZfoPanZTmyjbcgygoLmS6pznBlWociS7pZglseeoT84zwGOSiy3WhizDJTBe oEorpjaqxPI/t7ppIWHmyol+czwRN5lcCw7ga2S/W7vywrNJcJLZlAb4lx6xUq8+Yh811uQHWZBu oOY924M0x5j5tHecPOLwIcFgs8wqJz1EOoDc+idwT/gk0IKMPRan19sxmRRJrW4mGyCeWcrF7YEF NTL+XIBNyhHtaNuYq5JSBnLdp0wpkalFJDCJs9Rv24Md3EIsruYfwjyngZVZNJjO3Bhp7pH0YP+4 7xkiDX/6jV2EvRFZz1uXnkogQsuc50Lq7g41YCXRA= X-QQ-XMRINFO: Mp0Kj//9VHAxr69bL5MkOOs= From: Weiguo Li To: johndale@cisco.com Cc: dev@dpdk.org, stable@dpdk.org, Weiguo Li Subject: [PATCH] net/enic: avoid extra unlock when setting MTU in enic Date: Wed, 1 Nov 2023 15:28:09 +0800 X-OQ-MSGID: <20231101072809.1830768-1-liwg06@foxmail.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The 'set_mtu_done' goto statement is being executed in a context where the 'mtu_lock' has not been previously locked. To avoid the extra unlocking operation, replace the goto statement with a return statement. Fixes: c3e09182bcd6 ("net/enic: support scatter Rx in MTU update") Cc: stable@dpdk.org Signed-off-by: Weiguo Li Reviewed-by: Ferruh Yigit Reviewed-by: John Daley Signed-off-by: Weiguo Li --- .mailmap | 2 +- drivers/net/enic/enic_main.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.mailmap b/.mailmap index 3f5bab26a8..b4f0ae26b8 100644 --- a/.mailmap +++ b/.mailmap @@ -1500,7 +1500,7 @@ Waterman Cao Weichun Chen Wei Dai Weifeng Li -Weiguo Li +Weiguo Li Wei Huang Wei Hu Wei Hu (Xavier) diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c index 19a99a82c5..a6aaa760ca 100644 --- a/drivers/net/enic/enic_main.c +++ b/drivers/net/enic/enic_main.c @@ -1639,7 +1639,7 @@ int enic_set_mtu(struct enic *enic, uint16_t new_mtu) * packet length. */ if (!eth_dev->data->dev_started) - goto set_mtu_done; + return rc; /* * The device has started, re-do RQs on the fly. In the process, we