From patchwork Thu Nov 23 07:27:30 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sivaprasad Tummala X-Patchwork-Id: 134553 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A99D4433A3; Thu, 23 Nov 2023 08:27:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CBEB842EFF; Thu, 23 Nov 2023 08:27:50 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2063.outbound.protection.outlook.com [40.107.223.63]) by mails.dpdk.org (Postfix) with ESMTP id 3703D402C2; Thu, 23 Nov 2023 08:27:49 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ebQ/JXBHRpBJZ2Pb3H04nJj6A4GweOcP77QtsjwyDJCIUqOvBU2rCrSmQJjeYzoR20mwLk0yniTQvAyWLkiu+51nS6FTji/rKRhg5YYe2kNL+P7NXjiJSpk27kYpoWrAia+nOmNbyNzhEBu05KG8yJP9nuZIL3vYMcm+4wcBNfQS8WfC2D+/MsHk60zbHtU3KEv0swFhlLXLgezIkJAvejzWVTnlITfapkS37WQKpracSig5nFmjTZ4X4vy3plP4LrVqyD5HmS7ahsrupYHOxYWpgLUhTItPvBKpKq2GZqEHDAWbVqbH832ah1b6kav2SpcOX59yMOnR/+Lnw+YKtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=sij12nQfOrUsuq5GOdcURCH+XHOakYOrPbCjnTemKtM=; b=husOBXkwKIVpTYC22LdlT1n16WLz8i7KCmyS3vJobW30ZMI+qeEmekc6kxseNInCyKejWYXlOsD1MDV3Lkf1RF2PyYOKe+gprtOxQACmL7jjSyh/q17L8CjljFZzLGlVNWZinjkT3TgCQyuAWOB61EEXOBfL2HirIPB9JqdRugwD3IGnPG74ckyRiAgqMqiL8UtDGlcU1orWz/XEGSWf9UtY4o3/+jj6jF/enLsy2rhZ0f31j0+OKF6Z3ueuXn5t0igpu4jVhQnJaI0gjG1xbsohiI/bVriNMs13h1pilzvD4z3yXoFQ++M1DsbPEvy9uZUiGvUmxUvMEnFGF/RbmQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sij12nQfOrUsuq5GOdcURCH+XHOakYOrPbCjnTemKtM=; b=HCYeD2O9NwI/NeljTOumzw9H9eg9HZKKJAvolMlzsVHmktER/HGZYVTwrUrjmA2FX+cva4gVd9HF7kyUOT6iDxCjPxRhXqng7MU9B9MDfEe8hq9qVik90aqYJwXHR2OciEghUXmJFJCsPom7SNhZeLTf53UOW33Gd9+D/h7U0uo= Received: from DM6PR07CA0053.namprd07.prod.outlook.com (2603:10b6:5:74::30) by CY5PR12MB6131.namprd12.prod.outlook.com (2603:10b6:930:25::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.19; Thu, 23 Nov 2023 07:27:46 +0000 Received: from DS3PEPF000099E2.namprd04.prod.outlook.com (2603:10b6:5:74:cafe::bf) by DM6PR07CA0053.outlook.office365.com (2603:10b6:5:74::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7025.19 via Frontend Transport; Thu, 23 Nov 2023 07:27:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DS3PEPF000099E2.mail.protection.outlook.com (10.167.17.201) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7025.12 via Frontend Transport; Thu, 23 Nov 2023 07:27:46 +0000 Received: from telco-siena.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Thu, 23 Nov 2023 01:27:44 -0600 From: Sivaprasad Tummala To: , CC: , , , , Subject: [PATCH v2] eal/x86: add AMD vendor check to choose TSC calibration Date: Wed, 22 Nov 2023 23:27:30 -0800 Message-ID: <20231123072730.22948-1-sivaprasad.tummala@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231109052820.2129745-1-sivaprasad.tummala@amd.com> References: <20231109052820.2129745-1-sivaprasad.tummala@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS3PEPF000099E2:EE_|CY5PR12MB6131:EE_ X-MS-Office365-Filtering-Correlation-Id: e47249e6-8e10-4e9a-75f7-08dbebf5b066 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: aD12xo08VJKhtoRUwyzYxEmdR7Z9ZHlSuBm9z5RLWSb/qwMGcLGfheQZaPgyJ4Xp1OTDu8x3dhdmX2SWfuEr0/RaMkHHJsfILVZHo31bylviF+3j5JAGBiaOWQqILQ1eaCy9HHoGkOYa9urnjYVoXgKSUcMcu9T67igMO/4BIcDdG9cS/0iCattjCkoSfpxqzQHaANFAORcOKvAEXvUncCV5fnz4lPx1NfIEja+9PRHko1P8lnqrku+y/lZ+AmUYr+AkFaLfbqFMMjGi5XOZqrbK0g6aNa4DopBasEHaAQeyzTmVM1i3gl8rasAz1mNRWbuqcpa5MhaL3AfJ8/YmNjTKE0P7vBzkM6CeAIqwVpQLkseoRxYS0XV9CFVskzFoO+EiYkKFv2N1WOsf9imK9fv2N4Wf+84MCLGH1tLp+o2tY3qQu3GxZECad5hYGO3dIgSrovA6Ij13Gdg4JDLpq1Qs42n7f5E6jlX6cLMUrnq097KL3Y5CIpuqnyTAxTUxf6+10LVqMia4IgNMqV24BIfvKZZKJytmJ3J0swP7lGH1ZK8sc8QUfFsO8/oHJ9n5eK/kQnfgFdwdP5g4MEx6U4Is/pBsm+T9A7XfkxYwK8v9Nx0Bk5LzsXUEJndYAv0tIEETESDeku5M+9Aj4J/TKTOLsAEh5fDu2BUqQUCxXZX3VzgiD2UvAfWd3O1U5k0s1W8wPT/T2Z9uIdOZLMLps8Vqpd1qsz7Xe9ykgXCof+X/t1Cxow6Xt6/dUOkySt2HezZtjxc98kU0CYfnJcNvHw== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(4636009)(346002)(376002)(136003)(39860400002)(396003)(230922051799003)(451199024)(82310400011)(1800799012)(64100799003)(186009)(46966006)(36840700001)(40470700004)(40460700003)(26005)(426003)(1076003)(6666004)(7696005)(83380400001)(2616005)(36860700001)(44832011)(5660300002)(47076005)(4326008)(8936002)(336012)(8676002)(41300700001)(2906002)(478600001)(316002)(16526019)(54906003)(70206006)(110136005)(70586007)(86362001)(82740400003)(36756003)(81166007)(356005)(40480700001)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Nov 2023 07:27:46.0514 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: e47249e6-8e10-4e9a-75f7-08dbebf5b066 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS3PEPF000099E2.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6131 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org AMD Epyc processors doesn't support get_tsc_freq_arch(). The patch allows graceful return to allow fallback to alternate TSC calibration. Fixes: 3dbc565e81a0 ("timer: honor arch-specific TSC frequency query") Cc: jerin.jacob@caviumnetworks.com Cc: stable@dpdk.org Signed-off-by: Sivaprasad Tummala Acked-by: Ferruh Yigit --- lib/eal/x86/rte_cycles.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/lib/eal/x86/rte_cycles.c b/lib/eal/x86/rte_cycles.c index 69ed59b4f0..f147a5231d 100644 --- a/lib/eal/x86/rte_cycles.c +++ b/lib/eal/x86/rte_cycles.c @@ -10,6 +10,10 @@ #include #endif +#define x86_vendor_amd(t1, t2, t3) \ + ((t1 == 0x68747541) && /* htuA */ \ + (t2 == 0x444d4163) && /* DMAc */ \ + (t3 == 0x69746e65)) /* itne */ #include "eal_private.h" @@ -110,6 +114,18 @@ get_tsc_freq_arch(void) uint8_t mult, model; int32_t ret; +#ifdef RTE_TOOLCHAIN_MSVC + __cpuid(cpuinfo, 0); + a = cpuinfo[0]; + b = cpuinfo[1]; + c = cpuinfo[2]; + d = cpuinfo[3]; +#else + __cpuid(0, a, b, c, d); +#endif + if (x86_vendor_amd(b, c, d)) + return 0; + /* * Time Stamp Counter and Nominal Core Crystal Clock * Information Leaf