From patchwork Thu Dec 14 11:30:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bruce Richardson X-Patchwork-Id: 135199 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39429436EF; Thu, 14 Dec 2023 12:30:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1DDFE43258; Thu, 14 Dec 2023 12:30:34 +0100 (CET) Received: from mgamail.intel.com (mgamail.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 0084543250 for ; Thu, 14 Dec 2023 12:30:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1702553433; x=1734089433; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=f9yHyg2z9Xdyk+qeJJUdgvy9ggbGZmHvBl97TvYWDos=; b=WGPY9aJfH1ra9qLIJLdXIJiMdoBuImff3SVxsU1bLtvZaE9KIF03IQ+7 bp3EFMzBlm5rRIxJryadD8w2euvgnn72im3SzlltW5y88gUEFUBWYWE+i u2Es/MPhQL+fPjq50aa1FmomdZYaDd79RyBLKMGGYD3vI3MJRuDB7R/40 Jk18fM0hb8QnwpNo3vXj6V4LDm4JUXxtrvfWskXhNTtHMS6Uty/KwYIB+ EqeQYDEqK4841QB8JeLs18UQPykZpf2fA1Baj7f+NQUYB91V5k07xlHeV 1Bl56NwWBPC6VJ6NPccdMOie+gjgoUEl+dMYGzLQUwxWIVn6yitsNfxaD w==; X-IronPort-AV: E=McAfee;i="6600,9927,10923"; a="393978181" X-IronPort-AV: E=Sophos;i="6.04,275,1695711600"; d="scan'208";a="393978181" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Dec 2023 03:30:28 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10923"; a="724033603" X-IronPort-AV: E=Sophos;i="6.04,275,1695711600"; d="scan'208";a="724033603" Received: from unknown (HELO silpixa00401385.ir.intel.com) ([10.237.214.152]) by orsmga003.jf.intel.com with ESMTP; 14 Dec 2023 03:30:26 -0800 From: Bruce Richardson To: dev@dpdk.org Cc: Bruce Richardson Subject: [PATCH] app/test: remove ifdefs for cmdline library Date: Thu, 14 Dec 2023 11:30:21 +0000 Message-Id: <20231214113021.517622-1-bruce.richardson@intel.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The DPDK unit test binary relies on cmdline library and cannot do anything without it being present. As it's a mandatory dependency we can remove the ifdefs for it from main.c Signed-off-by: Bruce Richardson Acked-by: Tyler Retzlaff --- app/test/test.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/app/test/test.c b/app/test/test.c index bfa9ea52e3..c818fda17b 100644 --- a/app/test/test.c +++ b/app/test/test.c @@ -11,13 +11,11 @@ #include #include -#ifdef RTE_LIB_CMDLINE #include #include #include #include extern cmdline_parse_ctx_t main_ctx[]; -#endif #include #include @@ -106,12 +104,10 @@ int last_test_result; int main(int argc, char **argv) { -#ifdef RTE_LIB_CMDLINE struct cmdline *cl; char *tests[argc]; /* store an array of tests to run */ int test_count = 0; int i; -#endif char *extra_args; int ret; @@ -183,7 +179,6 @@ main(int argc, char **argv) "HPET is not enabled, using TSC as default timer\n"); -#ifdef RTE_LIB_CMDLINE char *dpdk_test = getenv("DPDK_TEST"); if (dpdk_test && strlen(dpdk_test) > 0) @@ -259,7 +254,6 @@ main(int argc, char **argv) cmdline_interact(cl); cmdline_stdin_exit(cl); } -#endif ret = 0; out: