From patchwork Wed Feb 5 17:19:54 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 150992 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D71F2461A0; Wed, 5 Feb 2025 18:20:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 03EC040647; Wed, 5 Feb 2025 18:20:12 +0100 (CET) Received: from mail-ot1-f44.google.com (mail-ot1-f44.google.com [209.85.210.44]) by mails.dpdk.org (Postfix) with ESMTP id EB1F840647 for ; Wed, 5 Feb 2025 18:20:10 +0100 (CET) Received: by mail-ot1-f44.google.com with SMTP id 46e09a7af769-724d1724657so590500a34.0 for ; Wed, 05 Feb 2025 09:20:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1738776010; x=1739380810; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=onggoaSB4OGPwR+btJrL8sA9fW6PZ0Eyq7UEXHv4zIk=; b=fhjdW54HVWcPfa4F54+z3pytqrgj8MXyRMpKp93BAtRgNQZxAiS4dPpAFFxUU7vyDl z3RLIZ5K7/S2zWUalhTR2wmxyA6QgTqEC7n10unjnorQ+HawcscV12C5KhAFzzGk8zA6 gzq5GS2Psv9fjqZ1MMO6UwWDF6thDpTrtWkPQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738776010; x=1739380810; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=onggoaSB4OGPwR+btJrL8sA9fW6PZ0Eyq7UEXHv4zIk=; b=oDTAjLF9Mz7B0DXilOmYeC4SeYk8haUKTKAhf1PW1tS/ithHr5hPmgXosvYpnoFxrj A1gweOcScEGWVfE3s1396RzOF7zzm555Me1qHebJ+Dljj86LUNZok8pI3NYc9WWDXzQy xZrkZ5IEWO2QBYgO63lnNCkDclXgS6hPHKn9wBe+gREQSDB6yzqOamUAgVYti7MHQ1YS hIdsL57EmB3ihk3Um96G6GaoxgKFR8mrmABOtoMhnVqQ7een5ezfWjHzLCcf4TdrdB0a T5tuniAGZX4EAe2Ayd+gwF47hMjcOsN8iKNKr+qvW3FVGXIrj2uR4A8BqQbLd4tKASt/ Ltzg== X-Gm-Message-State: AOJu0YyhZxNNllZIy0aq1jSRvcoCrqKvdMfMx9/z9j5XRmJJhWkRNXUC W4q9SAQCcZc3e9eMmY3r+VabhxyDYymH3t8POOYd9YQEfvsrjrX0B8hN+TFh5OlHbD1CwU/3hnT K7Lv7Uxfce87ki1Sa1W6RHfWMsBzM0RjUDDB87GMrryf3WuwWJht7TTxD+wMyEIAlOu8FdcojwL 04qIY8ifjBTvvm0kczZCXa+FCpahYr X-Gm-Gg: ASbGncshsEwc56tlH1NpEIxMT2EGJH3Q/G2YKq+uhuFmrVGMmqUSqkWULzNYGUBXeml zwFAx1gbI+xMlSqk50G6niPfClSulqnI0VUDgSTKynaXUKcxtEWtzrVNpsM6y52KB7LA0bwqW+3 dCIq2mwlfCofh20qg5WTcjFkv0KCB1r/7lRTloe0X4tG0VfGrj0o9LGIZfAXhbejx6kj8+tS6jK bIkAmNOfA0u8g0BOBHNXUXK2vzmvJQdzpFCwJ8alJfr/QZMtTT28y73jnHYSNKDDptSMyYT0SLL 5bskZqr3ZZF36z/YK+pleevpZbvGtMrVFwt4bFIsVPrC08jebaCLRyqVyO9O/1Odh1tdDmgaNWi /ggFG2e2n X-Google-Smtp-Source: AGHT+IGHumOp4DSSsfY2c9bzqig2GwkKHT8NNyBdnAhavPZnTFnmIOmn3jv4AdZP0Dg14wabHP7lfA== X-Received: by 2002:a05:6830:63ce:b0:710:a425:d6b8 with SMTP id 46e09a7af769-726ad72b73bmr62459a34.14.1738776009941; Wed, 05 Feb 2025 09:20:09 -0800 (PST) Received: from C02GC2QQMD6T.wifi.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-726617cde49sm4004016a34.27.2025.02.05.09.20.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Feb 2025 09:20:09 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: thomas@monjalon.net, Kalesh AP Subject: [PATCH 01/11] net/bnxt: disable TruFlow if compressed CQE is set Date: Wed, 5 Feb 2025 09:19:54 -0800 Message-Id: <20250205172004.50395-2-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20250205172004.50395-1-ajit.khaparde@broadcom.com> References: <20250205172004.50395-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org If a user selects compressed CQE mode using the cqe-mode devarg, it is clear that the user does not intend to use TruFlow mode. Since host backed TruFlow setting is enable by default now, disable TruFlow during initialization to prevent unexpected behavior when the two get enabled. Signed-off-by: Ajit Khaparde Signed-off-by: Kalesh AP --- drivers/net/bnxt/bnxt_ethdev.c | 5 +++++ drivers/net/bnxt/bnxt_hwrm.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 21e9aa902c..81a7723c7e 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -5785,6 +5785,11 @@ static int bnxt_get_config(struct bnxt *bp) if (rc) return rc; + if (bnxt_compressed_rx_cqe_mode_enabled(bp)) { + PMD_DRV_LOG_LINE(INFO, "Compressed CQE is set. Truflow is disabled."); + bp->fw_cap &= ~BNXT_FW_CAP_TRUFLOW_EN; + } + rc = bnxt_hwrm_queue_qportcfg(bp); if (rc) return rc; diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index d015ba2b9c..305c419051 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -1731,7 +1731,7 @@ int bnxt_hwrm_ver_get(struct bnxt *bp, uint32_t timeout) if (dev_caps_cfg & HWRM_VER_GET_OUTPUT_DEV_CAPS_CFG_CFA_TRUFLOW_SUPPORTED) { - PMD_DRV_LOG_LINE(DEBUG, "Host-based truflow feature enabled."); + PMD_DRV_LOG_LINE(DEBUG, "Host-based truflow feature supported."); bp->fw_cap |= BNXT_FW_CAP_TRUFLOW_EN; } From patchwork Wed Feb 5 17:19:55 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 150993 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 94BED461A0; Wed, 5 Feb 2025 18:20:21 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1EEE840659; Wed, 5 Feb 2025 18:20:13 +0100 (CET) Received: from mail-ot1-f49.google.com (mail-ot1-f49.google.com [209.85.210.49]) by mails.dpdk.org (Postfix) with ESMTP id 145474064C for ; Wed, 5 Feb 2025 18:20:12 +0100 (CET) Received: by mail-ot1-f49.google.com with SMTP id 46e09a7af769-71e3284f963so33190a34.1 for ; Wed, 05 Feb 2025 09:20:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1738776011; x=1739380811; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=DyWYKXiW0YF4TFx49ln8odujwWD+YZUdsHR102rFq6A=; b=UY19/K9urzhXkSB2RIlQxWcwFnc1jeUCz59FYt9BkxnytScFYIhEMLvxtblG8dprjD N8fsvNkmenDt3ObAehrFPC6VRumUiWFelE0CgQVOk8wXFxz2wuVCoi/ztGTw0MW5ro2f Ysco9VtkgAw5fp7KU5Q8UdfggKx+3n+8xi/2o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738776011; x=1739380811; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DyWYKXiW0YF4TFx49ln8odujwWD+YZUdsHR102rFq6A=; b=rznLTP2IebP/mr5ibL8kzouVm1KA/83ffRHgn1rlmY5QAa5GRd8+ymZpxBiO6k6jkE T4NPXhDGWmjmx6wy1JhD839M8aDCHbXDttkbFYOsKOvKxsq3nfFdr55VUWYHE8IVUalN tcxtYpCJ+gkjEQudqCz1P50CyPgttis/SzELLSM3Sx02NAz3hJEPIicJmcKPMXE332C1 aOXsRAAYO+p8EwPuGVMAo2zr8duQu4+XLCXEFTmGcMll2bTDjCmPgmIKxPbX23JS/IEW I8iG9uFzfIztQqHchaooClUOV54Izl6JDtZy9lhp57dcI9e9Uvl6wYQqzJAM4zsBh01y Lg/w== X-Gm-Message-State: AOJu0YzNhoLUiht/DZpsckbYrBHIzmuzAE6l3RfVH69V8qep6A+Vka47 BmZ+77jF7dzwCjhnnysPxEcv7UHxnQX0XVJWRYhbdLjO6RcU04AOPFcKw+LBa2zAv8Gmb+VcGpS 6j2A+GLo52qHsBibHVEwB85dciNjoAk9Jst3eeeSNfZm+esrr+snH3OdQLrowa3llQbeuVIJqPg 5KN9ffdFdlCbWKNDeX/84pmeAOde/v X-Gm-Gg: ASbGncsaWtgjTOJRO21ZwXuwdoyYlcgkhOtOmTu2q9WlFFM4QOMlgdh0yMAoHC6KlwV huIvAgAfYesWAdBVeEgBB+e5fRvpVi7qB8XLmXW3AAVGOmR0Ci/r4uF3IIEkIJqJ4atkcnCK3/b kxepDQAjMgJxVvI3ZDbXbAmGVyDvNCZG7n0RFeRY0IkDWThkECsoqzWZRdNBt9dADm5kBL8bLzt 953+fEfIeA3fm+kTuyjm/Y/1sIk8caUSrwPIFc57SPsNvax9oY4rcfKhx//jnCC0ljQqw90n+qJ nxCy0FXH3s0gJ8FSelvkbRrUwed0/dOSPqhV1NOEDL56fHM0wSc9b+QfOwzomipnE/qjEERjqo2 lzuDhFGpR X-Google-Smtp-Source: AGHT+IEJQXtYDs6gUPSaXXVW3gn8Aoxs/Jzv5+d8SbE4k/pLU0pRE8gqmqmdZ7/qIyM+xndynoE68g== X-Received: by 2002:a05:6830:6785:b0:71e:4fc:6ed6 with SMTP id 46e09a7af769-726a418c41cmr2643631a34.10.1738776011055; Wed, 05 Feb 2025 09:20:11 -0800 (PST) Received: from C02GC2QQMD6T.wifi.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-726617cde49sm4004016a34.27.2025.02.05.09.20.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Feb 2025 09:20:10 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: thomas@monjalon.net, Somnath Kotur , Damodharam Ammepalli , Kalesh AP Subject: [PATCH 02/11] net/bnxt: simplify check for CQE mode Date: Wed, 5 Feb 2025 09:19:55 -0800 Message-Id: <20250205172004.50395-3-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20250205172004.50395-1-ajit.khaparde@broadcom.com> References: <20250205172004.50395-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Simplify the check for the CQE mode. We don't have to check the Rx offload mode to determine which CQE mode is supported. CQE mode is configured at load time and once set will decide if TCP LRO or buffer split can be supported or not. Signed-off-by: Ajit Khaparde Reviewed-by: Somnath Kotur Reviewed-by: Damodharam Ammepalli Reviewed-by: Kalesh AP --- drivers/net/bnxt/bnxt.h | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h index 4a5c224c09..c9fdd36d3e 100644 --- a/drivers/net/bnxt/bnxt.h +++ b/drivers/net/bnxt/bnxt.h @@ -1112,12 +1112,8 @@ inline uint16_t bnxt_max_rings(struct bnxt *bp) static inline bool bnxt_compressed_rx_cqe_mode_enabled(struct bnxt *bp) { - uint64_t rx_offloads = bp->eth_dev->data->dev_conf.rxmode.offloads; - if (bp->vnic_cap_flags & BNXT_VNIC_CAP_L2_CQE_MODE && bp->flags2 & BNXT_FLAGS2_COMPRESSED_RX_CQE && - !(rx_offloads & RTE_ETH_RX_OFFLOAD_TCP_LRO) && - !(rx_offloads & RTE_ETH_RX_OFFLOAD_BUFFER_SPLIT) && !bp->num_reps && !bp->ieee_1588) return true; From patchwork Wed Feb 5 17:19:56 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 150994 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EB0D1461A0; Wed, 5 Feb 2025 18:20:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9DF4F40654; Wed, 5 Feb 2025 18:20:15 +0100 (CET) Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) by mails.dpdk.org (Postfix) with ESMTP id 2C20D4065A for ; Wed, 5 Feb 2025 18:20:13 +0100 (CET) Received: by mail-ot1-f43.google.com with SMTP id 46e09a7af769-7231e2ac9e4so20804a34.0 for ; Wed, 05 Feb 2025 09:20:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1738776012; x=1739380812; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UWuAYBaKgdX+Un9qXrfMRRvrRrfbiYfltFAhwI4YYjU=; b=EGQnrqfW1S+ej/YpRY0CgwSlKhCMTcb5FQPq7JZn49rgmBzFqYedEfdRQ44e8nXwHA kN5wgvybVYrIA78NDdEo/NW85bG2otlvWagCeP6HTgfh0ENPVKFGMZMHU5ivl/9Zwklr LQntXZY1KaKWzf39Xacn095oZMim/3ZyDNwzo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738776012; x=1739380812; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UWuAYBaKgdX+Un9qXrfMRRvrRrfbiYfltFAhwI4YYjU=; b=deVDofr40c4vmYmqmTxSmsfiiIBWxPwMKHfB/DfYX0cSD/oDH0lT0WaggVYMazbMAa HaNN0YnPTdJMNUFqI39aiYUoOkA3U0C6L825wo1z3vTINyYb9/rftctMU/TBXla2ie69 Zjn1Phcn7VUPMs+s3dOetNijzeqd6QsTsCbQ7uAcF4IhX9/dqpEDi/Sn+W9ITqCjOVTO zv1HoxdwtGDQn5xtieDTPUDyCyW6Cap5gwIlSP/9LpApa4cxP3vBMjZyCKz93xNnaYMf xc9GRqnNB3SS6e6/vWqV9vQu8eybHa9iyrmHCWrGwKl9sPJGxGreYarcHm/l5pV00ftR xtAg== X-Gm-Message-State: AOJu0YxSREF7HGHdfIB3YlfYwn7bJsNBULhCxuiSOyeyrn8+R+8DZkGw zub7G9vj7wG5ekp0kvTng0aZUhP+MavAzxOdU5PxmkECmzEJF0IDUC1M13NCpvr11fY9uXWNbm0 jbj1dYfiYYl9vEJADNU6pIpzMPxQeY558f2RZygWpTpyUPrQypmTl6kZDzZHCxox6h5R0jf6CXt mrhYKWPSumS7RJlS2/0DFZVy4+NxgS X-Gm-Gg: ASbGnctSRyjB20vyg3Lfgsf1l2HHsotWcRIllZxDnKMfO+jaQJeLubBSKA9C9WWM82P +hMCyUNYZtOnCN74qKm7DeUbXBvFtLJjw8FBT3fff6hQdNUMYYd+9LIn2DWUoHjUamqb9gPnjzx cVvxxPByhDaLucewIC36cD8ElIHOyCHUNQKNTj5ml3eNen6xFed4lvZOBEXkRcNe3VRFmlAlTHd fATWmlD7E2ZvA9+5B3gLbm3SqmC/A9KPI5UiGNUa70kKKCzkC2Qml3NnD+gLMyMQG3z4ezUJ4ab M1jq/nAAsw7Sk+Kq/2vwZCohABG2BraCGaHP+XyM809Bi6ErWbsw5E/XBWW91Hpjgc29r+jiTK/ 3B93G10v0 X-Google-Smtp-Source: AGHT+IG77WQaBQZ8y0P6leCDQoBeW9cQFuJeID2hfjfB+XnLIkGxwlL/IGev08fVgNa3V+ybkQBhZw== X-Received: by 2002:a05:6830:4487:b0:71e:f1:3e1 with SMTP id 46e09a7af769-726a4145e06mr2659586a34.3.1738776012198; Wed, 05 Feb 2025 09:20:12 -0800 (PST) Received: from C02GC2QQMD6T.wifi.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-726617cde49sm4004016a34.27.2025.02.05.09.20.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Feb 2025 09:20:11 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: thomas@monjalon.net, stable@dpdk.org Subject: [PATCH 03/11] net/bnxt: fix Rx handler Date: Wed, 5 Feb 2025 09:19:56 -0800 Message-Id: <20250205172004.50395-4-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20250205172004.50395-1-ajit.khaparde@broadcom.com> References: <20250205172004.50395-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Fix the code accounting the status of compressed CQE handler. The code was inside the block handling the normal CQE mode. Moved the code out. Without this the Rx datapath was broken for compressed CQEs in scalar mode. Fixes: 5c980062d895 ("net/bnxt: support compressed Rx CQE") Cc: stable@dpdk.org Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_rxr.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c index 5b43bcbea6..b53d9a917a 100644 --- a/drivers/net/bnxt/bnxt_rxr.c +++ b/drivers/net/bnxt/bnxt_rxr.c @@ -1390,14 +1390,6 @@ uint16_t bnxt_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, } else if ((CMP_TYPE(rxcmp) >= CMPL_BASE_TYPE_RX_TPA_START_V2) && (CMP_TYPE(rxcmp) <= CMPL_BASE_TYPE_RX_TPA_START_V3)) { rc = bnxt_rx_pkt(&rx_pkts[nb_rx_pkts], rxq, &raw_cons); - if (!rc) - nb_rx_pkts++; - else if (rc == -EBUSY) /* partial completion */ - break; - else if (rc == -ENODEV) /* completion for representor */ - nb_rep_rx_pkts++; - else if (rc == -ENOMEM) - nb_rx_pkts++; } else if (!BNXT_NUM_ASYNC_CPR(rxq->bp)) { evt = bnxt_event_hwrm_resp_handler(rxq->bp, @@ -1407,6 +1399,14 @@ uint16_t bnxt_recv_pkts(void *rx_queue, struct rte_mbuf **rx_pkts, goto done; } + if (!rc) + nb_rx_pkts++; + else if (rc == -EBUSY) /* partial completion */ + break; + else if (rc == -ENODEV) /* completion for representor */ + nb_rep_rx_pkts++; + else if (rc == -ENOMEM) + nb_rx_pkts++; raw_cons = NEXT_RAW_CMP(raw_cons); /* * The HW reposting may fall behind if mbuf allocation has From patchwork Wed Feb 5 17:19:57 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 150995 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A2FEF461A0; Wed, 5 Feb 2025 18:20:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 979F24066C; Wed, 5 Feb 2025 18:20:16 +0100 (CET) Received: from mail-ot1-f45.google.com (mail-ot1-f45.google.com [209.85.210.45]) by mails.dpdk.org (Postfix) with ESMTP id 8091F40667 for ; Wed, 5 Feb 2025 18:20:14 +0100 (CET) Received: by mail-ot1-f45.google.com with SMTP id 46e09a7af769-71e3284f963so33211a34.1 for ; Wed, 05 Feb 2025 09:20:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1738776014; x=1739380814; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AmgHhcZZlQatMO0TcMOaHZ5yw3xVSSdvoQBasv4ZB40=; b=cBTQDdgOApx+uaQ9ZKHkbB4SSwl878jKuPtVEaZ69nnaEpxH0eYPPQE78yBP81NsUY lpDse7GMwNpHLXhzKQCXyBaLbDXugTuC69fSJnUmuRdJcY3K+3B6prDkLhEschm+x0bI aDW344Qgyecx85G4IX3k3i0+H6pHIXaf5PaUU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738776014; x=1739380814; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AmgHhcZZlQatMO0TcMOaHZ5yw3xVSSdvoQBasv4ZB40=; b=VMgg+yuL1ObGK7RBGTkoxbHFY2ld6P5FnPypItczlBDsFyyBK5sfYtB09+5CZkY9dt 1Q85gp/cBMulm8KieWbHEkur7A8tA4MviTCDi3ghdofFAAus2FG/jf4HsHi0RUXEZxRx S2breKKK5IRDZGyn3kAcmOamEc3I2MhYBaPO/9hD3JgwNSGRiE3q2YdCE4NpKmcnpcUK lleOFw/R4GDDDSbMkSzjRT58TXqVSbNKwdRarWUXZ5nVpO70j0+sg/QxvbVaPPVxJnJD xuayoYxdD7ShsFBZtBwa8SJF+h202l/oM6lwrYpVclj36+vMqNWzwOw8nu2RSI97qWBc 6JfA== X-Gm-Message-State: AOJu0YxFp8MgqSM5zYq568msAVwIye78QGnixAWUH6r3sCOrEw2RDbZF hHhk6MnCmXRi+msB8bIxx9Ep0Z0nshvqj4FuPrGT/baF3NqMd8jT4/gi2UlFeVD5C4u3OjUy42Z fPmty1zdL+OaoS4R5zyowF+6zx+w8vNus5tIFLNZX7ntwmkVvI9+v+PN/T/c3aqUjiB1xwQZI3I vg+tvnsc+QGHGvSxf0A+sgLqhYUFUp X-Gm-Gg: ASbGnctvbPm0kWb2FzX+dATfpFUddPTVq1vrDigIZKXM3fdZKioR1qVTJUg8vpMICm4 vrNDXhfomYC4R7rEqd9iWtRvhlcqxQ9YCiLUIdH6s6YFkdCB4h8mgRZpHl5NekxqDCnmV0s2EPo l5BpN1nwJ23qfSPauPQwyS5OU0Q3TY5J8+baRIDPRDtSRnNTXtg/GkBI6XbTV25QN09GX3XBfC+ /bL3Mg0x2owqRrfuA59kTajsN71zbSvSBXThyZJpRUnsLpl+Z5iBlj8vVQfPP9DCVZU/E3MqDYB vLW0fFoC2R2JP3oHLe3b8SadstFjLjBWdlH4wR261+FCtASRsyDVfWGXx7pOepY9SEhVdDLdwlf /cjCPngGr X-Google-Smtp-Source: AGHT+IGEGoTYtqOdN0ZjNKTOE0Am/1dUUE2rsUC5PVa9kQxHFK0reiluaJc1GEe5NSZSKJGRYnhWNQ== X-Received: by 2002:a05:6830:6303:b0:71d:b6a9:7489 with SMTP id 46e09a7af769-726a41870c6mr2706428a34.7.1738776013692; Wed, 05 Feb 2025 09:20:13 -0800 (PST) Received: from C02GC2QQMD6T.wifi.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-726617cde49sm4004016a34.27.2025.02.05.09.20.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Feb 2025 09:20:13 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: thomas@monjalon.net, Somnath Kotur , Damodharam Ammepalli , Kalesh AP Subject: [PATCH 04/11] net/bnxt: set burst handler correctly Date: Wed, 5 Feb 2025 09:19:57 -0800 Message-Id: <20250205172004.50395-5-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20250205172004.50395-1-ajit.khaparde@broadcom.com> References: <20250205172004.50395-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org We are incorrectly setting the Rx and Tx burst handlers to static mode by default. Fix that by using the bnxt_receive_function and bnxt_transmit_function calls to determine if the vector mode is enabled and identify the appropriate burst handler during the initialization. Signed-off-by: Ajit Khaparde Reviewed-by: Somnath Kotur Reviewed-by: Damodharam Ammepalli Reviewed-by: Kalesh AP --- drivers/net/bnxt/bnxt_ethdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 81a7723c7e..b18247feb2 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -6532,8 +6532,8 @@ bnxt_dev_init(struct rte_eth_dev *eth_dev, void *params __rte_unused) eth_dev->rx_queue_count = bnxt_rx_queue_count_op; eth_dev->rx_descriptor_status = bnxt_rx_descriptor_status_op; eth_dev->tx_descriptor_status = bnxt_tx_descriptor_status_op; - eth_dev->rx_pkt_burst = &bnxt_recv_pkts; - eth_dev->tx_pkt_burst = &bnxt_xmit_pkts; + eth_dev->rx_pkt_burst = bnxt_receive_function(eth_dev); + eth_dev->tx_pkt_burst = bnxt_transmit_function(eth_dev); /* * For secondary processes, we don't initialise any further From patchwork Wed Feb 5 17:19:58 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 150996 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 50E4A461A0; Wed, 5 Feb 2025 18:20:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 14B9B406B8; Wed, 5 Feb 2025 18:20:18 +0100 (CET) Received: from mail-oo1-f46.google.com (mail-oo1-f46.google.com [209.85.161.46]) by mails.dpdk.org (Postfix) with ESMTP id 092164066C for ; Wed, 5 Feb 2025 18:20:16 +0100 (CET) Received: by mail-oo1-f46.google.com with SMTP id 006d021491bc7-5fc0c06e1deso3406682eaf.1 for ; Wed, 05 Feb 2025 09:20:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1738776015; x=1739380815; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=O85u+27WVnGagTl4sTWvq49mCi5oT6PwWx/mi9+I9+g=; b=TDTlphgponTIiKzcFpMA3RV8XsH9679+4HDai/NEhOH/02LLkneFxnwLhgXIB/cux5 K22zSbJgioGRankeyrOWnMUmt8UYTLf3av6h7OZhp4R5GRTVmg5Eg/IVZI0387c0gkEX s07ely5kim/88OfyC6LkuyXa5KHQzEF4Md4xg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738776015; x=1739380815; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=O85u+27WVnGagTl4sTWvq49mCi5oT6PwWx/mi9+I9+g=; b=OAK+0QrUPHF79oCP0E7iKUJvmO6HtNKb9vyCGgchSgjyHIncVWJhi0263Cf8y99g/j 5jfXp+l8eGmolr1jfT7IdHzqIpdLUa6OpIIu90vvSd9Ku1kJ0p+1D8PGXd0GAYIK+gSK En/pdeZyYCOGlpf73a2mG0gmPUa58aPqoIAqwBh/v4+8DFrOh3HVlQLONc2R/UTtfVFv nJSZLNP9XfjbHom9p5UVR+00miO81wtb6lqzD4OdW30x3a14Gm9JkQCsAQb3NFyWkeqD wl96tIQM0bDrdzvFFK8OjHo6n1nWRJWXe88DUADt40NaONgdCWHqPPUXIDK+Pl03gJX7 nAgQ== X-Gm-Message-State: AOJu0Yyc/p05uuJ46Zbp5KYDhB8idKw6RnBvEsM4YLU0bpa+uYrGMVwp 1fvsGnE8jgzCZ/3UAcEn7JfBRY6OICBLroqVs6eEVdZoQkxqaEr9UubJTXNYaGip1NkzXt16jUU AmTFoKb+Oi2cSpYgKMbVwHqZSDG745o0pRi9k2E5qy91kryhaV0Bcbl7esakjeRjZJLp0mBptr2 rJSq9ohHvuZtOnrwACRMcIIPlXiJST X-Gm-Gg: ASbGncsancGs2l94tamUeiA3e+5XloLsRjN6KKMz+gbEwCM0RmTtxkWKchGwHP3udeB wEbCNHkh1LOV5P6fXWRa/LupVs2HSamQCgBXCo2/TeZS4+yBTbu8XVJXWsuFTJ7t5ggjQFREg/b WCRjsByxHbx5MjNbku4ywApI9DpsI7IIn6qaMw2mJlNy7UgucNkF551sajudOEVMA2aTp86Jn4h eLdlaNSD/QS0nAGKLuJvucHXhvKhQ0YNnED8XLhLo6O4zr18lzy/BCY9NxDdHeryWxmXX34mMqJ zy39e2W+5Vxx9mktheMiT6dKXts3GFWt5IIwblrQ7iA84LmDukrH0g6mFwml0k07b1IjsPeGSnl 3mPJeY5j/ X-Google-Smtp-Source: AGHT+IE/LDrTMRXefw2ov4zhT2g/2ARVxAO31ZYHSgYEdsOzqI8rH7iuTFsT0DWYZ2ae79ZH2ejsOQ== X-Received: by 2002:a05:6820:2787:b0:5fa:6805:645b with SMTP id 006d021491bc7-5fc479cbc96mr2751736eaf.6.1738776015086; Wed, 05 Feb 2025 09:20:15 -0800 (PST) Received: from C02GC2QQMD6T.wifi.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-726617cde49sm4004016a34.27.2025.02.05.09.20.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Feb 2025 09:20:14 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: thomas@monjalon.net, Sangtani Parag Satishbhai , stable@dpdk.org, Somnath Kotur , Kalesh AP Subject: [PATCH 05/11] net/bnxt/truFlow: Fix seg fault when rep are re-attached Date: Wed, 5 Feb 2025 09:19:58 -0800 Message-Id: <20250205172004.50395-6-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20250205172004.50395-1-ajit.khaparde@broadcom.com> References: <20250205172004.50395-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Sangtani Parag Satishbhai When the PCI port is detached using the testpmd command, as part of cleanup testpmd removes resources of parent port and all the children's ports and calls the driver specific pci_remove API with the parent rte ethdev to clean-up ethdevs. For the bnxt driver, a condition to check type of ethdev is added in bnxt_pci_remove and based on the condition relevant ethdev is removed (VF/PF or VFR). As the RTE layer always calls PCI remove with the parent ethdev, the bnxt_pci_remove never frees children (VFRs) ethdev. As, these ethdevs were not freed it gives spurious status in re-allocation check(when pci port attach command is executed) and when RTE layers tries to access interrupt specific info from the ethdev due to uninitialized members it access NULL pointer which results in seg fault. The fix is made in bnxt_pci_remove to clean ethdev for parent (PF/VF) along with children (VFRs). Fixes: 322bd6e70272 ("net/bnxt: add port representor infrastructure") Cc: stable@dpdk.org Signed-off-by: Sangtani Parag Satishbhai Reviewed-by: Somnath Kotur Reviewed-by: Kalesh AP Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_ethdev.c | 22 +++++++++++++++------- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index b18247feb2..144d4377bd 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -6993,6 +6993,8 @@ static int bnxt_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, static int bnxt_pci_remove(struct rte_pci_device *pci_dev) { struct rte_eth_dev *eth_dev; + uint16_t port_id; + int rc = 0; eth_dev = rte_eth_dev_allocated(pci_dev->device.name); if (!eth_dev) @@ -7002,14 +7004,20 @@ static int bnxt_pci_remove(struct rte_pci_device *pci_dev) * +ve value will at least help in proper cleanup */ - PMD_DRV_LOG_LINE(DEBUG, "BNXT Port:%d pci remove", eth_dev->data->port_id); if (rte_eal_process_type() == RTE_PROC_PRIMARY) { - if (rte_eth_dev_is_repr(eth_dev)) - return rte_eth_dev_destroy(eth_dev, - bnxt_representor_uninit); - else - return rte_eth_dev_destroy(eth_dev, - bnxt_dev_uninit); + RTE_ETH_FOREACH_DEV_OF(port_id, &pci_dev->device) { + PMD_DRV_LOG_LINE(DEBUG, "BNXT Port:%d pci remove", port_id); + eth_dev = &rte_eth_devices[port_id]; + if (eth_dev->data->dev_flags & RTE_ETH_DEV_REPRESENTOR) + rc = rte_eth_dev_destroy(eth_dev, + bnxt_representor_uninit); + else + rc = rte_eth_dev_destroy(eth_dev, + bnxt_dev_uninit); + if (rc != 0) + return rc; + } + return rc; } else { return rte_eth_dev_pci_generic_remove(pci_dev, NULL); } From patchwork Wed Feb 5 17:19:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 150997 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 876AA461A0; Wed, 5 Feb 2025 18:20:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 51E8140A6C; Wed, 5 Feb 2025 18:20:19 +0100 (CET) Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) by mails.dpdk.org (Postfix) with ESMTP id 9004140678 for ; Wed, 5 Feb 2025 18:20:17 +0100 (CET) Received: by mail-ot1-f50.google.com with SMTP id 46e09a7af769-71e2aa8d5e3so25406a34.2 for ; Wed, 05 Feb 2025 09:20:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1738776016; x=1739380816; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7elrpdX6I2KNDHaXAB43jtrTXsgFvTpORSZdo3PoEBE=; b=PTvvv5kkoCBYOobYIthoRqI35ASBdbWoF9BuhiVTyIRer4qx6EatiUb/2mmtG080Lr huzNe67dQPX3jg1en9XOiN77j8mMyK1ddoPxgYmV0/897fZhz8yY+OjZkFYEJ9F0Zy5p pMm1HdWerO7y+IY0bWj0Q+n/2LNSzqprQtjAY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738776016; x=1739380816; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7elrpdX6I2KNDHaXAB43jtrTXsgFvTpORSZdo3PoEBE=; b=WEpF2DHSTWy0/cfSNHBZttWga0/y8w75XlsL+VBWr3lyfUzFvxP3Co8gK4z+6/PsUt nldAZsegVTL69Ctq6iI8BLGEO9ea6sLM5Mf+SDTd5YYL/Nr3jLmL2Iiub7DWETeMexcg T1BCfhX1RuIfuoplE3ySOF8TmLpljUXl1I5YJxbj1N55XguEI4btXhdH8uvo+AnqS8x6 +HkqseyJc0HnQyeM17qdpUY1NRcy0rtFm6/rHw/cXP10lBnnCu2FF/lS5U0TGnW//7NJ 0IUiuAmdU2zXsaqoHZmCeIxIOENN8jGo+y86WTGnwgaiVRIa38E7L1dbac5OiyqeaG1F eLUQ== X-Gm-Message-State: AOJu0Yw04xBXH9nBjaLJaX+iauxu5dF1iDJh4JPRyYO1DkNGMs5AQ9FC 9APrt4tD2CJSvupOZPwb6gdE+pG3afWVeCk6mmjq6EHsnvml7EGUF5XIiEFDonnmPpGijb/Xc/g NGWl4J8sbPjHlZvvd6bMAjN74HkGkkfJs0IpxRaWS+eNzaz5173lSTmqRpDSAWvuiZyKg4ZnHVo 1fHDgfG6GobmrxdxDW3y3uDxT7/MGt X-Gm-Gg: ASbGncst3g4jp84P/wg0xor0HDWz+JRBUsUQgOzmVq0EVzU6vkMz024xYOVGOzjD1r7 CO0KF/QpibiwbNeorVoKWOJu+LXuM0ztj1Jb5dwiKOwaf60fJnvfz0Ag0Z5PcFLxADgs8xthRsP w+qzecHUT/nrWuiEKwNoVaygZD9y+64FH6eU8aqfzf+8FFLbGBIiGrMLPIgpOfGcnx+4yLVA+1z L0MTx5blXr2QfjRZ5g+tZglyCFzF4DF/2d2UC9NrctFLBWHnDNOLmNbgw+ZwEcqLN4b6vfG/7In NtyOJmhFuu6HX/is0pyJNAqfcQS9KdEdwZRqRcDbhSkyEOKSDKrPT/Xo/+kBDiuZnhjVhFU5G+8 hpDvqq7bq X-Google-Smtp-Source: AGHT+IHmaoULWXWCdF9bN+FFExZrFvbIdhVk0B0GallUCBhhnmxcJ5UEQ5xwj4XduYJUnJKx9bBc4w== X-Received: by 2002:a05:6830:630b:b0:71d:f8bd:4be4 with SMTP id 46e09a7af769-726a428004emr2541195a34.19.1738776016403; Wed, 05 Feb 2025 09:20:16 -0800 (PST) Received: from C02GC2QQMD6T.wifi.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-726617cde49sm4004016a34.27.2025.02.05.09.20.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Feb 2025 09:20:16 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: thomas@monjalon.net, Peter Spreadborough Subject: [PATCH 06/11] net/bnxt: address coverity deadcode issue Date: Wed, 5 Feb 2025 09:19:59 -0800 Message-Id: <20250205172004.50395-7-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20250205172004.50395-1-ajit.khaparde@broadcom.com> References: <20250205172004.50395-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Peter Spreadborough This change addresses the CID 449075: Control flow issues (DEADCODE) reported by coverity associated with the ASSERT_RETURN macro. The change renames the macro and replaces the log macro to use PMD_DRV_LOG_LINE. Coverity issue: 449075 Signed-off-by: Peter Spreadborough Reviewed-by: Ajit Khaparde --- .../hcapi/cfa_v3/bld/p70/cfa_bld_p70_mpc.c | 90 +++++------ .../p70/host/cfa_bld_p70_host_mpc_wrapper.c | 150 +++++++++--------- 2 files changed, 120 insertions(+), 120 deletions(-) diff --git a/drivers/net/bnxt/hcapi/cfa_v3/bld/p70/cfa_bld_p70_mpc.c b/drivers/net/bnxt/hcapi/cfa_v3/bld/p70/cfa_bld_p70_mpc.c index 445d9aad87..3f8ef3a5f1 100644 --- a/drivers/net/bnxt/hcapi/cfa_v3/bld/p70/cfa_bld_p70_mpc.c +++ b/drivers/net/bnxt/hcapi/cfa_v3/bld/p70/cfa_bld_p70_mpc.c @@ -31,9 +31,9 @@ } while (0) #ifdef NXT_ENV_DEBUG -#define ASSERT_RETURN(ERRNO) CFA_LOG_ERR("Returning error: %d\n", (ERRNO)) +#define LOG_RC(ERRNO) PMD_DRV_LOG_LINE(ERR, "Returning error: %d", (ERRNO)) #else -#define ASSERT_RETURN(ERRNO) +#define LOG_RC(ERRNO) #endif /** @@ -68,7 +68,7 @@ static int fill_mpc_header(uint8_t *cmd, uint32_t size, uint32_t opaque_val) }; if (size < sizeof(struct mpc_header)) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } @@ -87,17 +87,17 @@ static int compose_mpc_read_clr_msg(uint8_t *cmd_buff, uint32_t *cmd_buff_len, sizeof(struct mpc_header) + sizeof(struct cfa_mpc_read_clr_cmd); if (parms->data_size != 1) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } if (parms->tbl_type >= CFA_HW_TABLE_MAX) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } if (*cmd_buff_len < cmd_size) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } @@ -138,17 +138,17 @@ static int compose_mpc_read_msg(uint8_t *cmd_buff, uint32_t *cmd_buff_len, sizeof(struct mpc_header) + sizeof(struct cfa_mpc_read_cmd); if (parms->data_size < 1 || parms->data_size > 4) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } if (parms->tbl_type >= CFA_HW_TABLE_MAX) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } if (*cmd_buff_len < cmd_size) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } @@ -194,22 +194,22 @@ static int compose_mpc_write_msg(uint8_t *cmd_buff, uint32_t *cmd_buff_len, parms->data_size * MPC_CFA_CACHE_ACCESS_UNIT_SIZE; if (parms->data_size < 1 || parms->data_size > 4) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } if (parms->tbl_type >= CFA_HW_TABLE_MAX) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } if (!parms->write.data_ptr) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } if (*cmd_buff_len < cmd_size) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } @@ -252,17 +252,17 @@ static int compose_mpc_evict_msg(uint8_t *cmd_buff, uint32_t *cmd_buff_len, sizeof(struct cfa_mpc_invalidate_cmd); if (parms->data_size < 1 || parms->data_size > 4) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } if (parms->tbl_type >= CFA_HW_TABLE_MAX) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } if (*cmd_buff_len < cmd_size) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } @@ -293,7 +293,7 @@ static int compose_mpc_evict_msg(uint8_t *cmd_buff, uint32_t *cmd_buff_len, break; case CFA_MPC_EV_EVICT_TABLE_SCOPE: /* Not supported */ - ASSERT_RETURN(-ENOTSUP); + LOG_RC(-ENOTSUP); return -ENOTSUP; default: case CFA_MPC_EV_EVICT_SCOPE_ADDRESS: @@ -326,7 +326,7 @@ int cfa_mpc_build_cache_axs_cmd(enum cfa_mpc_opcode opc, uint8_t *cmd_buff, { int rc; if (!cmd_buff || !cmd_buff_len || *cmd_buff_len == 0 || !parms) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } @@ -344,7 +344,7 @@ int cfa_mpc_build_cache_axs_cmd(enum cfa_mpc_opcode opc, uint8_t *cmd_buff, case CFA_MPC_INVALIDATE: return compose_mpc_evict_msg(cmd_buff, cmd_buff_len, parms); default: - ASSERT_RETURN(-ENOTSUP); + LOG_RC(-ENOTSUP); return -ENOTSUP; } } @@ -360,17 +360,17 @@ static int compose_mpc_em_search_msg(uint8_t *cmd_buff, uint32_t *cmd_buff_len, e->data_size * MPC_CFA_CACHE_ACCESS_UNIT_SIZE; if (e->data_size < 1 || e->data_size > 4) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } if (*cmd_buff_len < cmd_size) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } if (!e->em_entry) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } @@ -405,17 +405,17 @@ static int compose_mpc_em_insert_msg(uint8_t *cmd_buff, uint32_t *cmd_buff_len, e->data_size * MPC_CFA_CACHE_ACCESS_UNIT_SIZE; if (e->data_size < 1 || e->data_size > 4) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } if (*cmd_buff_len < cmd_size) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } if (!e->em_entry) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } @@ -455,7 +455,7 @@ static int compose_mpc_em_delete_msg(uint8_t *cmd_buff, uint32_t *cmd_buff_len, sizeof(struct cfa_mpc_em_delete_cmd); if (*cmd_buff_len < cmd_size) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } @@ -487,7 +487,7 @@ static int compose_mpc_em_chain_msg(uint8_t *cmd_buff, uint32_t *cmd_buff_len, sizeof(struct mpc_header) + sizeof(struct cfa_mpc_em_chain_cmd); if (*cmd_buff_len < cmd_size) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } @@ -530,7 +530,7 @@ int cfa_mpc_build_em_op_cmd(enum cfa_mpc_opcode opc, uint8_t *cmd_buff, { int rc; if (!cmd_buff || !cmd_buff_len || *cmd_buff_len == 0 || !parms) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } @@ -548,7 +548,7 @@ int cfa_mpc_build_em_op_cmd(enum cfa_mpc_opcode opc, uint8_t *cmd_buff, case CFA_MPC_EM_CHAIN: return compose_mpc_em_chain_msg(cmd_buff, cmd_buff_len, parms); default: - ASSERT_RETURN(-ENOTSUP); + LOG_RC(-ENOTSUP); return -ENOTSUP; } @@ -572,17 +572,17 @@ static int parse_mpc_read_clr_result(uint8_t *resp_buff, uint32_t resp_buff_len, sizeof(struct mpc_header)); if (resp_buff_len < resp_size) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } if (result->data_len < rd_size) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } if (!result->rd_data) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } @@ -622,17 +622,17 @@ static int parse_mpc_read_result(uint8_t *resp_buff, uint32_t resp_buff_len, sizeof(struct mpc_header)); if (resp_buff_len < resp_size) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } if (result->data_len < rd_size) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } if (!result->rd_data) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } @@ -671,7 +671,7 @@ static int parse_mpc_write_result(uint8_t *resp_buff, uint32_t resp_buff_len, sizeof(struct mpc_header)); if (resp_buff_len < resp_size) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } @@ -696,7 +696,7 @@ static int parse_mpc_evict_result(uint8_t *resp_buff, uint32_t resp_buff_len, sizeof(struct mpc_header)); if (resp_buff_len < resp_size) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } @@ -728,7 +728,7 @@ int cfa_mpc_parse_cache_axs_resp(enum cfa_mpc_opcode opc, uint8_t *resp_buff, struct cfa_mpc_cache_axs_result *result) { if (!resp_buff || resp_buff_len == 0 || !result) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } @@ -743,7 +743,7 @@ int cfa_mpc_parse_cache_axs_resp(enum cfa_mpc_opcode opc, uint8_t *resp_buff, case CFA_MPC_INVALIDATE: return parse_mpc_evict_result(resp_buff, resp_buff_len, result); default: - ASSERT_RETURN(-ENOTSUP); + LOG_RC(-ENOTSUP); return -ENOTSUP; } } @@ -762,7 +762,7 @@ static int parse_mpc_em_search_result(uint8_t *resp_buff, sizeof(struct cfa_mpc_em_search_cmp); if (resp_buff_len < resp_size) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } @@ -794,7 +794,7 @@ static int parse_mpc_em_insert_result(uint8_t *resp_buff, sizeof(struct cfa_mpc_em_insert_cmp); if (resp_buff_len < resp_size) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } @@ -828,7 +828,7 @@ static int parse_mpc_em_delete_result(uint8_t *resp_buff, sizeof(struct cfa_mpc_em_delete_cmp); if (resp_buff_len < resp_size) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } @@ -859,7 +859,7 @@ static int parse_mpc_em_chain_result(uint8_t *resp_buff, uint32_t resp_buff_len, sizeof(struct mpc_header) + sizeof(struct cfa_mpc_em_chain_cmp); if (resp_buff_len < resp_size) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } @@ -894,7 +894,7 @@ int cfa_mpc_parse_em_op_resp(enum cfa_mpc_opcode opc, uint8_t *resp_buff, struct cfa_mpc_em_op_result *result) { if (!resp_buff || resp_buff_len == 0 || !result) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } @@ -912,7 +912,7 @@ int cfa_mpc_parse_em_op_resp(enum cfa_mpc_opcode opc, uint8_t *resp_buff, return parse_mpc_em_chain_result(resp_buff, resp_buff_len, result); default: - ASSERT_RETURN(-ENOTSUP); + LOG_RC(-ENOTSUP); return -ENOTSUP; } } diff --git a/drivers/net/bnxt/hcapi/cfa_v3/bld/p70/host/cfa_bld_p70_host_mpc_wrapper.c b/drivers/net/bnxt/hcapi/cfa_v3/bld/p70/host/cfa_bld_p70_host_mpc_wrapper.c index d685cc8a63..4719be2b7e 100644 --- a/drivers/net/bnxt/hcapi/cfa_v3/bld/p70/host/cfa_bld_p70_host_mpc_wrapper.c +++ b/drivers/net/bnxt/hcapi/cfa_v3/bld/p70/host/cfa_bld_p70_host_mpc_wrapper.c @@ -21,9 +21,9 @@ #include "host/cfa_p70_mpc_field_mapping.h" #ifdef NXT_ENV_DEBUG -#define ASSERT_RETURN(ERRNO) CFA_LOG_ERR("Returning error: %d\n", (ERRNO)) +#define LOG_RC(ERRNO) PMD_DRV_LOG_LINE(ERR, "Returning error: %d", (ERRNO)) #else -#define ASSERT_RETURN(ERRNO) +#define LOG_RC(ERRNO) #endif /* @@ -47,7 +47,7 @@ uint64_t mapped_val; \ retcode = MAP_FUNC(fields[INDEX].val, &mapped_val); \ if (retcode) \ - ASSERT_RETURN(retcode); \ + LOG_RC(retcode); \ else \ parms.NAME = (TYPE)mapped_val; \ } \ @@ -75,7 +75,7 @@ uint64_t mapped_val; \ retcode = MAP_FUNC(result.NAME, &mapped_val); \ if (retcode) \ - ASSERT_RETURN(retcode); \ + LOG_RC(retcode); \ else \ fields[INDEX].val = mapped_val; \ } \ @@ -121,7 +121,7 @@ static int table_type_map(uint64_t val, uint64_t *mapped_val) *mapped_val = CFA_HW_TABLE_LOOKUP; break; default: - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } @@ -145,7 +145,7 @@ static int read_mode_map(uint64_t val, uint64_t *mapped_val) *mapped_val = CFA_MPC_RD_DEBUG_TAG; break; default: - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } return 0; @@ -162,7 +162,7 @@ static int write_mode_map(uint64_t val, uint64_t *mapped_val) *mapped_val = CFA_MPC_WR_WRITE_BACK; break; default: - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } return 0; @@ -191,7 +191,7 @@ static int evict_mode_map(uint64_t val, uint64_t *mapped_val) *mapped_val = CFA_MPC_EV_EVICT_TABLE_SCOPE; break; default: - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } return 0; @@ -232,7 +232,7 @@ static int status_code_map(uint64_t val, uint64_t *mapped_val) *mapped_val = CFA_BLD_MPC_EM_ABORT; break; default: - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } return 0; @@ -266,13 +266,13 @@ int cfa_bld_p70_mpc_build_cache_read(uint8_t *cmd, uint32_t *cmd_buff_len, /* Parameters check */ if (!cmd || !cmd_buff_len || !fields) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } if (!fields_valid(fields, CFA_BLD_MPC_READ_CMD_MAX_FLD, cfa_p70_mpc_read_cmd_gbl_to_dev)) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } @@ -291,7 +291,7 @@ int cfa_bld_p70_mpc_build_cache_read(uint8_t *cmd, uint32_t *cmd_buff_len, CFA_BLD_MPC_READ_CMD_TABLE_TYPE_FLD, fields, table_type_map); if (rc) { - ASSERT_RETURN(rc); + LOG_RC(rc); return rc; } @@ -299,7 +299,7 @@ int cfa_bld_p70_mpc_build_cache_read(uint8_t *cmd, uint32_t *cmd_buff_len, CFA_BLD_MPC_READ_CMD_CACHE_OPTION_FLD, fields, read_mode_map); if (rc) { - ASSERT_RETURN(rc); + LOG_RC(rc); return rc; } @@ -316,13 +316,13 @@ int cfa_bld_p70_mpc_build_cache_write(uint8_t *cmd, uint32_t *cmd_buff_len, /* Parameters check */ if (!cmd || !cmd_buff_len || !fields) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } if (!fields_valid(fields, CFA_BLD_MPC_WRITE_CMD_MAX_FLD, cfa_p70_mpc_write_cmd_gbl_to_dev)) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } @@ -339,7 +339,7 @@ int cfa_bld_p70_mpc_build_cache_write(uint8_t *cmd, uint32_t *cmd_buff_len, CFA_BLD_MPC_WRITE_CMD_TABLE_TYPE_FLD, fields, table_type_map); if (rc) { - ASSERT_RETURN(rc); + LOG_RC(rc); return rc; } @@ -348,7 +348,7 @@ int cfa_bld_p70_mpc_build_cache_write(uint8_t *cmd, uint32_t *cmd_buff_len, CFA_BLD_MPC_WRITE_CMD_CACHE_OPTION_FLD, fields, write_mode_map); if (rc) { - ASSERT_RETURN(rc); + LOG_RC(rc); return rc; } @@ -364,13 +364,13 @@ int cfa_bld_p70_mpc_build_cache_evict(uint8_t *cmd, uint32_t *cmd_buff_len, /* Parameters check */ if (!cmd || !cmd_buff_len || !fields) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } if (!fields_valid(fields, CFA_BLD_MPC_INVALIDATE_CMD_MAX_FLD, cfa_p70_mpc_invalidate_cmd_gbl_to_dev)) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } @@ -387,7 +387,7 @@ int cfa_bld_p70_mpc_build_cache_evict(uint8_t *cmd, uint32_t *cmd_buff_len, CFA_BLD_MPC_INVALIDATE_CMD_TABLE_TYPE_FLD, fields, table_type_map); if (rc) { - ASSERT_RETURN(rc); + LOG_RC(rc); return rc; } @@ -395,7 +395,7 @@ int cfa_bld_p70_mpc_build_cache_evict(uint8_t *cmd, uint32_t *cmd_buff_len, CFA_BLD_MPC_INVALIDATE_CMD_CACHE_OPTION_FLD, fields, evict_mode_map); if (rc) { - ASSERT_RETURN(rc); + LOG_RC(rc); return rc; } @@ -411,13 +411,13 @@ int cfa_bld_p70_mpc_build_cache_rdclr(uint8_t *cmd, uint32_t *cmd_buff_len, /* Parameters check */ if (!cmd || !cmd_buff_len || !fields) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } if (!fields_valid(fields, CFA_BLD_MPC_READ_CLR_CMD_MAX_FLD, cfa_p70_mpc_read_clr_cmd_gbl_to_dev)) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } @@ -436,7 +436,7 @@ int cfa_bld_p70_mpc_build_cache_rdclr(uint8_t *cmd, uint32_t *cmd_buff_len, CFA_BLD_MPC_READ_CLR_CMD_TABLE_TYPE_FLD, fields, table_type_map); if (rc) { - ASSERT_RETURN(rc); + LOG_RC(rc); return rc; } @@ -446,7 +446,7 @@ int cfa_bld_p70_mpc_build_cache_rdclr(uint8_t *cmd, uint32_t *cmd_buff_len, CFA_BLD_MPC_READ_CLR_CMD_CACHE_OPTION_FLD, fields, read_mode_map); if (rc) { - ASSERT_RETURN(rc); + LOG_RC(rc); return rc; } @@ -465,20 +465,20 @@ int cfa_bld_p70_mpc_build_em_search(uint8_t *cmd, uint32_t *cmd_buff_len, /* Parameters check */ if (!cmd || !cmd_buff_len || !fields) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } if (has_unsupported_fields(fields, CFA_BLD_MPC_EM_SEARCH_CMD_MAX_FLD, unsupported_fields, ARRAY_SIZE(unsupported_fields))) { - ASSERT_RETURN(-ENOTSUP); + LOG_RC(-ENOTSUP); return -ENOTSUP; } if (!fields_valid(fields, CFA_BLD_MPC_EM_SEARCH_CMD_MAX_FLD, cfa_p70_mpc_em_search_cmd_gbl_to_dev)) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } @@ -509,20 +509,20 @@ int cfa_bld_p70_mpc_build_em_insert(uint8_t *cmd, uint32_t *cmd_buff_len, /* Parameters check */ if (!cmd || !cmd_buff_len || !fields) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } if (has_unsupported_fields(fields, CFA_BLD_MPC_EM_INSERT_CMD_MAX_FLD, unsupported_fields, ARRAY_SIZE(unsupported_fields))) { - ASSERT_RETURN(-ENOTSUP); + LOG_RC(-ENOTSUP); return -ENOTSUP; } if (!fields_valid(fields, CFA_BLD_MPC_EM_INSERT_CMD_MAX_FLD, cfa_p70_mpc_em_insert_cmd_gbl_to_dev)) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } @@ -558,20 +558,20 @@ int cfa_bld_p70_mpc_build_em_delete(uint8_t *cmd, uint32_t *cmd_buff_len, /* Parameters check */ if (!cmd || !cmd_buff_len || !fields) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } if (has_unsupported_fields(fields, CFA_BLD_MPC_EM_DELETE_CMD_MAX_FLD, unsupported_fields, ARRAY_SIZE(unsupported_fields))) { - ASSERT_RETURN(-ENOTSUP); + LOG_RC(-ENOTSUP); return -ENOTSUP; } if (!fields_valid(fields, CFA_BLD_MPC_EM_DELETE_CMD_MAX_FLD, cfa_p70_mpc_em_delete_cmd_gbl_to_dev)) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } @@ -602,20 +602,20 @@ int cfa_bld_p70_mpc_build_em_chain(uint8_t *cmd, uint32_t *cmd_buff_len, /* Parameters check */ if (!cmd || !cmd_buff_len || !fields) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } if (has_unsupported_fields(fields, CFA_BLD_MPC_EM_CHAIN_CMD_MAX_FLD, unsupported_fields, ARRAY_SIZE(unsupported_fields))) { - ASSERT_RETURN(-ENOTSUP); + LOG_RC(-ENOTSUP); return -ENOTSUP; } if (!fields_valid(fields, CFA_BLD_MPC_EM_CHAIN_CMD_MAX_FLD, cfa_p70_mpc_em_chain_cmd_gbl_to_dev)) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } @@ -653,20 +653,20 @@ int cfa_bld_p70_mpc_parse_cache_read(uint8_t *resp, uint32_t resp_buff_len, /* Parameters check */ if (!resp || !resp_buff_len || !fields || !rd_data) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } if (has_unsupported_fields(fields, CFA_BLD_MPC_READ_CMP_MAX_FLD, unsupported_fields, ARRAY_SIZE(unsupported_fields))) { - ASSERT_RETURN(-ENOTSUP); + LOG_RC(-ENOTSUP); return -ENOTSUP; } if (!fields_valid(fields, CFA_BLD_MPC_READ_CMP_MAX_FLD, cfa_p70_mpc_read_cmp_gbl_to_dev)) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } @@ -683,7 +683,7 @@ int cfa_bld_p70_mpc_parse_cache_read(uint8_t *resp, uint32_t resp_buff_len, rc = GET_RESP_MAPPED_VALUE(status, CFA_BLD_MPC_READ_CMP_STATUS_FLD, fields, status_code_map); if (rc) { - ASSERT_RETURN(rc); + LOG_RC(rc); return rc; } @@ -707,20 +707,20 @@ int cfa_bld_p70_mpc_parse_cache_write(uint8_t *resp, uint32_t resp_buff_len, /* Parameters check */ if (!resp || !resp_buff_len || !fields) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } if (has_unsupported_fields(fields, CFA_BLD_MPC_WRITE_CMP_MAX_FLD, unsupported_fields, ARRAY_SIZE(unsupported_fields))) { - ASSERT_RETURN(-ENOTSUP); + LOG_RC(-ENOTSUP); return -ENOTSUP; } if (!fields_valid(fields, CFA_BLD_MPC_WRITE_CMP_MAX_FLD, cfa_p70_mpc_write_cmp_gbl_to_dev)) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } @@ -728,7 +728,7 @@ int cfa_bld_p70_mpc_parse_cache_write(uint8_t *resp, uint32_t resp_buff_len, rc = cfa_mpc_parse_cache_axs_resp(CFA_MPC_WRITE, resp, resp_buff_len, &result); if (rc) { - ASSERT_RETURN(rc); + LOG_RC(rc); return rc; } @@ -737,7 +737,7 @@ int cfa_bld_p70_mpc_parse_cache_write(uint8_t *resp, uint32_t resp_buff_len, rc = GET_RESP_MAPPED_VALUE(status, CFA_BLD_MPC_WRITE_CMP_STATUS_FLD, fields, status_code_map); if (rc) { - ASSERT_RETURN(rc); + LOG_RC(rc); return rc; } @@ -761,20 +761,20 @@ int cfa_bld_p70_mpc_parse_cache_evict(uint8_t *resp, uint32_t resp_buff_len, /* Parameters check */ if (!resp || !resp_buff_len || !fields) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } if (has_unsupported_fields(fields, CFA_BLD_MPC_INVALIDATE_CMP_MAX_FLD, unsupported_fields, ARRAY_SIZE(unsupported_fields))) { - ASSERT_RETURN(-ENOTSUP); + LOG_RC(-ENOTSUP); return -ENOTSUP; } if (!fields_valid(fields, CFA_BLD_MPC_INVALIDATE_CMP_MAX_FLD, cfa_p70_mpc_invalidate_cmp_gbl_to_dev)) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } @@ -782,7 +782,7 @@ int cfa_bld_p70_mpc_parse_cache_evict(uint8_t *resp, uint32_t resp_buff_len, rc = cfa_mpc_parse_cache_axs_resp(CFA_MPC_INVALIDATE, resp, resp_buff_len, &result); if (rc) { - ASSERT_RETURN(rc); + LOG_RC(rc); return rc; } @@ -793,7 +793,7 @@ int cfa_bld_p70_mpc_parse_cache_evict(uint8_t *resp, uint32_t resp_buff_len, CFA_BLD_MPC_INVALIDATE_CMP_STATUS_FLD, fields, status_code_map); if (rc) { - ASSERT_RETURN(rc); + LOG_RC(rc); return rc; } @@ -819,20 +819,20 @@ int cfa_bld_p70_mpc_parse_cache_rdclr(uint8_t *resp, uint32_t resp_buff_len, /* Parameters check */ if (!resp || !resp_buff_len || !fields || !rd_data) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } if (has_unsupported_fields(fields, CFA_BLD_MPC_READ_CMP_MAX_FLD, unsupported_fields, ARRAY_SIZE(unsupported_fields))) { - ASSERT_RETURN(-ENOTSUP); + LOG_RC(-ENOTSUP); return -ENOTSUP; } if (!fields_valid(fields, CFA_BLD_MPC_READ_CMP_MAX_FLD, cfa_p70_mpc_read_cmp_gbl_to_dev)) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } @@ -849,7 +849,7 @@ int cfa_bld_p70_mpc_parse_cache_rdclr(uint8_t *resp, uint32_t resp_buff_len, rc = GET_RESP_MAPPED_VALUE(status, CFA_BLD_MPC_READ_CMP_STATUS_FLD, fields, status_code_map); if (rc) { - ASSERT_RETURN(rc); + LOG_RC(rc); return rc; } @@ -872,20 +872,20 @@ int cfa_bld_p70_mpc_parse_em_search(uint8_t *resp, uint32_t resp_buff_len, /* Parameters check */ if (!resp || !resp_buff_len || !fields) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } if (has_unsupported_fields(fields, CFA_BLD_MPC_EM_SEARCH_CMP_MAX_FLD, unsupported_fields, ARRAY_SIZE(unsupported_fields))) { - ASSERT_RETURN(-ENOTSUP); + LOG_RC(-ENOTSUP); return -ENOTSUP; } if (!fields_valid(fields, CFA_BLD_MPC_EM_SEARCH_CMP_MAX_FLD, cfa_p70_mpc_em_search_cmp_gbl_to_dev)) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } @@ -893,7 +893,7 @@ int cfa_bld_p70_mpc_parse_em_search(uint8_t *resp, uint32_t resp_buff_len, rc = cfa_mpc_parse_em_op_resp(CFA_MPC_EM_SEARCH, resp, resp_buff_len, &result); if (rc) { - ASSERT_RETURN(rc); + LOG_RC(rc); return rc; } @@ -903,7 +903,7 @@ int cfa_bld_p70_mpc_parse_em_search(uint8_t *resp, uint32_t resp_buff_len, rc = GET_RESP_MAPPED_VALUE(status, CFA_BLD_MPC_EM_SEARCH_CMP_STATUS_FLD, fields, status_code_map); if (rc) { - ASSERT_RETURN(rc); + LOG_RC(rc); return rc; } @@ -939,20 +939,20 @@ int cfa_bld_p70_mpc_parse_em_insert(uint8_t *resp, uint32_t resp_buff_len, /* Parameters check */ if (!resp || !resp_buff_len || !fields) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } if (has_unsupported_fields(fields, CFA_BLD_MPC_EM_INSERT_CMP_MAX_FLD, unsupported_fields, ARRAY_SIZE(unsupported_fields))) { - ASSERT_RETURN(-ENOTSUP); + LOG_RC(-ENOTSUP); return -ENOTSUP; } if (!fields_valid(fields, CFA_BLD_MPC_EM_INSERT_CMP_MAX_FLD, cfa_p70_mpc_em_insert_cmp_gbl_to_dev)) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } @@ -960,7 +960,7 @@ int cfa_bld_p70_mpc_parse_em_insert(uint8_t *resp, uint32_t resp_buff_len, rc = cfa_mpc_parse_em_op_resp(CFA_MPC_EM_INSERT, resp, resp_buff_len, &result); if (rc) { - ASSERT_RETURN(rc); + LOG_RC(rc); return rc; } @@ -970,7 +970,7 @@ int cfa_bld_p70_mpc_parse_em_insert(uint8_t *resp, uint32_t resp_buff_len, rc = GET_RESP_MAPPED_VALUE(status, CFA_BLD_MPC_EM_INSERT_CMP_STATUS_FLD, fields, status_code_map); if (rc) { - ASSERT_RETURN(rc); + LOG_RC(rc); return rc; } @@ -1010,20 +1010,20 @@ int cfa_bld_p70_mpc_parse_em_delete(uint8_t *resp, uint32_t resp_buff_len, /* Parameters check */ if (!resp || !resp_buff_len || !fields) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } if (has_unsupported_fields(fields, CFA_BLD_MPC_EM_DELETE_CMP_MAX_FLD, unsupported_fields, ARRAY_SIZE(unsupported_fields))) { - ASSERT_RETURN(-ENOTSUP); + LOG_RC(-ENOTSUP); return -ENOTSUP; } if (!fields_valid(fields, CFA_BLD_MPC_EM_DELETE_CMP_MAX_FLD, cfa_p70_mpc_em_delete_cmp_gbl_to_dev)) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } @@ -1031,7 +1031,7 @@ int cfa_bld_p70_mpc_parse_em_delete(uint8_t *resp, uint32_t resp_buff_len, rc = cfa_mpc_parse_em_op_resp(CFA_MPC_EM_DELETE, resp, resp_buff_len, &result); if (rc) { - ASSERT_RETURN(rc); + LOG_RC(rc); return rc; } @@ -1041,7 +1041,7 @@ int cfa_bld_p70_mpc_parse_em_delete(uint8_t *resp, uint32_t resp_buff_len, rc = GET_RESP_MAPPED_VALUE(status, CFA_BLD_MPC_EM_DELETE_CMP_STATUS_FLD, fields, status_code_map); if (rc) { - ASSERT_RETURN(rc); + LOG_RC(rc); return rc; } @@ -1076,20 +1076,20 @@ int cfa_bld_p70_mpc_parse_em_chain(uint8_t *resp, uint32_t resp_buff_len, /* Parameters check */ if (!resp || !resp_buff_len || !fields) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } if (has_unsupported_fields(fields, CFA_BLD_MPC_EM_CHAIN_CMP_MAX_FLD, unsupported_fields, ARRAY_SIZE(unsupported_fields))) { - ASSERT_RETURN(-ENOTSUP); + LOG_RC(-ENOTSUP); return -ENOTSUP; } if (!fields_valid(fields, CFA_BLD_MPC_EM_CHAIN_CMP_MAX_FLD, cfa_p70_mpc_em_chain_cmp_gbl_to_dev)) { - ASSERT_RETURN(-EINVAL); + LOG_RC(-EINVAL); return -EINVAL; } @@ -1097,7 +1097,7 @@ int cfa_bld_p70_mpc_parse_em_chain(uint8_t *resp, uint32_t resp_buff_len, rc = cfa_mpc_parse_em_op_resp(CFA_MPC_EM_CHAIN, resp, resp_buff_len, &result); if (rc) { - ASSERT_RETURN(rc); + LOG_RC(rc); return rc; } @@ -1107,7 +1107,7 @@ int cfa_bld_p70_mpc_parse_em_chain(uint8_t *resp, uint32_t resp_buff_len, rc = GET_RESP_MAPPED_VALUE(status, CFA_BLD_MPC_EM_CHAIN_CMP_STATUS_FLD, fields, status_code_map); if (rc) { - ASSERT_RETURN(rc); + LOG_RC(rc); return rc; } From patchwork Wed Feb 5 17:20:00 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 150998 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0389461A0; Wed, 5 Feb 2025 18:20:54 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0AA3640A87; Wed, 5 Feb 2025 18:20:21 +0100 (CET) Received: from mail-ot1-f48.google.com (mail-ot1-f48.google.com [209.85.210.48]) by mails.dpdk.org (Postfix) with ESMTP id 9CB81402E4 for ; Wed, 5 Feb 2025 18:20:18 +0100 (CET) Received: by mail-ot1-f48.google.com with SMTP id 46e09a7af769-71e2766994bso25488a34.3 for ; Wed, 05 Feb 2025 09:20:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1738776018; x=1739380818; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oLB4CC3ArJ9hP+1eRA9RDOx2WztzB52Bo0Il4K2Puik=; b=ZDT4cfFWtgh+XW3HO9gB98yWuhfuuyCH0QTKPKCeqke8dr3l+9Op9rX62wLwXma/a9 Yux6XjyFpdchTDAXBbkh+CikDft7LHKJrIyjnxnz3LDFyYm34ZE1cf/qhChjYE8dfqeY LWQzHfOPVI/DPd4AyrQqBlWAut8Y8DCICMlgQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738776018; x=1739380818; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oLB4CC3ArJ9hP+1eRA9RDOx2WztzB52Bo0Il4K2Puik=; b=emMc0NPzW2Iw2enDdrSu1nDAf8h6AOz1AnuSYOAhGDXMWTHAENk7fLUsKFq/ExJB/s 4ZKg0h/IqvwMoBHUlhKx3Cq4UBT3fwGfEbbzZzEuoe1STxKo7SRrzANgD9z5WM2eg8+5 WRGzeMaOQu3iVlExDKJmfvOqJupfsPrA8+loBBrfYljbQCZ72374rVZrv9bl2vE+xOgn BPQwxFo2E8qFM8ST3r0j0dstRxJ6eK6ZyT3EoCbuFD+IxpRB6kMs9H28H4GLNzrBnNAs vv5Fydktp//K/DDxTuqv9y83zbF3onf4T939BEF0KodnG2HooQ2u/oDN41ESP69AoIG/ YsNw== X-Gm-Message-State: AOJu0YwZ+cmRu+g3/tbUNCDuTMCROepNsnBuPXoKAXYV46IrdDFKtDQb 6OgFNxFXzkobFa0KTRJBKrYlIHSsfOh5onUVysiyIA/6FcqlBvMJIdj9cFduuyCu0Iq8VaPMnCA sj8gFYnL8JIOj1JsmQj2WtycQRT4Uhq87I2Wp7Cts1ElkBYpkhm5MBxDTKKVhU+X0TxKT9ITQL5 /7rCziY54oz1tRGfrPj1auCEd317AP X-Gm-Gg: ASbGncvQy9pzxKSzAcWgLWBhM01zuf/ekTwNLFtYfAwPq1H2lO8SmO7WGOl9gVMBg6I Xz79ct8mkOzQiEV4PcjlFQDvYkurBHs305tb2Ata58fA/Yq7Wikyv+pHYbXxeABfAQyk7ko/4oV ffqquc8mbKYRCOCOxf38AVR1O6HDD+z6Sqsg2Sn1WK/AuvacMfmCAz1IP8gUJzX6gYRhiBW0w9x 2G20NDBusfrpiXQEg2Gtqsx6lUlT3AaSUwbboaWtXauw+VO8bBX7vDFNJxD1OYUWSsZuVJ3MXDe 6oMYijRige+7GncmdCq3SocqaRCJPrE4GXBEtdBxrb7c05MQxTwgtiiUIoV+3nHao3d/x+eQGUI QMjOKK/G8 X-Google-Smtp-Source: AGHT+IEOqnDQRjOhX+3Z5lrKx5fGXKMQQ3ZqBWmO+HtzwbPMwn2CYHvqvgpOLEcZI8S1vekNzsKnGQ== X-Received: by 2002:a05:6830:d16:b0:718:105b:1185 with SMTP id 46e09a7af769-726a41ba991mr2466863a34.14.1738776017557; Wed, 05 Feb 2025 09:20:17 -0800 (PST) Received: from C02GC2QQMD6T.wifi.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-726617cde49sm4004016a34.27.2025.02.05.09.20.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Feb 2025 09:20:17 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: thomas@monjalon.net, Peter Spreadborough Subject: [PATCH 07/11] net/bnxt: address coverity checked return issues Date: Wed, 5 Feb 2025 09:20:00 -0800 Message-Id: <20250205172004.50395-8-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20250205172004.50395-1-ajit.khaparde@broadcom.com> References: <20250205172004.50395-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Peter Spreadborough This change addresses the CID 449056: Error handling issues (CHECKED_RETURN) reported by coverity. The changes add return code handling to address the issue. Coverity issue: 449056 Signed-off-by: Peter Spreadborough Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_ulp/ulp_mapper.c | 10 +++++++--- drivers/net/bnxt/tf_ulp/ulp_rte_parser.c | 8 +++++++- 2 files changed, 14 insertions(+), 4 deletions(-) diff --git a/drivers/net/bnxt/tf_ulp/ulp_mapper.c b/drivers/net/bnxt/tf_ulp/ulp_mapper.c index 2429ac2f1a..1a68cf5dfd 100644 --- a/drivers/net/bnxt/tf_ulp/ulp_mapper.c +++ b/drivers/net/bnxt/tf_ulp/ulp_mapper.c @@ -3612,9 +3612,13 @@ ulp_mapper_func_cond_list_process(struct bnxt_ulp_mapper_parms *parms, } } /* write the value into result */ - ulp_operand_read(val, res_local + res_size - - ULP_BITS_2_BYTE_NR(oper_size), - ULP_BITS_2_BYTE_NR(val_len)); + if (unlikely(ulp_operand_read(val, res_local + res_size - + ULP_BITS_2_BYTE_NR(oper_size), + ULP_BITS_2_BYTE_NR(val_len)))) { + BNXT_DRV_DBG(ERR, + "field idx operand read failed\n"); + return -EINVAL; + } /* convert the data to cpu format */ *res = tfp_be_to_cpu_64(*res); diff --git a/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c b/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c index dd5985cd7b..bf3a3deb18 100644 --- a/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c +++ b/drivers/net/bnxt/tf_ulp/ulp_rte_parser.c @@ -517,7 +517,13 @@ ulp_rte_parser_svif_set(struct ulp_rte_parser_params *params, else svif_type = BNXT_ULP_DRV_FUNC_SVIF; } - ulp_port_db_svif_get(params->ulp_ctx, ifindex, svif_type, &svif); + + if (ulp_port_db_svif_get(params->ulp_ctx, ifindex, + svif_type, &svif)) { + BNXT_DRV_DBG(ERR, "ParseErr:ifindex is not valid\n"); + return BNXT_TF_RC_ERROR; + } + svif = rte_cpu_to_be_16(svif); mask = rte_cpu_to_be_16(mask); hdr_field = ¶ms->hdr_field[BNXT_ULP_PROTO_HDR_FIELD_SVIF_IDX]; From patchwork Wed Feb 5 17:20:01 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 150999 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B42DA461A0; Wed, 5 Feb 2025 18:20:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 349DE40A6F; Wed, 5 Feb 2025 18:20:22 +0100 (CET) Received: from mail-ot1-f49.google.com (mail-ot1-f49.google.com [209.85.210.49]) by mails.dpdk.org (Postfix) with ESMTP id D5C4440A6F for ; Wed, 5 Feb 2025 18:20:19 +0100 (CET) Received: by mail-ot1-f49.google.com with SMTP id 46e09a7af769-71fbb0d035dso27791a34.2 for ; Wed, 05 Feb 2025 09:20:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1738776019; x=1739380819; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Fxrq83+c3GumvxXC6lFTimV5QxFJheNg/bL0gLEcsTM=; b=NZIENFegljxG1jkskTUJMh8purgD3bKrRctgdvpMCB0mUhoKw/IGLVR256B77YYESf FbigEV2VqIxGRvgrnUVmWQzbV2ZjvIVuho45WY92Dla3O7kekmLNdckjlK/6DnNhA0Se YVID1aFfyrjyLI5Y1iyMO0dnXrqDoFXyh2ltM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738776019; x=1739380819; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Fxrq83+c3GumvxXC6lFTimV5QxFJheNg/bL0gLEcsTM=; b=OThSD+SmFaMsvDIQs7zRH1PhWEf+6YpElcjoScZUIHgTNDwgv+qC8fO+fO/QGh8EHE 8zwk47K4JVXIaDfZPWTQOd3E0RK1U3TUtNiHF70+3aD1gObmgSp8J+Xf5bWnNUbFsLly fiEyEh0JVXhB66+n4ehXK9UfUYKvRr+eJpHTAVi5muHMtYC0EczRmL9TQlkysPQfckOF ccQQ1tKOzkGqUFcjoB1YSEjLIc3SjnPbH5s+gp1kYK8TDNqOuujwYJP6pu/Sxb72+P5l aY5f1ziU4rF1VVB5/yWqiogp2KN658qjS3UvGgLGVrvmRtnGGvBTsh0+3PkvQA1rj10W ZR9g== X-Gm-Message-State: AOJu0YwCetZDjzwNx9GJsHDlo0yzydcEVLCXCB3iJGhYkJQjby8BqygE Q+JWrHZkk9YXAFLnRFjrNGcHEwLYfJBScAWyzZJNo+1iA0Qvw1WbmkKsk4lg1PQHMAfzq05wYB4 Z4deCdMBrAhipZET2WdqX79CO+JUSPiztdU7XiqR3k6unlKhw4WEv7lpE9lBU2Pr/jwIL6xhmtB Ie3cQdqFw72JISlLdr1vgg9E/mBH3a X-Gm-Gg: ASbGncvFnBV9OojVLeUMOT40UfE0ZtI+NbL7pXfj4Bghoig7RcM72c8euC0Az3lbRXb hB5g0KpK9oQlnG2CKldNJR8+HuPhaB9Oro2FflvsvI9YkMBugdjPGHr9Zh4sPyiX8JjG1SqgrII wpMxQLR2AAh5o1U/BT9DkA3bOPj2+wdaMXl7BsmqMHmqOFDiaGBZlukCmVqDw6NKCyaubfqY5lN 6z3A+6a1JRSYzwZdw/hQ+atmVddVdjlFT18jgbT2EzDFZI/jK6gnlJ3QLrgHn0QWJvOQz5hnE2H y3btz2OEfYrjhuE5QHwP4EiodNuSIMPDUXaXlX+7hNUtForTzUoJPH4Qeh4XBOtpYbizg+iWXbk ibDAh6NT7 X-Google-Smtp-Source: AGHT+IHQYfChmKUlUlXc+P1TgY8hL1TTOZD24LykVN5Mrpe7vHmpLt13pKMLW1QAwONNITq8DKgwcA== X-Received: by 2002:a05:6830:6787:b0:71d:634a:e0d6 with SMTP id 46e09a7af769-726a413e1b5mr2543074a34.6.1738776018984; Wed, 05 Feb 2025 09:20:18 -0800 (PST) Received: from C02GC2QQMD6T.wifi.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-726617cde49sm4004016a34.27.2025.02.05.09.20.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Feb 2025 09:20:18 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: thomas@monjalon.net, Peter Spreadborough Subject: [PATCH 08/11] net/bnxt: address coverity overflow issues Date: Wed, 5 Feb 2025 09:20:01 -0800 Message-Id: <20250205172004.50395-9-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20250205172004.50395-1-ajit.khaparde@broadcom.com> References: <20250205172004.50395-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Peter Spreadborough This change addresses the CID 449058: Integer handling issues (OVERFLOW_BEFORE_WIDEN) reported by coverity. Coverity issue: 449058 Signed-off-by: Peter Spreadborough Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_core/v3/tfc_tbl_scope.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/tf_core/v3/tfc_tbl_scope.c b/drivers/net/bnxt/tf_core/v3/tfc_tbl_scope.c index 1770069295..c29933b803 100644 --- a/drivers/net/bnxt/tf_core/v3/tfc_tbl_scope.c +++ b/drivers/net/bnxt/tf_core/v3/tfc_tbl_scope.c @@ -468,7 +468,7 @@ static int alloc_link_pbl(struct tfc_ts_mem_cfg *mem_cfg, uint32_t page_size, * and page tables. The allocation will occur once only per backing * store and will located by name and reused on subsequent runs. */ - total_size = page_size * total_pages; + total_size = (uint64_t)page_size * (uint64_t)total_pages; if (total_size <= (1024 * 256)) mz_size = RTE_MEMZONE_256KB; From patchwork Wed Feb 5 17:20:02 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 151000 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EAA2E461A0; Wed, 5 Feb 2025 18:21:04 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8365840B95; Wed, 5 Feb 2025 18:20:24 +0100 (CET) Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) by mails.dpdk.org (Postfix) with ESMTP id 296F440A75 for ; Wed, 5 Feb 2025 18:20:21 +0100 (CET) Received: by mail-ot1-f51.google.com with SMTP id 46e09a7af769-726819aa651so23111a34.1 for ; Wed, 05 Feb 2025 09:20:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1738776020; x=1739380820; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=te630U3+SNA15iWp7WLs+d0on1FeMuNQqsmrzCPaamM=; b=F5hvF+2wnQyvQ6YT9VAgAcMOhaM0tGNbtX12RFvQ26TamdYk3xuiXUlha8eVnb//0O QfYAJVHGsDNBdd3d1aRWsGQtZ/5AbxgOP5gLhz884zsow7ZrU4wAUnvq8jTRlfBRByEb 6DKcHHtY+2lYvH5hAsp62C2jBeaS+G36WXKeU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738776020; x=1739380820; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=te630U3+SNA15iWp7WLs+d0on1FeMuNQqsmrzCPaamM=; b=pGV8f6Dezt3tmGUHRbG2UzEZemcrRu6fRuQMib7OYYfb/G6UgBiDfJo/SnFE5IQneL fAztc7Ibe6pOV1JoRnJa9NHJ5wbz6+vvezSVIxRZxCms7kkaUoAWGFABsWQBMMPsw3fV 4HGX6LoNCwycWc1ihPN9N4mvUH2E8LcCwKXxkyjsfdFL2U+Z45VyIOcFS6wGEPQv9QDr wJhtBNJ4hZqO0+rdtA6YTb392VZVCOWue1BXuxNcjZxhkP/yKoIOTKZls23QUi205hxy yhWdTJdr5mYOttJx/X4Z2c3Hd0wnuhuyL3RpOf1NbU5ryYv7+yEZRCEvo/YYpuCE+g6Q f05A== X-Gm-Message-State: AOJu0Yxwo7Eww5aExZrjcrWqs96ME0BVXQ3wUXnihz9hcZkfxGtI9vMq kgLSKMak+8JjCtPI0Ibu5EixGch2PABqWGMxqMNTaTFpgtlxp7/VPv1VKgNUeDjp/Yg1tQX6mgC tRg1Fl1i1dBLTqUfz/w7qdbQ8N3CgkB2oI/Tz993cmQBes22kQRVZqPhlEt/to6Iv0wfgLoNHPx g8P6+e6KYZWKmdbi7aJl8AWrLbPgDG X-Gm-Gg: ASbGncv5G8x0MsReCpBtlwO3N/rpxqR/PjE+liApBiZDnlR0vm8l88/Uch1l9Gp/tqG B+AJXobE4V6YUTOp11VGzTaUNN9IerZnae/N+uCVpDkwRzB2oFIEGLf2j8gS4/oeWpG/0Fn+ou6 8MbiOziNEJxoJQiJ1oKqf+OXQ1X5Tb//t90Mrqd5QfGgHGlyWyl/4NLKsfdwe/oIecB+lDd8dkI JqKsn/wmEisQ34ytsSTxEiWkKLnME24cC4qKIyk8ors9bj3MuhAptuK+ScT5BW2c6uhzG5XxyMx Ez+T6pq7f+OAlOCrWG0sdOEXOLuablHTM/70+n7eyhds+VGh0rVBqQgRnF79Jr+28D/xRzjowVf QZ24y3P7B X-Google-Smtp-Source: AGHT+IFaDpl0ssou1iODefLWrw2/R6cfWd7Xz+UtcjjmEV0mE7FYwz7TiDDoeqXBs795jgnMOfvj0w== X-Received: by 2002:a05:6830:660b:b0:71d:f3be:438c with SMTP id 46e09a7af769-726a41545afmr2790468a34.4.1738776020209; Wed, 05 Feb 2025 09:20:20 -0800 (PST) Received: from C02GC2QQMD6T.wifi.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-726617cde49sm4004016a34.27.2025.02.05.09.20.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Feb 2025 09:20:19 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: thomas@monjalon.net, Peter Spreadborough Subject: [PATCH 09/11] net/bnxt: address coverity integer overflow issues Date: Wed, 5 Feb 2025 09:20:02 -0800 Message-Id: <20250205172004.50395-10-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20250205172004.50395-1-ajit.khaparde@broadcom.com> References: <20250205172004.50395-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Peter Spreadborough This change addresses the CID 449059: Integer handling issues (INTEGER_OVERFLOW) reported by coverity. Coverity issue: 449059 Signed-off-by: Peter Spreadborough Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/hcapi/cfa_v3/mm/cfa_mm.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/hcapi/cfa_v3/mm/cfa_mm.c b/drivers/net/bnxt/hcapi/cfa_v3/mm/cfa_mm.c index 61fafadb20..05528dd3e4 100644 --- a/drivers/net/bnxt/hcapi/cfa_v3/mm/cfa_mm.c +++ b/drivers/net/bnxt/hcapi/cfa_v3/mm/cfa_mm.c @@ -123,7 +123,11 @@ int cfa_mm_open(void *cmm, struct cfa_mm_open_parms *parms) } for (i = 0; i < num_blocks; i++) { - context->blk_tbl[i].prev_blk_idx = i - 1; + if (i == 0) + context->blk_tbl[i].prev_blk_idx = CFA_MM_INVALID32; + else + context->blk_tbl[i].prev_blk_idx = i - 1; + context->blk_tbl[i].next_blk_idx = i + 1; context->blk_tbl[i].num_free_records = records_per_block; context->blk_tbl[i].first_free_record = 0; From patchwork Wed Feb 5 17:20:03 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 151001 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D2BFC461A0; Wed, 5 Feb 2025 18:21:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F33FC40A7D; Wed, 5 Feb 2025 18:20:27 +0100 (CET) Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) by mails.dpdk.org (Postfix) with ESMTP id 3A9F340A72 for ; Wed, 5 Feb 2025 18:20:22 +0100 (CET) Received: by mail-ot1-f50.google.com with SMTP id 46e09a7af769-71e287897ceso43689a34.0 for ; Wed, 05 Feb 2025 09:20:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1738776021; x=1739380821; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4F+ezsTfyQiTlz+XpsQS1y58OXwpnowdwfis2twB6io=; b=C5WDQ+yqsCSeB4UUIqd+qdhwobanRVwS8IBQE4l+2v2822JMb858Pmn32JjJVp6SCr CM0AC06si4mphGnnXxnmU0EJLXgIUCld1o+MtYofDpV9y0CUfSR+h9YdcYavCV6Sd53Q efh1rYNnTwSZe73qvAGTq2FfhvHlndE6w4TE0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738776021; x=1739380821; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4F+ezsTfyQiTlz+XpsQS1y58OXwpnowdwfis2twB6io=; b=gpNk5qIN2ZBt9quqN9UJ1pVg9J8gK45XXQyzGSTN8H7uGB8rrE9tLaFrNqKjr2jxDR gUtrLea2x9BvQllKXFhrbRrHLTSSUSptSco4EEQt1ghrrwPAUow0wtXbfYgHpMS4jSl2 LZFBQQaJ9GOJtROlRtBQt0kM4c3OK6/f3LsP7YrC1cfytfBhWIVS4IECRZMKaqSzEGNr 4FgYo2LO5REkS3yaEZGjfTmF6zJUm2cWX5W+GAc7/cXmJ8jUPDDyMUmbjePpMKlgxX0q YZ2bLB5luvib7D+ckXhS3HURZQtRr7N1ee2GkynNKOAjYkhd90VSc7xj4ZA/DBjMJzq/ HLuA== X-Gm-Message-State: AOJu0YyB0KBJsFd+DJEL/BKwijaKCgiBfNun3PODwqMWRsQbWK4jvUSG Dh7nQOKQoJDKpq13WLo8ni8r2lqLME3fkelnGNzXWZl08EyyxBhFP7s+OIY+iujEEBCfcy9MD1/ ZZbvChE23YeW5owXlnxAjXRPYRO2FwtpikFXWoAiKzGWvMPYr6GdLoJloYCX8YgLlXp9iQ4yMAv Dn8wLteKhrQFqOXiuE5F0Rgh6G3lYO X-Gm-Gg: ASbGncuB23EZLKqx/1pjTlPkWvPgOTMoa9z5o+r+xc8JByMYPMpjCz60DBIbxR1bS6e q2wyGIQo6wcb3usHWNe0yxj+AlLoydqUKErJWL85F31Bj/AcNNmZ614ZyJ/Nn/3F4TsUk4z3a9Q YKie4THlJgZOafTlriv9VRhj0HTdLs8OFAQll1Oxa+IqPKSEkrlfgGODVttLrqTuIu6VcOZD03s YywMWESMpYRoreBJ9yAPf5UnCRrgYGEtHTycsuMTxMUyp+ZBacj/dooE1R+491bcBbbDRPUKrr1 xN+XsyyazXE/6DPKXeUZGUVnjRztnBOOZGk1gZ/dlSiLdsY9GExXrOB5bINcb6VOC6MkkY3FBLN ukT/9RbDD X-Google-Smtp-Source: AGHT+IGtG2l88uEewze0SiUl0qjTCDqEy391iup8PAJSpPMy5Os1vUt4qdL112iqsOORk1Yttyw4BA== X-Received: by 2002:a05:6830:4494:b0:71e:72:3ab6 with SMTP id 46e09a7af769-726a427eb7fmr2388079a34.26.1738776021268; Wed, 05 Feb 2025 09:20:21 -0800 (PST) Received: from C02GC2QQMD6T.wifi.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-726617cde49sm4004016a34.27.2025.02.05.09.20.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Feb 2025 09:20:21 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: thomas@monjalon.net, Peter Spreadborough Subject: [PATCH 10/11] net/bnxt: address coverity uninitialized variables issues Date: Wed, 5 Feb 2025 09:20:03 -0800 Message-Id: <20250205172004.50395-11-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20250205172004.50395-1-ajit.khaparde@broadcom.com> References: <20250205172004.50395-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Peter Spreadborough This change addresses the CID 449065: Uninitialized variables (UNINIT) issues reported by coverity. Coverity issue: 449065 Signed-off-by: Peter Spreadborough Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_core/v3/tfc_em.c | 1 + drivers/net/bnxt/tf_ulp/ulp_sc_mgr.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/net/bnxt/tf_core/v3/tfc_em.c b/drivers/net/bnxt/tf_core/v3/tfc_em.c index a70e35b6b1..d460ff2ee0 100644 --- a/drivers/net/bnxt/tf_core/v3/tfc_em.c +++ b/drivers/net/bnxt/tf_core/v3/tfc_em.c @@ -560,6 +560,7 @@ int tfc_em_delete_raw(struct tfc *tfcp, mpc_msg_out.cmp_type = CMPL_BASE_TYPE_MID_PATH_LONG; mpc_msg_out.msg_data = &rx_msg[TFC_MPC_HEADER_SIZE_BYTES]; mpc_msg_out.msg_size = TFC_MPC_MAX_RX_BYTES; + mpc_msg_out.chnl_id = 0; rc = tfc_mpc_send(tfcp->bp, &mpc_msg_in, diff --git a/drivers/net/bnxt/tf_ulp/ulp_sc_mgr.c b/drivers/net/bnxt/tf_ulp/ulp_sc_mgr.c index 5fa8e240db..57cbaaf09c 100644 --- a/drivers/net/bnxt/tf_ulp/ulp_sc_mgr.c +++ b/drivers/net/bnxt/tf_ulp/ulp_sc_mgr.c @@ -224,6 +224,7 @@ static uint32_t ulp_stats_cache_main_loop(void *arg) if (bnxt_ulp_cntxt_acquire_fdb_lock(ctxt)) break; + batch_info.enabled = false; rc = tfc_mpc_batch_start(&batch_info); if (unlikely(rc)) { PMD_DRV_LOG_LINE(ERR, From patchwork Wed Feb 5 17:20:04 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 151002 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7B274461A0; Wed, 5 Feb 2025 18:21:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1FDBA40B94; Wed, 5 Feb 2025 18:20:29 +0100 (CET) Received: from mail-ot1-f51.google.com (mail-ot1-f51.google.com [209.85.210.51]) by mails.dpdk.org (Postfix) with ESMTP id 3BB9B40A72 for ; Wed, 5 Feb 2025 18:20:23 +0100 (CET) Received: by mail-ot1-f51.google.com with SMTP id 46e09a7af769-71e2bb84fe3so27629a34.1 for ; Wed, 05 Feb 2025 09:20:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1738776022; x=1739380822; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZgWd5PLP0gx3Tb7mjdi+VvaEd6Sj6xeh89zcNq8Bc1g=; b=ep2aRRQLeB0ifSPYNhHZGi2D0RkOT4zhEnxH+JF9mTgQ0elM0/tjGlQPKRO+eOl27x 4fwHUSN8OySVTi87WzQrWeOwkzDZYB+oLUUHGu0dSL+H2bbhAxCm6OIpa8jw9p6LyEt2 4UoCOD1jrZdUVbyfi/jUgy4OufnZEbUz2Q3Zw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738776022; x=1739380822; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZgWd5PLP0gx3Tb7mjdi+VvaEd6Sj6xeh89zcNq8Bc1g=; b=mq7XQDh5CvVX9aO13Nqa9Ey7duMZeXFNowmtAJRLKmn2GVPvTSTX5FOlqZgVfET4G3 WRpPh5GI8DOA8dUCNtoDWoSpZDXDazL4NI0/vJeW7epq4yMFKAHwlpHe02YCzfzCR5nv 4pkDEzYlE9xB5VkwccJ2VPqNaiRzYnOHHxEsaqgMlGYuSAENuK/c8se/xMS+6jA+VH10 IaseiXQuYT24lpd0zaIz69nbEKgs3cs09cyNiQDbnHr/1SbbXiJougHfKohz2tXH236I t4Sp78eqcpe8KU1419NoCF4j2QeoKkcwzhW7wty6qB3QJAC/P/ZVcccDnlM4uRdoNvNW oz+A== X-Gm-Message-State: AOJu0Yx3suxPep7qQRDaHjK4O9GpP5T0a1OUHT+eBe1EycahcVxipjWU rCvfAxsoZZsxUznRG1ihkTJSEnRAarlx8eYH5XzsSZB1N/eQKKuoRZuwtrF9xg2FReHPkn1sqKE KKxAqFUdeWhEPi3lm+8r3tig4Qb+E3Ft5dnUl4Jze4/9wJA2X+7rNBCwtdbWD6NhzaJc7nr+LRu BIqDdgiCE/yRdMXusE2bh0itywIUV9 X-Gm-Gg: ASbGnctUXRB956kU6hBwD9okJVzpjTUKcqkZ4bO11i3NLg8JH3V3dPtt/8psuN99Zy0 oabO0yelBtmoLYTEi4SGQRIZnTa0eT96Mnpf4xa8eu+dAu4o/6hT/gRa+TGsWUKmRNJA2Nx8sJJ z9LkDdATrdXChQ1I3C0Z0B+PZ+ydLAB85JY4ln0rhht9elytnZkyiMSuJtNp6zPPcjxKOFX6ysw IKb+/GzBkX/WAUATIb0M1r4PURAZ0HCxO2++Iey7mSaFds8eJtXLMgNgebCGC21YZse09bOQKUQ N/Jy/eH5+aItmxQlMZePT8WSzVVNLjOr1RHxWK0zUoJ9hSXz1jSEv5QDfjV6ZP2eGXkWhHbh3xD jLleyDh1c X-Google-Smtp-Source: AGHT+IFwnKsoaL68Ro13y7BvxpmTd9XTvGe8tzfLDNg7wBlhwh8t2buCN7pPk29rt7SzvsfQtNeo8Q== X-Received: by 2002:a05:6830:6501:b0:71d:4086:6072 with SMTP id 46e09a7af769-726a419c77dmr2615599a34.7.1738776022318; Wed, 05 Feb 2025 09:20:22 -0800 (PST) Received: from C02GC2QQMD6T.wifi.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 46e09a7af769-726617cde49sm4004016a34.27.2025.02.05.09.20.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Feb 2025 09:20:22 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: thomas@monjalon.net, Peter Spreadborough Subject: [PATCH 11/11] net/bnxt: address coverity control flow issues Date: Wed, 5 Feb 2025 09:20:04 -0800 Message-Id: <20250205172004.50395-12-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) In-Reply-To: <20250205172004.50395-1-ajit.khaparde@broadcom.com> References: <20250205172004.50395-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Peter Spreadborough This change addresses the CID 449072: Control flow issues (DEADCODE) reported by coverity. Coverity issue: 449072 Signed-off-by: Peter Spreadborough Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/tf_ulp/bnxt_ulp_utils.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnxt/tf_ulp/bnxt_ulp_utils.h b/drivers/net/bnxt/tf_ulp/bnxt_ulp_utils.h index 5e0d906fbd..e6f316539c 100644 --- a/drivers/net/bnxt/tf_ulp/bnxt_ulp_utils.h +++ b/drivers/net/bnxt/tf_ulp/bnxt_ulp_utils.h @@ -1084,7 +1084,7 @@ bnxt_ulp_cap_feat_process(uint64_t feat_bits, uint64_t *out_bits) if (bit & BNXT_ULP_FEATURE_BIT_PARENT_DMAC) BNXT_DRV_DBG(ERR, "Parent Mac Address Feature is enabled\n"); - if (bit & BNXT_ULP_FEATURE_BIT_PORT_DMAC) + else if (bit & BNXT_ULP_FEATURE_BIT_PORT_DMAC) BNXT_DRV_DBG(ERR, "Port Mac Address Feature is enabled\n"); if (bit & BNXT_ULP_FEATURE_BIT_MULTI_TUNNEL_FLOW) BNXT_DRV_DBG(ERR, "Multi Tunnel Flow Feature is enabled\n");