From patchwork Sat Feb 8 20:21:53 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 151184 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A5F98461CD; Sat, 8 Feb 2025 21:32:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 75FDF402D9; Sat, 8 Feb 2025 21:31:56 +0100 (CET) Received: from mail-pl1-f175.google.com (mail-pl1-f175.google.com [209.85.214.175]) by mails.dpdk.org (Postfix) with ESMTP id 27D69402A0 for ; Sat, 8 Feb 2025 21:31:55 +0100 (CET) Received: by mail-pl1-f175.google.com with SMTP id d9443c01a7336-21f5268cf50so24983535ad.1 for ; Sat, 08 Feb 2025 12:31:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1739046714; x=1739651514; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=h9BTfoLjWfuzS1DoP0FGgfd61sEkhLecVg9ytCmHtKY=; b=g5RVNAIAJKmZIZ6Rfgu1pu3BXYcAN7VHGeZncAaFe5raWyB1xCoxrLV5EVMqCZxSD0 25uy3DoQJ21AIGjMQgq5yMs7uzqyv9Twb/cz/xLpVnXrwQ+hpSC9roJXly0aDC9MCqq2 SSizdBKfUyrYmVQUC6tJV7ks2iZtkWjzCpKUdcCGhFButdB92gJCoTXN+LjoOawoxy/d N+lXNt64VYVAm4p3JE75JRMKwfD0WjciJspGq/RUEEVEmkeFkdw7M+zivB/mz2gE6yBV 1OgCFJ6jYUyQ3rl8vRONOqyLEyFGOkz0qxDRv52Ye77DzlP9mrXuWLfom04f1ABK8bYn N84A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739046714; x=1739651514; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=h9BTfoLjWfuzS1DoP0FGgfd61sEkhLecVg9ytCmHtKY=; b=vGeoJmhz92kzEJM8eQKs8iFhXw51vM71MzwqXSQSXWwoztCUQ7svwZWICoyRQN9Mcl Sq2vu+fvponMdaX44KY/gqkIkfq7WuVIJCGQB1KFQMa8cOFhs4exl9CG/oeoRIO7wV/D miVL8Kb8bCawxJSQPghEH1ff8rKcV+SL036Q1fGz76GmZZbncrAfHPxjMyebRKc6KCju +abzibyMVFsJxLCrWR9BFAphgN84xaxps/EXWGA+zn+zauluuZJhrGLJrkbQY42XMPQY WvRrMX+eG802j2jAzvCSURBbbZOuhJChejtWKLf65jUmvWnZbw49qnHSwyTR7+2H+25n opJQ== X-Gm-Message-State: AOJu0YybwOYyWeWFLwBwzZMDk9MpWHeEbDtBMDX4zSb5BNzw5H/4gqap x5hmRlBd0/ycw1vVvb2MDFKCtfGFXzyxh4zLT0VL+/6RYpui7hVEDD4IBUuZ0JrO5ck74gWZ9ot 3OFQ= X-Gm-Gg: ASbGncsozH+xZWN5FByp690cC4Nauw9P5ZPaMySPo0qjJ5E26fPHTH/5R0WNEs8NF47 Z1j5fIHqd5DlPQ36Sb9zwr/4MAr+ZeAWRA5F+4lOkoD3pdFwjYrF/g7eNuQtKxQvUr4VLs+WHU2 6mR0e7caY+BP1xDXvuOCSP2ijrrtHXnN1fdpOA/oh6HUtXMIsu9CEPj4Zb8ybEFJpTt1yRlX7Rm /p5xdFoWhL2/I8+E+ok4yy9UORU4qSKR/ojEjSG0UtT9tbPUr3EpZv7qbR/9NB4rnJLLoIXr9oH Y4axNdgMXWdZS4dTtw0fdhZY4xkYfhUcurNzTJWhyro/Z+CmdHP3HGGAfC3TCy/eTALJ X-Google-Smtp-Source: AGHT+IEPIMFyesVf861cRnbWJvMdklAurI9r+F7eZMqdmHekAE/wtJR+OkPNKu9IMhz48X4qAAH8Kg== X-Received: by 2002:a05:6a00:189f:b0:729:cc5:fa42 with SMTP id d2e1a72fcca58-7305d516f36mr14805565b3a.20.1739046714247; Sat, 08 Feb 2025 12:31:54 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7304c780da5sm4882019b3a.69.2025.02.08.12.31.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 12:31:53 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH 01/32] devtools/cocci: prefer structure assignment over memcpy Date: Sat, 8 Feb 2025 12:21:53 -0800 Message-ID: <20250208203142.242284-2-stephen@networkplumber.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250208203142.242284-1-stephen@networkplumber.org> References: <20250208203142.242284-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Prefer using simple structure assignment instead of memcpy. Using a structure assignment preserves type information and compiler checks types already. Signed-off-by: Stephen Hemminger --- devtools/cocci/struct-assign.cocci | 15 +++++++++++++++ 1 file changed, 15 insertions(+) create mode 100644 devtools/cocci/struct-assign.cocci diff --git a/devtools/cocci/struct-assign.cocci b/devtools/cocci/struct-assign.cocci new file mode 100644 index 0000000000..052ebf3340 --- /dev/null +++ b/devtools/cocci/struct-assign.cocci @@ -0,0 +1,15 @@ +// +// prefer structure assignment over memcpy +// +@@ +type T; +T *SRCP; +T *DSTP; +@@ +( +- rte_memcpy(DSTP, SRCP, sizeof(T)) ++ *DSTP = *SRCP +| +- memcpy(DSTP, SRCP, sizeof(T)) ++ *DSTP = *SRCP +) From patchwork Sat Feb 8 20:21:54 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 151185 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A131461CD; Sat, 8 Feb 2025 21:32:08 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 915DA402E9; Sat, 8 Feb 2025 21:31:57 +0100 (CET) Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by mails.dpdk.org (Postfix) with ESMTP id 24359402C9 for ; Sat, 8 Feb 2025 21:31:56 +0100 (CET) Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-21f53ad05a0so28181505ad.3 for ; Sat, 08 Feb 2025 12:31:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1739046715; x=1739651515; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kkBhSy0h4ES6aAexc3N5WwCGlqzptrFZxlS0DDRmmeU=; b=1pGVzB7x47HnmSsmRGPK36w3mGLM7QrI4il2qAcGeqD0FPPUqJBI2obsInAq88XCOi WFNhC3H4hasJEvuOaJ2o1ON+rksdCB69LAoZUq3CVmvUSdTzqElRYnFZtm1psh1k6Ke1 /dFqr9pJ5YXqaMgo58UFF23QplfPHDbF2JiMhyp0IZD1Ar1wFPli9+VD89e7cv9lCNZi jjf4ekGgbzXtFqXSGok7Uk3Hb4KqUKuSXV4KNDyAQOAMHeNwQtTzrcqz3Ad1zeAdRTJB /SCkN+PNXhhelc7wMbAt0fbKyGbodA3KNJawKINo7ZQUh5+LHKpB/vuz/PnoC985/Zrw OHzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739046715; x=1739651515; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kkBhSy0h4ES6aAexc3N5WwCGlqzptrFZxlS0DDRmmeU=; b=YRpfKtxWBKoNs8PSG28h66WN+4ZIOb/cYwre6WeJ6pfdoCImT/l7GzdMwhOHNStj7P XOaalhuKQ/CKDSrckgcOs/5JQG5DXZo0tSPIpVHFLtW72jp/RN31EdN6IY91VcBCwL7C BMaRKxuqAd/OKBUgzCpFw061r7sA164klAPfD+mgMGcJZ1ABOoO4RWFGkrrddk7YXOk9 M1iVKRu1gPDhaT4j8ZJ/WLDsqy6vapoLTRb3HSj/H8P1NH5b7m71tXbvdPz0qOzWfs+x 12rX0+uabnZLho+B9KENckwerLm1IekiQvuBZcKoR6F7QdgZVOl5bZ9zWTDCCjscLoQI smIg== X-Gm-Message-State: AOJu0YxwpAbrqAjYaN5y3TbfvFt5sdoiiGTm6TE1CvbhQfs8c4znyzJM vC+ScJHxFp8lIfRVDrGhz5z3fdfe18zLjGefDhbTT086jPYBV7s4GhkEtG5G6xZWWjYJ1vm+C8P Vnow= X-Gm-Gg: ASbGncudJq+9Qu6gINIkf02LqSM6/SFNxeTI3WPfs0pqsPXIoNhWiT91Bkv8oRZUCdI 1QPX7HQOoWIHyV6sH5YfVmSEe9hzQsv2bAXLLeRdPI+ZXouLXQTJvjzEt7Aagk/f9yg9pqqqahC rDurVBe56urY+Dar5qgudO/SrVGmVm/OUbiTH5P1tUxIJAcBf3D9bl4NOgCAWmrmCN7bGpnL5bo aUqYDhAXMGInHXTuAi4/8cqXOMLSUl4YDmg6mShfHuNMouHNznpRZ6IIGVYIsg+LniltiLh1aoJ 7/Yk4PwJlieMDt0NX7s4jqJo+gVil6HK0zW8iab6NC/llti+/pqkTCF+YT8QdVQoCzES X-Google-Smtp-Source: AGHT+IE01daW9YfEjFwrvq0/DSuB79Hvk5mJk7DoCQKvNRGJ7U/aKLciIHbHrQusyIa6Hwef5Of9sQ== X-Received: by 2002:a05:6a00:c86:b0:725:456e:76e with SMTP id d2e1a72fcca58-7305d44a459mr12907946b3a.6.1739046715264; Sat, 08 Feb 2025 12:31:55 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7304c780da5sm4882019b3a.69.2025.02.08.12.31.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 12:31:54 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Ori Kam , Aman Singh Subject: [PATCH 02/32] app/testpmd: replace memcpy with assignment Date: Sat, 8 Feb 2025 12:21:54 -0800 Message-ID: <20250208203142.242284-3-stephen@networkplumber.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250208203142.242284-1-stephen@networkplumber.org> References: <20250208203142.242284-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Prefer structure assignment over memcpy. Found by cocci/struct_assign.cocci Signed-off-by: Stephen Hemminger --- app/test-pmd/cmdline_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c index e1720e54d7..9a2cd86821 100644 --- a/app/test-pmd/cmdline_flow.c +++ b/app/test-pmd/cmdline_flow.c @@ -13934,7 +13934,7 @@ cmd_set_raw_parsed_sample(const struct buffer *in) fprintf(stderr, "Error - Not supported action\n"); return; } - rte_memcpy(data, action, sizeof(struct rte_flow_action)); + *data = *action; data++; } } From patchwork Sat Feb 8 20:21:55 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 151186 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EE9E9461CD; Sat, 8 Feb 2025 21:32:15 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A1EEE402EE; Sat, 8 Feb 2025 21:31:59 +0100 (CET) Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) by mails.dpdk.org (Postfix) with ESMTP id B7FA3402ED for ; Sat, 8 Feb 2025 21:31:57 +0100 (CET) Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-21f4500a5c3so57623315ad.3 for ; Sat, 08 Feb 2025 12:31:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1739046717; x=1739651517; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=v1j9XiGDKApfoOd4c39AuRDGOI3XN1cA413jHKpZ2h0=; b=CVfvF2cLtpl/Leu8LswjR37BoHnFUSOnwEUBa7fO+aTx0ApvwuxTNpG7nXnGGSy2eG FQQOldkvPNMKUAoSVkim89er+pvvX/HcAS7CCjjINqWhxQB52xdBQDaPWPb+gKKr+ZIo f89lSYNLZaLN8d3S7qGFZVnVwXclh2w4mtAHed2lXaAyL6zjLkeWQUrc6ZW8vV2lGfdc mQmXc1eGuw9MJ6Ty2oEbEXTrI+otmIbRs2Hi1g39xOoVOwKY+qlGxPHxCuQJV1webXu8 UhL0qL+CeoUdGIBAY1wUklTeWazabM8oQL9OEJXsZ01qrR1rzMnxD8yYF7EJsNMpC72Z sjOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739046717; x=1739651517; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v1j9XiGDKApfoOd4c39AuRDGOI3XN1cA413jHKpZ2h0=; b=n/tqOwhDgaRKnufqsDdQs8vR5Ez+FICt0NavCSJ8K9hgiaQTtcllkUTxsgr1h/CInm /M27WWwVUb3ijUbwUQFC53CIFnu6nnBg9jUUIvq2aH2SgFIBmMR57d3IacOWmcd5cRrJ n0rtsWhda6zvbY4HAhfxtKquxBqfmhfPJnOoUzIvU5zH/OYINwumJ4oVJXHQHjGkJBHA gNHa9oZNrMyUzC3t0TwthYt4seTRS+FznhIspK743VE5h68wJI9GmZhpBfQ5bX6rlD1y rAmz3rMtl8oLwfn6hCHHa2sGQytY5uncGg8AZl2/CiLAvvBmPa4M5h5xSnISFD+XNIUy zWfA== X-Gm-Message-State: AOJu0YyLqTgjvFPPQ1b4GQx5lEJk1ILBIIfFhOzG5W3jgjlvfYcak5AK qqvnRoI+Ax4+5NA2W4DzYJzaQ96v7MLHjpXHRO4jJkE+p0HCkpaXgmYTCt0CsrBqJLiUEB0KPBf TX78= X-Gm-Gg: ASbGnctl1GEtq4T8lHyyAt93qwIX3Plcwpp0dwpTRIwzYCBtyHtyLU5cLWapYuwH5iU QduS5IZ6pvXiw5Sa9njIGeg4EMR/Sqk3OqVqLdjX7Lr5XAPSKrwMG6wrQjOYEzPWd7uFW3YlwSN J8YkP/41gJ4cJkMGzgwZiW3VmQ1Ju1NUkldmIkdiWtanMUdz05UQSRRx6hXYaFgVMbAKIcHnrk3 L3FvsxG8iSnXwb0LvlPBQu2kv8VNx6AfwHr+bB3ksa1ULI27ICCYy6VEP2Ut9FPWMk5WFDkYCdN 8FKOfTDn81Rnq4/TWbtrP0XkMQU+doMsDlUUwoRPheHEU5yWkZgvo+yLMqblUma3i7zK X-Google-Smtp-Source: AGHT+IFMq6WLaalS2iRzgJ7FU1nh5w4nuMY0xvru69Gbqh6gA54jNMC+nrT2KkHhJIYrx+saMlpG/w== X-Received: by 2002:a05:6a20:9f48:b0:1e1:bdae:e04d with SMTP id adf61e73a8af0-1ee03b708e5mr14546319637.36.1739046716824; Sat, 08 Feb 2025 12:31:56 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7304c780da5sm4882019b3a.69.2025.02.08.12.31.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 12:31:55 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Sunil Kumar Kori , Rakesh Kudurumalla Subject: [PATCH 03/32] app/graph: replace memcpy with structure assignment Date: Sat, 8 Feb 2025 12:21:55 -0800 Message-ID: <20250208203142.242284-4-stephen@networkplumber.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250208203142.242284-1-stephen@networkplumber.org> References: <20250208203142.242284-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Prefer structure assignment over memcpy. Found by struct-assign.cocci. Signed-off-by: Stephen Hemminger --- app/graph/ethdev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/graph/ethdev.c b/app/graph/ethdev.c index d343235dae..2f4cf65c96 100644 --- a/app/graph/ethdev.c +++ b/app/graph/ethdev.c @@ -422,7 +422,7 @@ ethdev_process(const char *name, struct ethdev_config *params) } /* Port */ - memcpy(&port_conf, &port_conf_default, sizeof(struct rte_eth_conf)); + port_conf = port_conf_default; if (rss) { uint64_t rss_hf = RTE_ETH_RSS_IP | RTE_ETH_RSS_TCP | RTE_ETH_RSS_UDP; From patchwork Sat Feb 8 20:21:56 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 151187 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0F088461CD; Sat, 8 Feb 2025 21:32:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2FF414060F; Sat, 8 Feb 2025 21:32:01 +0100 (CET) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mails.dpdk.org (Postfix) with ESMTP id 49689402C9 for ; Sat, 8 Feb 2025 21:31:59 +0100 (CET) Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-21f50895565so26204275ad.2 for ; Sat, 08 Feb 2025 12:31:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1739046718; x=1739651518; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tcYIAyKKPVd2crCbWEA0Sl9FDyUYM+KXlQOy5mPq3wg=; b=r7ICHBuxG26ffu33e2YFROW0c6oWBVrxqLf55ZQPA6I8usP1xc+W2b6pW4MMB62XNC ZOgf6htMFxW2jeN8LeBB141eoGCgyGgU1acFxkLfXl90HrY5sCI6+wfPfxF+wfBIZ9cE QGYsQpfUDJATiLcY4ZSYX1gH9zRdrSyvONfFI2B0uQenZi5WIhnugHCi3cfWf64asogK C634isqy9mA7w3JRqLvK/AU7XKhvBI1pxF8/DfCipEpJ7gGAwEDm3Y9cMK7fS6QP3PXv YlJeYmWwflyERpDhTvNQjiOaIoBdtFRGsn8WuG10xlzMye15AwYU+qsYSt35lYQCVpuH ywlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739046718; x=1739651518; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tcYIAyKKPVd2crCbWEA0Sl9FDyUYM+KXlQOy5mPq3wg=; b=KfWXdSaA9GbsenPhVN4u4Lx0uBtULvBwnrcim9r5dnvj9itkEmB8tYMnLVHBddIvSM 7mepWhfbj3Czl7dFkDi5dhP5ShYCR8pYyq0bXd0ybpPkSgL9xxM+25+xwg3XEtWIFAq7 EZBpugrJPSNrLbHuZizct/uGzUMZBoEu4YsIpnxoANsbihsvKabJFfc0C4m7k11wLzyH ewTWiMdqHBJvrUhcsYrFnT74MMB6V5MMd6SIv7a8KRxG5ZrvuEk2kuWRNRSC13ToLO2W o5nVp5hJ28sQ/lEHAG/HviYnU7rcfyKuG6aXkZltTOdoIu6V82lppGa73PKbFzafaw4/ fbEw== X-Gm-Message-State: AOJu0YxLCf5xSpnadn736QuVqEz7inBVCaDRzbKlKClZwJ0h72qNfZoU 9rZHIOP7C8rndYbZnNIb+eLZCy1/t6SwD+huXxzcHp4ShOG25l52nOO45dhz4Et+H4O5Ljl2tcz 5T8U= X-Gm-Gg: ASbGnctWF7qxh0OjNrBj2HtfL8PbHSB2Yg1goLorLNu8mfZzWN5Qz2eAI8C9/PCXcSD lXNF+Vzz5BNuo7NeqSopV23dfU1kY9kVLfbabLJxNhX5In7GseNfh0cyN2E9d16cT/jShkmhorL o35PET/Q4QgNepdbo2zYHXi9xbuueLq8brhB5BSYfyc1Pm51OcnqmE0/kDODwNXud/qBPjnKUkL cwKBsZPmCIR3hl/zqmntTFettBLihdzsB/KdAFJ5ZZh8gbTgXaF1CTu3hi8x25yI+zBMmBgXxz2 XUecDcc5ZyFj1H9Scze3UrKL/eAuy67YQn0RDgnF+jWxv5Dtf8ta+QMaC1keBpXSrCRa X-Google-Smtp-Source: AGHT+IGvrN15lSmnanXOIUSA6dnRmeT0MsVmIkzHasV1FzR0Ow05GEiaS0ekxcTIaClquoaA2P6xQQ== X-Received: by 2002:a05:6a21:918b:b0:1e1:ce4d:a144 with SMTP id adf61e73a8af0-1ee038c2641mr14307607637.0.1739046718512; Sat, 08 Feb 2025 12:31:58 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7304c780da5sm4882019b3a.69.2025.02.08.12.31.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 12:31:57 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Gagandeep Singh , Hemant Agrawal Subject: [PATCH 04/32] crypto/dpaa_sec: replace memcpy with assignment Date: Sat, 8 Feb 2025 12:21:56 -0800 Message-ID: <20250208203142.242284-5-stephen@networkplumber.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250208203142.242284-1-stephen@networkplumber.org> References: <20250208203142.242284-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Prefer structure assignment over memcpy. Found by cocci/struct_assign.cocci Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/crypto/dpaa_sec/dpaa_sec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/dpaa_sec/dpaa_sec.c b/drivers/crypto/dpaa_sec/dpaa_sec.c index 3fa88ca968..af605d2025 100644 --- a/drivers/crypto/dpaa_sec/dpaa_sec.c +++ b/drivers/crypto/dpaa_sec/dpaa_sec.c @@ -680,7 +680,7 @@ dpaa_sec_dump(struct dpaa_sec_op_ctx *ctx, struct dpaa_sec_qp *qp, FILE *f) } cdb = &sess->cdb; - rte_memcpy(&c_cdb, cdb, sizeof(struct sec_cdb)); + c_cdb = *cdb; #ifdef RTE_LIB_SECURITY fprintf(f, "\nsession protocol type = %d\n", sess->proto_alg); #endif From patchwork Sat Feb 8 20:21:57 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 151188 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BD75A461CD; Sat, 8 Feb 2025 21:32:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7B7FF40647; Sat, 8 Feb 2025 21:32:02 +0100 (CET) Received: from mail-pl1-f171.google.com (mail-pl1-f171.google.com [209.85.214.171]) by mails.dpdk.org (Postfix) with ESMTP id AF23640395 for ; Sat, 8 Feb 2025 21:32:00 +0100 (CET) Received: by mail-pl1-f171.google.com with SMTP id d9443c01a7336-219f8263ae0so58988505ad.0 for ; Sat, 08 Feb 2025 12:32:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1739046720; x=1739651520; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=U0tjkpHfiRhAmYxF1UXjjZsXNUmjuuO0FwTDnZIaCO8=; b=ejykypiXZrYdjHLIqX+LEh1YnvaFMtfdN5Srw4eDe3LalARLj9DLIKihEExgVAAkdi xPwdSqNaJxKXIG403IwR4zxu/ZTi9ld9LrCUWUcvnEk28onO1jz1T58saLXB5rnTwb18 YBKmBcT5IjlzlB4vgqMcoFkwH/aihu6Mzg7qnxh4N2Axj8kIGND28BBZ56MTgnCjo8cf QckcKgAnrQvnV+8wmDr6/kEcreQORkhaOjHjMMbefhKSdCwCV6oT/tmlTkNuP5i1GYAF +NFuh664UWrNXxXRlG9XKEsts5ZWJALJt7cP/hiC+02smDfJPTM8P2Scl2HIqjlQIx7Q lwaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739046720; x=1739651520; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U0tjkpHfiRhAmYxF1UXjjZsXNUmjuuO0FwTDnZIaCO8=; b=vMOYuD0NHUbLRmO6QDp/XqFjuKExO7+zO3PiVgXw/GviQfYkVQlf3BB8vcdXfRlAvZ HX+6dAa/BynHjQwtK9sEf1hYfmj9LtzAprrL9QeluUcsNbFdyIV2osfLyMsquzsbxUGu O5+loy3cLHcpqrbUzncanCsCA4nfn9XIzXED8WjPLNnV2MbIxa1evAoSXTR2hdyAvsDa k6Cipd2PTmMAYWEcNy2TeVM0NDe3HI0nuC0y8u4XBFiISfju7meq3/d+ir5wqDfeWRVA qav6/XetxHCqd12I4jhBgNKCvLmn6z0mSv69g2TQqRo1MQEYfu9eENjQg/BLUrUYYtoA yqNw== X-Gm-Message-State: AOJu0Yyq0OCcIQNPKfGoEcQH5VPjoVNTrjYB7uTiEDGk9GK8cjHhndCp Z4Lfk6J/vMJDGIOKWn5tZ452oa5sxFNRWopcPpdne1OjUN1RuURnbrqCpykfBBmVC7QUAS+H0jI 0YOw= X-Gm-Gg: ASbGncsOIJ2icd33OnwwBJHDgP4XDU3aZZlYhKx//ETBs5rQ3QX2OD+YU+p5u/3VJ/g v4oMZ/QQNdYjAXWFn9mK9sBR0EemvwXEakypiQwEzuyoDvAUZeDY0XrOcs7oW2j3weYVnxAfikb UvgSS2FlkT9tiMl3KTjyZKsL0WS5vjzWwRa70SzG0KHr3O3hIdEoYCqidTF2bvdM8WDqrjxqnQV 3xfbGZCRH2KXhx0/3WmHoyyZpl0I64gwcf7zx0LkF/hw2u+PX5Zgdea2HVOuB2KIo0XeQms6UBn r4bkhhhuUth5N274lxiE/pA+Ni2ZEj7w8f9nQrXuaR70QPBUvaeQOvgjXRfv1ysU1pp7 X-Google-Smtp-Source: AGHT+IFuE5fWxLlMabN2U+NxqhVzCP/u2uHCyAie6dospH6TVrLUnHRhjqDkr2e0UTCysMAiG0TR7Q== X-Received: by 2002:a05:6a00:23c8:b0:730:7d3f:8c80 with SMTP id d2e1a72fcca58-7307d3f92acmr3222709b3a.20.1739046719882; Sat, 08 Feb 2025 12:31:59 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7304c780da5sm4882019b3a.69.2025.02.08.12.31.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 12:31:59 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Gagandeep Singh , Hemant Agrawal Subject: [PATCH 05/32] dma/dpaa2: replace memcpy with assignment Date: Sat, 8 Feb 2025 12:21:57 -0800 Message-ID: <20250208203142.242284-6-stephen@networkplumber.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250208203142.242284-1-stephen@networkplumber.org> References: <20250208203142.242284-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Prefer structure assignment over memcpy. Found by cocci/struct_assign.cocci Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/dma/dpaa2/dpaa2_qdma.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/dma/dpaa2/dpaa2_qdma.c b/drivers/dma/dpaa2/dpaa2_qdma.c index 3c9a7b5485..c0e0a44e84 100644 --- a/drivers/dma/dpaa2/dpaa2_qdma.c +++ b/drivers/dma/dpaa2/dpaa2_qdma.c @@ -171,9 +171,7 @@ dpaa2_qdma_multi_eq(struct qdma_virt_queue *qdma_vq) if (unlikely(num_tx != qdma_vq->fd_idx)) { dst_idx = 0; for (idx = num_tx; idx < qdma_vq->fd_idx; idx++) { - rte_memcpy(&qdma_vq->fd[dst_idx], - &qdma_vq->fd[idx], - sizeof(struct qbman_fd)); + qdma_vq->fd[dst_idx] = qdma_vq->fd[idx]; dst_idx++; } } From patchwork Sat Feb 8 20:21:58 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 151189 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2313A461CD; Sat, 8 Feb 2025 21:32:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7164540649; Sat, 8 Feb 2025 21:32:05 +0100 (CET) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by mails.dpdk.org (Postfix) with ESMTP id 3528140615 for ; Sat, 8 Feb 2025 21:32:02 +0100 (CET) Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-21f61b01630so20259635ad.1 for ; Sat, 08 Feb 2025 12:32:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1739046721; x=1739651521; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=laxEXCx80XcdHoH1gOOKbSj67MVc4I5m5RVujYFj2G8=; b=FTTStHbGhafRNceI3x24k1ZIINWthAMAab3cPlP+lcXXyT3FyXtMtO/k3rWUHxfO6Q F9wQgdLrSy5Lf8Xab0twoOUPknIKWFXi7yZR/zwWRxoNFA9yfN/y3fsh/Gr3JnNnWg4j jEjftqOGNqADk6JP0GSGgXwmb0zTCLONmrjKQEwguz7rMUqBgoVXR2s6cZR6iD2ojhhQ y5ogxod/KoWfefCLK85M0w+7fpu9EODCZu+YXlTyUg9bRd5cOqWBHHmYOEm3FqrOKE1g bKzCkO5yAVbwSPHPxhVwphWOy3bp+Cd/puojPwWf8X88lmSBLMyGN0ZhKQlL4WmDAxnV p/GQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739046721; x=1739651521; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=laxEXCx80XcdHoH1gOOKbSj67MVc4I5m5RVujYFj2G8=; b=vI3EkqlR/PWtNv5YGzzJSh6Iu1/ZkiKZYs7FtTfl/+r85f2ImMn3W7rYwXUWPvNv/J H58ks6VoFPI2ogRmDhHzxB/ZfO+G+bYk2qk4j5jEF+Viow6I+35BAeHUKSgfyQA2nKpc agLgBVDpvFAYCGk3x/UCY0mIdrC7ht96/TE+Ls9FtYfbsilbu7KSGNfAvMWrXPJYh+QG nma7jXNOB3mpSpz1y04INJB6/pvbrwdbeMc0z5yipREBWhADI5b9ewG01U50WeWIzB0k T/cdHGQ7BFgceu3Co4sPiFb4B4R3I8XU6QKvf/qdCjd0rupAqC8HYcDt2ka1Ghs77Ri6 eXRw== X-Gm-Message-State: AOJu0Yzd1TMlPVu1cohg8PdDuKPPEIt/pLXLyvsVU2y//6IzOUXWfmPj 4weAy51wSQkO90cdhKNX9x9dOyKiJXLGKGLvIx37tQm2CE3JzPxsvaqoxrboz1cAz7QP6gj9TFT Mw3E= X-Gm-Gg: ASbGnct1c+lNE5VY7M2tGiKpwdSf8E9C0naNQfrhApwf24/K1VpcOc76eY7bPi3v6Mt iAyI7QlIyf7mqHzsTd6xHC921tRNk0rxzIand5k9zKjSPccfH9MGYo+2Xq6byM97AE9LzuO3x6r l2n880NBrplVEZgZjyJs158QHjMX3njl3RNbENOZo2zw1zff0FkYUtf/QIIOjH12dmZpDrfokvC hMIC8Hbi//aYVPsuihhzsx12GNze8S1fHdqHJL32CCATJOzSrMSpzIdvAu/zDYyyOezNMExMu1t 06t5tYaMIW/youKMOC5fydJOWIO15Y4Ni24Jkh7Cec9kIBqnDQL0gYo5F0PaBFeb81iY X-Google-Smtp-Source: AGHT+IEJec9El1Al32BdNjFH/HUigmyApaO4fLl2JIUPHbPU5xsxwkfkJOFuMCjHKlEwF4+sHJanGw== X-Received: by 2002:a05:6a21:6d8e:b0:1e2:2e4:6893 with SMTP id adf61e73a8af0-1ee052c529cmr12387299637.9.1739046721381; Sat, 08 Feb 2025 12:32:01 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7304c780da5sm4882019b3a.69.2025.02.08.12.32.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 12:32:00 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Amit Prakash Shukla , Jerin Jacob , Erik Gabriel Carrillo Subject: [PATCH 06/32] eventdev: replace memcpy with assignment Date: Sat, 8 Feb 2025 12:21:58 -0800 Message-ID: <20250208203142.242284-7-stephen@networkplumber.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250208203142.242284-1-stephen@networkplumber.org> References: <20250208203142.242284-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Prefer structure assignment over memcpy. Found by cocci/struct_assign.cocci Signed-off-by: Stephen Hemminger --- lib/eventdev/rte_event_dma_adapter.c | 2 +- lib/eventdev/rte_event_timer_adapter.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/eventdev/rte_event_dma_adapter.c b/lib/eventdev/rte_event_dma_adapter.c index 165374d195..70a208620a 100644 --- a/lib/eventdev/rte_event_dma_adapter.c +++ b/lib/eventdev/rte_event_dma_adapter.c @@ -449,7 +449,7 @@ rte_event_dma_adapter_create(uint8_t id, uint8_t evdev_id, struct rte_event_port if (pc == NULL) return -ENOMEM; - rte_memcpy(pc, port_config, sizeof(struct rte_event_port_conf)); + *pc = *port_config; ret = rte_event_dma_adapter_create_ext(id, evdev_id, edma_default_config_cb, mode, pc); if (ret != 0) rte_free(pc); diff --git a/lib/eventdev/rte_event_timer_adapter.c b/lib/eventdev/rte_event_timer_adapter.c index 5886965d14..871cfba576 100644 --- a/lib/eventdev/rte_event_timer_adapter.c +++ b/lib/eventdev/rte_event_timer_adapter.c @@ -549,7 +549,7 @@ event_buffer_add(struct event_buffer *bufp, struct rte_event *eventp) /* Instead of modulus, bitwise AND with mask to get head_idx. */ head_idx = bufp->head & EVENT_BUFFER_MASK; buf_eventp = &bufp->events[head_idx]; - rte_memcpy(buf_eventp, eventp, sizeof(struct rte_event)); + *buf_eventp = *eventp; /* Wrap automatically when overflow occurs. */ bufp->head++; From patchwork Sat Feb 8 20:21:59 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 151190 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4A041461CD; Sat, 8 Feb 2025 21:32:43 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 66F9240651; Sat, 8 Feb 2025 21:32:06 +0100 (CET) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mails.dpdk.org (Postfix) with ESMTP id CDDE140609 for ; Sat, 8 Feb 2025 21:32:03 +0100 (CET) Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-21f4500a5c3so57624505ad.3 for ; Sat, 08 Feb 2025 12:32:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1739046723; x=1739651523; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=zjrrdQzp86xm6MVD5Kb8geXtF1KgxOSOKLGq9JF6YA4=; b=QQrlHd68jjDz9m+nIs/08CZyjnaWz8af8j1NJUb9jpuPuWOXkTbLE9wFAj4qjGXMDf Z45vAGtX53V1a3PpjIBl+giOlo1ij15Sbzir6i1wqGeVHF+ubPuZm+E7+w7zOy9z6zNM 2myDLY43xw6G0XvZKQJoG/JPX4UMHwSwftGlrdNvy4sVXcaKNLY9xco1XS7ErRdByPxh MCYqdHVZv/3dEbcPG+mHLVNhlr+KkZaFddtIoRJNQzPUVq8D5gG3sUxpqKurJPWMgKNp WW03+hzlirFpxWaWshTRUyj8L6hZEE0xtXwlSHYjUS/pUD+7dTe6nYOWoDuxtml4YIbh Dkjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739046723; x=1739651523; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zjrrdQzp86xm6MVD5Kb8geXtF1KgxOSOKLGq9JF6YA4=; b=cLlRqsdKQNHcpTalX1KbZf1/RD0quwFxEHF0xTqoPJu5FubBO3G/PfWnjG9NTdD/Y2 evqrHKYE+zGj5GsFXpHrfZ5eyShYPuLhJo1Q3Dh1ODeQge0dSFm76zxhVVYnHJjCQnB9 f4wjy71bShf1rbIk0MmBXDshnk3AKCNMhPbYwolqtEnx4d+OUzTHQnlwdMr/sBsge/f2 yaeCj0TPBHclQvYetpshIGg7viI+e3gMuESUDiiI+qn+oALrAjwpQ9gl804bASAAQaUt PgNQPi1j05tHlXJtCxkNw0j0QgwHYVGGbU66xCulEfzWyRx/syApB7mqawQbgZ3cGKxP 4/DQ== X-Gm-Message-State: AOJu0YxAQWsfWg7dqOxYtHxjpWQG0yTZObzOsfwDaoLQLx+JCiMuR19h f0sD7iRL28JzYgRRG46kzGberYu9wqfsuGtSXZxBIG8rm8IFqJB9atX9elVqgJS8r6+ObTJUR1v p6Sg= X-Gm-Gg: ASbGncuBCGn5/FpMdldomCiLojExmFIAiTv7ahbovZv9fPrawEMxY3bzXhFaUVHLbOv 5+KRtsFzXCNALf4mEz8DiK7zqe90x48b8p/rLC9F3wamuTIlhLqC+NnebdPueyzgcSQUaBhU49N aquto9IU1Npm0/qKNLRcbWX7hpFmAjaB4heQEKFN8DeqZw3+QruGC6inZi8bk3tfAmJ0G2w6Atu vwCMkgLo3zSKwHFKF9nCrMu7b/eE6ONw8c6LGReMmcPZNrXvuUpTl5iGtmeLea8Pne1FpEofGL9 LGFWqui4xFNB2ixip9ivPx6HyZ2SEOE6cNtIryH9jitNU2X7b7MLVSRzNMwa/uXT9q3k X-Google-Smtp-Source: AGHT+IHUJccVsCjvlxqHGdqPYqweJS/ijYKyYNhnKXJC5riKALvWTEpSbdxHVllxoljuzHK5mU9byg== X-Received: by 2002:a05:6a21:9211:b0:1ed:75f4:d285 with SMTP id adf61e73a8af0-1ee03a8dcbcmr13857574637.19.1739046722997; Sat, 08 Feb 2025 12:32:02 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7304c780da5sm4882019b3a.69.2025.02.08.12.32.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 12:32:02 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Hemant Agrawal , Sachin Saxena Subject: [PATCH 07/32] event/dpaa2: replace memcpy with structure assignment Date: Sat, 8 Feb 2025 12:21:59 -0800 Message-ID: <20250208203142.242284-8-stephen@networkplumber.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250208203142.242284-1-stephen@networkplumber.org> References: <20250208203142.242284-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Prefer structure assignment over memcpy. Found by struct-assign.cocci. Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/event/dpaa2/dpaa2_eventdev.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/event/dpaa2/dpaa2_eventdev.c b/drivers/event/dpaa2/dpaa2_eventdev.c index 6c8ed3ff6b..95d9154b11 100644 --- a/drivers/event/dpaa2/dpaa2_eventdev.c +++ b/drivers/event/dpaa2/dpaa2_eventdev.c @@ -224,7 +224,7 @@ static void dpaa2_eventdev_process_parallel(struct qbman_swp *swp, RTE_SET_USED(rxq); - rte_memcpy(ev, ev_temp, sizeof(struct rte_event)); + *ev = *ev_temp; rte_free(ev_temp); qbman_swp_dqrr_consume(swp, dq); @@ -243,7 +243,7 @@ static void dpaa2_eventdev_process_atomic(struct qbman_swp *swp, RTE_SET_USED(swp); RTE_SET_USED(rxq); - rte_memcpy(ev, ev_temp, sizeof(struct rte_event)); + *ev = *ev_temp; rte_free(ev_temp); *dpaa2_seqn(ev->mbuf) = dqrr_index + 1; DPAA2_PER_LCORE_DQRR_SIZE++; @@ -588,8 +588,7 @@ dpaa2_eventdev_port_link(struct rte_eventdev *dev, void *port, for (i = 0; i < nb_links; i++) { evq_info = &priv->evq_info[queues[i]]; - memcpy(&dpaa2_portal->evq_info[queues[i]], evq_info, - sizeof(struct dpaa2_eventq)); + dpaa2_portal->evq_info[queues[i]] = *evq_info; dpaa2_portal->evq_info[queues[i]].event_port = port; dpaa2_portal->num_linked_evq++; } From patchwork Sat Feb 8 20:22:00 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 151191 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BAABB461CD; Sat, 8 Feb 2025 21:32:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8304C40656; Sat, 8 Feb 2025 21:32:07 +0100 (CET) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mails.dpdk.org (Postfix) with ESMTP id BC2764064E for ; Sat, 8 Feb 2025 21:32:05 +0100 (CET) Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-21c2f1b610dso78174885ad.0 for ; Sat, 08 Feb 2025 12:32:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1739046725; x=1739651525; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qeT7r4WiyXz9tJ6HeX7WbPfqgTjMbj+vgPGx8XOdZo4=; b=fYTauRDEneTY660xj4Ar3LoFYIQTqH0+rwedhfw27X9TOPITTxk+6aiAqqDxErmWaP /Dd1V/2SbV8ADaelqXXZb1Wez3R0hKPTiBLYxVflegPgwSd3QpDGEfpYVtoAHhsQlGwa R6Vv87tvQ69856xAnHHzqh2Q0Cq/Ta7edqaMBArR992iBb1u4oLkJ/T6DDbCNwa8vxKb rgc9kZJcdA8piaYpi+ze2dmIdRlBg68LXY0gm9F/c73ZtHV+A0wk9MX20qeYcD6w67dS j+G9RmddVvr36jPTITkwP2MlKnKCmIIyXd1txbUoIS1MgK0gjSb9GOO/w5U6CAiXUZfZ tp8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739046725; x=1739651525; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qeT7r4WiyXz9tJ6HeX7WbPfqgTjMbj+vgPGx8XOdZo4=; b=DGDIA1dvCiV7gLu0/ndBIGDryBw2aGCRMHyiDI3xhk7bDKy7DwTomnrRlCbuDtLA/T EVsC2+4XR8/HtFeuX1AeXryvyDdghrxMO0TnrBqhjAc754kEthhBI5LKLo/aYkzHtQEC u4HXruU7DTfx7nROoHtOdrJm/zvDOMBVydfj69LKNwHE0C79VAcX5V8MUNK3WlpRywTC VP3seFyJnaX3jRExp4DkjhG3IyA0n4ftjCdEUBX3pEE5enJiRBnJx6Kec7IucyKH0r93 zrKcoD8q1JdsxLxL2zETgjZs3KZbGTKxGhwIfw9JODYhwbdnGQvbLiQGHEh8rItoGjz9 S76Q== X-Gm-Message-State: AOJu0YwCA951Kkrrm812Om1fzUn4QuEyRR/XN7lfdKIK/VCe1RQM0iEA 2AnRb9jFeNrCKHORzvx/Z8q85rzhLQME9ee5LxY+zLS7fktmZewhXaFBbHEFO+ZVumOp5FlvmeF 8mcE= X-Gm-Gg: ASbGncvlgzhB0iKHXUr5Q52UEfmJyMZ73DuiDd5KmcQyxG8FLfvgo6GORVCkpeFhhiz XZGwmh/1OmDq7WoMrh6iIizVxm0mXT7BlqprL94s5W7ECC7mp1rBvLWg0qA5I3QbGhESp89vjm9 qd++QJwVFSteZtH8a8EBQohN23aQ4t4ygPwZHA8wq+6IK8xgA9LwwMo71V5zWexKMMqh2ZH85Fv WnC70iwjNK6xeIx2ENnwCCxtwABSMN6Yvah4x2dF8DMpOiN5KtrG3AxF+10GnSLVtKYaAS0Bfh3 DNg9m8J6itApLzxmWBJQiZxEpixjHBGeNsznoP6CtSDrz9ynNQRARCKhvObd49nLk3uY X-Google-Smtp-Source: AGHT+IFjP/kMmVsPq5cT1A6xwGwLVaSoKVdByS4dDW+x2jYH0kWRhHZBI6FjqbrUm8hEX6Q0NrQr1w== X-Received: by 2002:a05:6a00:340a:b0:724:59e0:5d22 with SMTP id d2e1a72fcca58-7305d539f85mr15058362b3a.20.1739046724889; Sat, 08 Feb 2025 12:32:04 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7304c780da5sm4882019b3a.69.2025.02.08.12.32.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 12:32:03 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , =?utf-8?q?Mattias_R?= =?utf-8?q?=C3=B6nnblom?= Subject: [PATCH 08/32] event/dsw: replace memcpy with assignment Date: Sat, 8 Feb 2025 12:22:00 -0800 Message-ID: <20250208203142.242284-9-stephen@networkplumber.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250208203142.242284-1-stephen@networkplumber.org> References: <20250208203142.242284-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Prefer structure assignment over memcpy. Found by cocci/struct_assign.cocci Signed-off-by: Stephen Hemminger Acked-by: Mattias Rönnblom --- drivers/event/dsw/dsw_event.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/event/dsw/dsw_event.c b/drivers/event/dsw/dsw_event.c index e68fb19890..399d9f050e 100644 --- a/drivers/event/dsw/dsw_event.c +++ b/drivers/event/dsw/dsw_event.c @@ -1078,8 +1078,7 @@ dsw_port_stash_any_migrating_events(struct dsw_port *port, offset++; } else if (offset > 0) { struct rte_event *out_event = &events[i - offset]; - rte_memcpy(out_event, in_event, - sizeof(struct rte_event)); + *out_event = *in_event; } } From patchwork Sat Feb 8 20:22:01 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 151192 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE9FA461CD; Sat, 8 Feb 2025 21:32:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6CC6D4065C; Sat, 8 Feb 2025 21:32:10 +0100 (CET) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mails.dpdk.org (Postfix) with ESMTP id D296440655 for ; Sat, 8 Feb 2025 21:32:06 +0100 (CET) Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-21f40deb941so60975405ad.2 for ; Sat, 08 Feb 2025 12:32:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1739046726; x=1739651526; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ic1SPNNb1AgPRNP3Om3M4+kD0f1b1EuoCgAXb69+MYE=; b=E0GZ5AzNN/4mKdkYhj2X09Vjcm0JlANcn2UsIAqpDaVpKa+0LZ4qQEs2/hkoXcwwX6 vhu9FMLrTGBw0QfHfF6FAB+AT1sca1FzsnWL7Q3C3uciHpiTq80gNmyrSL4D9vSRpULn afOAFBormSX+boHwKJrTCxzq2S5NfIdlGeDO2334HsgCEoaXH+4ZKOMejj5fuNUiW/vA aCJA00HgjxRbMdEoVoaHWeBD8RZS9sSYWh+XdUlICvsLIdPq2gfswE3VMh2vrBCe01m5 0tPYyuD/tUFakODHi1hjQTvIUyZHi7YFGG9hQc4FXl/Yt82hhLFsqsJz7yMOh0DEHRg4 1X2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739046726; x=1739651526; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ic1SPNNb1AgPRNP3Om3M4+kD0f1b1EuoCgAXb69+MYE=; b=gqXgRYkfxVAsjbWB6kuVEBFXENbZDwSD3O4853vMWOwLB4Tk3jG7+56fZCGO4nUjKU JzbtUx98WgFB0wOpffQytNyAfNQrNu7RFdSa+zK9YOSfMXAnIi3sMDws8MYjQZK57+2W dVOSkJdxoY2bySpePdhhr96wd9W2NV6mmmnfELjbW0iry0KLuAvDIHWGJxmdb1Y2AVYO qBaRc8hDiUWRv4miOTfHXinphgfD6gCbzLfR4XvzU5eu0qYgHJrKamYKlmyCclS93+ef pmMnvJ+AU/UvipwVjI+opqPbOVJDFgtLWIsiOItqAYsY1JaIVXOis6gimdRqaD0KYMuO a1Tg== X-Gm-Message-State: AOJu0Yx55C+cZGcv/Zh5y+YpPFR2BCtWO03XfCJJg/AFvhaiF1eWC6F1 69PLASWseCOy6IE31a6y6oVXxgoc6yVk2hRm5uHE2pPeIkxyDIe2pMX4xgxFdv73huoX8EiwWv8 /AVk= X-Gm-Gg: ASbGnctrBJnxFoibtcc5f86JEosuZM6hFCPVPVe/FeUGi/qEAzX3NjwpYhA2YWYirJD Cwj3Qc6HRyPAQBqritFg4vYRWdiXQNDyFTuS7jONrQeEb0Ri40v0rS5zHgMCbOpQXBAUw3qqlc0 UeNBy+F6LafBYuHoqbe+53ov8WrnS2K1mC3LnSmMzb5HMjkUia99tdOi9hv/NJbN/q3+ciOlXZj 3YdE0OFPPPCHE3q6O4f6YKL69V6n2dIo9LSJzP7RNqI9uN5zAsJcg/o1Fdy1ls15lh43gsEJX7z RVE9Bdb03Q7uDA9ea84IbGyh4qQx/SzyjbrtHEepW3dY79X5XSZN+2k7upI5v7qxXVKY X-Google-Smtp-Source: AGHT+IHHz6J5jCvXuR5CqcMBzfDsgIVCNoHaI8azXqqJFbJsVzEoWZSt9GO/XwBRlUmUYVofElVYFQ== X-Received: by 2002:a05:6a20:c909:b0:1e1:9ba5:80d8 with SMTP id adf61e73a8af0-1ee03b20a10mr13958929637.33.1739046726017; Sat, 08 Feb 2025 12:32:06 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7304c780da5sm4882019b3a.69.2025.02.08.12.32.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 12:32:05 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Srikanth Yalavarthi Subject: [PATCH 09/32] ml/cnxk: replace memcpy with assignment Date: Sat, 8 Feb 2025 12:22:01 -0800 Message-ID: <20250208203142.242284-10-stephen@networkplumber.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250208203142.242284-1-stephen@networkplumber.org> References: <20250208203142.242284-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Prefer structure assignment over memcpy. Found by cocci/struct_assign.cocci Signed-off-by: Stephen Hemminger --- drivers/ml/cnxk/cnxk_ml_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ml/cnxk/cnxk_ml_ops.c b/drivers/ml/cnxk/cnxk_ml_ops.c index d93c31535d..9958945670 100644 --- a/drivers/ml/cnxk/cnxk_ml_ops.c +++ b/drivers/ml/cnxk/cnxk_ml_ops.c @@ -1398,7 +1398,7 @@ cnxk_ml_model_info_get(struct rte_ml_dev *dev, uint16_t model_id, } info = (struct rte_ml_model_info *)model->info; - rte_memcpy(model_info, info, sizeof(struct rte_ml_model_info)); + *model_info = *info; model_info->input_info = info->input_info; model_info->output_info = info->output_info; From patchwork Sat Feb 8 20:22:02 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 151193 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 92C24461CD; Sat, 8 Feb 2025 21:33:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 591EC40663; Sat, 8 Feb 2025 21:32:11 +0100 (CET) Received: from mail-pl1-f179.google.com (mail-pl1-f179.google.com [209.85.214.179]) by mails.dpdk.org (Postfix) with ESMTP id 2905A4065A for ; Sat, 8 Feb 2025 21:32:08 +0100 (CET) Received: by mail-pl1-f179.google.com with SMTP id d9443c01a7336-21f6022c2c3so19259555ad.0 for ; Sat, 08 Feb 2025 12:32:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1739046727; x=1739651527; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZlVZN3TZ6YdSqh7cxKl5CdD2TINyVAMFiqe3mirEtSk=; b=vlx4cSjLcWwUV/OGh5u4+INc5gM6j/2Y65II/QOt0eFLO/qc9APM7ukZocFH7AwgWA BoIQ75Nutwy5vuznK/CB4Yoq8G3hwy36gvBfOqNvkHUem30k8z/CDsc1e1xozb50kxKH 2larEL50SfZtlNUYBw6S40YKvrOc5a3Dc1MxTXTS0ovUswVMySSvYx3FOz60CqBPAHUL 8Ixych9g2b3ubSka8eNcmwUpTrP5xJVogE5pG9mK5blvsAixo96H1Dw1BTdgg/fZo0oD JHiBDD7Wma9X31UQqqk45lagNHCie1h09iboU/S2wR05Sn0fzUeKXXMmbdrU7tK0GSG2 FPDA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739046727; x=1739651527; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZlVZN3TZ6YdSqh7cxKl5CdD2TINyVAMFiqe3mirEtSk=; b=f2lVRX/4PxHoixkKVfdPWquh9VCYHEAOq10DTeUQcp1qr2NthjdPg4i7w9UFLtCv5f IlpTpXyVK3BU11n9kMCm309mQuEaRfEv03EGYHSVqauNX3k9LSfnwObVocf3JD+smGce 9vsEjRM2Rgpkny7HDVZhIEZBHclSgZxDgLtEAoQZOBBYmKOsAA/Q9K7t3Hv2OdTFiFg5 1m1sUAQm2g5CX7j8OMIy/zq32Mlyc/Gg0Qqctf5n4bJygHUSuMGXUPnyv3GGFcJgXs1e H56dQeIhfOLkhc6NEwYIeHLcCH4693fmgfKSSeGJl0ZkhopX80ecxao+pcAx+WxD+qBA +y+Q== X-Gm-Message-State: AOJu0Yx6Q5FNsetgn8kKw6zKLb8xHcS1U8Sg0X9ZKqWYeS6vCRA1pUrf j6j5NxXZdo+Wri+KZBZNZvoz5XULtEWWgGNIFsl3dr7V99auz8Z0ML8cZmDZpnPzLpf7uczw/LA u2u4= X-Gm-Gg: ASbGncuMyhJiAHyRx2fV3aXb+KxkTmbYaqg4EUTA/pJf8wXxXfXwd9eiAEG2dQERQWi nbqLbqXwJ3sJ2a2PFV351SvyKUHwOkidVodCAeIp1qlD0cipS0bjqVuPN/CCw7POi1C0QbQlvMO Lgjin+303jJ9JeLl5oH7EDC4tLcK0+mc6oi2uL9K/LExWZzBBGCb4EkoJE5VnQ4ey1jpHreVhYu KT7VbI8cf3C5eP9a8Fwxp54ms/6F9N2jkIk28+FDFJulynjIvCAP/+WLWc4nJbHarYv+Eh1ZhJC XHhH5GeSu9CL3t/KnxroqsP14w8TYQqzemAVhtIOT2OuPDwtmQLREfN54OsRJ3SY9VZL X-Google-Smtp-Source: AGHT+IFQ6vL8OJoN886TVC/UqLT0fdHuAj3N3DAPl/dt+X2SKZ1tpMcdF2DgC9q5p2dGdD1ueFmpnQ== X-Received: by 2002:a05:6a00:4603:b0:725:f1e9:5334 with SMTP id d2e1a72fcca58-73042c73aeamr25042514b3a.8.1739046727272; Sat, 08 Feb 2025 12:32:07 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7304c780da5sm4882019b3a.69.2025.02.08.12.32.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 12:32:06 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Nicolas Chautru , Tomasz Kantecki , Kirill Rybalchenko Subject: [PATCH 10/32] examples: replace memcpy with assignment Date: Sat, 8 Feb 2025 12:22:02 -0800 Message-ID: <20250208203142.242284-11-stephen@networkplumber.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250208203142.242284-1-stephen@networkplumber.org> References: <20250208203142.242284-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Prefer structure assignment over memcpy. Found by cocci/struct_assign.cocci Signed-off-by: Stephen Hemminger --- examples/bbdev_app/main.c | 2 +- examples/l2fwd-cat/cat.c | 3 +-- examples/ptpclient/ptpclient.c | 4 +--- 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/examples/bbdev_app/main.c b/examples/bbdev_app/main.c index 46f20238db..03f15f91cc 100644 --- a/examples/bbdev_app/main.c +++ b/examples/bbdev_app/main.c @@ -360,7 +360,7 @@ add_ether_hdr(struct rte_mbuf *pkt_src, struct rte_mbuf *pkt_dst) eth_to = rte_pktmbuf_mtod(pkt_dst, struct rte_ether_hdr *); /* copy header */ - rte_memcpy(eth_to, eth_from, sizeof(struct rte_ether_hdr)); + *eth_to = *eth_from; } static inline void diff --git a/examples/l2fwd-cat/cat.c b/examples/l2fwd-cat/cat.c index 00e4cde48b..ac8feaec8e 100644 --- a/examples/l2fwd-cat/cat.c +++ b/examples/l2fwd-cat/cat.c @@ -314,8 +314,7 @@ parse_l3ca(const char *l3ca) if (cmask != 0 && is_contiguous(cmask) == 0) goto err; - rte_memcpy(&m_config[idx].cpumask, - &cpuset, sizeof(rte_cpuset_t)); + m_config[idx].cpumask = cpuset; if (cmask != 0) { m_config[idx].cdp = 1; diff --git a/examples/ptpclient/ptpclient.c b/examples/ptpclient/ptpclient.c index def8de29ff..2f9764bf07 100644 --- a/examples/ptpclient/ptpclient.c +++ b/examples/ptpclient/ptpclient.c @@ -470,9 +470,7 @@ parse_fup(struct ptpv2_time_receiver_ordinary *ptp_data) client_clkid->id[6] = eth_hdr->src_addr.addr_bytes[4]; client_clkid->id[7] = eth_hdr->src_addr.addr_bytes[5]; - rte_memcpy(&ptp_data->client_clock_id, - client_clkid, - sizeof(struct clock_id)); + ptp_data->client_clock_id = *client_clkid; /* Enable flag for hardware timestamping. */ created_pkt->ol_flags |= RTE_MBUF_F_TX_IEEE1588_TMST; From patchwork Sat Feb 8 20:22:03 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 151194 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3A425461CD; Sat, 8 Feb 2025 21:33:07 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5D29040668; Sat, 8 Feb 2025 21:32:12 +0100 (CET) Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by mails.dpdk.org (Postfix) with ESMTP id 49E484065A for ; Sat, 8 Feb 2025 21:32:09 +0100 (CET) Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-2f833af7a09so4434004a91.2 for ; Sat, 08 Feb 2025 12:32:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1739046728; x=1739651528; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2FdxElZpzefFV+Y57WLqp2fcwB1C8sWQf751HME/3zk=; b=L6YsQ941LNfFfkdlzJTfMtGla6JHSyCq0PAdqlXyv0cWaADJG77719hDQ9fD+bR6Kf L7olRDlbPFQTwD9Y2uoGFpr4SiqTctJqfPY/1vxhwpGkpH+Y04uuyUm0Kc1FsFmwoRHs 8k5UXsBEic7q/uWlK/4m8zxiujbHxCvQLmSdK3oY8SxwsR3/t+kP1ZppojSIxmcveiEy AeVGebITbMqsUpQfEdwx+VhhxWJr7FG0OiO2MmYbGB78E+GWxcrnwGmsK0nLfpWzli18 K+bjCBpZuDF56nUivbpYUgzm9QizWkrZtSif9Nfkg/UelSPfdnniPlV8QnYw6tuHbmLl bWpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739046728; x=1739651528; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2FdxElZpzefFV+Y57WLqp2fcwB1C8sWQf751HME/3zk=; b=nOrOCkl1PTO17/0hi6moVJHfa9m9ic+SzAmgr2/ZS4krhTsS6jIg4x7gEweD3DRvEo mPluxFDyoXF3N/CBtS9PGz1ZYtzPDzJM54aLA/3SNhNw22y9UhzrB6dXqKCCai3KLWe0 l1lr/bQmLULMJxOC9Ti+jksVsOiqLAdcbQIgwNV3ogbAkQNAXfxpcoJ8TZJSdx4QuVrB Qmla/wNGqIbwsUBdVFdory6CUXSMPi7lXGBxR8gNwnv1UA2K/DWyXBsBNNYJrrz3fBqY bSbZvNIob68k7n4DoqFN83yhWqy5RvbigIHLjQeNfDWulK+l9rne5LD5/9I3hLeTYs3A r8dg== X-Gm-Message-State: AOJu0Yzjd5sB5DAftHhAFU4AxE8M39wX6yQi4SRRsTW6jwLu5PcshCFr 3k6z2PDjQSsxQUXfN3zoUZLHGnlzT3lM9ag+XzZFgW3g4ifZ1WOvwEXBGqCXFgQHaA1Kj9vinBk EdjI= X-Gm-Gg: ASbGncsv8ygHCQOk6fMOPnphO+LwERCLGYqGOJBPI9adHlgBZLWmrrkwxmudGU7TFPV /qhtsiLPYl75S4w54S87zgSfWeLhrr1ZtRZFd5iHP2GiDqYcwsIm+1Pgo2bNoHltreBLLb908x1 F+xAIr2aL1FFx/4AkbBZ+829WAIE6H2V6nERcX79eDVEyPXepTeHOUZlS8Ao/Z04r4Y6VAdtBMm 3SQju6+d2Y8CrdFVhegwYEWuSi+0CERqcYk+aGmnK7nrZm5AUQPL/M8YAZJAODqK4HQHYxPW2Kr d743MFZk6BVgDsNKRT7PoJS+p5UrTtV3I3dixKO+70JrxygHXQHTbC25u5a2UJaeHp72 X-Google-Smtp-Source: AGHT+IEh4DfL/Tt7FDWc0uf4V1LEaRmjVYH1S6ColkBkdCQyWguuVmORYtGbgvDKeYW7ipop46asUw== X-Received: by 2002:a05:6a00:6f59:b0:730:7600:aeab with SMTP id d2e1a72fcca58-7307600aee0mr4659611b3a.13.1739046728368; Sat, 08 Feb 2025 12:32:08 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7304c780da5sm4882019b3a.69.2025.02.08.12.32.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 12:32:07 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Nithin Dabilpuram , Pavan Nikhilesh Subject: [PATCH 11/32] node: replace memcpy with assignment Date: Sat, 8 Feb 2025 12:22:03 -0800 Message-ID: <20250208203142.242284-12-stephen@networkplumber.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250208203142.242284-1-stephen@networkplumber.org> References: <20250208203142.242284-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Prefer structure assignment over memcpy. Found by cocci/rte_memcpy.cocci. Signed-off-by: Stephen Hemminger --- lib/node/ethdev_rx.c | 2 +- lib/node/ip4_reassembly.c | 2 +- lib/node/kernel_rx.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/node/ethdev_rx.c b/lib/node/ethdev_rx.c index 475eff6abe..bcd192cc0c 100644 --- a/lib/node/ethdev_rx.c +++ b/lib/node/ethdev_rx.c @@ -186,7 +186,7 @@ ethdev_rx_node_init(const struct rte_graph *graph, struct rte_node *node) while (elem) { if (elem->nid == node->id) { /* Update node specific context */ - memcpy(ctx, &elem->ctx, sizeof(ethdev_rx_node_ctx_t)); + *ctx = elem->ctx; break; } elem = elem->next; diff --git a/lib/node/ip4_reassembly.c b/lib/node/ip4_reassembly.c index eb5f391114..c8072e6e50 100644 --- a/lib/node/ip4_reassembly.c +++ b/lib/node/ip4_reassembly.c @@ -157,7 +157,7 @@ ip4_reassembly_node_init(const struct rte_graph *graph, struct rte_node *node) while (elem) { if (elem->node_id == node->id) { /* Update node specific context */ - memcpy(ctx, &elem->ctx, sizeof(ip4_reassembly_ctx_t)); + *ctx = elem->ctx; break; } elem = elem->next; diff --git a/lib/node/kernel_rx.c b/lib/node/kernel_rx.c index 6c20cdbb1e..461330414f 100644 --- a/lib/node/kernel_rx.c +++ b/lib/node/kernel_rx.c @@ -198,7 +198,7 @@ kernel_rx_node_init(const struct rte_graph *graph, struct rte_node *node) while (elem) { if (elem->nid == node->id) { /* Update node specific context */ - memcpy(ctx, &elem->ctx, sizeof(kernel_rx_node_ctx_t)); + *ctx = elem->ctx; break; } elem = elem->next; From patchwork Sat Feb 8 20:22:04 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 151195 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 50D49461CD; Sat, 8 Feb 2025 21:33:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C10C440677; Sat, 8 Feb 2025 21:32:13 +0100 (CET) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by mails.dpdk.org (Postfix) with ESMTP id 96C1F4065E for ; Sat, 8 Feb 2025 21:32:10 +0100 (CET) Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-2fa3e20952fso2234131a91.1 for ; Sat, 08 Feb 2025 12:32:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1739046730; x=1739651530; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=u5ipZ1fbyQXacCpVXmtr1owK0XNqdo1d/c96i3/7ryw=; b=MMKFCNFQkFsI4QqnGwq1xOkYEA20j4dPX+WDyZ2bff6rMJxU0Ti/5inU+itNWb1mmN 3xwl1B/wV0ecH+WZl5pPQ0/JR+r8ETAKQ16iZDUtAeMnkpFShG94Djh9FcAU0vLXT4Xs QrKhw38h/ShjHUNqwkNJfsMt0yfJlzWoAn4L09ZiE1zEGJEHbMDHuZIz4shzetLFz5zM JsDyKK0NKAUu1zHy3Rlclg7sqpcC4cQu6KCbZYxaWSuXr0ufweZw/wafvfmnPR5wSvNd 1SRBr169/lAau4sOapFAszM2BLQS7kz7hOGODIPpBsYl0g4h4B3u7qvGAdkl0O/XoEVu TZxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739046730; x=1739651530; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=u5ipZ1fbyQXacCpVXmtr1owK0XNqdo1d/c96i3/7ryw=; b=fQnylYe1u6VPcb09PLfyfYCH1SgxJxEa5h1IZ+32PVMX1U0dDfRQJ4y1Zu3Lx5+XBc 0I0n0LQdg0noQu6BlnbpnARFZTJygRIsBj3MlZ4L14UlCUolYtSlUqp39vOg/dO/b6/E f6tF5lNorcHPfydeNQiymGrnj7GEk0rcOo7sPrGXMfFBAxZpkMKJcp4FzOCThmtaSsgt f6sr9Yd010CJaUfcuYIy0MXzmTkcYnC9uWhbTvVXNUcBP+Ud26NiArozyK4WfwR0wyb5 y7BQT0zYCmOAn+661MspczAYSXE8jDrzEOrajUloAgbgA5Bo+gd8WFnmnI7wWqfXphLT 7bWQ== X-Gm-Message-State: AOJu0YzMd7+MUIfCuZMLyNqS6WuptHXyMnESgL5Nq2z2ervscQjLWE0D PNK3+pI2vgD5n79XfVTsKyBWG8cnLOQR4SkorubGU5zoIkb17+6ykFzGphB10tJl2XujpBhawp8 esX0= X-Gm-Gg: ASbGncspc0/FfaocKcdRCXl9h9NadhGt462NCNBIu4EOP1AOLag7L4BbX+MQbcDf/f2 5nU87kvERSAk5CLV1Wwvzt9QcSidzQVB77Rp89rfgUkAg3e+71ll+nEOUxM6CY+2BRekc0EkciL R7kuENP56jn3EaipPnahkN6okGr4ItJ5kwj+WowEc4ikbZXdGbaVy573XJtwH4uoAzJgVIahqfv LSagk9ej69YnWMZe5n/SiU2GYT1x12DnQtGvB7lgG2SRVpxTqED3guCvqweCTKG0OGtozgnISCL 6ZjG99D0+J19cZBhs1VZhTxz9us6p05h8hotBGD3CpTXbhhLa4gHAjdEJrGCGkeh/Tlz X-Google-Smtp-Source: AGHT+IEfm4XeFLS1K2ZBwkt9pqi8aFAdMuNB904l9HpBIBM/d3TnjOHVP5EVfJFaFbPu4FrppAujPQ== X-Received: by 2002:a05:6a00:3016:b0:725:e499:5b86 with SMTP id d2e1a72fcca58-7305d546034mr14241880b3a.20.1739046729863; Sat, 08 Feb 2025 12:32:09 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7304c780da5sm4882019b3a.69.2025.02.08.12.32.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 12:32:09 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Cristian Dumitrescu Subject: [PATCH 12/32] pipeline: replace memcpy with assignment Date: Sat, 8 Feb 2025 12:22:04 -0800 Message-ID: <20250208203142.242284-13-stephen@networkplumber.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250208203142.242284-1-stephen@networkplumber.org> References: <20250208203142.242284-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Prefer structure assignment over memcpy. Found by cocci/struct_assign.cocci Signed-off-by: Stephen Hemminger --- examples/ip_pipeline/parser.c | 2 +- lib/pipeline/rte_pipeline.c | 6 ++--- lib/pipeline/rte_swx_ctl.c | 2 +- lib/pipeline/rte_swx_ipsec.c | 2 +- lib/pipeline/rte_swx_pipeline_spec.c | 36 ++++++++++------------------ 5 files changed, 18 insertions(+), 30 deletions(-) diff --git a/examples/ip_pipeline/parser.c b/examples/ip_pipeline/parser.c index dfca026be5..8baa70e1f4 100644 --- a/examples/ip_pipeline/parser.c +++ b/examples/ip_pipeline/parser.c @@ -407,7 +407,7 @@ parse_mac_addr(const char *token, struct rte_ether_addr *addr) if (tmp == NULL) return -1; - memcpy(addr, tmp, sizeof(struct rte_ether_addr)); + *addr = *tmp; return 0; } diff --git a/lib/pipeline/rte_pipeline.c b/lib/pipeline/rte_pipeline.c index a09a89f746..bad85341c9 100644 --- a/lib/pipeline/rte_pipeline.c +++ b/lib/pipeline/rte_pipeline.c @@ -368,7 +368,7 @@ rte_pipeline_table_create(struct rte_pipeline *p, *table_id = id; /* Save input parameters */ - memcpy(&table->ops, params->ops, sizeof(struct rte_table_ops)); + table->ops = *params->ops; table->f_action_hit = params->f_action_hit; table->f_action_miss = params->f_action_miss; table->arg_ah = params->arg_ah; @@ -831,7 +831,7 @@ rte_pipeline_port_in_create(struct rte_pipeline *p, *port_id = id; /* Save input parameters */ - memcpy(&port->ops, params->ops, sizeof(struct rte_port_in_ops)); + port->ops = *params->ops; port->f_action = params->f_action; port->arg_ah = params->arg_ah; port->burst_size = params->burst_size; @@ -881,7 +881,7 @@ rte_pipeline_port_out_create(struct rte_pipeline *p, *port_id = id; /* Save input parameters */ - memcpy(&port->ops, params->ops, sizeof(struct rte_port_out_ops)); + port->ops = *params->ops; port->f_action = params->f_action; port->arg_ah = params->arg_ah; diff --git a/lib/pipeline/rte_swx_ctl.c b/lib/pipeline/rte_swx_ctl.c index 857770d297..db83c31c7c 100644 --- a/lib/pipeline/rte_swx_ctl.c +++ b/lib/pipeline/rte_swx_ctl.c @@ -832,7 +832,7 @@ selector_group_duplicate_to_pending(struct selector *s, uint32_t group_id) if (!mp) goto error; - memcpy(mp, m, sizeof(struct rte_swx_table_selector_member)); + *mp = *m; TAILQ_INSERT_TAIL(&gp->members, mp, node); } diff --git a/lib/pipeline/rte_swx_ipsec.c b/lib/pipeline/rte_swx_ipsec.c index 17a9d2b98b..e710ba2f9d 100644 --- a/lib/pipeline/rte_swx_ipsec.c +++ b/lib/pipeline/rte_swx_ipsec.c @@ -366,7 +366,7 @@ rte_swx_ipsec_create(struct rte_swx_ipsec **ipsec_out, ipsec->ring_out = ring_out; ipsec->dev_id = (uint8_t)dev_id; ipsec->qp_id = params->crypto_dev_queue_pair_id; - memcpy(&ipsec->bsz, ¶ms->bsz, sizeof(struct rte_swx_ipsec_burst_size)); + ipsec->bsz = params->bsz; ipsec->n_sa_max = n_sa_max; ipsec->crypto_wr_threshold = params->bsz.crypto_wr * 3 / 4; diff --git a/lib/pipeline/rte_swx_pipeline_spec.c b/lib/pipeline/rte_swx_pipeline_spec.c index 17419e7b85..986bbe5fd4 100644 --- a/lib/pipeline/rte_swx_pipeline_spec.c +++ b/lib/pipeline/rte_swx_pipeline_spec.c @@ -2985,7 +2985,7 @@ pipeline_spec_parse(FILE *spec, } s->structs = new_structs; - memcpy(&s->structs[s->n_structs], &struct_spec, sizeof(struct struct_spec)); + s->structs[s->n_structs] = struct_spec; s->n_structs++; memset(&struct_spec, 0, sizeof(struct struct_spec)); @@ -3022,7 +3022,7 @@ pipeline_spec_parse(FILE *spec, } s->actions = new_actions; - memcpy(&s->actions[s->n_actions], &action_spec, sizeof(struct action_spec)); + s->actions[s->n_actions] = action_spec; s->n_actions++; memset(&action_spec, 0, sizeof(struct action_spec)); @@ -3059,7 +3059,7 @@ pipeline_spec_parse(FILE *spec, } s->tables = new_tables; - memcpy(&s->tables[s->n_tables], &table_spec, sizeof(struct table_spec)); + s->tables[s->n_tables] = table_spec; s->n_tables++; memset(&table_spec, 0, sizeof(struct table_spec)); @@ -3096,9 +3096,7 @@ pipeline_spec_parse(FILE *spec, } s->selectors = new_selectors; - memcpy(&s->selectors[s->n_selectors], - &selector_spec, - sizeof(struct selector_spec)); + s->selectors[s->n_selectors] = selector_spec; s->n_selectors++; memset(&selector_spec, 0, sizeof(struct selector_spec)); @@ -3135,9 +3133,7 @@ pipeline_spec_parse(FILE *spec, } s->learners = new_learners; - memcpy(&s->learners[s->n_learners], - &learner_spec, - sizeof(struct learner_spec)); + s->learners[s->n_learners] = learner_spec; s->n_learners++; memset(&learner_spec, 0, sizeof(struct learner_spec)); @@ -3173,7 +3169,7 @@ pipeline_spec_parse(FILE *spec, } s->apply = new_apply; - memcpy(&s->apply[s->n_apply], &apply_spec, sizeof(struct apply_spec)); + s->apply[s->n_apply] = apply_spec; s->n_apply++; memset(&apply_spec, 0, sizeof(struct apply_spec)); @@ -3205,7 +3201,7 @@ pipeline_spec_parse(FILE *spec, } s->extobjs = new_extobjs; - memcpy(&s->extobjs[s->n_extobjs], &extobj_spec, sizeof(struct extobj_spec)); + s->extobjs[s->n_extobjs] = extobj_spec; s->n_extobjs++; memset(&extobj_spec, 0, sizeof(struct extobj_spec)); @@ -3252,7 +3248,7 @@ pipeline_spec_parse(FILE *spec, } s->headers = new_headers; - memcpy(&s->headers[s->n_headers], &header_spec, sizeof(struct header_spec)); + s->headers[s->n_headers] = header_spec; s->n_headers++; memset(&header_spec, 0, sizeof(struct header_spec)); @@ -3284,9 +3280,7 @@ pipeline_spec_parse(FILE *spec, } s->metadata = new_metadata; - memcpy(&s->metadata[s->n_metadata], - &metadata_spec, - sizeof(struct metadata_spec)); + s->metadata[s->n_metadata] = metadata_spec; s->n_metadata++; memset(&metadata_spec, 0, sizeof(struct metadata_spec)); @@ -3378,9 +3372,7 @@ pipeline_spec_parse(FILE *spec, } s->regarrays = new_regarrays; - memcpy(&s->regarrays[s->n_regarrays], - ®array_spec, - sizeof(struct regarray_spec)); + s->regarrays[s->n_regarrays] = regarray_spec; s->n_regarrays++; memset(®array_spec, 0, sizeof(struct regarray_spec)); @@ -3412,9 +3404,7 @@ pipeline_spec_parse(FILE *spec, } s->metarrays = new_metarrays; - memcpy(&s->metarrays[s->n_metarrays], - &metarray_spec, - sizeof(struct metarray_spec)); + s->metarrays[s->n_metarrays] = metarray_spec; s->n_metarrays++; memset(&metarray_spec, 0, sizeof(struct metarray_spec)); @@ -3446,9 +3436,7 @@ pipeline_spec_parse(FILE *spec, } s->rss = new_rss; - memcpy(&s->rss[s->n_rss], - &rss_spec, - sizeof(struct rss_spec)); + s->rss[s->n_rss] = rss_spec; s->n_rss++; memset(&rss_spec, 0, sizeof(struct rss_spec)); From patchwork Sat Feb 8 20:22:05 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 151196 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 55CB9461CD; Sat, 8 Feb 2025 21:33:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DBC584066D; Sat, 8 Feb 2025 21:32:14 +0100 (CET) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by mails.dpdk.org (Postfix) with ESMTP id A880D40665 for ; Sat, 8 Feb 2025 21:32:11 +0100 (CET) Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-2f9b91dff71so4968438a91.2 for ; Sat, 08 Feb 2025 12:32:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1739046731; x=1739651531; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=SGrAWg9m4MtEXr/sMnC/5/hCnU3kDaDFhtpQV6triho=; b=gxL7dOBSl53OgvKE2Xc/EHAwUm0xzRsRiB0UxZrqRbnWVT82e5idzh6XeLEB4Ry2F/ fOSHwlHkD9sxtYazblsqhagJUebcqyhu6vrQj6nACGzAMP5fgBDccliBB1erHViyTCjs PjU33xLn1jhSyGDY2iyFBu1Yu7X5XdIg7wU9tLBVNLXZMJxqDovpDk2zt12GfjuceAsE ZlBTLVUQOGW88c2IcIGr9OgNikaNr2NnnX2wx4mte5Usrz/iCcN8puwHA4RL3Ci4Yiu9 FLVMBMj9JVB6juu7y31BG0prTmsSQ9/S8kMbDcnuhelg/Wrrlb6Da/fFl45Mr0cOXs5t ilVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739046731; x=1739651531; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SGrAWg9m4MtEXr/sMnC/5/hCnU3kDaDFhtpQV6triho=; b=vK3svO4rY78ZHEvXLRQytojLaxzg5PN4PlZesSH6h1a0h9t1+Na7i18taagRubj4UW INWtJpc+EbDQWZK92fStvNeuipsvLQUAqEv+ZhfiV9oXj7PV82H0+AT19F8R3uuIX/C3 63WMVv+nT8/iGM6p9awbalCzPK8Bdne8G+A54d7EDdNppmdNji1V9JtE1Dh1v8IHQ153 GRalf+HPhxZ9iz4UyUHBkLk8dF5FaCGp5aS229CwxbKLrtc/FJX0E0xriCjLRuM3OySs uhZGwWkX1Vnik2TO2NSuhjA2EAPrd5hP4vHgCPW/Fuc8Um/9rjm95uv2yby1lqqD/wOb ve8A== X-Gm-Message-State: AOJu0Yysqa3jgRMYiGfG+q8JS3wxUL6Eb2hYI/qvmue+huZncp+S+qGt iuBUJbJtr7cc85JlYEprp12GwGM9Lj+phlxc3widTdKjuMn12g1ev4TVyboXeFJv8VoQPFy+Q+T m12Q= X-Gm-Gg: ASbGnctn8PC0b8a+EF/73Xpx0SFfm/YkCscTnBlkVfTDdHLN+8i22P3xUl4uVadmoXS ZSo1Xq6d4yNVK3XIaaW7vR1VclioGKNtynDBe5T28nQoAgaBWU9KWa2ZxKp+7nKUwxCz2b6dsfo mKBcyS0lKc/2vfZcLPuK50hRZ+ZhKr9kJNoKx/xzuUghL6hRBExKid1iKoI48bNU9Qf8wOdggxO je+4kxSZeCR5FAcwIemBZ8qi4qiXq/dIGMAt4gZtSO/HGFDvMQkmKhRMeXeLGEDnSe48m5TfjN9 swk3RgpFPlgKKZdvk+ANWeXYypwnp2Xl/MnEguLObwpmgjEPE/LhoAh7erPh7SGOOYaQ X-Google-Smtp-Source: AGHT+IHX4/z1bmEbuleAuvIKti9u1cl1KRXkfcldyq7zC7EMIdr0iB5TEWN0vk2Kb/pDsIdk/tKBJQ== X-Received: by 2002:a05:6a00:1d99:b0:728:e745:23cd with SMTP id d2e1a72fcca58-7305d421a40mr15751176b3a.3.1739046730853; Sat, 08 Feb 2025 12:32:10 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7304c780da5sm4882019b3a.69.2025.02.08.12.32.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 12:32:10 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Cristian Dumitrescu Subject: [PATCH 13/32] sched: replace memcpy with structure assignment Date: Sat, 8 Feb 2025 12:22:05 -0800 Message-ID: <20250208203142.242284-14-stephen@networkplumber.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250208203142.242284-1-stephen@networkplumber.org> References: <20250208203142.242284-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Prefer structure assignment over memcpy. Found by struct-assign.cocci. Signed-off-by: Stephen Hemminger --- lib/sched/rte_sched.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/sched/rte_sched.c b/lib/sched/rte_sched.c index bbdb5d1d86..c9b955b8e8 100644 --- a/lib/sched/rte_sched.c +++ b/lib/sched/rte_sched.c @@ -1775,7 +1775,7 @@ rte_sched_queue_read_stats(struct rte_sched_port *port, qe = s->queue_extra + subport_qindex; /* Copy queue stats and clear */ - memcpy(stats, &qe->stats, sizeof(struct rte_sched_queue_stats)); + *stats = qe->stats; memset(&qe->stats, 0, sizeof(struct rte_sched_queue_stats)); /* Queue length */ From patchwork Sat Feb 8 20:22:06 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 151197 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 637C4461CD; Sat, 8 Feb 2025 21:33:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E59AE40685; Sat, 8 Feb 2025 21:32:15 +0100 (CET) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mails.dpdk.org (Postfix) with ESMTP id A7AC64066A for ; Sat, 8 Feb 2025 21:32:12 +0100 (CET) Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-21f74c4e586so7555065ad.0 for ; Sat, 08 Feb 2025 12:32:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1739046732; x=1739651532; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=c80/9TdpxlsXti0oFqXAVasGclPwFBVacHO7egCHovM=; b=XEh/IFDraDORZ31kgB9DanRYCIpKc5eQ+93bH9bsNvttp9w5WzNSzMMr2NK1nxnfPL M11C/wLiRRFgdA7OTF+alqgp/BVlHP4f2Okr5GCVnZFTjIKihTPAVN1gon2f37kW5Bl8 loQVQTWdbjWmaNFfFiSybbAfyfShv5M6ADNCDASoQYe+noBGsb4Zjp780GvvhO91lAZe Ooxw5Hb9DxQeM9JXJWdfoxN+AZrNRJcwmxRxQ70TcOZazaXVuceJMQu0CQR5aMELujnE jS4NrKo025Uqgr6DSZRzSDew4sP8JiNAjBskqIRrzpuP7B5xJngA5IbdpHIbYBd/6Qkh OYxw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739046732; x=1739651532; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=c80/9TdpxlsXti0oFqXAVasGclPwFBVacHO7egCHovM=; b=IjMeI6JDU3pAdEbptTapDQn4bJ6854rRB0oFvfxq/A7SybFQsBD7jh0Fs77p/Z3OFs f6X8UYixC9Q3Iq+94QGGPnKKwb5Dz6VpHSLnwwFeG1p6QJabKF7vBWbR0EqOyFRCXflT f//jpPjcBHtQlHppaOYFEVWjSXbPRS9wRdNy8zni6w+xn87NErF5SBYiNNhv2SvxBgrC wb7k1izlAG0RzPSu6DVTeWGV/19PMl7Shrb+kpu1dNZT2ZwWr6YxaO+TRpJ90Rqku5sD 8r8Utt6ZGWHT3x/a5GwJSxZqIaFn5lQKm8ezxc+HaspK1Cff5nmw2NJC8LL94F1q0kYB BHqg== X-Gm-Message-State: AOJu0YwvLMKp0MskRYK5mmHInu+RTrKf9CqtmKCkqaolbLIwtx6YUt5F Wigw/5aliWVYSsA9+EA88xgcTihr2hrC7eiyJf5ClEm4r2qaVJ4L31vP+LqiuY9EKndWL62LSgY Kbv8= X-Gm-Gg: ASbGncv/JWSaZbEQMHl6Ocxj1SBa5qq0ZkNdirEyD/wvJ+LbbEhM2/7pO60Y3t1q8Fi pKJhzGDSEKwX8NEQRZ77OiJEBWVk70NxldTb3CFAa1wjtsrEUVK1ExivCo9vQ5d9k+KY8VfWpvR ZJL9DDEjFam35l+5Vf2oiGDV0R9MW0aSgewaOqHjBZrYcd07yfVXOa81K4vplVlXPoQOvJEKq/b AH8t4/uVz4rO1V5zOGwYoEIEDq6JWtXYq2iM/pVSwWvMfM3JrzKbNx+Zppsi0/bn9rG1DJmH7Is X9buUGwJ78r9nQCllat1Ti6jNj6J6Z1HcV/n6oBCyNZQZ9d9/p7jzEGuAcsnGjepB5d4 X-Google-Smtp-Source: AGHT+IGFVrN1E21lo9RR91PmMH2yQNwkjKorAMI5ICVgVZgm9UtyRWGEkJiqj4Sr0JYZAO94BINWjg== X-Received: by 2002:a05:6a00:1acc:b0:728:ecab:51e3 with SMTP id d2e1a72fcca58-7305d47f31cmr9550886b3a.11.1739046731870; Sat, 08 Feb 2025 12:32:11 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7304c780da5sm4882019b3a.69.2025.02.08.12.32.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 12:32:11 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Cristian Dumitrescu Subject: [PATCH 14/32] table: replace memcpy with structure assignment Date: Sat, 8 Feb 2025 12:22:06 -0800 Message-ID: <20250208203142.242284-15-stephen@networkplumber.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250208203142.242284-1-stephen@networkplumber.org> References: <20250208203142.242284-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Prefer structure assignment over memcpy. Found by struct-assign.cocci. Signed-off-by: Stephen Hemminger --- lib/table/rte_swx_table_selector.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/table/rte_swx_table_selector.c b/lib/table/rte_swx_table_selector.c index 18e021fe6f..da693cdba6 100644 --- a/lib/table/rte_swx_table_selector.c +++ b/lib/table/rte_swx_table_selector.c @@ -225,7 +225,7 @@ table_params_copy(struct table *t, struct rte_swx_table_selector_params *params) if (selector_size < 8) selector_size = 8; - memcpy(&t->params, params, sizeof(struct rte_swx_table_selector_params)); + t->params = *params; t->params.selector_size = selector_size; t->params.selector_mask = NULL; t->params.n_groups_max = rte_align32pow2(params->n_groups_max); From patchwork Sat Feb 8 20:22:07 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 151198 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7294A461CD; Sat, 8 Feb 2025 21:33:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DD77E402D7; Sat, 8 Feb 2025 21:32:16 +0100 (CET) Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by mails.dpdk.org (Postfix) with ESMTP id 997EA40650 for ; Sat, 8 Feb 2025 21:32:13 +0100 (CET) Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-2f9bd7c480eso5786516a91.1 for ; Sat, 08 Feb 2025 12:32:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1739046733; x=1739651533; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dwumik8AL9gXNbaQcQoYUzwtaLs4pzRfeSyg3VNOr0g=; b=h4wgPFyVkwFbqnUA3VFNVaDfamreY9PxJhrSOlPQKfW+ppZ1B+yQcA4T+qNE9P2N70 Ji3yHDdFK7SFF3OWS3NiVPZNfNumH/wmz6AJbQa7ufC1EbgBuYuvJQJ3JAuDdbFDfleE sv5B2nhPhPXZmw3ChHfpuUshHYaDSl0A7OnidUmzT0RFKSOGOhM6tnYirvV+Gkf42geQ japxbLzr3TETrnwlEmvSB9ltfKGmeIBT9/DRL8gMIDO9oABn8f2CH6z15TbqMJvMgX3M a0poLHEiQar82C9UmL4BWMicppGGmwYJfZX/wj0JllWYXs8+shH9QYU3mwvGMSDQmOme 0bNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739046733; x=1739651533; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dwumik8AL9gXNbaQcQoYUzwtaLs4pzRfeSyg3VNOr0g=; b=Uomg9BU9cs0TmQqgHXHRTj3rLWIGyBGw7r17lAd06b76nREjtOQV3jZ7B5jA0azCod Q6p2iepyEB5SqlrqbHTPtlAtkfQ35Sn03JwiKpxjqSBsxLpeG3PrxOtUGr/jU2dLcjTn 4p7eQ9qHBM1AQeoVtDQDWVNPZflrEZmW/SeoB0DvbHEbGJvYu01DGJ/Dv0RzV9KESTvG 2udhWRV/GdagO2tgOQvOzm7Ghc7cC/eBDkJS16OSllYJR4RNx0WUlJ6gwl/NUTSFikRx /BuSiaOtmAe407LxpZQijroTLGn1tlZzvysOiRfWsQ0P7vqA4CTqev/I9+kofTsil7zV pIPQ== X-Gm-Message-State: AOJu0Yzf9LTWtMxg11LW7f87ffIIIA4953XcaU8qNkPO7Sz8/m43U1Cq n0LQESj7aaTGAkEx1o5DEhEoccs4hosIGerle8fvw0E13clNdlA4D/dVf6zTb+Ob7EWR/nPaATS 7Hh4= X-Gm-Gg: ASbGncvPMYyb3Fhht8IVQEFzgLHrpux5SLXPtnWVNLf3iVrYEsaMhj/2MCVVq9tlKTJ qHcmkRAlToL4CtrvTwu+mTpMWNTNYW4BUTXFT790uX+uW8Diz50TFhtgjRI4lgqSpAIGi6ignby q6rBE4yB5FCYkwa7Hqdrt7jHtBxjyv28RJLMS1ZppgDf56vAGDmyKWKci1a1DVaN7ti42qUTkNh FyZC+UGjAoOuV7K66f5XQvt2KWxLaI8IHURSfzw/X84OX16Om14wuGEGoqC3Bsiu/hyVL1L6ofo Av2bpm8oiOLrYQ4PGTX5Q/jMq4q+jZTOjJWcP4h1KLVcs+QVmtaF/6RBPFQiN7d45Lb8 X-Google-Smtp-Source: AGHT+IEJWY8kDKGAFRT13tmS0EMay7XCzz5PIJEurrbktLjWvHWlaR2EtNX7iIO88MtWxTogNVALzQ== X-Received: by 2002:a05:6a00:6f1a:b0:730:74f8:25b9 with SMTP id d2e1a72fcca58-73074f8430cmr4672837b3a.17.1739046732745; Sat, 08 Feb 2025 12:32:12 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7304c780da5sm4882019b3a.69.2025.02.08.12.32.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 12:32:12 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Christian Koue Muf , Serhii Iliushyk Subject: [PATCH 15/32] net/ntnic: replace memcpy with structure assignment Date: Sat, 8 Feb 2025 12:22:07 -0800 Message-ID: <20250208203142.242284-16-stephen@networkplumber.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250208203142.242284-1-stephen@networkplumber.org> References: <20250208203142.242284-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Prefer structure assignment over memcpy. Found by struct-assign.cocci. Signed-off-by: Stephen Hemminger --- drivers/net/ntnic/nthw/flow_api/flow_id_table.c | 4 ++-- .../nthw/flow_api/profile_inline/flow_api_profile_inline.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/ntnic/nthw/flow_api/flow_id_table.c b/drivers/net/ntnic/nthw/flow_api/flow_id_table.c index a63f5542d1..61cec41590 100644 --- a/drivers/net/ntnic/nthw/flow_api/flow_id_table.c +++ b/drivers/net/ntnic/nthw/flow_api/flow_id_table.c @@ -99,7 +99,7 @@ uint32_t ntnic_id_table_get_id(void *id_table, union flm_handles flm_h, uint8_t struct ntnic_id_table_element *element = ntnic_id_table_array_find_element(handle, new_id); element->caller_id = caller_id; element->type = type; - memcpy(&element->handle, &flm_h, sizeof(union flm_handles)); + element->handle = flm_h; rte_spinlock_unlock(&handle->mtx); @@ -139,7 +139,7 @@ void ntnic_id_table_find(void *id_table, uint32_t id, union flm_handles *flm_h, *caller_id = element->caller_id; *type = element->type; - memcpy(flm_h, &element->handle, sizeof(union flm_handles)); + *flm_h = element->handle; rte_spinlock_unlock(&handle->mtx); } diff --git a/drivers/net/ntnic/nthw/flow_api/profile_inline/flow_api_profile_inline.c b/drivers/net/ntnic/nthw/flow_api/profile_inline/flow_api_profile_inline.c index ff8eb502f4..5565a7857c 100644 --- a/drivers/net/ntnic/nthw/flow_api/profile_inline/flow_api_profile_inline.c +++ b/drivers/net/ntnic/nthw/flow_api/profile_inline/flow_api_profile_inline.c @@ -3099,7 +3099,7 @@ static int convert_fh_to_fh_flm(struct flow_handle *fh, const uint32_t *packet_d if (fh->type != FLOW_HANDLE_TYPE_FLOW) return -1; - memcpy(&fh_copy, fh, sizeof(struct flow_handle)); + fh_copy = *fh; memset(fh, 0x0, sizeof(struct flow_handle)); fd = fh_copy.fd; From patchwork Sat Feb 8 20:22:08 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 151199 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 23235461CD; Sat, 8 Feb 2025 21:33:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DE96240695; Sat, 8 Feb 2025 21:32:17 +0100 (CET) Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by mails.dpdk.org (Postfix) with ESMTP id 922B24066D for ; Sat, 8 Feb 2025 21:32:14 +0100 (CET) Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-2f42992f608so4822063a91.0 for ; Sat, 08 Feb 2025 12:32:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1739046734; x=1739651534; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ZCJPFILj3Md5HFtnzDLz1Y0XfpqaLYgctdooy5SB3ek=; b=R06Oi2Mq0vKsxY0lmw9pelNtHz6rNRni48DBgM07o+YEnLg4r9z18NCGnqG4vDYxLK m/MS+C1uGdEGYyiW++cstJWL3U2RJe/67yk+/2hHOapuL35ZDLnFys8eV6J3dPTLUpUe NTwoM8ZYuB850S81dO8+iDByVO5Xmi8GoEFGeZtGsq3z5qrArBGfLqjJH/wDE8wWi+6+ PS9LRAHnCfUtrI+PDxpZQtHD9bdmqFSfVJBvIWMVLUjzs55peZ7LilxtzADATVKs0iow EA7N2J7OUY4V4X/ZKSkpc0H3zfmsM3i8s1deYqXvcz1775X2KXNG9IP1GJfgpxNq0Bk+ nHaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739046734; x=1739651534; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZCJPFILj3Md5HFtnzDLz1Y0XfpqaLYgctdooy5SB3ek=; b=CkM1H47qm1TvC/NHrSa82vstwWwnMZHKV3IIb5/dtqa+AXuZuJ50GQo2WgixTWPCOl Va41DYWEsaD5xlu5U4UX9OHF5iFqMhfP6yFSkSlPJRhAyjbx3ocezx6at94Gqim6riBK 8fSD+2xKp1HKz79WKYV1+olE04VmZRUFZhKVo3n3SUihRf/D1p55Bn4OiVWsePUyQfBj R1m2/DRMn/dYl02bCDjP11mLsHZBuP0aZvawOY8KFoC0CX92cEAEKmoWJnMov2RdPt8g iolQ6u/8oW/BNG7ltvJTfxBqXcBjKB6c9hNWFxJYUh5Ur6ExX7w35fPwSetO2/37WoO+ E3qA== X-Gm-Message-State: AOJu0YxciZTxcKGQnpsn3FSw/fa8wqaUjssNppzBYRbty78k6n6VQ1v1 ki+OLIhoKyzAVmYj61ZDCf3W+mI3sKkBA8zxu6rFCWtXZFNjgxOSRtpBlCgtK9lWygD32iuYJF1 qfoo= X-Gm-Gg: ASbGnctmBaIGwSU+1OV9JeSH+WbAz9Bpx08aIyCL69k4gSQfHm3xmp5oN5YhRIIHwab YsFMmfReKEmdCKUP6FceIn7PTJefgLNrRsb4iGC9W4ffC65H2vJOZBvtcCM1lK+uprFBMV4UO2w rOzQQ69vSIzjOiXcwYmopQ/VFZilDP5IY6kt3FyuGu5IwziptGZPrYEpz7k6IwAe6rBN8am9u6S vbHH4f7gVH334EGRYbBEOrCjDVaqVcE6LSMeYlrjnw++YEjedq188w5f5R8SOcMeIE9vu26cR0E tI2mzgHY/sxc/eHLhvm+Xmmq9+nbMzefp19/olwhXauA9wJp1wIcq5fIonLbtYhiw0OT X-Google-Smtp-Source: AGHT+IFLu9YMjsSFAOohDmrzdE2ZWzD1hkacGP7WMthzW8/kJB3KN6IKE+cTtk1Dbvyh9KpqvICxmw== X-Received: by 2002:a05:6a00:3488:b0:725:b347:c3cc with SMTP id d2e1a72fcca58-7305d529a92mr13443106b3a.23.1739046733784; Sat, 08 Feb 2025 12:32:13 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7304c780da5sm4882019b3a.69.2025.02.08.12.32.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 12:32:13 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Ajit Khaparde , Somnath Kotur Subject: [PATCH 16/32] net/bnxt: replace memcpy with structure assignment Date: Sat, 8 Feb 2025 12:22:08 -0800 Message-ID: <20250208203142.242284-17-stephen@networkplumber.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250208203142.242284-1-stephen@networkplumber.org> References: <20250208203142.242284-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Prefer structure assignment over memcpy. Found by struct-assign.cocci. Signed-off-by: Stephen Hemminger Acked-by: Somnath Kotur --- drivers/net/bnxt/bnxt_hwrm.c | 3 +-- drivers/net/bnxt/tf_core/tf_rm.c | 8 ++------ drivers/net/bnxt/tf_ulp/ulp_tun.c | 3 +-- 3 files changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index d015ba2b9c..b2f73207ae 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -3266,8 +3266,7 @@ int bnxt_hwrm_func_qstats(struct bnxt *bp, uint16_t fid, HWRM_CHECK_RESULT(); if (func_qstats) - memcpy(func_qstats, resp, - sizeof(struct hwrm_func_qstats_output)); + *func_qstats = *resp; if (!stats) goto exit; diff --git a/drivers/net/bnxt/tf_core/tf_rm.c b/drivers/net/bnxt/tf_core/tf_rm.c index e9a2fbd851..18f46c0a0a 100644 --- a/drivers/net/bnxt/tf_core/tf_rm.c +++ b/drivers/net/bnxt/tf_core/tf_rm.c @@ -1265,9 +1265,7 @@ tf_rm_get_info(struct tf_rm_get_alloc_info_parms *parms) if (cfg_type == TF_RM_ELEM_CFG_NULL) return -ENOTSUP; - memcpy(parms->info, - &rm_db->db[parms->subtype].alloc, - sizeof(struct tf_rm_alloc_info)); + *parms->info = rm_db->db[parms->subtype].alloc; return 0; } @@ -1299,9 +1297,7 @@ tf_rm_get_all_info(struct tf_rm_get_alloc_info_parms *parms, int size) continue; } - memcpy(info, - &rm_db->db[i].alloc, - sizeof(struct tf_rm_alloc_info)); + *info = rm_db->db[i].alloc; info++; } diff --git a/drivers/net/bnxt/tf_ulp/ulp_tun.c b/drivers/net/bnxt/tf_ulp/ulp_tun.c index 7ebe81c4ea..b90b4bf252 100644 --- a/drivers/net/bnxt/tf_ulp/ulp_tun.c +++ b/drivers/net/bnxt/tf_ulp/ulp_tun.c @@ -40,8 +40,7 @@ ulp_app_tun_search_entry(struct bnxt_ulp_context *ulp_ctx, } if (free_entry >= 0) { *tun_entry = &tun_ent_list[free_entry]; - memcpy(&tun_ent_list[free_entry].app_tunnel, app_tunnel, - sizeof(struct rte_flow_tunnel)); + tun_ent_list[free_entry].app_tunnel = *app_tunnel; tun_ent_list[free_entry].ref_cnt = 1; rc = 1; } else { From patchwork Sat Feb 8 20:22:09 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 151200 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 65C59461CD; Sat, 8 Feb 2025 21:33:40 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 47A29406B8; Sat, 8 Feb 2025 21:32:19 +0100 (CET) Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) by mails.dpdk.org (Postfix) with ESMTP id 133B340689 for ; Sat, 8 Feb 2025 21:32:16 +0100 (CET) Received: by mail-pj1-f54.google.com with SMTP id 98e67ed59e1d1-2fa2c1ab145so2932750a91.3 for ; Sat, 08 Feb 2025 12:32:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1739046735; x=1739651535; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=a0dGiUsM7XPLY76vdWYlKm0vJV6dsaLMqLz9vbQrmaY=; b=vy2JTmyISfBmtawhzK1c4e8w/yQZhtWPWIpKx2HOqYHIjOB+K5dyJ1apFu0vlEFHxW T7zkZ+15iYxieMf6XcoOEX3t70xsTj/Yg38kj2viUY7dCMBQhn2V6VA0IA6UQ/cLsc1J MqRjlxnHviRAK0a4CsyNAhM/RcMgJcaZlvB4qMsnnMBUB0Yf9W114PuFYJOqwycPgf6w uMnRg99wARzlomYflLdpEZj4Ear9U1OQwbYlvG+wCvbCLt+iWJVOcZZTjIXQz8y2ZFc2 gwcifdQmGMBIqmmIVj73cZ6Rt6NrznQlt/wuoSgEdDHphUDJRvUHhU7bb5DfMcaZm0Ou KXSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739046735; x=1739651535; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=a0dGiUsM7XPLY76vdWYlKm0vJV6dsaLMqLz9vbQrmaY=; b=JW8+YEG8pAeDD3WsBulzldazqjPSFqA+EaiIf8mruyz0Yoica/uWoyr7+85rTi9rsa 7jtpBhcpWyZWjm2TIbKPCWewCZHHfKqxqPoO9pTH70l++uRpAAnNGnghAjNBisMVDQLe Myb4H5ISFwXc/GgRygDkJvRP7WIOdrw8TGs/7q1NFBC6R4dnqG8odj6c2kEXiP6dwpt/ MwLuVRhm3cPMJdoIwuJda3VcKZqF/3051E6OtF0o/ZEwm4ldK2eDPvZn4ueokDVIXScQ lP/csYPpBZhCYjj5CgWBfUiQ5IPQtJejbiPS+ifEv2IH1hi8+Ra8xgeakQ0BzJ6OH9+o JVqg== X-Gm-Message-State: AOJu0YwgGpsyFf06q7ahc+SmAtsqqWbKx3m3Eyruj77Okc0sK0MJJE1L XRbi2HOuppIAe9X6E9QoMCgroRWZaWt7HHEQm7GwHp2vsYd9Pbv0O4FI4NnEt7DUToTgk4frsx6 y9xw= X-Gm-Gg: ASbGncsmh5ALq8WH7iZfaZpmbIL8WMFKPawoQd7t4IhejPDYmcF6LEagfq6lzfV2d7H ck4tkBeFcAAU1+JqnvkQmj52cBPWDLu3SWaEmOKYYFj/fhpxb5KNJni43bEv/WRZgg/iUYx/dWS vnQZ48kPoqOon9nEBsuXLekJ/1/fhibljEXJIdXE/BHB2U4GaAiH6v1r/yAShlNMJKPY8Ljosl8 ICk7GU7tzYKTJqFHkEhPHz6IG/genBuoIZiXPTRKzinBr04ESvYh35CqBpgIVp4yqDVB7gInKad z5B528uztKcPpjDX6FH+1pWUG6K++Az44o46wUeG4CF3wG93tvhsVsr3LEhJaym58rzm X-Google-Smtp-Source: AGHT+IEd+kZnKcES+bAzyOyWl8EjDHm+7L3FRFBTJzLBIsWpUA99gQZmUWNfyNQe5ycf7/2K0v3aIg== X-Received: by 2002:a05:6a00:f9b:b0:72a:8bb6:2963 with SMTP id d2e1a72fcca58-7305d49d1bcmr10657874b3a.13.1739046735280; Sat, 08 Feb 2025 12:32:15 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7304c780da5sm4882019b3a.69.2025.02.08.12.32.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 12:32:14 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Kai Ji Subject: [PATCH 17/32] crypto/qat: replace memcpy with structure assignment Date: Sat, 8 Feb 2025 12:22:09 -0800 Message-ID: <20250208203142.242284-18-stephen@networkplumber.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250208203142.242284-1-stephen@networkplumber.org> References: <20250208203142.242284-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Prefer structure assignment over memcpy. Found by struct-assign.cocci. Signed-off-by: Stephen Hemminger --- drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c | 3 +-- drivers/crypto/qat/dev/qat_crypto_pmd_gen5.c | 3 +-- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c b/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c index af664fb9b9..478e766b97 100644 --- a/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c +++ b/drivers/crypto/qat/dev/qat_crypto_pmd_gen3.c @@ -277,8 +277,7 @@ qat_sym_crypto_cap_get_gen3(struct qat_cryptodev_private *internals, RTE_CRYPTO_CIPHER_DES_DOCSISBPI))) continue; - memcpy(addr + curr_capa, capabilities + iter, - sizeof(struct rte_cryptodev_capabilities)); + *(addr + curr_capa) = *(capabilities + iter); if (internals->qat_dev->options.has_wireless_slice && ( check_auth_capa(&capabilities[iter], diff --git a/drivers/crypto/qat/dev/qat_crypto_pmd_gen5.c b/drivers/crypto/qat/dev/qat_crypto_pmd_gen5.c index e1302e9b36..7d2d234959 100644 --- a/drivers/crypto/qat/dev/qat_crypto_pmd_gen5.c +++ b/drivers/crypto/qat/dev/qat_crypto_pmd_gen5.c @@ -203,8 +203,7 @@ qat_sym_crypto_cap_get_gen5(struct qat_cryptodev_private *internals, continue; } - memcpy(addr + curr_capa, capabilities + iter, - sizeof(struct rte_cryptodev_capabilities)); + *(addr + curr_capa) = *(capabilities + iter); curr_capa++; } internals->qat_dev_capabilities = internals->capa_mz->addr; From patchwork Sat Feb 8 20:22:10 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 151201 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E75C5461CD; Sat, 8 Feb 2025 21:33:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 71C1840676; Sat, 8 Feb 2025 21:32:20 +0100 (CET) Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) by mails.dpdk.org (Postfix) with ESMTP id EFA4A4068A for ; Sat, 8 Feb 2025 21:32:16 +0100 (CET) Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-219f8263ae0so58989945ad.0 for ; Sat, 08 Feb 2025 12:32:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1739046736; x=1739651536; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TcXARBxuSrL/585OvNO6UlgMWVw5mWFsybo55mU5d9s=; b=iwU0urylU0Wk2cVmg9iJTrGVSl7hT5zMO7sKyYep3r8+DOImWUwDffn56QqBh3NbQn 4+TMb7iFvdN8oI0jySOWgIfWiS0MMxSui/WUnFK3UeIJl+QFBUhqhewuq5ZwmxUI7zFJ GtoF3FbgAi2oTKKmRL/4tdXP9w9XdYXL5OEpWm0WLLifponAhnCftxaQ8xx+Z3+QaX40 kYS/+SkaZbIMbk0FfDIai8JIg84rZVcVT85J2gunAaBePqb0dGQF/+os1y1vB8whplCP 97c4cPXmyk7fyDQDWkzU6lPTaXccHCz7vd6yFGi3Mc3/xXYMkeqEFOmN80VaKOG4E7Ig 64OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739046736; x=1739651536; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TcXARBxuSrL/585OvNO6UlgMWVw5mWFsybo55mU5d9s=; b=AGZNQklnNNeYXiMQQN0XUHbuihnMwy2fKA9RSLytM+HK+RChSPVXCNNbNLYqtGnfgr aZTb5GDFZxnPTtEwxNiW2Yv18cw9vbAU67tDWRZlsL5pucrXnGG5NyvfqOPWDS5LzStz ydQo2+tWx4BuQCbqEwzNYvS8bEeQrae7JIEmlfJb9QUVxQUtN3DBaPH8XSD8H8QEdk89 yTUgW3GokBWt9dWVz9rRdkXS4MSHqENGjNAj5Nqjs4+ZfJSJMjWm8qRoVU4lXLF2TLK3 5yLaU+beVv2zGfFj/lr7c+SiHGkYVW2FS4CSweSlAliQzSMdbSOqbDKBCBFTmVpnqqpT 0jsA== X-Gm-Message-State: AOJu0YwHixG29rZ/c6RdRaetdatRWKlUCSwX5tGCCsE1vHpU47il1hwB t7wu8EAoCdn8KFJau/Ej0Rry3jroY1a11pB++j9+VAUicEtaLyEnEv6XeCPEZqpQb1+S8k9gc4B Vwj0= X-Gm-Gg: ASbGncvyRz2MqU+/upF3XqFZEvnBmLsB1l+WCsgpvvbST0x0elGHIIRCXb94a18jSzt kdma8j+N+p+ZlSJs7WzcNPGUCu19E20UMDnk6MnapllBXUAtTZK8yqjVzYACVW7oJzayAeQ6KE0 mGzV3AYopxifaRHW14G53kcvbVDowa6Z1CYDoEsB9PzgKjGrp9/LBhzxVYsodQEO/nUl/4L9BGs U9xro3Wr0X4BcdUeF3GBA8OMuYUD4UIfiGcIlBadOhWOTGOvF8wG/+CQoPxn0N8pbJt9hfJIpK6 uaDtEGtSxC3+0FwK2zm34SysdriYFkkSSbWoju0MduTZTDNfYFQ/qGPOW6bBRsXXoveB X-Google-Smtp-Source: AGHT+IGlexey7GFBFcP0HXdTpDklaxXeys7jAQTw06BxIufurGMLDced7r4t29b311ig48uxRkv8lg== X-Received: by 2002:a05:6a00:3029:b0:724:592d:aa5f with SMTP id d2e1a72fcca58-7305d4ef721mr14390058b3a.19.1739046736191; Sat, 08 Feb 2025 12:32:16 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7304c780da5sm4882019b3a.69.2025.02.08.12.32.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 12:32:15 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Ashwin Sekhar T K , Pavan Nikhilesh Subject: [PATCH 18/32] mempool/cnxk: replace memcpy with structure assignment Date: Sat, 8 Feb 2025 12:22:10 -0800 Message-ID: <20250208203142.242284-19-stephen@networkplumber.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250208203142.242284-1-stephen@networkplumber.org> References: <20250208203142.242284-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Prefer structure assignment over memcpy. Found by struct-assign.cocci. Signed-off-by: Stephen Hemminger --- drivers/mempool/cnxk/cnxk_mempool_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mempool/cnxk/cnxk_mempool_ops.c b/drivers/mempool/cnxk/cnxk_mempool_ops.c index bb35e2d1d2..5c7fcea487 100644 --- a/drivers/mempool/cnxk/cnxk_mempool_ops.c +++ b/drivers/mempool/cnxk/cnxk_mempool_ops.c @@ -103,7 +103,7 @@ cnxk_mempool_alloc(struct rte_mempool *mp) struct npa_aura_s *paura; paura = CNXK_MEMPOOL_CONFIG(mp); - memcpy(&aura, paura, sizeof(struct npa_aura_s)); + aura = *paura; } rc = roc_npa_pool_create(&aura_handle, block_size, block_count, &aura, From patchwork Sat Feb 8 20:22:11 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 151202 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75637461CD; Sat, 8 Feb 2025 21:33:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8E28B40A4B; Sat, 8 Feb 2025 21:32:21 +0100 (CET) Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by mails.dpdk.org (Postfix) with ESMTP id DAB1A40693 for ; Sat, 8 Feb 2025 21:32:17 +0100 (CET) Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-2fa4493a695so1021957a91.0 for ; Sat, 08 Feb 2025 12:32:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1739046737; x=1739651537; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uDpgqYPNFIiCtUSqeygn7R0ZOSGdUQvXZl5vN2i7aac=; b=p6AdxIVmKUBp5UdusL/42T3dL8qLQJnrIe87kAltgNopTS1knNIukYyLY7Zpl22gPl Vmtcqh720qhvWaZADZ9BadaKw6oO/6n3qPR8kMJafEPtnN3cvrhYU3xk4Z1rnbxGM/an fTZ2a2FH5J9OlrDDMD86DVVMEHXMjtJX3YauMcPjEWx4y3Ng6wJzYx7RWw9eYBFdiPZx FZJs0kYGlNKhDfHrRPC3RJJB8e+MZX15eN82spmbtCKduBimMLWHcZJQXXi7U4OvbdLd HM1iSQYLL8kBX9x/By/PCCOLORHDHjAzNsL5qsSL0GHD2MyWAQkY74OPL1XOWW8kmP8N 82FA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739046737; x=1739651537; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=uDpgqYPNFIiCtUSqeygn7R0ZOSGdUQvXZl5vN2i7aac=; b=c9tSisAR82xcC1OEvRBec+G4+PrFFNnM7Nq2u2d7Fu+KxfJD4ssNTg5aC0B9VPM+uq Uo6aOPPaF+uva1+5Q8cnVLb/558jT4UdUAauq7bUBrGxGAX51U/j3VUjAxkbziAebzvh vcbzefWp3/rfnxAXs8BN8lysE3L8ty833r7GD5ZJ72u99zjpRV0FWEJXgzO6lHAa3gpU fGek7AwT6uTNIZB66qvt4UZW1yqBUHzvvZbBpKGYxlbWIwewFU4Bc7s+xohzG2LSBhjN CddzzsWQn2TXbdYCzhtfpMynSLpvGNePXn5sA/gWN0aiXKMHhvkXYybxESqy0lyeTVNp tfxA== X-Gm-Message-State: AOJu0YxqoQY+3c/wd12qFmlXmRsliIp6WvfcxhjKVw2TF/tEK6RGnGCx MRH80frGk6S2pFLJ4+LBtE/lqo+5RqfMLWoLh5fuWxf2cCqzFWEpoy+FMej8Ki4ebdN4avl+l+8 I/Lo= X-Gm-Gg: ASbGncveFXmrAVr9cJtvy6QFCyZSLrmYltLfBe58b3VlYKS+pqozip4o7F8zERvKxL8 5lrlhLz4OYJvCc8KDzQIP20O91TS1rMuIggwMlqoB1DTNsU7HFpXfb3ByH5a4kd2MSCqdpMoTAB ghmvCgngrkB7Ipx5igM28+XmdXdK74yUjjsBRkj/T0ZnIg+mKOPngv+C+w2YM4XtnZAq33UVb8l 8jsljGAfa95T8V5QXWs1dgEgxQ0bmaqOM+Rq9pTYgp3UsgD+IA76iaMq9KjebUjiqWmAY27+c2B kGxc7g2oonxb2J+7hGgB2yC7Sq2LWWlJY94cuBulGDGAcAmAa3ltfx4qFHkESXWK8Ybl X-Google-Smtp-Source: AGHT+IHsowE3iQljQtRVztR+c2W10s7kD9/fwI7VbQhY7rjMIXyj5G6TAyAKG0PesJc/8obfWYJn2w== X-Received: by 2002:a05:6a00:18a9:b0:72f:c513:a5fc with SMTP id d2e1a72fcca58-7305d51886fmr10447131b3a.23.1739046737141; Sat, 08 Feb 2025 12:32:17 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7304c780da5sm4882019b3a.69.2025.02.08.12.32.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 12:32:16 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Hemant Agrawal , Sachin Saxena Subject: [PATCH 19/32] net/dpaa2: replace memcpy with assignment Date: Sat, 8 Feb 2025 12:22:11 -0800 Message-ID: <20250208203142.242284-20-stephen@networkplumber.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250208203142.242284-1-stephen@networkplumber.org> References: <20250208203142.242284-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Prefer structure assignment over memcpy. Found by cocci/struct_assign.cocci Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_mux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/dpaa2/dpaa2_mux.c b/drivers/net/dpaa2/dpaa2_mux.c index 2f124313fa..3f259cd16f 100644 --- a/drivers/net/dpaa2/dpaa2_mux.c +++ b/drivers/net/dpaa2/dpaa2_mux.c @@ -293,7 +293,7 @@ rte_pmd_dpaa2_mux_flow_create(uint32_t dpdmux_id, ret); goto creation_error; } - rte_memcpy(&s_kg_cfg, &kg_cfg, sizeof(struct dpkg_profile_cfg)); + s_kg_cfg = kg_cfg; } else { if (memcmp(&s_kg_cfg, &kg_cfg, sizeof(struct dpkg_profile_cfg))) { From patchwork Sat Feb 8 20:22:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 151203 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 250FF461CD; Sat, 8 Feb 2025 21:33:54 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 916064069F; Sat, 8 Feb 2025 21:32:22 +0100 (CET) Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by mails.dpdk.org (Postfix) with ESMTP id C1B7040697 for ; Sat, 8 Feb 2025 21:32:18 +0100 (CET) Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-2f42992f608so4822091a91.0 for ; Sat, 08 Feb 2025 12:32:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1739046738; x=1739651538; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=8QKOIsIbBy5fZzwp3fIEtv5TDw6lojY01AbuNT+Qgk4=; b=y2XXY3BR1SMXAofF4lL+O0zn6IUpq7C3bGa579TkPtA4yPIfEVIPOHv9EPKCclmK22 +8GDXkDhpI8BMaMkO1kwvxeFwlx665x7guRNDF1SyowwxqFQRmwmsdfTkcO6oiVQvuMS CZNLxkYRg/PQWIv0wklUn3odWG96SHjItGTGEfLbgddtdBVGALIki93CRNY2QJNFsNu4 0Dj+No4DykWbrjijDSZZhTXwm76SvOeajEdfgOvFSK7c/RLnu6dM84rJYCsNArcoUvrO ZJDcoZEKdMeWUu0HvtZYNN13hxyIGO5fN1JmoyECkY/x8mxcHal/kQnKBNr6KV4PTpsM M7DA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739046738; x=1739651538; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8QKOIsIbBy5fZzwp3fIEtv5TDw6lojY01AbuNT+Qgk4=; b=N++3pW7GQzp648YYoI7lGr91V9qIS8NeA1tExHtqOSguJgCoO3gaBPv+bNAZjqsgzX q6dYoi2eIKoFE5F+JgIGEa3zp/NgnFg5tpPK6EkZ5NiS/rQVsyT5RJvOmrgelFeVZK9N MN+6UniCmJGF0dPRSeEJ8H6ZXNz3OVaZQijWCO21K8lGTmOU8S5iqTdipuldmZi2NaIH wrNyRQAzGZUNP7RVZhivKrrxCPblb5wcpnfAFI9PJSa7A0JQoHnz8m31P1RZgOdUzWT3 G4+BuAf2vv9okZo+04G6gn9LRRdZt30UCQLuE7ZlvmtuVD9UvxC9h5dvfop6KIsVeEOw TYqA== X-Gm-Message-State: AOJu0YzrvYOjAYjrnTQYH2EumFLqLaf2/ay0I83S4PNR9m7LQUOAOhpY +WtJhMx9YPYiE3POYGRhRrzRatnDdYCBseABboy2zGPujacjxI/eadBbFoOV+3I6nD5/+hPtOcI TMpU= X-Gm-Gg: ASbGncuRo0scndVciz+n5rFMReCPa2FpqnSZIWurUtbb3tQn/2Jla1iAig2SNFg3l2w Lp1lIDZFvElvBDxRyi5yUvbb8QT/WQoTWZ6ztlbiODs+eNM9qTUd6a+4W+aEl5xoDYxTAqb32H0 yMZixwaldlHlj9o8drNLJMfKRXeeYIxwfHfR+nfQOniYNAikhfTpA51SlKdXl/kVF0anGkDH8h1 Dq0Uh4RZChEL/e0G4XWePEmAxrTU0LF7Tm+8tWUDqWeYj434Ma6D3Y0knhaTwIJXsT7kvsqJb+K M5OQidJrZCG5Gcb/8+OAXb1cAuxvFDObchbSdj/EIV5Gtgzku/QdZaKB17rDcZdNLhUG X-Google-Smtp-Source: AGHT+IFiihp5EMl4crO0YPcso17doh8fwJlnZfc7/vvrNuAlzWQO8NGHPm4tqZGQboti3PXfW1YYxg== X-Received: by 2002:a05:6a00:340a:b0:72d:710d:611c with SMTP id d2e1a72fcca58-7305d525de6mr14940188b3a.20.1739046738039; Sat, 08 Feb 2025 12:32:18 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7304c780da5sm4882019b3a.69.2025.02.08.12.32.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 12:32:17 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , John Daley , Hyong Youb Kim Subject: [PATCH 20/32] net/enic: replace memcpy with assignment Date: Sat, 8 Feb 2025 12:22:12 -0800 Message-ID: <20250208203142.242284-21-stephen@networkplumber.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250208203142.242284-1-stephen@networkplumber.org> References: <20250208203142.242284-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Prefer structure assignment over memcpy. Found by cocci/struct_assign.cocci Signed-off-by: Stephen Hemminger --- drivers/net/enic/enic_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c index b755b15d92..82abcde322 100644 --- a/drivers/net/enic/enic_main.c +++ b/drivers/net/enic/enic_main.c @@ -1238,7 +1238,7 @@ int enic_set_rss_reta(struct enic *enic, union vnic_rss_cpu *rss_cpu) if (!rss_cpu_buf_va) return -ENOMEM; - rte_memcpy(rss_cpu_buf_va, rss_cpu, sizeof(union vnic_rss_cpu)); + *rss_cpu_buf_va = *rss_cpu; err = enic_set_rss_cpu(enic, rss_cpu_buf_pa, From patchwork Sat Feb 8 20:22:13 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 151204 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 115A9461CD; Sat, 8 Feb 2025 21:33:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9936440684; Sat, 8 Feb 2025 21:32:23 +0100 (CET) Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by mails.dpdk.org (Postfix) with ESMTP id DE35A406FF for ; Sat, 8 Feb 2025 21:32:19 +0100 (CET) Received: by mail-pl1-f174.google.com with SMTP id d9443c01a7336-21f53ad05a0so28184235ad.3 for ; Sat, 08 Feb 2025 12:32:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1739046739; x=1739651539; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=HBW5jXPgtEd8AFHB6Vd2JVa+/kle53aIkTQEqhQjZPo=; b=SB/6VoA+x1FBu7FSoaIG3wIOGMnOuAAgx4iRTNyahiYrey8jzAcMobFp2GWV1c1g3b VSn/KC4y2wI0tfNDQXblClEZUMhLKCGKqkN0sn2pGgQ35p++oNVlJv+1petG9j0zVxic Tl//1+80IqyE4g/m5K9vvPIUdPcsY1YhvtKK8cMiSAhNPqSaXBbqe8G4ohZgJAEaFJch t//YSemwPAeNHertwLzQnOP8eo8yiX2XtzeqTv7j6Zpo1LbY/7KskCFdA08EoEgHKElu EtYEm175IDXc4iV5nLmhy6f3tWnUhkORGcosJHchl/cWFnS6ihGR2qyL6Ze5/D/1tbW/ m/Gw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739046739; x=1739651539; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=HBW5jXPgtEd8AFHB6Vd2JVa+/kle53aIkTQEqhQjZPo=; b=WrHYdowpXKB1z6fn6N2fhnRpnNidsyVs+pz+Pzdv5HkrDYFFIXasreyTPo84JrlBJS 12PHqjp2FYdWiYaCYH3fYkmmtYA2ndwYH08lovObvNP44o3p52IHYXEeALnpvIfK8SJm 7t/8lJeKlBXn5Im9+5mtkVBlXyIZh2pt7R4Mgy8/gGj4jE184O1OWaUxhTcsMoEXtTlo s6j+46pdOOfiw6fgo/qnYwlZheMnqwKWW3mJeHkVEt7NhW0PqKBFFcvUzQxQyA+YxUvi OEP9qqEm7VjbUn1uRn9RiHiGk5wYfjUS11/DM88lJHxLjQ9efaTMFU0dAj6WT/D82kEK ayBg== X-Gm-Message-State: AOJu0YzbmUq5jTp8QJKHRblNiCQarVg9EVrgZhWZ6pHFKveqp6QIVMsi 7+7EbpFvSi99//dQbyfp1cwpH8Y5N/Qbno/PZlkK/Uzr61vM1ju7WJPu9nHh1HRLciOPz744edv lVlw= X-Gm-Gg: ASbGncuxSGGko5kubD+kuwsAPW+RUaEVbe5xtnEj6GaN1Wha72yB8fFoze0qJIgSYPq 2PC9uY04hLye15lSfFP7OerkG6EFo6MgrDsheauYjNA0TkXeYIO/rBZ+85PcnFDJ2AMZ/PAoNAI ujEPLbTtQFSbO4wGqT3f1cbCLmj1zA5i+1IyeKN6N62uBjZHnp4c6B/3bUJ134TxBpQwQynQN5C CQsMKZ4cASlpNeJjN5bOQ4xSH7ex/1K8yr1R0G9+TwcxwUCrRLNrWp5qV1C1f6rGKYNvo/8FhJL BHN+L7l+Pd/1yLVI2lehvJTVytwWA0mxd8MSjFgCw1GSUC8ZiZXM2Jjat4utV5D+ZX91 X-Google-Smtp-Source: AGHT+IF6BtGu9yXMrrMRNnWL5t81S2/9pnO99q6Q58NhpFF9M8Q7azZ5cknbem+m5IT8X4Sx1anCUw== X-Received: by 2002:a05:6300:710c:b0:1ee:1be1:79d6 with SMTP id adf61e73a8af0-1ee1be17b1bmr3201080637.41.1739046739153; Sat, 08 Feb 2025 12:32:19 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7304c780da5sm4882019b3a.69.2025.02.08.12.32.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 12:32:18 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Ian Stokes , Bruce Richardson , Anatoly Burakov , Vladimir Medvedkin Subject: [PATCH 21/32] net/intel/i40e: replace memcpy with structure assignment Date: Sat, 8 Feb 2025 12:22:13 -0800 Message-ID: <20250208203142.242284-22-stephen@networkplumber.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250208203142.242284-1-stephen@networkplumber.org> References: <20250208203142.242284-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Prefer structure assignment over memcpy. Found by struct-assign.cocci. Signed-off-by: Stephen Hemminger --- drivers/net/intel/i40e/i40e_ethdev.c | 6 ++---- drivers/net/intel/i40e/i40e_fdir.c | 3 +-- drivers/net/intel/i40e/i40e_flow.c | 3 +-- drivers/net/intel/i40e/rte_pmd_i40e.c | 3 +-- drivers/net/intel/ixgbe/ixgbe_flow.c | 4 +--- 5 files changed, 6 insertions(+), 13 deletions(-) diff --git a/drivers/net/intel/i40e/i40e_ethdev.c b/drivers/net/intel/i40e/i40e_ethdev.c index bf5560ccc8..8a7afd6dbe 100644 --- a/drivers/net/intel/i40e/i40e_ethdev.c +++ b/drivers/net/intel/i40e/i40e_ethdev.c @@ -5987,8 +5987,7 @@ i40e_vsi_setup(struct i40e_pf *pf, PMD_DRV_LOG(ERR, "Failed to get VSI params"); goto fail_msix_alloc; } - rte_memcpy(&vsi->info, &ctxt.info, - sizeof(struct i40e_aqc_vsi_properties_data)); + vsi->info = ctxt.info; vsi->vsi_id = ctxt.vsi_number; vsi->info.valid_sections = 0; @@ -6005,8 +6004,7 @@ i40e_vsi_setup(struct i40e_pf *pf, rte_cpu_to_le_16(I40E_AQ_VSI_PROP_VLAN_VALID); vsi->info.port_vlan_flags = I40E_AQ_VSI_PVLAN_MODE_ALL | I40E_AQ_VSI_PVLAN_EMOD_STR_BOTH; - rte_memcpy(&ctxt.info, &vsi->info, - sizeof(struct i40e_aqc_vsi_properties_data)); + ctxt.info = vsi->info; ret = i40e_vsi_config_tc_queue_mapping(vsi, &ctxt.info, I40E_DEFAULT_TCMAP); if (ret != I40E_SUCCESS) { diff --git a/drivers/net/intel/i40e/i40e_fdir.c b/drivers/net/intel/i40e/i40e_fdir.c index 349627a2ed..3d0ba25cba 100644 --- a/drivers/net/intel/i40e/i40e_fdir.c +++ b/drivers/net/intel/i40e/i40e_fdir.c @@ -1252,8 +1252,7 @@ i40e_flow_store_flex_mask(struct i40e_pf *pf, sizeof(struct i40e_fdir_flex_mask)))) return 1; - memcpy(&pf->fdir.flex_mask[pctype], &flex_mask, - sizeof(struct i40e_fdir_flex_mask)); + pf->fdir.flex_mask[pctype] = flex_mask; return 0; } diff --git a/drivers/net/intel/i40e/i40e_flow.c b/drivers/net/intel/i40e/i40e_flow.c index cd598431e1..f130f53ae0 100644 --- a/drivers/net/intel/i40e/i40e_flow.c +++ b/drivers/net/intel/i40e/i40e_flow.c @@ -2364,8 +2364,7 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev *dev, next_dst_off += raw_spec->length; raw_id++; - memcpy(&filter->input.flow_ext.flex_pit[field_idx], - &flex_pit, sizeof(struct i40e_fdir_flex_pit)); + filter->input.flow_ext.flex_pit[field_idx] = flex_pit; filter->input.flow_ext.layer_idx = layer_idx; filter->input.flow_ext.raw_id = raw_id; filter->input.flow_ext.is_flex_flow = true; diff --git a/drivers/net/intel/i40e/rte_pmd_i40e.c b/drivers/net/intel/i40e/rte_pmd_i40e.c index 9d39984ea1..e620731199 100644 --- a/drivers/net/intel/i40e/rte_pmd_i40e.c +++ b/drivers/net/intel/i40e/rte_pmd_i40e.c @@ -2961,8 +2961,7 @@ i40e_queue_region_get_all_info(struct i40e_pf *pf, { struct i40e_queue_regions *info = &pf->queue_region; - rte_memcpy(regions_ptr, info, - sizeof(struct i40e_queue_regions)); + *regions_ptr = *info; return 0; } diff --git a/drivers/net/intel/ixgbe/ixgbe_flow.c b/drivers/net/intel/ixgbe/ixgbe_flow.c index 33da2f47ec..be8f3072fb 100644 --- a/drivers/net/intel/ixgbe/ixgbe_flow.c +++ b/drivers/net/intel/ixgbe/ixgbe_flow.c @@ -3142,9 +3142,7 @@ ixgbe_flow_create(struct rte_eth_dev *dev, if (fdir_rule.b_mask) { if (!fdir_info->mask_added) { /* It's the first time the mask is set. */ - rte_memcpy(&fdir_info->mask, - &fdir_rule.mask, - sizeof(struct ixgbe_hw_fdir_mask)); + *&fdir_info->mask = *&fdir_rule.mask; if (fdir_rule.mask.flex_bytes_mask) { ret = ixgbe_fdir_set_flexbytes_offset(dev, From patchwork Sat Feb 8 20:22:14 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 151205 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CC070461CD; Sat, 8 Feb 2025 21:34:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EB14A40A73; Sat, 8 Feb 2025 21:32:24 +0100 (CET) Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by mails.dpdk.org (Postfix) with ESMTP id E74D6409FA for ; Sat, 8 Feb 2025 21:32:20 +0100 (CET) Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-2fa4493a695so1021988a91.0 for ; Sat, 08 Feb 2025 12:32:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1739046740; x=1739651540; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=OaGGt1IzpilubFPyUaH3i0IX2QOhYcvHwgwphkkbYaU=; b=OPMWZUOrTMSJSWbL4rOBGG71YA4pqbsIl5T+Vm3RuNfdWkzXpIT9kq6hdeNB35EuPx xhAGHd+SzvEIxzBj/KaX32FCnQfRRJbIYSRiyI8JSTtCcYkU9rXaPgrDVefvxHFikgQA DX5i0281X6v2W/wwZJAbC0lSJdJLkHJZaDeWpxscRUjaSlJ7wBE0Kvitfa75zUPs6vOc XBbUopJBrnLG0ckthVhW7Kql6/qvluzpvFWMVeWnTasN+mnODObwmLe3tGYQTWSo8CFr jPFWAUqgXdPzFNSxvC3xF3X0n2Czv8fR0TW2s5u5EzbcSUg/ctLIaIxUYKG55P4gER7i VVWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739046740; x=1739651540; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=OaGGt1IzpilubFPyUaH3i0IX2QOhYcvHwgwphkkbYaU=; b=S7EfCisE8LmrhSIRS9EuI87BOhXni6Us4VR8cz4afJOTit+oq2EbuJBoSJqBxKFCDh U4ztqXSeSmdAO8ad8hYcuNN0BHsqa5nQvac3+CS0EkQCbPUpl9+h8Jw4CARO/S0VrLO8 5307rBXXTdf13LJrc0MGnnjeKm7MEu3OxgEc4UUBpTITx2xRriZ6EU1JDN875WE/cAzw jtFtJSOhEg7R9QQi4rrPywWa0kW/lqYocc4Rl1giX9/JQSl/0S47hHzzMII8Z35AxdZ5 oPbWJTmoTe8vgEEY5ZL/qWwHge0W77tFjdczA5OVpkwYNVHD9dBn2zKmkaUcYoomg6x3 3vrw== X-Gm-Message-State: AOJu0YwytPFJpPsNtd6MYiW1y2Jr1zucYH/2/9EHWUC6UhkcnjLK39jh Ur1x0zPJBLE3p3Mg/sxEOAOcOMzhnMOQqIV07JHFDrY688ey/mh+LCYgDqT97LML1pUQ1Q02kXw 2nvY= X-Gm-Gg: ASbGnctYBxHJrpz9eqfp/8xgbsYEaAsxyvCRIXWtjrOO/F/xJW07d3xCACUQUpwoO/Z hU7P5H5eVXgVf/9pZck740JNhslM+5lTqt6Y3FnA5G4j6cTfipG6Nh1Ov3NtDO6cHA6j04siOZs AqTEi6ND20d0sn1A2AUGob0Sp1oCsWq1OkEf0ETyG2Ngrbt1ZkSH/LhR9F2K4vL39lmLFGJePIk R+lUC10uUeXWd/5OB4Jr1c4Rl7459qZDstTJ6G2PApO4UHQXvf9wQXiL42uTHrU/hHdlDk6QeJk JoP4OGkRCDPaCO00Jr9VxjJDDvFoq6azKLN0F2Kf49ZwqpQ9D82QktGGfjBxJtduu/sv X-Google-Smtp-Source: AGHT+IF/CTIKax2wJ0mxAsMno2NnBFN2g90mcqRiIbzum+h/NcDhLLhuh00hEzUAJH8lhaHhAq6D3Q== X-Received: by 2002:a05:6a00:2385:b0:725:b201:2362 with SMTP id d2e1a72fcca58-7305d46849fmr11999388b3a.11.1739046740230; Sat, 08 Feb 2025 12:32:20 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7304c780da5sm4882019b3a.69.2025.02.08.12.32.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 12:32:19 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Chaoyong He Subject: [PATCH 22/32] net/nfp: replace memcpy with assignment Date: Sat, 8 Feb 2025 12:22:14 -0800 Message-ID: <20250208203142.242284-23-stephen@networkplumber.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250208203142.242284-1-stephen@networkplumber.org> References: <20250208203142.242284-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Prefer structure assignment over memcpy. Found by cocci/struct_assign.cocci Signed-off-by: Stephen Hemminger Acked-by: Chaoyong He --- drivers/net/nfp/flower/nfp_flower_representor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/nfp/flower/nfp_flower_representor.c b/drivers/net/nfp/flower/nfp_flower_representor.c index 9601aa5f96..ae0f082eb9 100644 --- a/drivers/net/nfp/flower/nfp_flower_representor.c +++ b/drivers/net/nfp/flower/nfp_flower_representor.c @@ -318,7 +318,7 @@ nfp_flower_repr_stats_get(struct rte_eth_dev *ethdev, struct nfp_flower_representor *repr; repr = ethdev->data->dev_private; - rte_memcpy(stats, &repr->repr_stats, sizeof(struct rte_eth_stats)); + *stats = repr->repr_stats; return 0; } From patchwork Sat Feb 8 20:22:15 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 151206 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1224461CD; Sat, 8 Feb 2025 21:34:09 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AF6CF40A87; Sat, 8 Feb 2025 21:32:26 +0100 (CET) Received: from mail-pj1-f51.google.com (mail-pj1-f51.google.com [209.85.216.51]) by mails.dpdk.org (Postfix) with ESMTP id 026E440A6B for ; Sat, 8 Feb 2025 21:32:22 +0100 (CET) Received: by mail-pj1-f51.google.com with SMTP id 98e67ed59e1d1-2fa488351ffso837593a91.3 for ; Sat, 08 Feb 2025 12:32:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1739046741; x=1739651541; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7oH5uTmmZlTeQlsWM1XMd+2q8kxfIxTDVtV/uIkhbvA=; b=fsOupnl9bQ7jmwGScY24zWPYGMXp98rhQZkL8Sd8z0rHX5MXGKFa5r6K1ixW2+2I/w PRrsHsiCHVb4fTfDvcSBHzUZ3S0mywz85B8vORSJ413Wwv2cXqEkLJqA5AHZEqtGQFEe EGjsKRvCYydTyecAM3YPe1XbkRNx5phMVbkI6SUkEaWRvTuAtqG/d7Q7hpTdTgNe09b2 GqRY6BG++ZvvCaDHOM7f21ZzBWt89O3JES9xvJOhnOjpz2ZUOkBazzOYxrLEI7AQbkPT RJ3VsD+bkQJP+VvFeDleUo4f5VdWBGTR8vKMUV2lRG7mJzSfNyv8ppJpv66huR7i8rm3 hz2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739046741; x=1739651541; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7oH5uTmmZlTeQlsWM1XMd+2q8kxfIxTDVtV/uIkhbvA=; b=cCkinVDHqkWOqv1X9I8B4XFTkXF/Cz6gD6dPLIoXUCwLJ+FpVGaW9nU3UY54FS1508 SuUU902MZS/xtaoPeScHTtktxQ8pmKfKBYsPsO6zQCijo+wkUtX7/QRG5DiLHD3YbRhC m/SgyN2QdnZkRP17PPvLUxpYLLnr/j9oduTJsH5qSV+XGqtY0CmPEuMwc9bniI7P6vkv d2Ib4eiANUCnPl2ftDmk3DGkSXIqzInA/qEtviYEkWAYgWoxTjGGzCASKrdq/51DgHXX LB/ShCHz0hJV2RrhiNfX4Ubt70ADMSdNxBzgSsekGStIy9CmrbzioPNU0bI/JlQLZQgv itjg== X-Gm-Message-State: AOJu0YyhtpKy0WzfI/7drP+YHCTzcx9peVLSGkrR/606W/ptpwAE43b8 VpAlPkM/IBUEqnTakkFqLxS8WsoGnpxFFVM3gfO7R5S8fbLw+48ua/7qPIkboiczWNO0tIZON1Y xX3I= X-Gm-Gg: ASbGncv5RagrfowJ4OejcaATdb6ltoCtYdcok64cmQYnVE6PtS53kukOrr587lyz2zi 9iD6f4MwD5vKdxtqDznXj6RkQkws1/FoyWHjivqdrGwj3fqhpYHZho0P6SFh1KUXALe2aOln8We CEk+0Q11dnWHnTcMMVYjgtmCl3NNrgjQ/OVxWg5iCflhr/Nx1rFO8M1K0W38O/kDIqhVAPI+2d4 acfXHwTMUHpzXUwwXltnKXO77ue2Ll+JD6yqMKp7OoUueLuwu/dwDUqcYA7GP6c9Iqw0ekOj2Gl /QAYSuIkIWz5yBU5/6nr95HVbb4dFF11wlyzu6bnDNMFwDcxZHfpt8OsOJU71WVxix9e X-Google-Smtp-Source: AGHT+IHhoea/QF1gQ9pTncIUa5FMJqvgbmB/JMfou++23reA63bYMhgxaTIbRo/xcyRDEkXahxQhQA== X-Received: by 2002:a05:6a00:2d8a:b0:727:3cd0:1167 with SMTP id d2e1a72fcca58-7305d5058cbmr11388620b3a.21.1739046741192; Sat, 08 Feb 2025 12:32:21 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7304c780da5sm4882019b3a.69.2025.02.08.12.32.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 12:32:20 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Jiawen Wu , Jian Wang Subject: [PATCH 23/32] net/txgbe: replace memcpy with assignment Date: Sat, 8 Feb 2025 12:22:15 -0800 Message-ID: <20250208203142.242284-24-stephen@networkplumber.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250208203142.242284-1-stephen@networkplumber.org> References: <20250208203142.242284-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Prefer structure assignment over memcpy. Found by cocci/struct_assign.cocci Signed-off-by: Stephen Hemminger --- drivers/net/txgbe/txgbe_flow.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/txgbe/txgbe_flow.c b/drivers/net/txgbe/txgbe_flow.c index 5d2dd45368..9e446c80c3 100644 --- a/drivers/net/txgbe/txgbe_flow.c +++ b/drivers/net/txgbe/txgbe_flow.c @@ -2827,9 +2827,7 @@ txgbe_flow_create(struct rte_eth_dev *dev, if (fdir_rule.b_mask) { if (!fdir_info->mask_added) { /* It's the first time the mask is set. */ - rte_memcpy(&fdir_info->mask, - &fdir_rule.mask, - sizeof(struct txgbe_hw_fdir_mask)); + fdir_info->mask = fdir_rule.mask; fdir_info->flex_bytes_offset = fdir_rule.flex_bytes_offset; From patchwork Sat Feb 8 20:22:16 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 151207 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 952EC461CD; Sat, 8 Feb 2025 21:34:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C8E6140B90; Sat, 8 Feb 2025 21:32:27 +0100 (CET) Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) by mails.dpdk.org (Postfix) with ESMTP id 374C340A71 for ; Sat, 8 Feb 2025 21:32:23 +0100 (CET) Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-2fa286ea7e8so2560777a91.2 for ; Sat, 08 Feb 2025 12:32:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1739046742; x=1739651542; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bBZ/zHLIbHgctJ6u3DxdG/kA5QApjdDY0ZTnoZTw5wk=; b=cbh21FZu9OEypd8UVLmZv7zLaiEpdcNzgY6Ks+glcG+OBTlTjcfnW/zb+x9QgmfHsK QS+85um8VP3BxmrHCZR/AS4nVKGO/dBnGlmKI7x/3bkUYp34ivC/g4T9xjYMWmJR+ko9 XoDCW3LOIONs8muayL6vQ6ow7ys64pyZhqP0uMtqOO9M1l+cLYqbHDb2Uc3DWsVUbNZD 6EmnkPWFLEgYroyH/QW7pYGWerPN0LDOPIB7NYoFV9mfcf9/x/4dTbbedU6l7HOkDzET yC5obKvuyoz69Bz+elEKK1or/3BYuYNlH+tuxO5tWkfD9hlQsGeRK+kZ01XA3qrQLgxg dUGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739046742; x=1739651542; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bBZ/zHLIbHgctJ6u3DxdG/kA5QApjdDY0ZTnoZTw5wk=; b=I4K/XS4MV+ZVmYvyGT7Vd2eo/dP74wOtRuUUzqc5/iC7qgGGj1k4QP7+4rJ7MhoGhq RyIbgfcaRLGIZ8u0dRq/7cBlgICX59DFIOka/2+bZLtWol6q87pEFh4gSgOygxE+1nrE Z6ljgr1wPiCqsCKUsZpEEy3C0pJdFQ8MuA6v1y37vAxvBwRlH+n7fVzaImz0+pc5pJOv sS9HcHRv7Osga0N9Vs7UsqBNINZFOWqZfoYGR+bpgCqT7ObVPz6qsCfA3tqpBjUca/Y6 Fn7Lp/nySwGlc+pwIcyvSUP9TIP3N9wVNtXAtdnvEXMqidnUwIs7cJmzRfdubxxm30Pp Zxng== X-Gm-Message-State: AOJu0YzERhYhN7gIzhoP0h8T9PaTStar/kcrvlSYfd4+z7E/nLJrrQMv d3ZvuXGxy5skBEGE+FbO7Ek2Tljyz9e3HC/rUifLsM77SvT3+by8NKZeJ5Wo4GzQUMBP3au7G9/ gWZ8= X-Gm-Gg: ASbGncsSDpUsnTSx41j0gC5BmxsNGabBvav//W5ytGab45+hXKmWKvifjOjNOvxWm6p fRcXSp6jYNQCtTjyqmrh8HBG8Msqz1hriLOZMGsXWYU5MromyufVdnim2VK+Fs1C3TcBAlWOK01 U+dmfG0Ap0/5ZWnCWA2Tr4zpbHZOdyFPC+J8qYs+VtNsMd2Y2cXg3KnZpr+hK0v0acE3ux7Az4b 3fmTUNcpKTbq3uGE/Fawl2zAvw1gGfW+oHJ+NHyPmz36DuNzN/1PKO/GwNATmecV+v7ujqx+DPs JrIkMWz3N/OShLsSYQwS+2wGfBm4aqn+xw4XUquYXTsZNZBzUxaUiAZZ9+Lc6vPUZpeF X-Google-Smtp-Source: AGHT+IEGIKKFGCcIdmaBhb3WOLh2wdtCkd5owUp9DAATt1CGGsetPbA7J7zpDDr1zdcjc2Vxb6F0QQ== X-Received: by 2002:aa7:88cb:0:b0:72f:d7ce:500f with SMTP id d2e1a72fcca58-7305d525eb4mr13082696b3a.21.1739046742269; Sat, 08 Feb 2025 12:32:22 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7304c780da5sm4882019b3a.69.2025.02.08.12.32.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 12:32:21 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Julien Aube Subject: [PATCH 24/32] net/bnx2x: replace memcpy with structure assignment Date: Sat, 8 Feb 2025 12:22:16 -0800 Message-ID: <20250208203142.242284-25-stephen@networkplumber.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250208203142.242284-1-stephen@networkplumber.org> References: <20250208203142.242284-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Prefer structure assignment over memcpy. Found by struct-assign.cocci. Signed-off-by: Stephen Hemminger --- drivers/net/bnx2x/bnx2x_stats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bnx2x/bnx2x_stats.c b/drivers/net/bnx2x/bnx2x_stats.c index 8adbe7e381..b14139c052 100644 --- a/drivers/net/bnx2x/bnx2x_stats.c +++ b/drivers/net/bnx2x/bnx2x_stats.c @@ -805,7 +805,7 @@ bnx2x_hw_stats_update(struct bnx2x_softc *sc) etherstatspktsover1522octets); } - memcpy(old, new, sizeof(struct nig_stats)); + *old = *new; memcpy(RTE_PTR_ADD(estats, offsetof(struct bnx2x_eth_stats, rx_stat_ifhcinbadoctets_hi)), &pstats->mac_stx[1], sizeof(struct mac_stx)); From patchwork Sat Feb 8 20:22:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 151208 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 54A7C461CD; Sat, 8 Feb 2025 21:34:19 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D540440B95; Sat, 8 Feb 2025 21:32:28 +0100 (CET) Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by mails.dpdk.org (Postfix) with ESMTP id B7D6340A71 for ; Sat, 8 Feb 2025 21:32:24 +0100 (CET) Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-2fa51743d80so596960a91.2 for ; Sat, 08 Feb 2025 12:32:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1739046744; x=1739651544; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=vJU00z5krNB8VFfDBOBUNZuyYjD5XdluTlMNoEB3Gwg=; b=2d1ucTDVROSWufHRwy44hIjqix96hce2+ZT4GZ/OwQypML3QpL2ADJjcpzB9Mo6H52 RRaVjN835mkupjCRIErgyz832xYU+i9zATAHL4dXQz/SDXdKA+wypLPri9aCmMlZ15hA cPExufGmEMHeOmHP9gehxOXTp/HqwjZCmSYNsClRORPQgqVtn6jJ8K/X9/ehkMk5nMU7 gxnyYWhFeWnLBHp6T/SCsk7hWBZz0sIVOOjoYbRs6Rmb371/cn6unJtswbfZgBA3fGbn 0O/FbF7zE97hGQYu5fhajz8sCG2QLs6LJXo3Ni/qgP4EOlh7Ti2/zLhDUCP3aOaUqY/d icvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739046744; x=1739651544; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vJU00z5krNB8VFfDBOBUNZuyYjD5XdluTlMNoEB3Gwg=; b=iiqQLiTSWPxelH7UwHb8BJdcKcth3RY19T11ppw+TW6xJ0nHjDTsztujdrhslHIwRA bw5Amhf098QZm7yzA9qLhw/4lXnaAgB47+sGWEiySnzvIovDs7aY0TO/j+51c8rZNZEl Nh225sbPMywb4hwnWXUwIIbD1EKnyBGrtuAV2+FmiE+eFRHoQppcK0/qLAYwRdYWC/PQ MaHYFiKeNBpgDUG8NXVDwsiB9ezhLvaXZRQWrVv4nc6KXg9ZUI6Wz2szMCZgSx0UX1Vx rwD7rKVYkQkwbiSk2mHq7t4pero3JjqfEl/Keiab0rQL2h0LsB22t4uIUpb7GIYlAImX FKcw== X-Gm-Message-State: AOJu0YxKoDjfR+Qef6uAKVNbiwz2yV14UnaTXDE5ytZ3SKDROiWlfqNc na/Vp0tR9yijzknBDcRs4bwO8vI58Y+yEIxFHkThoarAsDKRjAFIR28a+T5MxV5ZuMBCWI/QW/I UlwM= X-Gm-Gg: ASbGncuUXImJAEG4dps7bsswx7I+PeIP40R/f2Re0ABImLry1+KjaOTnA2Ox1FUZS6L ZMQuhe2PZAbkBSBo21YMKlq8MuKXDBmp8iQ1AZqjAHxz01zJu2d4ZdSKdmiFhAoaNaMpyWRgHfr LjuuTeryuyPNQrzW5Vn5SoLUbEAAC08ljgDRePanD/I4XuvtoZQMu7y/aXRtOkD7suGZJUpyqDH K1xxvoqWTYDtR4mr4ePeAWm3cx3EPzfzG1AlRh+rGFTDtHUug/FnldBtNn/ZedglZjahzNJkGXK RyCOk/rBKYq6PSG2bJBF2Kc5czm5OPWvnhzwRYSxOh4lFkD8jmFJkCB1cLSqh2q/awHQ X-Google-Smtp-Source: AGHT+IF2lYHY2rvg+et+loSg9Nzz2AQeTsoB7lGNXj6FWY8eHEncYHQW28+IHU6veyWnuVR9ZgBzFw== X-Received: by 2002:a05:6a00:a15:b0:727:d55e:4be3 with SMTP id d2e1a72fcca58-7305d463732mr12022558b3a.7.1739046743948; Sat, 08 Feb 2025 12:32:23 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7304c780da5sm4882019b3a.69.2025.02.08.12.32.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 12:32:22 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Hemant Agrawal , Sachin Saxena Subject: [PATCH 25/32] net/dpaa2: replace memcpy with structure assignment Date: Sat, 8 Feb 2025 12:22:17 -0800 Message-ID: <20250208203142.242284-26-stephen@networkplumber.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250208203142.242284-1-stephen@networkplumber.org> References: <20250208203142.242284-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Prefer structure assignment over memcpy. Found by struct-assign.cocci. Signed-off-by: Stephen Hemminger Acked-by: Hemant Agrawal --- drivers/net/dpaa2/dpaa2_ethdev.c | 5 ++--- drivers/net/dpaa2/dpaa2_flow.c | 9 +++------ 2 files changed, 5 insertions(+), 9 deletions(-) diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c index a9bce854c3..452d58ae28 100644 --- a/drivers/net/dpaa2/dpaa2_ethdev.c +++ b/drivers/net/dpaa2/dpaa2_ethdev.c @@ -2539,8 +2539,7 @@ populate_mac_addr(struct fsl_mc_io *dpni_dev, ret); goto cleanup; } - memcpy(&prime_mac, &phy_mac, - sizeof(struct rte_ether_addr)); + prime_mac = phy_mac; } } else if (rte_is_zero_ether_addr(&prime_mac)) { /* In case phys and prime, both are zero, create random MAC */ @@ -2555,7 +2554,7 @@ populate_mac_addr(struct fsl_mc_io *dpni_dev, } /* prime_mac the final MAC address */ - memcpy(mac_entry, &prime_mac, sizeof(struct rte_ether_addr)); + *mac_entry = prime_mac; return 0; cleanup: diff --git a/drivers/net/dpaa2/dpaa2_flow.c b/drivers/net/dpaa2/dpaa2_flow.c index c94eb51ba5..299c50dcdf 100644 --- a/drivers/net/dpaa2/dpaa2_flow.c +++ b/drivers/net/dpaa2/dpaa2_flow.c @@ -1008,8 +1008,7 @@ dpaa2_flow_faf_add_hdr(int faf_byte, if (pos != dpkg->num_extracts) { /* Not the last pos, must have IP address extract.*/ for (i = dpkg->num_extracts - 1; i >= pos; i--) { - memcpy(&extracts[i + 1], - &extracts[i], sizeof(struct dpkg_extract)); + extracts[i + 1] = extracts[i]; } } @@ -1063,8 +1062,7 @@ dpaa2_flow_pr_add_hdr(uint32_t pr_offset, if (pos != dpkg->num_extracts) { /* Not the last pos, must have IP address extract.*/ for (i = dpkg->num_extracts - 1; i >= pos; i--) { - memcpy(&extracts[i + 1], - &extracts[i], sizeof(struct dpkg_extract)); + extracts[i + 1] = extracts[i]; } } @@ -1118,8 +1116,7 @@ dpaa2_flow_extract_add_hdr(enum net_prot prot, if (pos != dpkg->num_extracts) { /* Not the last pos, must have IP address extract.*/ for (i = dpkg->num_extracts - 1; i >= pos; i--) { - memcpy(&extracts[i + 1], - &extracts[i], sizeof(struct dpkg_extract)); + extracts[i + 1] = extracts[i]; } } From patchwork Sat Feb 8 20:22:18 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 151209 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A2294461CD; Sat, 8 Feb 2025 21:34:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 07CC740A7A; Sat, 8 Feb 2025 21:32:30 +0100 (CET) Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by mails.dpdk.org (Postfix) with ESMTP id B2B9C40A7A for ; Sat, 8 Feb 2025 21:32:25 +0100 (CET) Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-2fa5af6d743so478688a91.3 for ; Sat, 08 Feb 2025 12:32:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1739046745; x=1739651545; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xRdpvpxDVZKFBK6eqg+ttncqs5Ud8HtjXdCbUeGdT+Y=; b=fGKXX0vCGopxekgQr3kkcX4cCi7TIpRHy1EXoMekkl+IqvBX78p8Du83PAnLYsvYe1 LbA0WOeJl87LYkyyvEfd2ieS4tqpfH+Q7ZTbdTpuy+ZSvEU09m8Je74gUmSMze9WS/t3 +luOD/DC7mMo0gkQjF7aihyLBsGF4trw+bzuC/EvKPpjwit29A5dbH0c9M7Bs6to6hnY 6R05x+Kcer7N2SwKx8Qyq0zo5uWZIp//LtE7cwRIUhjN0hDwh9guQ+K26rgHskKcQdqg lG6HDBLqs2eGb6BVjuZ6WRXJ65ZXRU54jupNZoGjF7qut3vJvOAXqO7daC6mMK+eAUWW 6bBA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739046745; x=1739651545; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xRdpvpxDVZKFBK6eqg+ttncqs5Ud8HtjXdCbUeGdT+Y=; b=og7Mzg7ZsE6XyVQ1dtwMiit+aw69/mVHcEn5zbDhnsjfMyW6vbE9CbjbGI01MkQXAO f3g0WCwKWSWQlRwd+JpGXVUzhNoEozGkIiFL4dfbEU7oGkOUp+garVa/IEg52ucHaYA/ JznuX4VKtppacxAP5mcC/oaeQJzbw7pgXCZLH36t3T7Yp303jGydXVUSbccd+WISoZEH 9A1BlQ5F+yDLhbrfVihqGx5lP0QAp0E4mJvG3lsJjXtk09N62yEU7c/X181Cw8u0tmQl 2nlM46o6b8/N6Vhn/iUqbRX3kCOddf/KH+37w+spl8apk3geSciM9CPyYgH/EKlere22 X2zg== X-Gm-Message-State: AOJu0YySU7AkbHwXMfrFGW75P+M67TW1Q59hJDw5pfck13hhnBuTZjCo 7WKeGF2h9d0r5rkFudro0V5Vz8DtiQdY2ioNg3GqcMQmwFSOG816BZX0Li2b8U9ovAmn0pfhbeR afAU= X-Gm-Gg: ASbGncsY6zne2rXqcunj/50SQ2Ls2jYl2qoHkp6BujkdCY+EqK7LlY76Auw+E0K4acQ fZWx7t0ADajpRrIcpcoGIywh+7EOMAymXT+sq53v4UyzVERlYyF40SfT73rXiXrOgaxpWAl1+Nd vygv9C1vWtT3w/I8xJZX8TWeUkyW02jlZS4a/iXopxXHPWHZgxTp3nYRTNzOm7UJcd6ctOQRKxc cLDRawtdFmzV08Fx6E/fOOvNmyfFk08IGLFoGj7jwqY0jGChGyf41EIU+IwssXKF/ZNDj/viyb+ HtkpxljJuVDv/dKCO7ERYwXcCsxHz0fd27dc8wQ6/6z2LeFgebPsdywUvw1qtW7+RhmU X-Google-Smtp-Source: AGHT+IHlZfHsGj2AHmv9ze7nzWVUWOaumLUnV8klbrXc9CHfWc9wqayOLldTRUkj7/Yt/TbjKPG3YQ== X-Received: by 2002:a05:6a00:2289:b0:725:460e:6bc0 with SMTP id d2e1a72fcca58-7305d2ac0admr14302757b3a.0.1739046744956; Sat, 08 Feb 2025 12:32:24 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7304c780da5sm4882019b3a.69.2025.02.08.12.32.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 12:32:24 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Chas Williams , "Min Hu (Connor)" Subject: [PATCH 26/32] net/bonding: replace memcpy with structure assignment Date: Sat, 8 Feb 2025 12:22:18 -0800 Message-ID: <20250208203142.242284-27-stephen@networkplumber.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250208203142.242284-1-stephen@networkplumber.org> References: <20250208203142.242284-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Prefer structure assignment over memcpy. Found by struct-assign.cocci. Signed-off-by: Stephen Hemminger --- drivers/net/bonding/rte_eth_bond_pmd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/bonding/rte_eth_bond_pmd.c b/drivers/net/bonding/rte_eth_bond_pmd.c index 467f7fe7ea..c8fcd4a172 100644 --- a/drivers/net/bonding/rte_eth_bond_pmd.c +++ b/drivers/net/bonding/rte_eth_bond_pmd.c @@ -3222,7 +3222,7 @@ bond_ethdev_rss_hash_update(struct rte_eth_dev *dev, struct bond_dev_private *internals = dev->data->dev_private; struct rte_eth_rss_conf bond_rss_conf; - memcpy(&bond_rss_conf, rss_conf, sizeof(struct rte_eth_rss_conf)); + bond_rss_conf = *rss_conf; bond_rss_conf.rss_hf &= internals->flow_type_rss_offloads; From patchwork Sat Feb 8 20:22:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 151210 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 97EFE461CD; Sat, 8 Feb 2025 21:34:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2368140B9A; Sat, 8 Feb 2025 21:32:31 +0100 (CET) Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) by mails.dpdk.org (Postfix) with ESMTP id C3ACB40A8A for ; Sat, 8 Feb 2025 21:32:26 +0100 (CET) Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-21c2f1b610dso78178945ad.0 for ; Sat, 08 Feb 2025 12:32:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1739046746; x=1739651546; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KlSMeuHPqlc7SgSwIiAjm4w0H9XCZs6cABq03Q3YF9E=; b=tk6TGFVLQYEwKlsvtSmCmWRLK56zhW7Q4F7zxZQXGmwYHIMVM4jADhpGvpr/xhrIEW Dv8YL7L//1JsN90NGnDyd59o3r5IjBog1hVoC2acNA92x08dCcT7+R5XqzLIv1pMGhBb gOTFiqWEsFRzI9PMyb48Vbirj4CL0GLv2YdZqiOb7+FzdvJuyF32FaJXWYLRm7zLItUM Nu0F9uvegDX3rCHyGDv9WXdoDTcl/skjpCVsxiG92B9W+eCO2N2hJAM8S0UNuJFOnsar xOrgkfjJntbdsAKNpgXKLojijPXhHGXTETTqVb+X4ykMYwLBUhquVaeV03QHaJd+VQd8 l0rQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739046746; x=1739651546; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KlSMeuHPqlc7SgSwIiAjm4w0H9XCZs6cABq03Q3YF9E=; b=gJ+PCwHzV8CahxF6TuHsGfgbHMz2J7SMLsCH21LOAw0QslpMBCy4WOKSY5eUZ4m/ZE ZXubI+FWDOwFqv95IJEq/4HmS8Q8yBZJ+hJqc5yd92fkezXntfyl/VjPwoI9ERMFUVse rZj4OiAldFmX5G1f/l2uiaGsSzY0Rwp37BOw4DRM+tD0DsHZZFIW7QvJX9zIkxSatE4r HFlDevmKNNvxCYp6XgB7XJjrmzmd+f/N4IF6z7HAVsLW6ccN8ZNT4AErsj9vYYgq4D8t kQ0QpAkEhpvwFq5jn91VxJ8jRpTL6DkRPIKDBh3lti402VnHFEefV/GjTcmFEpfoBcW4 EXZA== X-Gm-Message-State: AOJu0YwbOn8I1+D43XR1qxJ+9I4U0ayjFlW86BzqX3jBLMzc79UASWtc WSD51XE1FCxgSziYOrII9SnMtofz4eC3wfrX78PEXwrT26cnpKKrZOZttr3Bd+1vTVfjXMpJIym Nwb0= X-Gm-Gg: ASbGncuxHy05aR2CfkewH9Fb5xOM9DvlT2Gap4jD5ivEL6MPUdpjT/EMEPqHw9jLziE BxaJrzvAvD5473/WZJFxVRpDFBDGC6G6b0Bv9JAxKTZr7g+uKTZOWb7mkS0RfpwUi6+J2fvj/qd z2Yg/osc5yA/qxrM/fgVs/F26ZJgWxmcIHYCVeK4W/0fvxwOyQ7y7+XnI+bFzB1bugd+j2EXizv YHsL0mHr9S2anYDrIgjYBZwmZTuKPt70csx3mbTrjrwRO5nIHnDpWCqXhkAaMs3YFMVg4JpJy3/ AvWyPb57ePYtTm3vNyzm7ZcmZa4JCs/lPgDbTzLVfesPrIwyyGUomlGXzvzP2m3ievjO X-Google-Smtp-Source: AGHT+IH8Q5INUPz67DgAYHpFk3dAtKy1HLyuvMjB+TJNrjsc8FTO7Z5TDI8Ik9hFNcvsBGSeG9JKVw== X-Received: by 2002:a05:6a21:99a6:b0:1ed:a4c2:a639 with SMTP id adf61e73a8af0-1ee03a3b9ebmr13176554637.10.1739046746050; Sat, 08 Feb 2025 12:32:26 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7304c780da5sm4882019b3a.69.2025.02.08.12.32.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 12:32:25 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , Harman Kalra Subject: [PATCH 27/32] net/cnxk: replace memcpy with structure assignment Date: Sat, 8 Feb 2025 12:22:19 -0800 Message-ID: <20250208203142.242284-28-stephen@networkplumber.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250208203142.242284-1-stephen@networkplumber.org> References: <20250208203142.242284-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Prefer structure assignment over memcpy. Found by struct-assign.cocci. Signed-off-by: Stephen Hemminger --- drivers/net/cnxk/cnxk_ethdev_cman.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/cnxk/cnxk_ethdev_cman.c b/drivers/net/cnxk/cnxk_ethdev_cman.c index a7ccdfb756..75cbad02c4 100644 --- a/drivers/net/cnxk/cnxk_ethdev_cman.c +++ b/drivers/net/cnxk/cnxk_ethdev_cman.c @@ -140,6 +140,6 @@ cnxk_nix_cman_config_get(struct rte_eth_dev *eth_dev, struct rte_eth_cman_config { struct cnxk_eth_dev *dev = cnxk_eth_pmd_priv(eth_dev); - memcpy(config, &dev->cman_cfg, sizeof(struct rte_eth_cman_config)); + *config = dev->cman_cfg; return 0; } From patchwork Sat Feb 8 20:22:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 151212 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B92C0461CD; Sat, 8 Feb 2025 21:34:41 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 17E5240DD0; Sat, 8 Feb 2025 21:32:34 +0100 (CET) Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) by mails.dpdk.org (Postfix) with ESMTP id 8B6E740A7A for ; Sat, 8 Feb 2025 21:32:29 +0100 (CET) Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-21f61b01630so20262015ad.1 for ; Sat, 08 Feb 2025 12:32:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1739046749; x=1739651549; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=2KQseYG6QECDUj8QEStbcHmCDX44V8vT5WT+KPdm/j4=; b=S6k/VKlYv8bRSvd3zSFlAlnIagRRC9iuOqw8B8RTuHJMtmi6KKJrXBUIb3fEFuiG6g tX678mGrgzyr2hnAnaD0esZeodG9epNtxzMMeyFdHirFKUwY0vsrnhKB/qtlK3tEdsyu wncYPcogB4XK9pzE2PfzREaI/NY/Uv+0W69280t/WxLFuPFEQbbC3vHza1ebwfSUNUld WrYyoo2kIPWZmPuiol/FDJYQ3oMbnytPv87w2bJHyMMsdxR+uoPYI9TbNOWShtVVHsD5 HTvLDjEWWsg7B6sts4KQHdIpBxC1cSFAnyJEnW03WKO9s+fw1uPqIXQOCDZLuI/xpQ6R cNow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739046749; x=1739651549; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2KQseYG6QECDUj8QEStbcHmCDX44V8vT5WT+KPdm/j4=; b=EjWF7bxKAhfp+WsgZhP2vvbXi2UM0UGEemGupurcZqoSHGMMZznV5KzASMMfxvCMOI L6ym30TzB5fkVCeO/2hvdiNH2cM1nTn738BfXPhK2aXG30Jttb0baM6HuMMFeVNIBvJp vjdAlVzk9vy+8qtsxPSar+cDxzUG97iX6aR3KJp3qZaOpAPtHnwvkC/Mdp39bVGYMM9Q i20d2uMsX5HztYhknhZcqH/YATVv41ijPLtMwmjam3AbPVloDs+2GpFs+/OE2imEcTzw gut2IS5jEpLawGGclFSDXSnEhJAkg6RLnnSvmet6I6/4iCQtCZ2FHhgEk5SDHNqn6RB4 +hpQ== X-Gm-Message-State: AOJu0Yw1oZnHloYqMBDEsHYrFgv3PhaOwM4DbkwgPXR6XAMq19Ypz3AT I4awn7xZd/xXT87mxo/Uvuf4abMLWm8KfdIcHFbMp6gRoVORO0hHrxNSO10gqteVbA/jmS4GaDM S3zQ= X-Gm-Gg: ASbGncvBkoL6Dct/3yBMRhwaGUQJAPsLc8ald7NbSjIgE/85coYXfw+0T6FjZJxlO4m 0H/hAn2WCD+2sFrWI6JawrV+mR/CI0pv/yYVgqJ/wDFcQVg9e+BMVxPc1e017zoeCtGOeDl0SR0 V+v3AnO/rcOSOY3wwNVq/110cuQGZyTEXJgTXoIbZRGACacCNYEWq07CXrnH/xEPOS8mRCb3b1X QQCpLFvHMAMbPjys2tZ8CmTjnWJQd0zzRuQgW3RAHrNz20ROyMuaA9sx+Dz9N+nWizkbkCErERx pZ9tx7cBt+gjnZVOVzUkfvlzZL8ipn7d19DnJ4Hw//zSLhgpeGtS0ATEcbf39tYbpFHc X-Google-Smtp-Source: AGHT+IGTby3d6xsDNL4YwjJ8cjqaemaznLNWN3LkNCzcSQECOvR/+H/b1L8ltjImvfUVEibGALGUzQ== X-Received: by 2002:a05:6a20:c709:b0:1e1:a789:1b4d with SMTP id adf61e73a8af0-1ee0539cdd0mr12059430637.15.1739046747272; Sat, 08 Feb 2025 12:32:27 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7304c780da5sm4882019b3a.69.2025.02.08.12.32.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 12:32:26 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , John Daley , Hyong Youb Kim Subject: [PATCH 28/32] net/enic: replace memcpy with structure assignment Date: Sat, 8 Feb 2025 12:22:20 -0800 Message-ID: <20250208203142.242284-29-stephen@networkplumber.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250208203142.242284-1-stephen@networkplumber.org> References: <20250208203142.242284-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Prefer structure assignment over memcpy. Found by struct-assign.cocci. Signed-off-by: Stephen Hemminger --- drivers/net/enic/enic_fm_flow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/enic/enic_fm_flow.c b/drivers/net/enic/enic_fm_flow.c index 8988148454..c2c3e55206 100644 --- a/drivers/net/enic/enic_fm_flow.c +++ b/drivers/net/enic/enic_fm_flow.c @@ -2590,7 +2590,7 @@ enic_action_handle_get(struct enic_flowman *fm, struct fm_action *action_in, return rte_flow_error_set(error, ENOMEM, RTE_FLOW_ERROR_TYPE_HANDLE, NULL, "enic: calloc(fm-action)"); - memcpy(&ah->key, action_in, sizeof(struct fm_action)); + ah->key = *action_in; args[0] = FM_ACTION_ALLOC; args[1] = fm->cmd.pa; ret = flowman_cmd(fm, args, 2); From patchwork Sat Feb 8 20:22:21 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 151211 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AF0C6461CD; Sat, 8 Feb 2025 21:34:34 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8BA9040BA2; Sat, 8 Feb 2025 21:32:32 +0100 (CET) Received: from mail-pj1-f43.google.com (mail-pj1-f43.google.com [209.85.216.43]) by mails.dpdk.org (Postfix) with ESMTP id 2FF7640B9A for ; Sat, 8 Feb 2025 21:32:29 +0100 (CET) Received: by mail-pj1-f43.google.com with SMTP id 98e67ed59e1d1-2fa19e1d027so3545710a91.0 for ; Sat, 08 Feb 2025 12:32:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1739046748; x=1739651548; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TFP884Oj2lBUZmtdtMpIv0LWkx4rU5WlVkkWd1wQ+iE=; b=AyKXn6lXrnKsGnmVXEZNlGiNQbmCnY48u9FcbSNdg37OZtsEWXUeMTdwLDnBJCPaDF xkZDsqMYs6uMcnNh3njPG/iauAc1fui/K8Owk5a0XvGf+FDy7Yb01zy2LpOk0jVr0B9h aMPipy1x3pu4wR70wbiwN1015b+UDE4/irjbZRW4tHCdFYmwA1/rKx8R+78wg1tMmnVZ dXJWAVYmF42GMYKiXDTiNwmfc7eLJKmCyhsGbVuuqvmD7V9KOj7Ah2sRZ/dTiH470qye bdoNwzCEOiktM8o8gkWhPl+x7DePPX7X/fMRVYcLXqHqXpl1rurf4duEJe3IMrdX+awj lMkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739046748; x=1739651548; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TFP884Oj2lBUZmtdtMpIv0LWkx4rU5WlVkkWd1wQ+iE=; b=TyqYRnj3FPnO0v68YJP8KkPJKkQCGTCYh5zAFsJSwvitr8TSu9OhiFnI35hKHvHcY3 Ah9l2kMSbv4i0K8aeerUbRd48FaomUT4rpxLZAUMdw9fpCtX4E3zt2YRTBsIqkAPjdnB mjFIlWFtO2XL19UNMSiLq4OnvUaQRLbcPPyiTw+55A+DBrbB/J32CSK/Ak69vevMQsIa zPzX7j7YPrAcbLRTL9q6wzT/4pyP7mXqWcV/kEoe3EwtBp6eo72K7q6RcSAkwLDANAFK 1QRnt6Rtxvd3SK3GrpnS/KilQkBu2Blpilp/Kh5le8x1YlUPKeHgtKYO1vFOtg4sCmsi oa7g== X-Gm-Message-State: AOJu0YznvioSO8ar5EBIQwdNtf0s6SxOpjHIjIifTZ31z6Dg4Aqe+LYy mDfHwQEGFIHLrNvLsoLUFPUfR88rtkL/ZQpEtCSfgAy2nxyhDQ0l6u9Qri4rQcOIe9MAkeYBE20 +Dww= X-Gm-Gg: ASbGncs9q7R5H677qgOTaMrHPy6PxpAAi5liClG1HKpTo+LxxPPp/zqX67l/orTRIR+ kRygLZEJzDaaRpD/fCWpGAbIp5pgfrcNF7DwI23/H3pc4YOHvM93S0fmfG262ctXy6glNSbXVNt gqd8hGvlvrPCs9QoYhzkhQ0wLPLiSmgTfOAG63jjDQXmrOcnc2TnOwRnmtXGw3lL9K0aaBvRe2t hIvQpHcP5y6/TboLYYLZlodjDHgXtJR1iNhGvMnZvpfdC8LhlkyH3MkfJXhDDziS8EkNsxDCOLh JpcTpRk8cCPPCq1fzbtI6J+VygG4UZaGJK2PzXqnfrumEepQc9IAJdaN06z+lpHIVXsu X-Google-Smtp-Source: AGHT+IGQcF0suXuNFZt2z5qJLteSo+1Rcovq2mUNOX+PBPsFfoeEI/H55TzlNWQGJtz35XaUImd7mQ== X-Received: by 2002:a05:6a00:1884:b0:724:f8d4:2b6e with SMTP id d2e1a72fcca58-7305d43a8b1mr14508431b3a.4.1739046748400; Sat, 08 Feb 2025 12:32:28 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7304c780da5sm4882019b3a.69.2025.02.08.12.32.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 12:32:27 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Vladimir Medvedkin , Ian Stokes Subject: [PATCH 29/32] net/iavf: replace memcpy with structure assignment Date: Sat, 8 Feb 2025 12:22:21 -0800 Message-ID: <20250208203142.242284-30-stephen@networkplumber.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250208203142.242284-1-stephen@networkplumber.org> References: <20250208203142.242284-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Prefer structure assignment over memcpy. Found by struct-assign.cocci. Signed-off-by: Stephen Hemminger --- drivers/net/intel/iavf/iavf_ipsec_crypto.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/intel/iavf/iavf_ipsec_crypto.c b/drivers/net/intel/iavf/iavf_ipsec_crypto.c index 90421a66c3..d5bfbecf08 100644 --- a/drivers/net/intel/iavf/iavf_ipsec_crypto.c +++ b/drivers/net/intel/iavf/iavf_ipsec_crypto.c @@ -1139,8 +1139,7 @@ iavf_ipsec_crypto_pkt_metadata_set(void *device, struct iavf_ipsec_crypto_pkt_metadata *); /* Set immutable metadata values from session template */ - memcpy(md, &iavf_sess->pkt_metadata_template, - sizeof(struct iavf_ipsec_crypto_pkt_metadata)); + *md = iavf_sess->pkt_metadata_template; esp_tail = iavf_ipsec_crypto_get_esp_trailer(m, iavf_sess, &esp_trailer_length); From patchwork Sat Feb 8 20:22:22 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 151213 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E9D02461CD; Sat, 8 Feb 2025 21:34:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 37BFA40DD6; Sat, 8 Feb 2025 21:32:35 +0100 (CET) Received: from mail-pj1-f52.google.com (mail-pj1-f52.google.com [209.85.216.52]) by mails.dpdk.org (Postfix) with ESMTP id 28EA040B92 for ; Sat, 8 Feb 2025 21:32:30 +0100 (CET) Received: by mail-pj1-f52.google.com with SMTP id 98e67ed59e1d1-2fa21145217so4309208a91.3 for ; Sat, 08 Feb 2025 12:32:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1739046749; x=1739651549; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=sg76zCYgTOR9gfS3lia7wWJJOv9HAGuTBZmYnGP1OD8=; b=TxNPX79A/qKT/lQ2a1YAy+YpShmxiF5zGCUSQ6p063C/zZ7V/uROfS5BrkCXtkpbIq AqnZV7Zs42KLZZCFfLERPc9rVMZ3CcR+n5GMt0/gPSM33t1lVYXc7OIy5GMrIuS62P7J DQtl8CtQ3f93Mv1vOZQrr5J9GzyA6ru2TAh1iWkBNcsADwvuHAji3g7Vp7lin3NWzRKj sNfkdscwwHsdyeI08z+rW2C1bQW7DrkZY6NLT5LSTIMw5FlqrT7Hv/AbAaby+Ujk6tpU Qxn/4Kg0Mlq5U6Z+Ek1R/lw0nlP4RCyZSOPGPK1AjWPnp5rKotnP+C2JIG15IOm/UDg5 IM/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739046749; x=1739651549; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sg76zCYgTOR9gfS3lia7wWJJOv9HAGuTBZmYnGP1OD8=; b=cxtHr/FIQ5YSoPPtRLMi7fQAzKVKKj2p5LsU9ZBUylCioPPD85qQr3hJTVxQam9CKF IiHhfNDFYHze3tsmgY6n8a8bPfl78lsue0Y3VPJVsx+LJjggfymPGWNqbZBa4U5fLD6G PsBTqRVVPoIC3d1t4ZTMIQZG+PKHwlf5GjtcR3cbutDh4dBQyVdEwSluC8EsBfBuyCvD mvSWf6SXfS4ldSPnYVuCFM+mzRfBaFRVgHjGv0cGh7KJdOWq10LSdJqD0PIaZ5ACmu7U DmN7qkv7+N/FlXaMYvlJexSNTHAk1Wiq7EMOzSdEK9u4dStRQ5h/QpIJ5JKPVk3for7P ZKCg== X-Gm-Message-State: AOJu0YxL9R4EDY8Lrt+gHmLEy3YV+XToWbNw6fesdtNESsFMlx0CXP3K N5QHME/75h6e2grWNf1+AUwT2QqM2zPrJEZZ2v3696utk7nGmf3R+xEK3mQkoeTIbuLP0E2QyMF Tpog= X-Gm-Gg: ASbGncuQGNTWzGouhJEf7/p8QtKG60U7xw+FHI/KzeMHLw3ETpKf5K8Hb6d7PUCin++ B/m8cmL1RejGNDAj1eQew5P9GgUvpGS7k0Z5VOTcbUivwJBEzkYh//IjpEbZ5MZw0B4UdN482OA 4BIKnIJ4KmR+1/Do53+u3Oyg7mO5tpoL2nMoX6zaTtmB2s4vrTl0vGYDU8C7gg7gv1Ttf5wOX8K 7o1wAm9A4hIGwiGP2fNewMpImwU4T8Vz0ZzLTmWy21ciryGaKSpV9ausitRODhBmVYez932vLYb 3+Emn/1KLB6WSPsfMr+g1x3uHrVunemlwez9YTCwl/4ycRaT0N8/U9S3bxgGTJdkv03E X-Google-Smtp-Source: AGHT+IF0CLJgNUMQS1rd0t7f8EZuEDsSf+OCu62oENzCqDLhq6avu8ysYRuq6bQ3e0skkcjOPakUEA== X-Received: by 2002:a05:6a00:1890:b0:728:ea15:6d68 with SMTP id d2e1a72fcca58-7305d51c70dmr13092394b3a.18.1739046749380; Sat, 08 Feb 2025 12:32:29 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7304c780da5sm4882019b3a.69.2025.02.08.12.32.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 12:32:28 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Bruce Richardson , Anatoly Burakov Subject: [PATCH 30/32] net/ice: replace memcpy with structure assignment Date: Sat, 8 Feb 2025 12:22:22 -0800 Message-ID: <20250208203142.242284-31-stephen@networkplumber.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250208203142.242284-1-stephen@networkplumber.org> References: <20250208203142.242284-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Prefer structure assignment over memcpy. Found by struct-assign.cocci. Signed-off-by: Stephen Hemminger --- drivers/net/intel/ice/ice_hash.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/intel/ice/ice_hash.c b/drivers/net/intel/ice/ice_hash.c index 00d65bc637..aa6a21c055 100644 --- a/drivers/net/intel/ice/ice_hash.c +++ b/drivers/net/intel/ice/ice_hash.c @@ -1309,8 +1309,7 @@ ice_hash_create(struct ice_adapter *ad, goto out; } else { if (rss_meta->raw.raw_ena) { - memcpy(&filter_ptr->rss_cfg.raw, &rss_meta->raw, - sizeof(struct ice_rss_raw_cfg)); + filter_ptr->rss_cfg.raw = rss_meta->raw; ret = ice_hash_add_raw_cfg(ad, &rss_meta->raw, pf->main_vsi->idx); if (ret) { @@ -1321,8 +1320,7 @@ ice_hash_create(struct ice_adapter *ad, goto error; } } else { - memcpy(&filter_ptr->rss_cfg.hash, &rss_meta->cfg, - sizeof(struct ice_rss_hash_cfg)); + filter_ptr->rss_cfg.hash = rss_meta->cfg; ret = ice_add_rss_cfg_wrap(pf, vsi->idx, &filter_ptr->rss_cfg.hash); if (ret) { From patchwork Sat Feb 8 20:22:23 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 151214 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 74F1F461CD; Sat, 8 Feb 2025 21:34:52 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 52A0A40A7D; Sat, 8 Feb 2025 21:32:36 +0100 (CET) Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by mails.dpdk.org (Postfix) with ESMTP id 81A0340B9F for ; Sat, 8 Feb 2025 21:32:31 +0100 (CET) Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2166651f752so71917915ad.3 for ; Sat, 08 Feb 2025 12:32:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1739046751; x=1739651551; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=fUR6XHuFBoNaJfR2km4oqUrluHfeQKp4ZjjOi5tuAj0=; b=iWxA2kz64D4pBkGrGE/RlVVlgSTKWwynw6J8pkFEh96Anm6yiB/W9d1xG8C1UHoWQL Ah7sFvscIugpYZBdKiC7Fu7qJGHiXZbMkOtP+lyx8Q+hmgU556a3QQgZJyLGj9v+Egu9 TUOptubeddqGDpNycHTlOBtTEK2WtbQg9duNK9vtpECYV3UWwalfRcRwrTT7F0RAievi UZymzveBBUnwiUHanWMY906jyF1pQkfrMo/7JRkAVjVMHLCdCVr1OL1fbP9++y5qogYw qsV8ENV0k14YPdIHgbB8+4mPRunrEl1RQ41BpUQspSNJVaIwFa+NESEWGatvZE2VV+Nk cKzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739046751; x=1739651551; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=fUR6XHuFBoNaJfR2km4oqUrluHfeQKp4ZjjOi5tuAj0=; b=T4cfFD6vSuIPOS6ghVuNMsbw1VRLqakJzJzBdO6mYbgSLxkBsOpTBS/vPLqDdZKql8 5zaOr8Hgt90A+kPF+c8JLdkcQNW/t9dlF+JQ8r8MkreEKWlafufTFGOQSeBaHGG93rvN wruItVKAzNRNn00jEO4hStFxRDH3w3H82pdI8hICuU3PSqaXcpxkHC0s6HsYyiWd3Ruh SJ308I1w6GU+BsXQVnk13YjeMcqsQ3fW1tOa/WiqxUTp3mVa/KEn2XaRYc4n3b2ZFWtw RV8Pb08rgJ8YFFndBp/U/OYbI9mOAfwAhZSiypsSZddrtgHe1Z9RLH7GVXuebCRZWsBv fIJg== X-Gm-Message-State: AOJu0YxKUPrXptFXszEiZHYUAXpCFI6/rARD0UBM/BV3wKhe0i7wNTFX 9g6jQG53zp0fCrAMRq+lSPGUurghRsA9jOxIQOOJwdk3GBNUhwAXt1RU9XYkE0soSurjPZR1hzc vfGM= X-Gm-Gg: ASbGncstPeCyhmGzKn/hIl+e6Eh0eKUZ3yPrqUpKkTKKYaY41pWdBUD3M3Lt+evIby/ e05DLfrwTMgf9FYiFppY8uly4Lgnls/WIoMiFHfJqimqW5UTx2+uOHU+1lInvuyI+gobinr7wWS xpHYSZpmxIn9uXd34mM0jG+8SWTaCqy4VoRhb1So3JeJd7YFhx/T3rVv6mj8YRUVV9Ztkpzr/f5 z544deekq7XIFZBGymOMzNMWhvqN9864rkZVci4lvKQzPojV7142/MjObVQCQGkI1/fkj3BX3Gl T7RZR/EUL4OM6XhtP0a8iZbr+TYm3YuV1qi0m3nl04ty2XneOBH4dup7SV2bEomQn8iD X-Google-Smtp-Source: AGHT+IFPx9A1InrMjgl4jGbs0IQFhjx2RVCI22vOM5aqcqnDCPIzORqIZ+zgad7TaUv1RBroONfPjg== X-Received: by 2002:a05:6a20:6f88:b0:1e1:becc:1c91 with SMTP id adf61e73a8af0-1ee03b42a5cmr13811063637.28.1739046750753; Sat, 08 Feb 2025 12:32:30 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7304c780da5sm4882019b3a.69.2025.02.08.12.32.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 12:32:29 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Konstantin Ananyev , Fan Zhang , Ashish Gupta , Akhil Goyal , Anoob Joseph Subject: [PATCH 31/32] test: replace memcpy with structure assignment Date: Sat, 8 Feb 2025 12:22:23 -0800 Message-ID: <20250208203142.242284-32-stephen@networkplumber.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250208203142.242284-1-stephen@networkplumber.org> References: <20250208203142.242284-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Prefer structure assignment over memcpy. Found by struct-assign.cocci. Signed-off-by: Stephen Hemminger --- app/test/test_acl.c | 5 ++-- app/test/test_compressdev.c | 36 +++++++++------------------ app/test/test_security_inline_proto.c | 23 +++++++---------- 3 files changed, 23 insertions(+), 41 deletions(-) diff --git a/app/test/test_acl.c b/app/test/test_acl.c index 503ff08894..43d13b5b0f 100644 --- a/app/test/test_acl.c +++ b/app/test/test_acl.c @@ -1223,8 +1223,7 @@ test_create_find_add(void) /* create dummy acl */ for (i = 0; i < LEN; i++) { - memcpy(&rules[i], &acl_rule, - sizeof(struct rte_acl_ipv4vlan_rule)); + rules[i] = acl_rule; /* skip zero */ rules[i].data.userdata = i + 1; /* one rule per category */ @@ -1286,7 +1285,7 @@ test_invalid_rules(void) * such rules. */ /* create dummy acl */ - memcpy(&rule, &acl_rule, sizeof(struct rte_acl_ipv4vlan_rule)); + rule = acl_rule; rule.data.userdata = 1; rule.dst_port_low = 0xfff0; rule.dst_port_high = 0x0010; diff --git a/app/test/test_compressdev.c b/app/test/test_compressdev.c index 81b8e02006..c217ad6cda 100644 --- a/app/test/test_compressdev.c +++ b/app/test/test_compressdev.c @@ -346,8 +346,7 @@ test_compressdev_invalid_configuration(void) RTE_LOG(INFO, USER1, "This is a negative test, errors are expected\n"); /* Invalid configuration with 0 queue pairs */ - memcpy(&invalid_config, &valid_config, - sizeof(struct rte_compressdev_config)); + invalid_config = valid_config; invalid_config.nb_queue_pairs = 0; TEST_ASSERT_FAIL(rte_compressdev_configure(0, &invalid_config), @@ -360,8 +359,7 @@ test_compressdev_invalid_configuration(void) */ rte_compressdev_info_get(0, &dev_info); if (dev_info.max_nb_queue_pairs != 0) { - memcpy(&invalid_config, &valid_config, - sizeof(struct rte_compressdev_config)); + invalid_config = valid_config; invalid_config.nb_queue_pairs = dev_info.max_nb_queue_pairs + 1; TEST_ASSERT_FAIL(rte_compressdev_configure(0, &invalid_config), @@ -2188,8 +2186,7 @@ test_compressdev_deflate_stateless_fixed(void) goto exit; } - memcpy(compress_xform, ts_params->def_comp_xform, - sizeof(struct rte_comp_xform)); + *compress_xform = *ts_params->def_comp_xform; compress_xform->compress.deflate.huffman = RTE_COMP_HUFFMAN_FIXED; struct interim_data_params int_data = { @@ -2260,8 +2257,7 @@ test_compressdev_deflate_stateless_dynamic(void) goto exit; } - memcpy(compress_xform, ts_params->def_comp_xform, - sizeof(struct rte_comp_xform)); + *compress_xform = *ts_params->def_comp_xform; compress_xform->compress.deflate.huffman = RTE_COMP_HUFFMAN_DYNAMIC; struct interim_data_params int_data = { @@ -2372,8 +2368,7 @@ test_compressdev_deflate_stateless_multi_level(void) goto exit; } - memcpy(compress_xform, ts_params->def_comp_xform, - sizeof(struct rte_comp_xform)); + *compress_xform = *ts_params->def_comp_xform; struct interim_data_params int_data = { NULL, @@ -2442,8 +2437,7 @@ test_compressdev_deflate_stateless_multi_xform(void) goto exit; } - memcpy(compress_xforms[i], ts_params->def_comp_xform, - sizeof(struct rte_comp_xform)); + *compress_xforms[i] = *ts_params->def_comp_xform; compress_xforms[i]->compress.level = level; level++; @@ -2456,8 +2450,7 @@ test_compressdev_deflate_stateless_multi_xform(void) goto exit; } - memcpy(decompress_xforms[i], ts_params->def_decomp_xform, - sizeof(struct rte_comp_xform)); + *decompress_xforms[i] = *ts_params->def_decomp_xform; } for (i = 0; i < NUM_XFORMS; i++) { @@ -2614,8 +2607,7 @@ test_compressdev_deflate_stateless_checksum(void) return TEST_FAILED; } - memcpy(compress_xform, ts_params->def_comp_xform, - sizeof(struct rte_comp_xform)); + *compress_xform = *ts_params->def_comp_xform; struct rte_comp_xform *decompress_xform = rte_malloc(NULL, sizeof(struct rte_comp_xform), 0); @@ -2625,8 +2617,7 @@ test_compressdev_deflate_stateless_checksum(void) return TEST_FAILED; } - memcpy(decompress_xform, ts_params->def_decomp_xform, - sizeof(struct rte_comp_xform)); + *decompress_xform = *ts_params->def_decomp_xform; struct interim_data_params int_data = { NULL, @@ -2960,8 +2951,7 @@ test_compressdev_deflate_stateful_decomp_checksum(void) return TEST_FAILED; } - memcpy(compress_xform, ts_params->def_comp_xform, - sizeof(struct rte_comp_xform)); + *compress_xform = *ts_params->def_comp_xform; struct rte_comp_xform *decompress_xform = rte_malloc(NULL, sizeof(struct rte_comp_xform), 0); @@ -2971,8 +2961,7 @@ test_compressdev_deflate_stateful_decomp_checksum(void) return TEST_FAILED; } - memcpy(decompress_xform, ts_params->def_decomp_xform, - sizeof(struct rte_comp_xform)); + *decompress_xform = *ts_params->def_decomp_xform; struct interim_data_params int_data = { &compress_test_bufs[0], @@ -3186,8 +3175,7 @@ test_compressdev_deflate_stateless_fixed_oos_recoverable(void) goto exit; } - memcpy(compress_xform, ts_params->def_comp_xform, - sizeof(struct rte_comp_xform)); + *compress_xform = *ts_params->def_comp_xform; compress_xform->compress.deflate.huffman = RTE_COMP_HUFFMAN_FIXED; struct interim_data_params int_data = { diff --git a/app/test/test_security_inline_proto.c b/app/test/test_security_inline_proto.c index 480469f672..04ecfd02c6 100644 --- a/app/test/test_security_inline_proto.c +++ b/app/test/test_security_inline_proto.c @@ -858,7 +858,7 @@ test_ipsec_with_rx_inject(struct ip_pkt_vector *vector, const struct ipsec_test_ burst_sz = vector->burst ? ENCAP_DECAP_BURST_SZ : 1; nb_tx = burst_sz; - memcpy(&sa_data, vector->sa_data, sizeof(struct ipsec_test_data)); + sa_data = *vector->sa_data; sa_data.ipsec_xform.direction = RTE_SECURITY_IPSEC_SA_DIR_EGRESS; outer_ipv4 = is_outer_ipv4(&sa_data); @@ -873,7 +873,7 @@ test_ipsec_with_rx_inject(struct ip_pkt_vector *vector, const struct ipsec_test_ } for (i = 0; i < burst_sz; i++) { - memcpy(&sa_data, vector->sa_data, sizeof(struct ipsec_test_data)); + sa_data = *vector->sa_data; /* Update SPI for every new SA */ sa_data.ipsec_xform.spi += i; sa_data.ipsec_xform.direction = RTE_SECURITY_IPSEC_SA_DIR_EGRESS; @@ -901,7 +901,7 @@ test_ipsec_with_rx_inject(struct ip_pkt_vector *vector, const struct ipsec_test_ } for (i = 0; i < burst_sz; i++) { - memcpy(&sa_data, vector->sa_data, sizeof(struct ipsec_test_data)); + sa_data = *vector->sa_data; /* Update SPI for every new SA */ sa_data.ipsec_xform.spi += i; sa_data.ipsec_xform.direction = RTE_SECURITY_IPSEC_SA_DIR_INGRESS; @@ -1078,7 +1078,7 @@ test_ipsec_with_reassembly(struct reassembly_vector *vector, memset(tx_pkts_burst, 0, sizeof(tx_pkts_burst[0]) * nb_tx); memset(rx_pkts_burst, 0, sizeof(rx_pkts_burst[0]) * nb_tx); - memcpy(&sa_data, vector->sa_data, sizeof(struct ipsec_test_data)); + sa_data = *vector->sa_data; sa_data.ipsec_xform.direction = RTE_SECURITY_IPSEC_SA_DIR_EGRESS; outer_ipv4 = is_outer_ipv4(&sa_data); @@ -1096,8 +1096,7 @@ test_ipsec_with_reassembly(struct reassembly_vector *vector, } for (i = 0; i < burst_sz; i++) { - memcpy(&sa_data, vector->sa_data, - sizeof(struct ipsec_test_data)); + sa_data = *vector->sa_data; /* Update SPI for every new SA */ sa_data.ipsec_xform.spi += i; sa_data.ipsec_xform.direction = @@ -1132,8 +1131,7 @@ test_ipsec_with_reassembly(struct reassembly_vector *vector, } for (i = 0; i < burst_sz; i++) { - memcpy(&sa_data, vector->sa_data, - sizeof(struct ipsec_test_data)); + sa_data = *vector->sa_data; /* Update SPI for every new SA */ sa_data.ipsec_xform.spi += i; sa_data.ipsec_xform.direction = @@ -2371,13 +2369,11 @@ test_inline_ip_reassembly(const void *testdata) reassembly_td.nb_frags = td->nb_frags; reassembly_td.burst = td->burst; - memcpy(&full_pkt, td->full_pkt, - sizeof(struct ip_reassembly_test_packet)); + full_pkt = *td->full_pkt; reassembly_td.full_pkt = &full_pkt; for (; i < reassembly_td.nb_frags; i++) { - memcpy(&frags[i], td->frags[i], - sizeof(struct ip_reassembly_test_packet)); + frags[i] = *td->frags[i]; reassembly_td.frags[i] = &frags[i]; /* Add extra data for multi-seg test on all fragments except last one */ @@ -2466,8 +2462,7 @@ test_ipsec_inline_proto_rx_inj_inb(const void *test_data) out_td.sa_data = td->sa_data; out_td.burst = td->burst; - memcpy(&full_pkt, td->full_pkt, - sizeof(struct ip_reassembly_test_packet)); + full_pkt = *td->full_pkt; out_td.full_pkt = &full_pkt; /* Add extra data for multi-seg test */ From patchwork Sat Feb 8 20:22:24 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 151215 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E85D2461CD; Sat, 8 Feb 2025 21:34:57 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6DF8740DDC; Sat, 8 Feb 2025 21:32:37 +0100 (CET) Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by mails.dpdk.org (Postfix) with ESMTP id 12AA140608 for ; Sat, 8 Feb 2025 21:32:33 +0100 (CET) Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-2fa1e25e337so3373285a91.1 for ; Sat, 08 Feb 2025 12:32:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1739046752; x=1739651552; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jamikUKVHIVt/j0Nj9txcipDyZKo2sG2vntbFoi2xdU=; b=PawEj+V6Jxk3cuKHzivYAPoJpZWGi73oXes44rRQC1QPI6Zl6/CaVRsjBMp5f2bEdC uUCJScwSHiu/8+xv6D1gfBR8HdcdaB4xj9wyzrl1n+D2IdojnoNDe/eGnPyRcgYR69G6 lT/RZ+wq2e1LvWeTjZAoGyB1zaLjfy1E/SQzRrLtmaLbiwkI8YzboytX8eVvGzlhnRfn pf3nm7++pPvPvdzoCntQFQO46kl2R7sbw+cKSJn4fe9z48y42qBKBMOtt7H575TvPv43 QQSxTEwHPNcp4+YoH+Fk4zdioVMpcAH66yOGTstZ7qkbPkkr+uL4cvMYC1hziBarn5Ca 6CVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739046752; x=1739651552; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jamikUKVHIVt/j0Nj9txcipDyZKo2sG2vntbFoi2xdU=; b=AxMoGM9AUaqTE1ys3cZBYCjLS5hvmuN7Ko9byXXX1G/JJBRJUy6NVgPrvJ6MsJEdrW 0rcB5hu/nId6m5rOyGW7K5ixUkr/Aefub6kgbX6rRwyU6VY88xvYtSN2EHr4qyiqdUS7 UML4B/aNT9TFWoT0vl2pJ6FIZa14XcJsAlNAf3mhmHT1QBDhXuJJcSjMDpZPgQ4pJizo EppaM0CxC8PERnUl8/BGegoeGhEMvPMFt+Hk1D44DR9B8ObwEhPEBqwtvyrux7jjzL5m z1MppwdF48TZMdSdn4B/LBMTbYfmUq/ojbbEbMDdhU+fvBYM+pLY8U+9pv1g+2rU0ZQF wiaA== X-Gm-Message-State: AOJu0YwWh9qDFMWg/Q7G3R4cVr8VcrJFyJDGjpfjTKHn9DcQAVu4xL/O qgvWA3tohBwh2JAj96/LAoyWH69A9e14ZaTFDg9DnrKTEp0OC6EzZVW0QczfOVqGFzq9lyrIdHB JOLs= X-Gm-Gg: ASbGnctvIzN2ViP1GVZPYlCaWiuM5PNdYN6dPdhOe2CP8Kw0+8hPXvcIkVCqCnD8eg6 OWczRxg9mT0DErxb6NU2SzWBq+Jfn7cJjSBLgUSBaUsSSwW90wWJxdIIyMZf+E9VgSOISTCx418 /HCB/LTvIRwktaMkad19X9kFMtO4+fPAkjHNVMZZl6JBChv1ZjPt/qqGqRLlqjll1Hxvd7AA1MN ULYEzN0HVRW1D8kSvC/hyRkz/ax7AlRm2lcOrvuQl8F/9GPi96l2alc+AQ63a74mOKCV2brJyt2 CP3sfERdvJ0VoraY4eDR7poGX7J4/DVNUKLBDoKK3MyE1Mswe3uFxrpsWM5MVjQL4usw X-Google-Smtp-Source: AGHT+IGIs6F9q9yQq+qfs6tzwtlf/jwdYYUwmsFhX90bJeWMnxA1sYd3mCXb7++Q0kaOafZEU2vrBA== X-Received: by 2002:a05:6a00:2d10:b0:72a:bc54:be9e with SMTP id d2e1a72fcca58-7305d549e4emr13009005b3a.15.1739046752166; Sat, 08 Feb 2025 12:32:32 -0800 (PST) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-7304c780da5sm4882019b3a.69.2025.02.08.12.32.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Feb 2025 12:32:31 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger , Akhil Goyal , Fan Zhang Subject: [PATCH 32/32] test/cryptodev: replace memcpy with structure assignment Date: Sat, 8 Feb 2025 12:22:24 -0800 Message-ID: <20250208203142.242284-33-stephen@networkplumber.org> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250208203142.242284-1-stephen@networkplumber.org> References: <20250208203142.242284-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Prefer structure assignment over memcpy. Found by cocci/struct_assign.cocci Signed-off-by: Stephen Hemminger --- app/test/test_cryptodev.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c index 441ecc6ad5..50518dc5c6 100644 --- a/app/test/test_cryptodev.c +++ b/app/test/test_cryptodev.c @@ -14837,8 +14837,7 @@ test_multi_session_random_usage(void) for (i = 0; i < MB_SESSION_NUMBER; i++) { - rte_memcpy(&ut_paramz[i].ut_params, &unittest_params, - sizeof(struct crypto_unittest_params)); + ut_paramz[i].ut_params = unittest_params; test_AES_CBC_HMAC_SHA512_decrypt_create_session_params( &ut_paramz[i].ut_params,