Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 11690,
    "url": "http://patchwork.dpdk.org/api/1.0/patches/11690/?format=api",
    "project": {
        "id": 1,
        "url": "http://patchwork.dpdk.org/api/1.0/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk"
    },
    "msgid": "<56F38F26.1030707@redhat.com>",
    "date": "2016-03-24T06:54:30",
    "name": "[dpdk-dev,v2,2/7] drivers/net/e1000: Fix missing brackets",
    "commit_ref": null,
    "pull_url": null,
    "state": "not-applicable",
    "archived": true,
    "hash": "ef9d7ebfdf7d5549f5aef96af42f77c22c50efd4",
    "submitter": {
        "id": 169,
        "url": "http://patchwork.dpdk.org/api/1.0/people/169/?format=api",
        "name": "Panu Matilainen",
        "email": "pmatilai@redhat.com"
    },
    "delegate": null,
    "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/56F38F26.1030707@redhat.com/mbox/",
    "series": [],
    "check": "pending",
    "checks": "http://patchwork.dpdk.org/api/patches/11690/checks/",
    "tags": {},
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 159AD2BF2;\n\tThu, 24 Mar 2016 07:54:35 +0100 (CET)",
            "from mx1.redhat.com (mx1.redhat.com [209.132.183.28])\n\tby dpdk.org (Postfix) with ESMTP id 6D5812BD7\n\tfor <dev@dpdk.org>; Thu, 24 Mar 2016 07:54:33 +0100 (CET)",
            "from int-mx13.intmail.prod.int.phx2.redhat.com\n\t(int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26])\n\tby mx1.redhat.com (Postfix) with ESMTPS id 9ABC2804E4;\n\tThu, 24 Mar 2016 06:54:32 +0000 (UTC)",
            "from sopuli.koti.laiskiainen.org (vpn1-4-151.ams2.redhat.com\n\t[10.36.4.151])\n\tby int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with\n\tESMTP id u2O6sUG6031228; Thu, 24 Mar 2016 02:54:31 -0400"
        ],
        "To": "\"Lu, Wenzhuo\" <wenzhuo.lu@intel.com>,\n\tThomas Monjalon <thomas.monjalon@6wind.com>",
        "References": "<1458682638-28378-1-git-send-email-aconole@redhat.com>\n\t<1458682638-28378-3-git-send-email-aconole@redhat.com>\n\t<5248499.WRMHcbhMjp@xps13> <1470283.VAKgtTzWav@xps13>\n\t<6A0DE07E22DDAD4C9103DF62FEBC09090343E973@shsmsx102.ccr.corp.intel.com>",
        "Cc": "Aaron Conole <aconole@redhat.com>, \"dev@dpdk.org\" <dev@dpdk.org>,\n\t\"Richardson, Bruce\" <bruce.richardson@intel.com>",
        "From": "Panu Matilainen <pmatilai@redhat.com>",
        "Message-ID": "<56F38F26.1030707@redhat.com>",
        "Date": "Thu, 24 Mar 2016 08:54:30 +0200",
        "User-Agent": "Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101\n\tThunderbird/38.6.0",
        "MIME-Version": "1.0",
        "In-Reply-To": "<6A0DE07E22DDAD4C9103DF62FEBC09090343E973@shsmsx102.ccr.corp.intel.com>",
        "Content-Type": "text/plain; charset=utf-8; format=flowed",
        "Content-Transfer-Encoding": "7bit",
        "X-Scanned-By": "MIMEDefang 2.68 on 10.5.11.26",
        "Subject": "Re: [dpdk-dev] [PATCH v2 2/7] drivers/net/e1000: Fix missing\n\tbrackets",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "On 03/24/2016 02:35 AM, Lu, Wenzhuo wrote:\n> Hi Thomas, Aaron,\n>>> Wenzhuo, do you agree to fix the base driver here?\n> Honestly I find the logic has some problem and maybe more changes needed. I'm talking with our kernel driver contactors to make sure they have no concern about  my idea.\n> And Aaron, do we really need to fix this code? For I find this function is not called. So it has no real impact to us. Could we just wait until kernel driver fixes it and leverage the new version? Thanks.\n\nIt breaks the build with gcc >= 6.0 due to -Werror so yes we need to fix \nit, one way or the other.\n\nAs spelled out in an earlier mail \n(http://dpdk.org/ml/archives/dev/2016-March/034290.html), for somebody \nbuilding with gcc >= 6.0 the options basically are:\n1) disable the driver entirely\n2) build with -Wno-error\n3) paper over it with local warning disablers\n4) patch the thing locally\n\nIf the offending function really is not used at all in DPDK context then \n3) is an entirely valid option for an upstream solution, ie something \nlike (untested)\n\n\n\n\t- Panu -",
    "diff": "--- a/drivers/net/e1000/Makefile\n+++ b/drivers/net/e1000/Makefile\n@@ -54,6 +54,9 @@ else\n  #\n  CFLAGS_BASE_DRIVER = -Wno-uninitialized -Wno-unused-parameter\n  CFLAGS_BASE_DRIVER += -Wno-unused-variable\n+ifeq ($(shell test $(GCC_VERSION) -ge 60 && echo 1), 1)\n+CFLAGS_BASE_DRIVER += -Wno-misleading-indentation\n+endif\n  endif\n\n  #\n",
    "prefixes": [
        "dpdk-dev",
        "v2",
        "2/7"
    ]
}