Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.0/patches/140034/?format=api
{ "id": 140034, "url": "http://patchwork.dpdk.org/api/1.0/patches/140034/?format=api", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/1.0/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk" }, "msgid": "<20240513155911.31872-6-nandinipersad361@gmail.com>", "date": "2024-05-13T15:59:07", "name": "[5/9] doc: reword trace library section in prog guide", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "b27336e3ce6e30eb9a1e2756865cb903f04689cb", "submitter": { "id": 3325, "url": "http://patchwork.dpdk.org/api/1.0/people/3325/?format=api", "name": "Nandini Persad", "email": "nandinipersad361@gmail.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/1.0/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20240513155911.31872-6-nandinipersad361@gmail.com/mbox/", "series": [ { "id": 31913, "url": "http://patchwork.dpdk.org/api/1.0/series/31913/?format=api", "date": "2024-05-13T15:59:02", "name": "reowrd in prog guide", "version": 1, "mbox": "http://patchwork.dpdk.org/series/31913/mbox/" } ], "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/140034/checks/", "tags": {}, "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 8CFA74401C;\n\tMon, 13 May 2024 18:02:11 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 7907B40A7F;\n\tMon, 13 May 2024 18:01:42 +0200 (CEST)", "from mail-pf1-f179.google.com (mail-pf1-f179.google.com\n [209.85.210.179])\n by mails.dpdk.org (Postfix) with ESMTP id 3F5F44068A\n for <dev@dpdk.org>; Mon, 13 May 2024 17:59:40 +0200 (CEST)", "by mail-pf1-f179.google.com with SMTP id\n d2e1a72fcca58-6f44e3fd382so3711176b3a.1\n for <dev@dpdk.org>; Mon, 13 May 2024 08:59:40 -0700 (PDT)", "from localhost.localdomain (syn-076-032-089-124.res.spectrum.com.\n [76.32.89.124]) by smtp.gmail.com with ESMTPSA id\n d2e1a72fcca58-6f4d2aa16dfsm7715078b3a.93.2024.05.13.08.59.37\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 13 May 2024 08:59:38 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=gmail.com; s=20230601; t=1715615979; x=1716220779; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=2p47UM4tIgMfnMjnj/W6AfbiByZ4hwFb0ZHr58mNlX4=;\n b=a20xh4W5SNTxg6wCSn0SaRHtzkORQjJ7FXIBEsym3PogjQAQr+UztcGrSpCl3EiE0w\n j1G5qBKJiZNIsGFb5jFTgDeFq5JwSwB4pofe+kjrEcLW9zju/hzib7wLaQ0CtRgVT4jJ\n fx17muHxzopDgGuLABBTnermKSpIUrVw8XUd7HRp6D1ueeUpHVDuwc8fBucEGnky4iWy\n QNv6CebV2ZtEi68ZJ+YHvpo0yDDCmhMNe4Phw7nTexcgff5J6Kosj5KgrhKsKo7bfTRu\n mdJyYdqC9GX+qHjEEl3UFkwpQ1K719b1wJ2M8hb3GgPh3bycUE9nYJ4K05vF9LA7ySSS\n XY2w==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1715615979; x=1716220779;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=2p47UM4tIgMfnMjnj/W6AfbiByZ4hwFb0ZHr58mNlX4=;\n b=XNaC270ImJ3YYKOkc/RiXV/tGJCrlKlGxo48IiqHLh1CtOvTicfzk+kSIPx+Iv7yjX\n rlBV8jwxFKIS/gpZMyftVuXrC+NtIVLCmBf6CP7TUOY1GP85laprxpoAcgve49NKBEiI\n R1ZC9B2fGe92dT/fHb1d0oNAMiDjx4EAO0SeBJN2ijWXe7R8jU+MpALZCY8taUowiwo1\n bJ6iFlx2G6hQ+GhmMck++Q3f+ShbSOoz8KLKPLt6j+R7aW4HYN1poXYw6A3VcNcUjWlW\n IhJmSM+J+nusyVlEUmNzcpUx++zaVuJd5wPrgBGkC/a8UeW9EyviKnkO8Lyeh49uUPQy\n AjQA==", "X-Gm-Message-State": "AOJu0YwsDhiBAgUNY+v+q91z0pA7xeNj2fmgW4kk2D4dexx1T5GFv33w\n UGZApf6P6KbvJ9cft8pvj/xAVG26SY/28hBYttnidZTMdS8PhzyBG9m9WQ==", "X-Google-Smtp-Source": "\n AGHT+IEdGdCdfS99rnljsL55kKoFhazW/yfeBlDRWRndasZ8GlrH0glEYsW3w3qSytzQmiOs9HHrTA==", "X-Received": "by 2002:a05:6a00:b51:b0:6ed:88e5:53d4 with SMTP id\n d2e1a72fcca58-6f4e02aa365mr12948693b3a.8.1715615978648;\n Mon, 13 May 2024 08:59:38 -0700 (PDT)", "From": "Nandini Persad <nandinipersad361@gmail.com>", "To": "dev@dpdk.org", "Cc": "Jerin Jacob <jerinj@marvell.com>,\n\tSunil Kumar Kori <skori@marvell.com>", "Subject": "[PATCH 5/9] doc: reword trace library section in prog guide", "Date": "Mon, 13 May 2024 08:59:07 -0700", "Message-Id": "<20240513155911.31872-6-nandinipersad361@gmail.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20240513155911.31872-1-nandinipersad361@gmail.com>", "References": "<20240513155911.31872-1-nandinipersad361@gmail.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-Mailman-Approved-At": "Mon, 13 May 2024 18:01:34 +0200", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "made minor syntax edits to sect 9.1-9.7 of prog guide\n\nSigned-off-by: Nandini Persad <nandinipersad361@gmail.com>\n---\n doc/guides/prog_guide/trace_lib.rst | 50 ++++++++++++++---------------\n 1 file changed, 25 insertions(+), 25 deletions(-)", "diff": "diff --git a/doc/guides/prog_guide/trace_lib.rst b/doc/guides/prog_guide/trace_lib.rst\nindex d9b17abe90..e2983017d8 100644\n--- a/doc/guides/prog_guide/trace_lib.rst\n+++ b/doc/guides/prog_guide/trace_lib.rst\n@@ -14,29 +14,29 @@ When recording, specific instrumentation points placed in the software source\n code generate events that are saved on a giant tape: a trace file.\n The trace file then later can be opened in *trace viewers* to visualize and\n analyze the trace events with timestamps and multi-core views.\n-Such a mechanism will be useful for resolving a wide range of problems such as\n-multi-core synchronization issues, latency measurements, finding out the\n-post analysis information like CPU idle time, etc that would otherwise be\n-extremely challenging to get.\n+This mechanism will be useful for resolving a wide range of problems such as\n+multi-core synchronization issues, latency measurements, and finding\n+post analysis information like CPU idle time, etc., that would otherwise be\n+extremely challenging to gather.\n \n Tracing is often compared to *logging*. However, tracers and loggers are two\n-different tools, serving two different purposes.\n-Tracers are designed to record much lower-level events that occur much more\n+different tools serving two different purposes.\n+Tracers are designed to record much lower-level events that occur more\n frequently than log messages, often in the range of thousands per second, with\n very little execution overhead.\n Logging is more appropriate for a very high-level analysis of less frequent\n events: user accesses, exceptional conditions (errors and warnings, for\n-example), database transactions, instant messaging communications, and such.\n+example), database transactions, instant messaging communications, etc.\n Simply put, logging is one of the many use cases that can be satisfied with\n tracing.\n \n DPDK tracing library features\n -----------------------------\n \n-- A framework to add tracepoints in control and fast path APIs with minimum\n+- Provides framework to add tracepoints in control and fast path APIs with minimum\n impact on performance.\n Typical trace overhead is ~20 cycles and instrumentation overhead is 1 cycle.\n-- Enable and disable the tracepoints at runtime.\n+- Enable and disable tracepoints at runtime.\n - Save the trace buffer to the filesystem at any point in time.\n - Support ``overwrite`` and ``discard`` trace mode operations.\n - String-based tracepoint object lookup.\n@@ -47,7 +47,7 @@ DPDK tracing library features\n For detailed information, refer to\n `Common Trace Format <https://diamon.org/ctf/>`_.\n \n-How to add a tracepoint?\n+How to add a Tracepoint\n ------------------------\n \n This section steps you through the details of adding a simple tracepoint.\n@@ -67,14 +67,14 @@ Create the tracepoint header file\n rte_trace_point_emit_string(str);\n )\n \n-The above macro creates ``app_trace_string`` tracepoint.\n+The above macro creates the ``app_trace_string`` tracepoint.\n The user can choose any name for the tracepoint.\n However, when adding a tracepoint in the DPDK library, the\n ``rte_<library_name>_trace_[<domain>_]<name>`` naming convention must be\n followed.\n The examples are ``rte_eal_trace_generic_str``, ``rte_mempool_trace_create``.\n \n-The ``RTE_TRACE_POINT`` macro expands from above definition as the following\n+The ``RTE_TRACE_POINT`` macro expands from the above definition as the following\n function template:\n \n .. code-block:: c\n@@ -91,7 +91,7 @@ The consumer of this tracepoint can invoke\n ``app_trace_string(const char *str)`` to emit the trace event to the trace\n buffer.\n \n-Register the tracepoint\n+Register the Tracepoint\n ~~~~~~~~~~~~~~~~~~~~~~~\n \n .. code-block:: c\n@@ -122,40 +122,40 @@ convention.\n \n The ``RTE_TRACE_POINT_REGISTER`` defines the placeholder for the\n ``rte_trace_point_t`` tracepoint object.\n- For generic tracepoint or for tracepoint used in public header files,\n+ For a generic tracepoint or for the tracepoint used in public header files,\n the user must export a ``__<trace_function_name>`` symbol\n in the library ``.map`` file for this tracepoint\n- to be used out of the library, in shared builds.\n+ to be used out of the library in shared builds.\n For example, ``__app_trace_string`` will be the exported symbol in the\n above example.\n \n-Fast path tracepoint\n+Fast Path Tracepoint\n --------------------\n \n In order to avoid performance impact in fast path code, the library introduced\n ``RTE_TRACE_POINT_FP``. When adding the tracepoint in fast path code,\n the user must use ``RTE_TRACE_POINT_FP`` instead of ``RTE_TRACE_POINT``.\n \n-``RTE_TRACE_POINT_FP`` is compiled out by default and it can be enabled using\n+``RTE_TRACE_POINT_FP`` is compiled by default and can be enabled using\n the ``enable_trace_fp`` option for meson build.\n \n-Event record mode\n+Event Record Mode\n -----------------\n \n-Event record mode is an attribute of trace buffers. Trace library exposes the\n+Event record mode is an attribute of trace buffers. The trace library exposes the\n following modes:\n \n Overwrite\n- When the trace buffer is full, new trace events overwrites the existing\n+ When the trace buffer is full, new trace events overwrite the existing\n captured events in the trace buffer.\n Discard\n When the trace buffer is full, new trace events will be discarded.\n \n-The mode can be configured either using EAL command line parameter\n-``--trace-mode`` on application boot up or use ``rte_trace_mode_set()`` API to\n+The mode can be configured either using the EAL command line parameter\n+``--trace-mode`` on application boot up or use the ``rte_trace_mode_set()`` API to\n configure at runtime.\n \n-Trace file location\n+Trace File Location\n -------------------\n \n On ``rte_trace_save()`` or ``rte_eal_cleanup()`` invocation, the library saves\n@@ -167,7 +167,7 @@ option.\n For more information, refer to :doc:`../linux_gsg/linux_eal_parameters` for\n trace EAL command line options.\n \n-View and analyze the recorded events\n+View and Analyze Recorded Events\n ------------------------------------\n \n Once the trace directory is available, the user can view/inspect the recorded\n@@ -176,7 +176,7 @@ events.\n There are many tools you can use to read DPDK traces:\n \n #. ``babeltrace`` is a command-line utility that converts trace formats; it\n- supports the format that DPDK trace library produces, CTF, as well as a\n+ supports the format that the DPDK trace library produces, CTF, as well as a\n basic text output that can be grep'ed.\n The babeltrace command is part of the Open Source Babeltrace project.\n \n", "prefixes": [ "5/9" ] }