Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/1.0/patches/68060/?format=api
{ "id": 68060, "url": "http://patchwork.dpdk.org/api/1.0/patches/68060/?format=api", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/1.0/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk" }, "msgid": "<20200409154257.11539-4-wisamm@mellanox.com>", "date": "2020-04-09T15:42:56", "name": "[4/5] app/test-flow-perf: add memory dump to app", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "47c615bd8a1fbb28b14c38f85ae5cf6922a4ac68", "submitter": { "id": 938, "url": "http://patchwork.dpdk.org/api/1.0/people/938/?format=api", "name": "Wisam Jaddo", "email": "wisamm@mellanox.com" }, "delegate": { "id": 1, "url": "http://patchwork.dpdk.org/api/1.0/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/patch/20200409154257.11539-4-wisamm@mellanox.com/mbox/", "series": [ { "id": 9270, "url": "http://patchwork.dpdk.org/api/1.0/series/9270/?format=api", "date": "2020-04-09T15:42:53", "name": "[1/5] app/test-flow-perf: add flow performance skeleton", "version": 1, "mbox": "http://patchwork.dpdk.org/series/9270/mbox/" } ], "check": "success", "checks": "http://patchwork.dpdk.org/api/patches/68060/checks/", "tags": {}, "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 94645A0597;\n\tThu, 9 Apr 2020 17:44:01 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 4CEDA1D162;\n\tThu, 9 Apr 2020 17:43:24 +0200 (CEST)", "from EUR02-AM5-obe.outbound.protection.outlook.com\n (mail-eopbgr00053.outbound.protection.outlook.com [40.107.0.53])\n by dpdk.org (Postfix) with ESMTP id 5F4891D14B\n for <dev@dpdk.org>; Thu, 9 Apr 2020 17:43:20 +0200 (CEST)", "from AM0PR05MB6610.eurprd05.prod.outlook.com (2603:10a6:208:12f::18)\n by AM0SPR01MB0078.eurprd05.prod.outlook.com (2603:10a6:208:156::29)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2900.15; Thu, 9 Apr\n 2020 15:43:19 +0000", "from AM0PR05MB6610.eurprd05.prod.outlook.com\n ([fe80::6dbd:6f77:4519:eeb6]) by AM0PR05MB6610.eurprd05.prod.outlook.com\n ([fe80::6dbd:6f77:4519:eeb6%5]) with mapi id 15.20.2878.023; Thu, 9 Apr 2020\n 15:43:19 +0000", "from mellanox.com (37.142.13.130) by\n PR3P192CA0040.EURP192.PROD.OUTLOOK.COM (2603:10a6:102:57::15) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.2900.17 via Frontend Transport; Thu, 9 Apr 2020 15:43:18 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=myn7Fv8RaZvwnmkapfvaUyr25AAI6HbHTTumt8C67M9RsgCQwui8N7ZbK4L6brwDU55zx6oKkah2KGQnrf2gTB03srYdMzroQjY6P4XkEnz8ZP6PsppXtibMvnSn/n9xiajdh7W/6zyy1F1lxRaj7+fPXDlRAONL8tayxOK//ucx/h9DZcZ0k/jCYnfDjkEp1f5QGXGCFFIsUg04QPpa/eGg+mZBwd3ZgLtyj4b2nWTPcxrJussxm4Z79cg8tRwh8xab0CyRfqi2DJlv610A0va9HC1FAeeX9cDDQafWVhYqxPxjadfp0vQLEHQIqK9EmCpdfcoouXteGAZn9cKydQ==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=M05zpHKKsYouy1KeVll85YgoOnLuTEpR9IKjMEUOxM0=;\n b=DLyjydeVY7XNxIwPtyzhsZuk9IPxceT3+xPoIYmaK2NuUVFa6pGgtUIHe7l/xWbdPS9YsP6+VXN+O+DreGP08OCOZthCV5pKdeM7qrInITUc1KWKcjmc2grFDK2U4v0MaiVQHlPDCJXq0zQJYHJbXTXHZnI/HjZVD/BuAQlGpABZFc8EfDqCnsj32EvRHIy8/+Yf0vbEPLAVtETdvirMp2i31SVI9d/Lc3W/tzGvBZW76aJCC2CZUwlDV4KrHKj9E69BrFDQIA8RMOe5DXyUYPWOaeHjs/9EXbSyjEr6Doimc6/8C2XgSdYiswqdDL9D1QzGIEMGJUXYBPx9fBzM9A==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=mellanox.com; dmarc=pass action=none header.from=mellanox.com;\n dkim=pass header.d=mellanox.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=M05zpHKKsYouy1KeVll85YgoOnLuTEpR9IKjMEUOxM0=;\n b=aXJALDKXQJ2cZgxr489gR76bPx4E3rq7s5CNQlYdHZru+ZPZPXh5jzfVFZPsD0nUtXUBt3jW26IIAwB5/IHod/MZVr0wmhQHCRk+W4L4rHxYpdfYuIQ+wlZTQEt3HPvopJcHs7tf9rRYdzOU3umdwhyFUiNBejzTqj/EG6CkXzQ=", "Authentication-Results": "spf=none (sender IP is )\n smtp.mailfrom=wisamm@mellanox.com;", "From": "Wisam Jaddo <wisamm@mellanox.com>", "To": "dev@dpdk.org,\n\tjackmin@mellanox.com,\n\tjerinjacobk@gmail.com", "Cc": "thomas@monjalon.net,\n\tSuanming Mou <suanmingm@mellanox.com>", "Date": "Thu, 9 Apr 2020 15:42:56 +0000", "Message-Id": "<20200409154257.11539-4-wisamm@mellanox.com>", "X-Mailer": [ "git-send-email 2.17.1", "git-send-email 2.17.1" ], "In-Reply-To": "<20200409154257.11539-1-wisamm@mellanox.com>", "References": "<1584452772-31147-1-git-send-email-wisamm@mellanox.com>\n <20200409154257.11539-1-wisamm@mellanox.com>", "Content-Type": "text/plain", "X-ClientProxiedBy": "PR3P192CA0040.EURP192.PROD.OUTLOOK.COM\n (2603:10a6:102:57::15) To AM0PR05MB6610.eurprd05.prod.outlook.com\n (2603:10a6:208:12f::18)", "MIME-Version": "1.0", "X-MS-Exchange-MessageSentRepresentingType": "1", "X-Originating-IP": "[37.142.13.130]", "X-MS-PublicTrafficType": "Email", "X-MS-Office365-Filtering-HT": "Tenant", "X-MS-Office365-Filtering-Correlation-Id": "79209967-27e2-42db-5ed3-08d7dc9cba24", "X-MS-TrafficTypeDiagnostic": "AM0SPR01MB0078:|AM0SPR01MB0078:", "X-LD-Processed": "a652971c-7d2e-4d9b-a6a4-d149256f461b,ExtAddr", "X-MS-Exchange-Transport-Forked": "True", "X-Microsoft-Antispam-PRVS": "\n <AM0SPR01MB00780B8755E0D2AA9B10E76EA9C10@AM0SPR01MB0078.eurprd05.prod.outlook.com>", "X-MS-Oob-TLC-OOBClassifiers": "OLM:2276;", "X-Forefront-PRVS": "0368E78B5B", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:AM0PR05MB6610.eurprd05.prod.outlook.com; PTR:; CAT:NONE;\n SFTY:;\n SFS:(10009020)(4636009)(396003)(39860400002)(346002)(376002)(136003)(366004)(66946007)(7696005)(1076003)(55016002)(2906002)(52116002)(5660300002)(66556008)(8936002)(8886007)(81156014)(86362001)(316002)(6666004)(26005)(186003)(8676002)(66476007)(16526019)(4326008)(107886003)(956004)(478600001)(2616005)(81166007)(36756003);\n DIR:OUT; SFP:1101;", "Received-SPF": "None (protection.outlook.com: mellanox.com does not designate\n permitted sender hosts)", "X-MS-Exchange-SenderADCheck": "1", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n F+dtb/pELqlaoAosPnXPMz2pSSXuD/rlhTnA/5KIaCujmQe3uj0Z22KFp4Aq5fPkrqmfXfrByNReDUhiArPn1qpezn0fIeNHz2Qpyb7eVVU2yCUVwHi39PfK2JeyKIxUsp4+OXX6x27KxB/aBKnzkwx6PYPssLcEH94BP1oAxe+Fq6mDxPdCBSshpOJw4gyMjWM9jK1zfWsvB1wVxM41h0wnbFRQq7tLzIApEc4KC+bHJ/m5IFchgcL2I4NhlrvQfIaWT8GUVUccMT8NjB0cyoSFy48dodH42akZRDV82KRxM42xpQKMViYudLOGe+SawKzYwM1p7BVrkop1lMCYM6k7dJDkcX4HZNyk+Ge3IBxA08OE5Iq6SIHnr1uDxGrb2ekK7Jw9HqlCwn7vrvhzhSRUhEHFkNBrp4mo07iZWGXOgvHoo0JuY9rGoGUaDCKY", "X-MS-Exchange-AntiSpam-MessageData": "\n RSxd4D/MnicaslALBkKcK3HvxWRP1/qYVWmGyTpkFEf8bFPQW27Z9CQGQYkiG1ZhUUj+7TjCvo7d/DXqYTVj38Q10eSQZq8iBW+L4NZqt5XAS6ONkW1XZLXCVefgVfWTJNm8h9Tg3rAO8ZB7xFu8LQ==", "X-OriginatorOrg": "Mellanox.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 79209967-27e2-42db-5ed3-08d7dc9cba24", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "09 Apr 2020 15:43:19.4437 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "a652971c-7d2e-4d9b-a6a4-d149256f461b", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n NffjIEFR2RJ1TypblVEuiv3Y+t4wjyGqvhULCJt3y6ydrjct2mHNvcx9I/nKzJOVWh7nI17A9/NtFtpcFL/YPw==", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "AM0SPR01MB0078", "Subject": "[dpdk-dev] [PATCH 4/5] app/test-flow-perf: add memory dump to app", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Introduce new feature to dump memory statistics of each socket\nand a total for all before and after the creation.\n\nThis will give two main advantage:\n1- Check the memory consumption for large number of flows\n\"insertion rate scenario alone\"\n\n2- Check that no memory leackage after doing insertion then\ndeletion.\n\nSigned-off-by: Suanming Mou <suanmingm@mellanox.com>\nSigned-off-by: Wisam Jaddo <wisamm@mellanox.com>\n---\n app/test-flow-perf/main.c | 69 ++++++++++++++++++++++++++++++++++\n doc/guides/tools/flow-perf.rst | 6 ++-\n 2 files changed, 74 insertions(+), 1 deletion(-)", "diff": "diff --git a/app/test-flow-perf/main.c b/app/test-flow-perf/main.c\nindex 84f2c0c39b..438fbf850a 100644\n--- a/app/test-flow-perf/main.c\n+++ b/app/test-flow-perf/main.c\n@@ -62,6 +62,7 @@ static uint16_t flow_actions;\n static uint8_t flow_attrs;\n static volatile bool force_quit;\n static volatile bool dump_iterations;\n+static volatile bool dump_socket_mem_flag;\n static volatile bool delete_flag;\n static struct rte_mempool *mbuf_mp;\n static uint32_t nb_lcores;\n@@ -78,6 +79,7 @@ static void usage(char *progname)\n \t\t\" iteration\\n\");\n \tprintf(\" --deletion-rate: Enable deletion rate\"\n \t\t\" calculations\\n\");\n+\tprintf(\" --dump-socket-mem: to dump all socket memory\\n\");\n \n \tprintf(\"To set flow attributes:\\n\");\n \tprintf(\" --ingress: set ingress attribute in flows\\n\");\n@@ -127,6 +129,7 @@ args_parse(int argc, char **argv)\n \t\t{ \"flows-count\", 1, 0, 0 },\n \t\t{ \"dump-iterations\", 0, 0, 0 },\n \t\t{ \"deletion-rate\", 0, 0, 0 },\n+\t\t{ \"dump-socket-mem\", 0, 0, 0 },\n \t\t/* Attributes */\n \t\t{ \"ingress\", 0, 0, 0 },\n \t\t{ \"egress\", 0, 0, 0 },\n@@ -310,6 +313,8 @@ args_parse(int argc, char **argv)\n \t\t\t\tdump_iterations = true;\n \t\t\tif (!strcmp(lgopts[opt_idx].name, \"deletion-rate\"))\n \t\t\t\tdelete_flag = true;\n+\t\t\tif (!strcmp(lgopts[opt_idx].name, \"dump-socket-mem\"))\n+\t\t\t\tdump_socket_mem_flag = true;\n \t\t\tbreak;\n \t\tdefault:\n \t\t\tusage(argv[0]);\n@@ -321,6 +326,62 @@ args_parse(int argc, char **argv)\n \tprintf(\"end_flow\\n\");\n }\n \n+/* Dump the socket memory statistics on console */\n+static size_t\n+dump_socket_mem(FILE *f)\n+{\n+\tstruct rte_malloc_socket_stats socket_stats;\n+\tunsigned int i = 0;\n+\tsize_t total = 0;\n+\tsize_t alloc = 0;\n+\tsize_t free = 0;\n+\tunsigned int n_alloc = 0;\n+\tunsigned int n_free = 0;\n+\tbool active_nodes = false;\n+\n+\n+\tfor (i = 0; i < RTE_MAX_NUMA_NODES; i++) {\n+\t\tif (rte_malloc_get_socket_stats(i, &socket_stats) ||\n+\t\t !socket_stats.heap_totalsz_bytes)\n+\t\t\tcontinue;\n+\t\tactive_nodes = true;\n+\t\ttotal += socket_stats.heap_totalsz_bytes;\n+\t\talloc += socket_stats.heap_allocsz_bytes;\n+\t\tfree += socket_stats.heap_freesz_bytes;\n+\t\tn_alloc += socket_stats.alloc_count;\n+\t\tn_free += socket_stats.free_count;\n+\t\tif (dump_socket_mem_flag) {\n+\t\t\tfprintf(f, \"::::::::::::::::::::::::::::::::::::::::\");\n+\t\t\tfprintf(f,\n+\t\t\t\t\"\\nSocket %u:\\nsize(M) total: %.6lf\\nalloc:\"\n+\t\t\t\t\" %.6lf(%.3lf%%)\\nfree: %.6lf\"\n+\t\t\t\t\"\\nmax: %.6lf\"\n+\t\t\t\t\"\\ncount alloc: %u\\nfree: %u\\n\",\n+\t\t\t\ti,\n+\t\t\t\tsocket_stats.heap_totalsz_bytes / 1.0e6,\n+\t\t\t\tsocket_stats.heap_allocsz_bytes / 1.0e6,\n+\t\t\t\t(double)socket_stats.heap_allocsz_bytes * 100 /\n+\t\t\t\t(double)socket_stats.heap_totalsz_bytes,\n+\t\t\t\tsocket_stats.heap_freesz_bytes / 1.0e6,\n+\t\t\t\tsocket_stats.greatest_free_size / 1.0e6,\n+\t\t\t\tsocket_stats.alloc_count,\n+\t\t\t\tsocket_stats.free_count);\n+\t\t\t\tfprintf(f, \"::::::::::::::::::::::::::::::::::::::::\");\n+\t\t}\n+\t}\n+\tif (dump_socket_mem_flag && active_nodes) {\n+\t\tfprintf(f,\n+\t\t\t\"\\nTotal: size(M)\\ntotal: %.6lf\"\n+\t\t\t\"\\nalloc: %.6lf(%.3lf%%)\\nfree: %.6lf\"\n+\t\t\t\"\\ncount alloc: %u\\nfree: %u\\n\",\n+\t\t\ttotal / 1.0e6, alloc / 1.0e6,\n+\t\t\t(double)alloc * 100 / (double)total, free / 1.0e6,\n+\t\t\tn_alloc, n_free);\n+\t\tfprintf(f, \"::::::::::::::::::::::::::::::::::::::::\\n\");\n+\t}\n+\treturn alloc;\n+}\n+\n static void\n print_flow_error(struct rte_flow_error error)\n {\n@@ -657,6 +718,7 @@ main(int argc, char **argv)\n \tuint16_t nr_ports;\n \tint ret;\n \tstruct rte_flow_error error;\n+\tint64_t alloc, last_alloc;\n \n \tnr_ports = rte_eth_dev_count_avail();\n \tret = rte_eal_init(argc, argv);\n@@ -666,6 +728,7 @@ main(int argc, char **argv)\n \tforce_quit = false;\n \tdump_iterations = false;\n \tdelete_flag = false;\n+\tdump_socket_mem_flag = false;\n \tflows_count = 4000000;\n \titerations_number = 100000;\n \tflow_group = 0;\n@@ -686,7 +749,13 @@ main(int argc, char **argv)\n \tif (nb_lcores <= 1)\n \t\trte_exit(EXIT_FAILURE, \"This app needs at least two cores\\n\");\n \n+\tlast_alloc = (int64_t)dump_socket_mem(stdout);\n \tflows_handler();\n+\talloc = (int64_t)dump_socket_mem(stdout);\n+\n+\tif (last_alloc)\n+\t\tfprintf(stdout, \":: Memory allocation change(M): %.6lf\\n\",\n+\t\t(alloc - last_alloc) / 1.0e6);\n \n \tRTE_LCORE_FOREACH_SLAVE(lcore_id)\n \ndiff --git a/doc/guides/tools/flow-perf.rst b/doc/guides/tools/flow-perf.rst\nindex e07e659df5..28d452fd06 100644\n--- a/doc/guides/tools/flow-perf.rst\n+++ b/doc/guides/tools/flow-perf.rst\n@@ -18,7 +18,8 @@ give different flow each time, and all other items will have open masks.\n The current design have single core insertion rate. In the future we may\n have a multi core insertion rate measurement support in the app.\n \n-The application also provide the ability to measure rte flow deletion rate.\n+The application also provide the ability to measure rte flow deletion rate,\n+in addition to memory consumption before and after the flows creation.\n \n \n Compiling the Application\n@@ -94,6 +95,9 @@ The command line options are:\n *\t``--deletion-rate``\n \tEnable deletion rate calculations.\n \n+*\t``--dump-socket-mem``\n+\tDump the memory stats for each socket before the insertion and after.\n+\n Attributes:\n \n *\t``--ingress``\n", "prefixes": [ "4/5" ] }