Cover Detail
Show a cover letter.
GET /api/covers/106888/?format=api
{ "id": 106888, "url": "http://patchwork.dpdk.org/api/covers/106888/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/cover/tencent_F6238474ECBE8F462E456862FE79944E5109@qq.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<tencent_F6238474ECBE8F462E456862FE79944E5109@qq.com>", "list_archive_url": "https://inbox.dpdk.org/dev/tencent_F6238474ECBE8F462E456862FE79944E5109@qq.com", "date": "2022-02-06T00:44:08", "name": "[0/6] fix the curly braces mismatch problem", "submitter": { "id": 2458, "url": "http://patchwork.dpdk.org/api/people/2458/?format=api", "name": "Weiguo Li", "email": "liwg06@foxmail.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/cover/tencent_F6238474ECBE8F462E456862FE79944E5109@qq.com/mbox/", "series": [ { "id": 21474, "url": "http://patchwork.dpdk.org/api/series/21474/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=21474", "date": "2022-02-06T00:44:08", "name": "fix the curly braces mismatch problem", "version": 1, "mbox": "http://patchwork.dpdk.org/series/21474/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/covers/106888/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E04F9A034E;\n\tSun, 6 Feb 2022 01:45:41 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D8BF1410FC;\n\tSun, 6 Feb 2022 01:45:30 +0100 (CET)", "from out203-205-221-231.mail.qq.com (out203-205-221-231.mail.qq.com\n [203.205.221.231])\n by mails.dpdk.org (Postfix) with ESMTP id 6DAAA406A2\n for <dev@dpdk.org>; Sun, 6 Feb 2022 01:45:26 +0100 (CET)", "from liwg-ubuntu.lan ([111.193.130.237])\n by newxmesmtplogicsvrsza5.qq.com (NewEsmtp) with SMTP\n id B0E20ABF; Sun, 06 Feb 2022 08:44:14 +0800" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com;\n s=s201512; t=1644108323;\n bh=yE3+ny1ggFI55TQ6nGtZ6zfev6Sjf9aRUKeZGz4Nofw=;\n h=From:To:Subject:Date;\n b=Mf9YzwBcz+bASCqQcHuXAYP5Sg/POeGEkWx1xvXT/jyIVSVoNzZRiyfreAATTrwbs\n tJO5KCbvlOD5vZAsQNz1J2Dcz1RQTTZC1+Gp5UOS4iDNSWC6CS51gmdZ5lXJWd710/\n /2TCVWDJW/iHiU7YKCUPHJ5aBjpBgSk2lLiAunMA=", "X-QQ-mid": "xmsmtpt1644108254tfu7qz1b7", "Message-ID": "<tencent_F6238474ECBE8F462E456862FE79944E5109@qq.com>", "X-QQ-XMAILINFO": "MX+1SEN3H+wA5JwU9mjAHdkijtyTGV9yABb22IrTw09GtlyqIUKcz5o+Bt1h9Y\n WNSRwEGRMEaJHdSUMYDjoFqwGrN3+3jLQ5eKEgSVo5CKXnRrEW5mO8EI/9K1aExQGZXNaOBgYDuh\n Fm8rCQsnaAFjo1fTrKavXUaGLl5BK+lb9pmBMJ5EPFlHRIRmMEAQR9Qzfm1eq+9zmGyKPDlSFKeN\n M4l6S1rmovYqWHJteBS7Bkg2czWYttaCGxZ6DTjJhgdurWZWeXeHRKzNBbti4NCd2cp5DJubqyne\n nwSfw5PGrsYlb5VXK8VsT8qwRPsiB2t5FrVDumvulblaApiziRTO4N1YY3z5PgmGx6YHj/aIsS9J\n hoZj1PmnBKkA8sUkKoRSyy5Vd+12YKgol4iBS2YT9UGNibI4No3aAlNrKHOmKfgkqWsptD8sMCbu\n fxa7MH1PqjiiNdtLC+bdJciAxcns88B7CQLugHsAdJrDBR+Trngn35MZDDyRGYAbE6XPnqFhhKmB\n TnWeOAD8Z/Alqd3kWESUY+vhgxpGJnpmEY9/5eyoPGmqlbGsLm5brYH1yzAo2MDi+JSoVjHdKKU9\n mWpjX1NlvyMjP6UahGUpTEs8TqO0TdeyVXxtmufaKEFBbMmIoT3MNHOiFnP8FOkzObSoaa/qALHw\n jxIwt/Fprw7ShiBbLjJG4ajZ7ZxyZbcLXzo5Ux8ykqz1BufF3q+J73aqayFWBtaXv/3zEaPINjVp\n Uksytrdoz9Dv/zgRoathBjoV4S8wpdsmVugP/rEzvApH1YbsqjlF4bdEHKKEhn+2g497DV28GZRv\n JMDEG4UgJFfGWl1ztPMPppKMpF8snsmP9lb6a9uoImUQ==", "From": "Weiguo Li <liwg06@foxmail.com>", "To": "dev@dpdk.org", "Subject": "[PATCH 0/6] fix the curly braces mismatch problem", "Date": "Sun, 6 Feb 2022 08:44:08 +0800", "X-OQ-MSGID": "<20220206004414.2801177-1-liwg06@foxmail.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "To make C header file compatible with C++ linking, a conventional\npractice enclose the code with braces as below:\n\n#ifdef __cplusplus\nextern \"C\" {\n#endif\n\n...\n\n#ifdef __cplusplus\n}\n#endif\n\nSome alternative forms of \"#ifdef __cplusplus\", like \n\"#if defined(__cplusplus)\" or \"# ifdef __cplusplus\", also work.\n\nWhile it's suspicious when a header file matchs this regular\nexpression \"if.*__cplusplus\" exactly once.\n\nThe following script is used to find these files:\ngrep -r ~/git/dpdk --include=*.h -e \"if.*__cplusplus\" -c|grep \":1$\"\n\nApart from two false positive cases, I found some real issues --\nsome missing the left brace parts, the others missing the right\nbrace parts. \n\nIn one of the cases, the c++ guard is removed since it's useless in \nprivate header as previous patch (http://dpdk.org/patch/98948) noted.\nFor the other cases, the missing parts are supplemented.\n\nWeiguo Li (6):\n bus/dpaa: fix the curly braces mismatch problem\n common/mlx5: fix the curly braces mismatch problem\n net/cxgbe: fix the curly braces mismatch problem\n net/dpaa2: fix the curly braces mismatch problem\n eal/windows: fix the curly braces mismatch problem\n eventdev: remove C++ include guard from private header\n\n drivers/bus/dpaa/include/fsl_fman.h | 5 +++++\n drivers/bus/dpaa/rte_dpaa_bus.h | 4 ++++\n drivers/common/mlx5/windows/mlx5_win_defs.h | 5 +++++\n drivers/common/mlx5/windows/mlx5_win_ext.h | 4 ++++\n drivers/net/cxgbe/base/common.h | 5 +++++\n drivers/net/dpaa2/dpaa2_sparser.h | 5 +++++\n lib/eal/windows/include/dirent.h | 4 ++++\n lib/eventdev/eventdev_pmd.h | 4 ----\n 8 files changed, 32 insertions(+), 4 deletions(-)" }