Cover Detail
Show a cover letter.
GET /api/covers/60538/?format=api
{ "id": 60538, "url": "http://patchwork.dpdk.org/api/covers/60538/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/cover/20191004171913.59574-1-bruce.richardson@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20191004171913.59574-1-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20191004171913.59574-1-bruce.richardson@intel.com", "date": "2019-10-04T17:19:08", "name": "[0/5] some bbdev cleanups", "submitter": { "id": 20, "url": "http://patchwork.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/cover/20191004171913.59574-1-bruce.richardson@intel.com/mbox/", "series": [ { "id": 6699, "url": "http://patchwork.dpdk.org/api/series/6699/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=6699", "date": "2019-10-04T17:19:08", "name": "some bbdev cleanups", "version": 1, "mbox": "http://patchwork.dpdk.org/series/6699/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/covers/60538/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id 6AB3A1C242;\n\tFri, 4 Oct 2019 19:19:25 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 1291C1C225\n\tfor <dev@dpdk.org>; Fri, 4 Oct 2019 19:19:23 +0200 (CEST)", "from fmsmga004.fm.intel.com ([10.253.24.48])\n\tby fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;\n\t04 Oct 2019 10:19:23 -0700", "from silpixa00399126.ir.intel.com (HELO\n\tsilpixa00399126.ger.corp.intel.com) ([10.237.223.2])\n\tby fmsmga004.fm.intel.com with ESMTP; 04 Oct 2019 10:19:21 -0700" ], "X-Amp-Result": "SKIPPED(no attachment in message)", "X-Amp-File-Uploaded": "False", "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.67,257,1566889200\"; d=\"scan'208\";a=\"217228452\"", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org,\n\tNicolas Chautru <nicolas.chautru@intel.com>", "Cc": "Akhil Goyal <akhil.goyal@nxp.com>, Andrzej Ostruszka <amo@semihalf.com>, \n\tBruce Richardson <bruce.richardson@intel.com>", "Date": "Fri, 4 Oct 2019 18:19:08 +0100", "Message-Id": "<20191004171913.59574-1-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.21.0", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH 0/5] some bbdev cleanups", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "As pointed out in the discussion of the patchset for building shared and\nstatic libraries separately [1], the test_bbdev_perf.c file explicitly\ndisables some code for shared library builds. This is due to functions\nnot being properly exported from one of the baseband drivers.\n\nWhile fixing this and looking to remove the #ifdef for shared libraries,\nit was discovered that the per-driver macro used in that file was\nincorrect for use in the meson build due to inconsistencies of naming\nbetween the two builds.\n\nTherefore, this set adjusts the macros and names of the drivers so that\nthey are consistent across drivers, and between both meson and make.\nThereafter the missing function for the fpga_lte_fec driver is exported\nand the #ifdef removed from the code.\n\nAfter these patches are replied, the only instance of the\nRTE_BUILD_SHARED_LIB macro used in .c/.h file is in rte_compat.h for\nfunction versioning support.\n\n[1] http://patches.dpdk.org/project/dpdk/list/?series=6596\n\nBruce Richardson (5):\n drivers/baseband: align meson defines with make\n baseband/fpga_lte_fec: align naming to other bbdevs\n drivers/baseband: remove override of driver names\n baseband/fpga_lte_fec: add public API to map file\n app/test-bbdev: enable fpga_lte_fec support in shared builds\n\n app/test-bbdev/Makefile | 3 +++\n app/test-bbdev/meson.build | 6 +++---\n app/test-bbdev/test_bbdev_perf.c | 8 +++-----\n config/common_base | 2 +-\n doc/guides/bbdevs/fpga_lte_fec.rst | 2 +-\n drivers/baseband/Makefile | 2 +-\n drivers/baseband/fpga_lte_fec/Makefile | 6 +++---\n drivers/baseband/fpga_lte_fec/fpga_lte_fec.h | 1 +\n drivers/baseband/fpga_lte_fec/meson.build | 1 -\n .../fpga_lte_fec/rte_pmd_bbdev_fpga_lte_fec_version.map | 4 ++++\n drivers/baseband/meson.build | 4 ++--\n drivers/baseband/null/meson.build | 1 -\n drivers/baseband/turbo_sw/meson.build | 1 -\n mk/rte.app.mk | 2 +-\n 14 files changed, 23 insertions(+), 20 deletions(-)" }