Cover Detail
Show a cover letter.
GET /api/covers/73646/?format=api
{ "id": 73646, "url": "http://patchwork.dpdk.org/api/covers/73646/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/cover/20200709134823.9176-1-l.wojciechow@partner.samsung.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20200709134823.9176-1-l.wojciechow@partner.samsung.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20200709134823.9176-1-l.wojciechow@partner.samsung.com", "date": "2020-07-09T13:48:19", "name": "[v3,0/4] introduce global debug flag", "submitter": { "id": 1628, "url": "http://patchwork.dpdk.org/api/people/1628/?format=api", "name": "Lukasz Wojciechowski", "email": "l.wojciechow@partner.samsung.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/cover/20200709134823.9176-1-l.wojciechow@partner.samsung.com/mbox/", "series": [ { "id": 10930, "url": "http://patchwork.dpdk.org/api/series/10930/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=10930", "date": "2020-07-09T13:48:19", "name": "introduce global debug flag", "version": 3, "mbox": "http://patchwork.dpdk.org/series/10930/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/covers/73646/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from dpdk.org (dpdk.org [92.243.14.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 08138A0528;\n\tThu, 9 Jul 2020 15:48:49 +0200 (CEST)", "from [92.243.14.124] (localhost [127.0.0.1])\n\tby dpdk.org (Postfix) with ESMTP id D2B841E916;\n\tThu, 9 Jul 2020 15:48:48 +0200 (CEST)", "from mailout2.w1.samsung.com (mailout2.w1.samsung.com\n [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 469971E913\n for <dev@dpdk.org>; Thu, 9 Jul 2020 15:48:47 +0200 (CEST)", "from eucas1p2.samsung.com (unknown [182.198.249.207])\n by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id\n 20200709134846euoutp0273018988303a946532177a696a86feae~gGbN4cmAY0823008230euoutp02Y\n for <dev@dpdk.org>; Thu, 9 Jul 2020 13:48:46 +0000 (GMT)", "from eusmges2new.samsung.com (unknown [203.254.199.244]) by\n eucas1p1.samsung.com (KnoxPortal) with ESMTP id\n 20200709134846eucas1p122402a23819940fb3890305b6c689312~gGbNskgih1087810878eucas1p1F;\n Thu, 9 Jul 2020 13:48:46 +0000 (GMT)", "from eucas1p2.samsung.com ( [182.198.249.207]) by\n eusmges2new.samsung.com (EUCPMTA) with SMTP id CC.9D.05997.E30270F5; Thu, 9\n Jul 2020 14:48:46 +0100 (BST)", "from eusmtrp1.samsung.com (unknown [182.198.249.138]) by\n eucas1p1.samsung.com (KnoxPortal) with ESMTPA id\n 20200709134846eucas1p193d963c3f21f0d5c4985024b6d015042~gGbNWGwEi1110411104eucas1p1G;\n Thu, 9 Jul 2020 13:48:46 +0000 (GMT)", "from eusmgms2.samsung.com (unknown [182.198.249.180]) by\n eusmtrp1.samsung.com (KnoxPortal) with ESMTP id\n 20200709134846eusmtrp1a0330bd63cf9f6c9d00f998f0460ead0~gGbNVl1Sl1329113291eusmtrp1L;\n Thu, 9 Jul 2020 13:48:46 +0000 (GMT)", "from eusmtip2.samsung.com ( [203.254.199.222]) by\n eusmgms2.samsung.com (EUCPMTA) with SMTP id 60.9E.06017.E30270F5; Thu, 9\n Jul 2020 14:48:46 +0100 (BST)", "from localhost.localdomain (unknown [106.210.88.70]) by\n eusmtip2.samsung.com (KnoxPortal) with ESMTPA id\n 20200709134845eusmtip2ccf72659ac47a3fdc16fbaeebc415d50~gGbNDqsg12268722687eusmtip2R;\n Thu, 9 Jul 2020 13:48:45 +0000 (GMT)" ], "DKIM-Filter": "OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com\n 20200709134846euoutp0273018988303a946532177a696a86feae~gGbN4cmAY0823008230euoutp02Y", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com;\n s=mail20170921; t=1594302526;\n bh=U06hjsPf/wEQS+inyhjHJJc0BPWjF9d6ao14gcUQfps=;\n h=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n b=FJyXdppVMczMcudTvGKMDBGIeJQ98LUEWPMf5e9yzhZLjNUu6okuVoUbAdMTTNiby\n NuU5c4qE/bFAjWDtRyCdgYwdSY3U40knT4GULEwP1s6el28Lz3dGGzDVuTanLN0x6E\n xlnylTYAXuGWa4x34OwSTxvlsX4+DuUB1+b665AA=", "X-AuditID": "cbfec7f4-65dff7000000176d-4a-5f07203e9638", "From": "Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>", "To": "", "Cc": "dev@dpdk.org, l.wojciechow@partner.samsung.com", "Date": "Thu, 9 Jul 2020 15:48:19 +0200", "Message-Id": "<20200709134823.9176-1-l.wojciechow@partner.samsung.com>", "X-Mailer": "git-send-email 2.17.1", "In-Reply-To": "<20200422214555.11837-1-l.wojciechow@partner.samsung.com>", "X-Brightmail-Tracker": [ "\n H4sIAAAAAAAAA+NgFrrCIsWRmVeSWpSXmKPExsWy7djP87p2CuzxBi1rpSzefdrOZPGsZx2j\n A5PHrwVLWT0OvtvDFMAUxWWTkpqTWZZapG+XwJXR3jaPseC1dMXLv32MDYwXRboYOTkkBEwk\n Fk5/x97FyMUhJLCCUWLPngMsEM4XRom+VZOgnM+MEru+L2ODabk69SwTiC0ksJxRouVeBFzR\n mv9/WUESbAK2EkdmfgWzRQRYJFZ+/84CYjMLGEm87J7I3MXIwSEsYCyxcYo7SJhFQFVi184T\n YCW8Ai4SE1+vZITYJS+xesMBZhCbU8BN4vTRFrCDJAR2sEksO/WTBaLIReLSwi4mCFtY4tXx\n LewQtozE6ck9UA3bGCWu/v7JCOHsZ5S43rsCqspa4vC/32wgFzELaEqs36UPEXaU+D/xKAtI\n WEKAT+LGW0GI+/kkJm2bzgwR5pXoaBOCqNaTeNozlRFm7Z+1T6BO85A4d3AHKyR8ZjJKbNx+\n lHECo/wshGULGBlXMYqnlhbnpqcWG+WllusVJ+YWl+al6yXn525iBMb16X/Hv+xg3PUn6RCj\n AAejEg9vwl+2eCHWxLLiytxDjBIczEoivE5nT8cJ8aYkVlalFuXHF5XmpBYfYpTmYFES5zVe\n 9DJWSCA9sSQ1OzW1ILUIJsvEwSnVwLj2fGLZhsa50059unrqgLc0l0yFyJKjxe7m23u2coTs\n r7yS4fC5UeYp5y3WJyV3Ju1d2+/znPeLa7ikjaHEG6V/wYI8tb6NGzSvZ77rvR25zYRjU9+c\n Jcc337YxfS5ipOmZ6bG2Sqss27d5+750xU0T49gq9kzjX9zw8DgL94sbG52Som/rxSuxFGck\n GmoxFxUnAgDhsQAc5wIAAA==", "\n H4sIAAAAAAAAA+NgFtrMLMWRmVeSWpSXmKPExsVy+t/xe7p2CuzxBvPvsFq8+7SdyeJZzzpG\n ByaPXwuWsnocfLeHKYApSs+mKL+0JFUhI7+4xFYp2tDCSM/Q0kLPyMRSz9DYPNbKyFRJ384m\n JTUnsyy1SN8uQS+jvW0eY8Fr6YqXf/sYGxgvinQxcnJICJhIXJ16lgnEFhJYyiixfn5GFyMH\n UFxG4sMlAYgSYYk/17rYuhi5gEo+Mkp0f1jGDpJgE7CVODLzKyuILSLAIrHy+3cWEJsZaObt\n eU1sIHOEBYwlNk5xBwmzCKhK7Np5AqyEV8BFYuLrlYwQ8+UlVm84wAxicwq4SZw+2sICcY6r\n xNfDrewTGPkWMDKsYhRJLS3OTc8tNtIrTswtLs1L10vOz93ECAywbcd+btnB2PUu+BCjAAej\n Eg9vwl+2eCHWxLLiytxDjBIczEoivE5nT8cJ8aYkVlalFuXHF5XmpBYfYjQFOmois5Rocj4w\n +PNK4g1NDc0tLA3Njc2NzSyUxHk7BA7GCAmkJ5akZqemFqQWwfQxcXBKNTCeEex9tPA682Op\n ZqdHMvvl7Hg1YpMPLd89Pfantyf7+8BXtz4vfO/I8nLlT4tn+bMlHv8r/6Ue/URAj49fjbPt\n l/+7k2X1Lv8PMO+a472Ece2RQ94zD/HxPDvxcx//v4hrc3YEiEl/ahJ5nRB9707V7P1mD65+\n 2cxXFKHalM66O2VHXtB6kVc3lFiKMxINtZiLihMBcWS9V0YCAAA=" ], "X-CMS-MailID": "20200709134846eucas1p193d963c3f21f0d5c4985024b6d015042", "X-Msg-Generator": "CA", "Content-Type": "text/plain; charset=\"utf-8\"", "X-RootMTR": "20200709134846eucas1p193d963c3f21f0d5c4985024b6d015042", "X-EPHeader": "CA", "CMS-TYPE": "201P", "X-CMS-RootMailID": "20200709134846eucas1p193d963c3f21f0d5c4985024b6d015042", "References": "<20200422214555.11837-1-l.wojciechow@partner.samsung.com>\n <CGME20200709134846eucas1p193d963c3f21f0d5c4985024b6d015042@eucas1p1.samsung.com>", "Subject": "[dpdk-dev] [PATCH v3 0/4] introduce global debug flag", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This set of patches introduces a global rte_debug flag for dpdk.\nThis will allow easy switch to debug build configuration using a single\nflag. In the debug mode a RTE_DEBUG macro is defined to 1\nand for every enabled to be built library a RTE_DEBUG_{library name}\nand for every enabled to be built driver\na RTE_DEBUG_{driver_class}_{driver_name} is also defined.\nThese macros can be used to place a debug code\ninside #ifdef #endif clauses.\n\nThe following requirements were discussed on the mailing list:\n1) The global debug flag is required to enable all the sanity checks\nand validations that are normally not used due to performance reasons\n\n2) The best option would be to have a single flag - not to introduce\ntoo many build options\n\n3) This option should be separated from meson \"debug\" option\n(used for build with symbols) and can be called \"rte_debug\"\n\n4) The currently existing DEBUG macros should not be replaced with\na RTE_DEBUG macro. This would allow to still enable them using\nCFLAGS=\"-D...\" to test a single module (library, driver).\n\n5) Currently existing options' names should be standardized\nto RTE_DEBUG_{library/driver name}, so they can be automatically enabled\nwhen rte_debug is set. Standardized names would allow easy usage\nin other modules.\n\n6) The debug functionality should be encapsulated in:\n if (rte_log_can_log(...)) {\n ...\n }\nfor possibility to be filtered out in runtime.\n\n\nBecause of the hot discussion of v1 version of patches, I limit\nthe v2 version to mbuf library changes only, to see how it will impact\nthe performance with rte_log_can_log usage and to get opinions.\n\nv3 contains mbuf performance tests, which might help dpdk developers\ncommunity to decide if drop of performance related to rte_log_can_log\ncan be accepted.\n\nIf agreement is reached, next steps would be to follow changes\nin other libraries and drivers.\n\n---\nv3:\n* Define RTE_DEBUG_* flags also for drivers\n* Bring back CONFIG option for librte_mbuf, but with new flag name\n* Add mbuf performance tests\n\nv2:\n* Use new meson option rte_debug instead of debug\n* Add standardized defines for built libraries\n* Limit patches to mbuf library (as a POC)\n* Use rte_log_can_log to wrap debug section\n\nLukasz Wojciechowski (4):\n config: introduce global rte debug flag\n config: remove unused config flags\n mbuf: standardize library debug flag\n app/test: add mbuf perf tests\n\n app/test/Makefile | 1 +\n app/test/meson.build | 4 +-\n app/test/test_mbuf.c | 3 +-\n app/test/test_mbuf_perf.c | 273 +++++++++++++++++++++++++++++\n config/common_base | 6 +-\n config/meson.build | 4 +\n doc/guides/prog_guide/mbuf_lib.rst | 2 +-\n drivers/baseband/meson.build | 1 +\n drivers/bus/meson.build | 1 +\n drivers/common/meson.build | 1 +\n drivers/compress/meson.build | 1 +\n drivers/crypto/meson.build | 1 +\n drivers/event/meson.build | 1 +\n drivers/mempool/meson.build | 1 +\n drivers/meson.build | 3 +\n drivers/net/meson.build | 1 +\n drivers/raw/meson.build | 1 +\n drivers/vdpa/meson.build | 1 +\n lib/librte_mbuf/rte_mbuf.h | 12 +-\n lib/meson.build | 4 +\n meson_options.txt | 2 +\n 21 files changed, 312 insertions(+), 12 deletions(-)\n create mode 100644 app/test/test_mbuf_perf.c" }