Cover Detail
Show a cover letter.
GET /api/covers/810/?format=api
{ "id": 810, "url": "http://patchwork.dpdk.org/api/covers/810/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/cover/20240326190422.577028-1-luca.vizzarro@arm.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20240326190422.577028-1-luca.vizzarro@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20240326190422.577028-1-luca.vizzarro@arm.com", "date": "2024-03-26T19:04:16", "name": "[0/6] dts: add testpmd params and statefulness", "submitter": { "id": 3197, "url": "http://patchwork.dpdk.org/api/people/3197/?format=api", "name": "Luca Vizzarro", "email": "luca.vizzarro@arm.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/cover/20240326190422.577028-1-luca.vizzarro@arm.com/mbox/", "series": [ { "id": 31622, "url": "http://patchwork.dpdk.org/api/series/31622/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=31622", "date": "2024-03-26T19:04:16", "name": "dts: add testpmd params and statefulness", "version": 1, "mbox": "http://patchwork.dpdk.org/series/31622/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/covers/810/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 36BA343D5B;\n\tTue, 26 Mar 2024 20:04:33 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BAEE640E72;\n\tTue, 26 Mar 2024 20:04:32 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by mails.dpdk.org (Postfix) with ESMTP id 548DF40E4A\n for <dev@dpdk.org>; Tue, 26 Mar 2024 20:04:31 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 6B8162F4;\n Tue, 26 Mar 2024 12:05:04 -0700 (PDT)", "from localhost.localdomain (unknown [10.57.16.115])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id E32683F64C;\n Tue, 26 Mar 2024 12:04:29 -0700 (PDT)" ], "From": "Luca Vizzarro <luca.vizzarro@arm.com>", "To": "dev@dpdk.org", "Cc": "=?utf-8?q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>,\n Luca Vizzarro <luca.vizzarro@arm.com>", "Subject": "[PATCH 0/6] dts: add testpmd params and statefulness", "Date": "Tue, 26 Mar 2024 19:04:16 +0000", "Message-Id": "<20240326190422.577028-1-luca.vizzarro@arm.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Hello!\n\nSending in some major work relating to Bugzilla Bug 1371. In a few words\nI have created a common data structure to handle command line parameters\nfor shells. I applied this to the current EalParameters class, and made\nit so it's reflected across the interactive shell classes for\nconsistency. Finally, I have implemented all the testpmd parameters\nthat are publicly documented in a class, and updated the buffer scatter\ntest suite to use it. The two statefulness patches are very basic and\nhopefully the beginning of tracking some state in each testpmd session.\n\nHere are some things I'd like to discuss about these patches:\n- the testpmd params defaults. These are a mix between the declared\n defaults on testpmd doc page and some of which we are aware of. I have\n not used all the defaults declared on the testpmd doc page, because I\n have found some inconsistencies when going through testpmd's source\n code.\n- the overall structure of the parameter classes. Each of the parameter\n classes are placed in different files, not following a proper\n structure. I'd be keen to restructure everything, and I am open to\n suggestions.\n- most of the docstrings relating to the testpmd parameters class are\n effectively taking from testpmd's doc pages. Would this satisfy our\n needs?\n- I've tested the docstrings against Juraj's pending API doc generation\n patches and noticed that union types are not correctly represented\n when these are more than two. Not sure if this is a bug or not, but if\n not, any suggestions on how we could solve this?\n\nLooking forward to hearing your replies!\n\nBest regards,\nLuca\n\nLuca Vizzarro (6):\n dts: add parameters data structure\n dts: use Params for interactive shells\n dts: add testpmd shell params\n dts: use testpmd params for scatter test suite\n dts: add statefulness to InteractiveShell\n dts: add statefulness to TestPmdShell\n\n dts/framework/params.py | 232 ++++++\n .../remote_session/interactive_shell.py | 26 +-\n dts/framework/remote_session/testpmd_shell.py | 680 +++++++++++++++++-\n dts/framework/testbed_model/__init__.py | 2 +-\n dts/framework/testbed_model/node.py | 4 +-\n dts/framework/testbed_model/os_session.py | 4 +-\n dts/framework/testbed_model/sut_node.py | 106 ++-\n dts/tests/TestSuite_pmd_buffer_scatter.py | 20 +-\n 8 files changed, 972 insertions(+), 102 deletions(-)\n create mode 100644 dts/framework/params.py" }