Cover Detail
Show a cover letter.
GET /api/covers/86418/?format=api
{ "id": 86418, "url": "http://patchwork.dpdk.org/api/covers/86418/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/cover/cover.1610473000.git.anatoly.burakov@intel.com/", "project": { "id": 1, "url": "http://patchwork.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<cover.1610473000.git.anatoly.burakov@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/cover.1610473000.git.anatoly.burakov@intel.com", "date": "2021-01-12T17:37:08", "name": "[v16,00/11] Add PMD power management", "submitter": { "id": 4, "url": "http://patchwork.dpdk.org/api/people/4/?format=api", "name": "Anatoly Burakov", "email": "anatoly.burakov@intel.com" }, "mbox": "http://patchwork.dpdk.org/project/dpdk/cover/cover.1610473000.git.anatoly.burakov@intel.com/mbox/", "series": [ { "id": 14673, "url": "http://patchwork.dpdk.org/api/series/14673/?format=api", "web_url": "http://patchwork.dpdk.org/project/dpdk/list/?series=14673", "date": "2021-01-12T17:37:08", "name": "Add PMD power management", "version": 16, "mbox": "http://patchwork.dpdk.org/series/14673/mbox/" } ], "comments": "http://patchwork.dpdk.org/api/covers/86418/comments/", "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 489E2A04B5;\n\tTue, 12 Jan 2021 18:37:27 +0100 (CET)", "from [217.70.189.124] (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B54E8140E77;\n\tTue, 12 Jan 2021 18:37:26 +0100 (CET)", "from mga04.intel.com (mga04.intel.com [192.55.52.120])\n by mails.dpdk.org (Postfix) with ESMTP id 0AA80140E76\n for <dev@dpdk.org>; Tue, 12 Jan 2021 18:37:24 +0100 (CET)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 12 Jan 2021 09:37:22 -0800", "from silpixa00399498.ir.intel.com (HELO\n silpixa00399498.ger.corp.intel.com) ([10.237.222.179])\n by fmsmga001.fm.intel.com with ESMTP; 12 Jan 2021 09:37:20 -0800" ], "IronPort-SDR": [ "\n u5zXCrnUW7sRGBbe6LH5Ba3yc0QBcvYyqH4N864KRF9VD1W3Ot+6prN0aXA5wqPpDWlGHqbtlq\n M3+XKgikG4mw==", "\n d1l1Cq11aTREx1qSrZZRb84gWUmqkWOmJ8idCsVGURfSpM7LjkRKL1m9llYx/88dKMc5P+Rz2/\n LUMVxcxWOWQA==" ], "X-IronPort-AV": [ "E=McAfee;i=\"6000,8403,9862\"; a=\"175497947\"", "E=Sophos;i=\"5.79,342,1602572400\"; d=\"scan'208\";a=\"175497947\"", "E=Sophos;i=\"5.79,342,1602572400\"; d=\"scan'208\";a=\"464604121\"" ], "X-ExtLoop1": "1", "From": "Anatoly Burakov <anatoly.burakov@intel.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, konstantin.ananyev@intel.com,\n timothy.mcdaniel@intel.com, david.hunt@intel.com,\n bruce.richardson@intel.com, chris.macnamara@intel.com", "Date": "Tue, 12 Jan 2021 17:37:08 +0000", "Message-Id": "<cover.1610473000.git.anatoly.burakov@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<cover.1610377084.git.anatoly.burakov@intel.com>", "References": "<cover.1610377084.git.anatoly.burakov@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Subject": "[dpdk-dev] [PATCH v16 00/11] Add PMD power management", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "This patchset proposes a simple API for Ethernet drivers to cause the \nCPU to enter a power-optimized state while waiting for packets to \narrive. There are multiple proposed mechanisms to achieve said power\nsavings: simple frequency scaling, idle loop, and monitoring the Rx\nqueue for incoming packages. The latter is achieved through cooperation\nwith the NIC driver that will allow us to know address of wake up event,\nand wait for writes on that address.\n\nOn IA, this is achieved through using UMONITOR/UMWAIT instructions. They \nare used in their raw opcode form because there is no widespread \ncompiler support for them yet. Still, the API is made generic enough to\nhopefully support other architectures, if they happen to implement \nsimilar instructions.\n\nTo achieve power savings, there is a very simple mechanism used: we're \ncounting empty polls, and if a certain threshold is reached, we employ\none of the suggested power management schemes automatically, from within\na Rx callback inside the PMD. Once there's traffic again, the empty poll\ncounter is reset.\n\nThis patchset also introduces a few changes into existing power \nmanagement-related intrinsics, namely to provide a native way of waking \nup a sleeping core without application being responsible for it, as well \nas general robustness improvements. There's quite a bit of locking going \non, but these locks are per-thread and very little (if any) contention \nis expected, so the performance impact shouldn't be that bad (and in any \ncase the locking happens when we're about to sleep anyway).\n\nWhy are we putting it into ethdev as opposed to leaving this up to the \napplication? Our customers specifically requested a way to do it with\nminimal changes to the application code. The current approach allows to \njust flip a switch and automatically have power savings.\n\nThings of note:\n\n- Only 1:1 core to queue mapping is supported, meaning that each lcore \n must at most handle RX on a single queue\n- Support 3 type policies. Monitor/Pause/Frequency Scaling\n- Power management is enabled per-queue\n- The API doesn't extend to other device types\n\nv16:\n- Implemented Konstantin's suggestions and comments\n- Added return values to the API\n\nv15:\n- Fixed incorrect check in UMWAIT callback\n- Fixed accidental whitespace changes\n\nv14:\n- Fixed ARM/PPC builds\n- Addressed various review comments\n\nv13:\n- Reworked the librte_power code to require less locking and handle invalid\n parameters better\n- Fix numerous rebase errors present in v12\n\nv12:\n- Rebase on top of 21.02\n- Rework of power intrinsics code\n\nAnatoly Burakov (5):\n eal: uninline power intrinsics\n eal: avoid invalid API usage in power intrinsics\n eal: change API of power intrinsics\n eal: remove sync version of power monitor\n eal: add monitor wakeup function\n\nLiang Ma (6):\n ethdev: add simple power management API\n power: add PMD power management API and callback\n net/ixgbe: implement power management API\n net/i40e: implement power management API\n net/ice: implement power management API\n examples/l3fwd-power: enable PMD power mgmt\n\n doc/guides/prog_guide/power_man.rst | 44 +++\n doc/guides/rel_notes/release_21_02.rst | 15 +\n .../sample_app_ug/l3_forward_power_man.rst | 35 ++\n drivers/event/dlb/dlb.c | 10 +-\n drivers/event/dlb2/dlb2.c | 10 +-\n drivers/net/i40e/i40e_ethdev.c | 1 +\n drivers/net/i40e/i40e_rxtx.c | 25 ++\n drivers/net/i40e/i40e_rxtx.h | 1 +\n drivers/net/ice/ice_ethdev.c | 1 +\n drivers/net/ice/ice_rxtx.c | 26 ++\n drivers/net/ice/ice_rxtx.h | 1 +\n drivers/net/ixgbe/ixgbe_ethdev.c | 1 +\n drivers/net/ixgbe/ixgbe_rxtx.c | 25 ++\n drivers/net/ixgbe/ixgbe_rxtx.h | 1 +\n examples/l3fwd-power/main.c | 89 ++++-\n .../arm/include/rte_power_intrinsics.h | 40 --\n lib/librte_eal/arm/meson.build | 1 +\n lib/librte_eal/arm/rte_power_intrinsics.c | 38 ++\n .../include/generic/rte_power_intrinsics.h | 88 ++---\n .../ppc/include/rte_power_intrinsics.h | 40 --\n lib/librte_eal/ppc/meson.build | 1 +\n lib/librte_eal/ppc/rte_power_intrinsics.c | 38 ++\n lib/librte_eal/version.map | 3 +\n .../x86/include/rte_power_intrinsics.h | 115 ------\n lib/librte_eal/x86/meson.build | 1 +\n lib/librte_eal/x86/rte_power_intrinsics.c | 220 +++++++++++\n lib/librte_ethdev/rte_ethdev.c | 28 ++\n lib/librte_ethdev/rte_ethdev.h | 25 ++\n lib/librte_ethdev/rte_ethdev_driver.h | 22 ++\n lib/librte_ethdev/version.map | 3 +\n lib/librte_power/meson.build | 5 +-\n lib/librte_power/rte_power_pmd_mgmt.c | 359 ++++++++++++++++++\n lib/librte_power/rte_power_pmd_mgmt.h | 90 +++++\n lib/librte_power/version.map | 5 +\n 34 files changed, 1148 insertions(+), 259 deletions(-)\n create mode 100644 lib/librte_eal/arm/rte_power_intrinsics.c\n create mode 100644 lib/librte_eal/ppc/rte_power_intrinsics.c\n create mode 100644 lib/librte_eal/x86/rte_power_intrinsics.c\n create mode 100644 lib/librte_power/rte_power_pmd_mgmt.c\n create mode 100644 lib/librte_power/rte_power_pmd_mgmt.h" }